mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-30 13:08:48 -06:00
Nick Nyssen
4e69ca14d3
Follow-up to review of this branch, no production change. The oracle now asserts the list still ends at Arial Unicode before checking it. Without that, deriving the path from list.first() instead of last() stayed green on this machine and printed "not installed" — the check disappeared because /System/Library/Fonts/DevanagariMT.ttc is absent here. Deriving the path from the list is still better than repeating a literal, but only if something verifies it points where the test thinks. The three retune tripwires (MAX_BYTES, DEVANAGARI_PROBE, MAX_FACES) move into their own test, so the layout test stays about Apple's directory layout and these are labelled for what they are: constants nothing else pins, each confirmed to be the only guard by deleting it and seeing the matching regression go green again. Comments corrected accordingly, including not claiming Apple moved a target when a user could equally have removed it. Verified on macOS 26.6 (Apple M5 Max): fmt --all clean; clippy -D warnings all-targets quiet; system_fonts 13 passed with and without PDFCRAFT_SYSTEM_FONTS=0; whole crate 1341 passed / 0 failed / 5 ignored; xtask layers (37 crates) and assets (272/6/22). Mutations re-run at this commit: folder-major expansion, folder-order swap, typo restore, loader reversal, cap raised to 512 MiB, probe swapped to Arabic alef and MAX_FACES cut to 1 are all red; deleting the PDFCRAFT_SYSTEM_FONTS=0 early return leaves all 1341 green, which is stated rather than hidden.