mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-11-01 14:08:23 -06:00
alehelandClaude Opus 5.5
4b3033c869
From a review of this branch: - Escape mid-drag with a text markup tool (Highlight, Underline, Strikeout, Squiggly, Replace Text) or Redact over text left the half-made selection on the page: the cancel took the Escape that would have cleared it. It is dropped now. The marks made from a selection at its end (after the page tools, which the release blocking did not reach) also wait for a cancelled press's button; egui ends its own drag on Escape without a drag stop, so they were not made in practice, but nothing but egui stopped them. - The open paragraph's frame took the press above and below the text only: its sides still gave edge grips (a closed paragraph's rewrap handles) on the Editor layer, over the frame. Edges now belong to closed paragraphs only. - A press in the frame right after a release kept the last press's owner until a page claimed it, so a drag from the margin beside a page could move the comment just clicked. A new press now drops the last owner before the pages give it theirs. - A release and a new press in one frame no longer leave the new press cancelled. - Added content is picked up with the tools that act on it (Select, Add text, Edit text), not with every tool while Edit a PDF is open. - The layer docs in page_cursor.rs say what lies on each layer now. New tests an_open_paragraphs_frame_takes_the_box_beside_its_text and a_drag_from_beside_the_page_right_after_a_click_leaves_the_comment_alone (the release and the next press in one frame) fail on the previous commit. escape_cancels_a_highlight_being_dragged_over_text (with a control: the drag highlights without Escape) passes there too, for the reason above, and stays as a guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>