mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-25 02:29:31 -06:00
Brandon ThomasandClaude Opus 5.5
d90b3f897f
Release builds said "Text recognition isn't installed: its models are missing" because no packaging script or release job fetched the OCR models: only `cargo xtask models` does, into the source tree. - packaging/env.sh gains stage_models DEST, which runs `cargo xtask models DEST` (every ATTRIBUTION.toml kind = "model" file, SHA-256 verified, with its licence text). No model file is named, so the models PRs #433/#572 add ship without packaging changes. - `cargo xtask models` also writes ATTRIBUTION.txt crediting each model (CC-BY-SA-4.0 requires attribution when redistributed). - macOS: PdfCraft.app/Contents/Resources/models, before signing. - Windows: models\ beside pdfcraft.exe in the MSI (WiX v5 <Files> harvest) and the portable zip; test-msi.ps1 checks the folder. - Linux deb/rpm/tar.gz/AppImage, Flatpak bundle and FreeBSD tarball: share/pdfcraft/models beside bin/. Models::search_dirs now also looks in <exe dir>/../share/pdfcraft/models (Models::dirs_beside_exe); a test builds every package layout on disk and finds the models in each. release.yml and freebsd.yml check the packages contain them. - The missing-models messages no longer tell end users to run cargo, and the 11 catalogs that keyed an old PRINTCRAFT_MODELS wording (or the previous one) now key the current English text; ATTRIBUTION hashes updated. A test checks the translations match. The web (wasm) build, which the issue reports, still has no models; this is the desktop half only. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
151 lines
9.6 KiB
PowerShell
151 lines
9.6 KiB
PowerShell
<#
|
|
.SYNOPSIS
|
|
Check the compiled MSI's install scope, publisher, shortcuts, native UI and OCR models, without installing it.
|
|
.EXAMPLE
|
|
pwsh packaging/windows/test-msi.ps1 dist/release/pdfcraft-0.2.1-windows-x64.msi
|
|
#>
|
|
param([Parameter(Mandatory)] [string] $Path)
|
|
$ErrorActionPreference = 'Stop'
|
|
$Installer = New-Object -ComObject WindowsInstaller.Installer
|
|
$Database = $Installer.OpenDatabase((Resolve-Path -LiteralPath $Path).Path, 0)
|
|
|
|
function Read-Row([string] $Sql, [int] $Columns) {
|
|
$view = $Database.OpenView($Sql)
|
|
try {
|
|
[void] $view.Execute()
|
|
$record = $view.Fetch()
|
|
if (-not $record) { throw "MSI row missing: $Sql" }
|
|
$values = @(for ($i = 1; $i -le $Columns; $i++) { $record.StringData($i) })
|
|
return ,$values
|
|
} finally { [void] $view.Close() }
|
|
}
|
|
|
|
function Assert-Equal($Actual, $Expected, [string] $What) {
|
|
if ($Actual -cne $Expected) { throw "$What`: expected '$Expected', got '$Actual'" }
|
|
}
|
|
|
|
function Assert-NoRow([string] $Sql, [string] $What) {
|
|
$view = $Database.OpenView($Sql)
|
|
try {
|
|
[void] $view.Execute()
|
|
if ($view.Fetch()) { throw "Unexpected MSI row ($What): $Sql" }
|
|
} finally { [void] $view.Close() }
|
|
}
|
|
|
|
# Test the compiled condition with Windows Installer's evaluator, in a restricted session that
|
|
# cannot change machine state. Normal installs/repairs work, per-user overrides fail, and removal
|
|
# of an older incorrectly scoped installation remains possible (#305).
|
|
$scopeMessage = 'PdfCraft must be installed for all users. Run setup with administrator privileges and ALLUSERS=1; per-user installation is not supported.'
|
|
$scopeCondition = Read-Row ('SELECT `Condition` FROM `LaunchCondition` WHERE `Description` = ''' + $scopeMessage + '''') 1
|
|
$Installer.UILevel = 2
|
|
$session = $null
|
|
try {
|
|
$session = $Installer.OpenPackage((Resolve-Path -LiteralPath $Path).Path, 1)
|
|
foreach ($case in @(
|
|
@('machine install', '1', '', '', '', 1),
|
|
@('machine repair', '1', '', '1', '', 1),
|
|
@('forced per-user install', '2', '1', '', '', 0),
|
|
@('empty ALLUSERS', '', '', '', '', 0),
|
|
@('resolved per-user install', '', '1', '', '', 0),
|
|
@('forced per-user repair', '2', '1', '1', '', 0),
|
|
@('machine uninstall', '1', '', '1', 'ALL', 1),
|
|
@('legacy per-user uninstall', '', '1', '1', 'ALL', 1))) {
|
|
$session.Property('ALLUSERS') = $case[1]
|
|
$session.Property('MSIINSTALLPERUSER') = $case[2]
|
|
$session.Property('Installed') = $case[3]
|
|
$session.Property('REMOVE') = $case[4]
|
|
Assert-Equal ($session.EvaluateCondition($scopeCondition[0])) $case[5] $case[0]
|
|
}
|
|
} finally {
|
|
if ($session) { [void] [Runtime.InteropServices.Marshal]::FinalReleaseComObject($session) }
|
|
}
|
|
foreach ($sequence in @('InstallUISequence', 'InstallExecuteSequence')) {
|
|
$launch = Read-Row ('SELECT `Condition`, `Sequence` FROM `' + $sequence + '` WHERE `Action` = ''LaunchConditions''') 2
|
|
Assert-Equal $launch[0] '' "$sequence launch conditions are unconditional"
|
|
$cost = Read-Row ('SELECT `Sequence` FROM `' + $sequence + '` WHERE `Action` = ''CostInitialize''') 1
|
|
if ([int] $launch[1] -le 0 -or [int] $launch[1] -ge [int] $cost[0]) {
|
|
throw "$sequence must reject per-user overrides before costing"
|
|
}
|
|
}
|
|
$manufacturer = Read-Row 'SELECT `Value` FROM `Property` WHERE `Property` = ''Manufacturer''' 1
|
|
Assert-Equal $manufacturer[0] 'Learning Machines LLC' 'MSI manufacturer'
|
|
$status = Read-Row 'SELECT `Text` FROM `Control` WHERE `Dialog_` = ''InstallProgress'' AND `Control` = ''Status''' 1
|
|
Assert-Equal $status[0] 'Please wait while setup completes.' 'Persistent progress message'
|
|
Assert-NoRow 'SELECT `Event` FROM `EventMapping` WHERE `Dialog_` = ''InstallProgress'' AND `Control_` = ''Status''' 'progress text subscription'
|
|
|
|
# Plain (non-advertised) shortcuts to pdfcraft.exe, each in its own component; the desktop one is
|
|
# gated by INSTALLDESKTOPSHORTCUT, which defaults to 1 and is secure so the UI choice reaches the
|
|
# elevated install.
|
|
foreach ($entry in @(@('StartMenuShortcut', 'ProgramMenuFolder', 'PdfcraftStartMenuShortcut', ''),
|
|
@('DesktopShortcut', 'DesktopFolder', 'PdfcraftDesktopShortcut', 'INSTALLDESKTOPSHORTCUT = 1'))) {
|
|
$row = Read-Row ('SELECT `Directory_`, `Target`, `Icon_`, `WkDir`, `Component_` FROM `Shortcut` WHERE `Shortcut` = ''' + $entry[0] + '''') 5
|
|
Assert-Equal $row[0] $entry[1] "$($entry[0]) directory"
|
|
Assert-Equal $row[1] '[#PdfcraftExe]' "$($entry[0]) target"
|
|
Assert-Equal $row[2] 'PdfcraftIcon.ico' "$($entry[0]) icon"
|
|
Assert-Equal $row[3] 'INSTALLFOLDER' "$($entry[0]) working directory"
|
|
Assert-Equal $row[4] $entry[2] "$($entry[0]) component"
|
|
$component = Read-Row ('SELECT `Directory_`, `Condition` FROM `Component` WHERE `Component` = ''' + $entry[2] + '''') 2
|
|
Assert-Equal $component[0] $entry[1] "$($entry[2]) directory"
|
|
Assert-Equal $component[1] $entry[3] "$($entry[2]) condition"
|
|
}
|
|
$default = Read-Row 'SELECT `Value` FROM `Property` WHERE `Property` = ''INSTALLDESKTOPSHORTCUT''' 1
|
|
Assert-Equal $default[0] '1' 'Desktop shortcut default'
|
|
$secure = Read-Row 'SELECT `Value` FROM `Property` WHERE `Property` = ''SecureCustomProperties''' 1
|
|
if (($secure[0] -split ';') -notcontains 'INSTALLDESKTOPSHORTCUT') { throw "INSTALLDESKTOPSHORTCUT is not secure: '$($secure[0])'" }
|
|
$checkbox = Read-Row 'SELECT `Type`, `Property`, `Text` FROM `Control` WHERE `Dialog_` = ''InstallWelcome'' AND `Control` = ''DesktopShortcut''' 3
|
|
Assert-Equal $checkbox[0] 'CheckBox' 'Welcome desktop-shortcut control'
|
|
Assert-Equal $checkbox[1] 'INSTALLDESKTOPSHORTCUT' 'Welcome checkbox property'
|
|
if ($checkbox[2] -notmatch 'desktop shortcut') { throw "Welcome checkbox label: '$($checkbox[2])'" }
|
|
$checked = Read-Row 'SELECT `Value` FROM `CheckBox` WHERE `Property` = ''INSTALLDESKTOPSHORTCUT''' 1
|
|
Assert-Equal $checked[0] '1' 'Welcome checkbox value'
|
|
$app = Read-Row 'SELECT `KeyPath` FROM `Component` WHERE `Component` = ''PdfcraftApp''' 1
|
|
Assert-Equal $app[0] 'PdfcraftExe' 'Shortcut executable key path'
|
|
$scope = Read-Row 'SELECT `Value` FROM `Property` WHERE `Property` = ''ALLUSERS''' 1
|
|
Assert-Equal $scope[0] '1' 'Per-machine shortcut scope'
|
|
|
|
# Image context menu opens the DPI chooser; the app component owns every registry row so
|
|
# uninstall removes it. No image default association is changed.
|
|
foreach ($ext in @('png', 'jpg', 'jpeg', 'tif', 'tiff', 'gif', 'bmp', 'jp2', 'j2k', 'jpx')) {
|
|
$key = 'Software\Classes\SystemFileAssociations\.' + $ext + '\shell\PdfCraft.CreatePdf'
|
|
$menu = Read-Row ('SELECT `Value`, `Component_`, `Root` FROM `Registry` WHERE `Key` = ''' + $key + ''' AND `Name` IS NULL') 3
|
|
Assert-Equal $menu[0] 'Create PDF with PdfCraft…' "$ext context menu label"
|
|
Assert-Equal $menu[1] 'PdfcraftApp' "$ext context menu component"
|
|
Assert-Equal $menu[2] '2' "$ext context menu HKLM root"
|
|
$command = Read-Row ('SELECT `Value` FROM `Registry` WHERE `Key` = ''' + $key + '\command''') 1
|
|
Assert-Equal $command[0] '"[#PdfcraftExe]" --create-images "%1"' "$ext context menu command"
|
|
$selection = Read-Row ('SELECT `Value` FROM `Registry` WHERE `Key` = ''' + $key + ''' AND `Name` = ''MultiSelectModel''') 1
|
|
Assert-Equal $selection[0] 'Single' "$ext context menu selection"
|
|
}
|
|
|
|
# Negative sequences are Windows Installer's success/user-exit/failure paths. Only full UI
|
|
# shows these dialogs: an unattended /qn or /qb install must never wait for a Finish click.
|
|
foreach ($exit in @(@('InstallComplete', '-1'), @('InstallCancelled', '-2'), @('InstallFailed', '-3'))) {
|
|
$row = Read-Row ('SELECT `Condition`, `Sequence` FROM `InstallUISequence` WHERE `Action` = ''' + $exit[0] + '''') 2
|
|
Assert-Equal $row[0] 'UILevel = 5' "$($exit[0]) UI level"
|
|
Assert-Equal $row[1] $exit[1] "$($exit[0]) exit path"
|
|
$finish = Read-Row ('SELECT `Type`, `Text` FROM `Control` WHERE `Dialog_` = ''' + $exit[0] + ''' AND `Control` = ''Finish''') 2
|
|
Assert-Equal $finish[0] 'PushButton' "$($exit[0]) Finish control"
|
|
Assert-Equal $finish[1] '&Finish' "$($exit[0]) Finish label"
|
|
$endDialog = Read-Row ('SELECT `Argument` FROM `ControlEvent` WHERE `Dialog_` = ''' + $exit[0] + ''' AND `Control_` = ''Finish'' AND `Event` = ''EndDialog''') 1
|
|
Assert-Equal $endDialog[0] 'Return' "$($exit[0]) Finish event"
|
|
}
|
|
$title = Read-Row 'SELECT `Text` FROM `Control` WHERE `Dialog_` = ''InstallComplete'' AND `Control` = ''Title''' 1
|
|
if ($title[0] -notmatch 'completed successfully') { throw 'Success dialog does not confirm completion' }
|
|
# OCR models (#103): installed into models\ beside pdfcraft.exe, where the app looks for them.
|
|
$modelsDir = Read-Row 'SELECT `Directory_Parent`, `DefaultDir` FROM `Directory` WHERE `Directory` = ''ModelsFolder''' 2
|
|
Assert-Equal $modelsDir[0] 'INSTALLFOLDER' 'OCR models folder parent'
|
|
# DefaultDir is `models`, or `SHORT|models` with a generated 8.3 name.
|
|
if ($modelsDir[1] -notmatch '(^|\|)models$') { throw "OCR models folder name: '$($modelsDir[1])'" }
|
|
$modelFiles = 0
|
|
$view = $Database.OpenView('SELECT `File`.`FileName` FROM `File`, `Component` WHERE `File`.`Component_` = `Component`.`Component` AND `Component`.`Directory_` = ''ModelsFolder''')
|
|
try {
|
|
[void] $view.Execute()
|
|
while ($record = $view.Fetch()) { if ($record.StringData(1) -match '\.rten$') { $modelFiles++ } }
|
|
} finally { [void] $view.Close() }
|
|
if ($modelFiles -lt 2) { throw "expected the OCR models (*.rten) in models\, found $modelFiles" }
|
|
$rm = Read-Row 'SELECT `Dialog` FROM `Dialog` WHERE `Dialog` = ''MsiRMFilesInUse''' 1
|
|
Assert-Equal $rm[0] 'MsiRMFilesInUse' 'Files-in-use dialog'
|
|
[void] [Runtime.InteropServices.Marshal]::FinalReleaseComObject($Database)
|
|
[void] [Runtime.InteropServices.Marshal]::FinalReleaseComObject($Installer)
|
|
Write-Output 'ok MSI: per-machine scope guard, publisher, persistent progress text, Start Menu shortcut, optional desktop shortcut (default on, checkbox), icon/key path, full-UI success/cancel/error and Finish controls, files-in-use dialog, OCR models'
|