mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-25 18:47:22 -06:00
* M10: enhance camera images: straighten a page from four corners (ocr.camera-perspective) Four corners on a page (any order, a convex quadrilateral) are warped to an upright rectangle that replaces what the page shows, read at the page picture's own resolution (at most 600 dpi) and kept at that physical size. One undoable step through Replace Pages, so comments, links and bookmarks stay. - geom: a pure 3x3 homography solve and corner ordering (no dependencies); collinear, concave and non-finite input gives None. - engine: camera::warp (bilinear, over white, capped at 40 MP) and Session::enhance_camera_page. - automation: page_enhance_camera (corners in top-left-origin points). - parity: ocr.camera-perspective is partial; the UI handles, automatic edge detection and contrast cleanup are still missing. Refs #1008. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M10: Enhance camera image: drag four corners on the page, then Enhance page (ocr.camera-perspective) Scan & OCR ▸ Enhance camera image (ocr.enhance_camera) shows four corner handles on the current page, inset 5% from its edges, with what will be cut away dimmed. Enhance page straightens what they enclose through Session::enhance_camera_page (one undoable step); Cancel and Esc leave the page alone. The buttons float at the top right, clear of a centred page's corners, and the instructions are a notice, as for Crop. A command of its own, beside Enhance scanned file (ocr.enhance), which stays for scan correction (#1012). - ui-egui: camera_ui (handles, dimming, bar), QuickTool::EnhanceCamera, quick_tool "enhance-camera" for ui.state and the shot example. - Catalogs: the three new labels in every language with UI coverage (plus es, pl, zh-hant); ATTRIBUTION.toml hashes updated. - automation: page_enhance_camera is linked to the command. - parity: ocr.camera-perspective lists the command and the UI test. Refs #1008. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M10: Enhance camera image finds the document's edges (ocr.camera-perspective) The corners now start on the photographed document's edges when they can be found, else inset 5% as before. camera_edges::detect_document, pure Rust and deterministic: shrink to 400 px, blur, Sobel edges thinned and thresholded against the 98th percentile; a Hough transform where each edge votes within 6 degrees of its own normal; pairs of near-horizontal and near-vertical lines make convex quadrilaterals (at least 12% of the picture), kept when every side lies on a matching edge along at least 55% of its length and scored by area times the square of the mean support; each side is then refitted through its edge points (total least squares). None when nothing convinces. - Session::detect_camera_corners (user space); page_enhance_camera finds the corners itself when `corners` is omitted and reports the corners it used and whether they were detected; the UI command starts from them. - Tests on synthetic photos: plain table, text on the sheet, wood grain with a shadow, strong perspective, a 30 degree turn, a sheet running off the picture, no document, white on white, bad input; end to end through the engine and the tool. - Parity notes: what is still missing (turning the result upright, rounded corners, clean-up). Refs #1008. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M10: after Enhance page, rotate, crop or organize the page (ocr.camera-perspective) Enhance camera image no longer closes on Enhance page: the bar then offers rotate counterclockwise and clockwise for the enhanced page (one undo step each), Crop pages and Organize pages (which leave the tool for those tools), and Done; Esc leaves too. A photo of a card often comes out a quarter turn off until the page is turned upright automatically. The two icon buttons are named for screen readers. Every label already exists in the catalogs. Refs #1008. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M10: Enhance camera image cleans the photo up and chooses its look (#1034) After Enhance page the bar offers a look (Original, Colour, Greyscale, Black and white) and a Clean-up slider (0-100, default Colour at 50). Choosing a look or letting go of the slider enhances the page again from the straightened photo and turns it as before, so the history keeps one enhancement (and one turn), never a pile of them. camera_clean, pure Rust: - clean: the paper's illumination is estimated per channel on a coarse grid (each block's 90th percentile, lifted to the 75th percentile of the 5x5 blocks around it so a stamp or picture isn't taken for paper, then smoothed) and divided out, so casts, shadows and darker edges go and the paper turns white; a contrast stretch grows with the level, and from 60 isolated dark pixels are removed. Colour ink stays. - apply(look): Original is the photo as taken; Greyscale is the cleaned page in grey; Black and white evens the lighting fully, thresholds the whole page (the level sets the threshold: higher keeps fainter strokes) and despeckles. Black and white is stored as PNG (lossless): JPEG would smear grey around every letter. - Session::enhance_camera_page_at(look, level); page_enhance_camera takes `mode` (original, colour, greyscale, bw) and `level` (0-100), refusing anything else. - "Clean-up", "Original", "Greyscale" and "Black and white" in every catalog with UI coverage, plus es, pl and zh-hant. - Tests: shadow and yellow cast become white paper with dark text, a blue stamp stays blue, strength grows with the level, specks go but text stays, the four looks (black and white is only black and white, the threshold moves with the level), bad sizes; a shadowed sheet through the engine; level and mode through the tool; the slider and the looks re-enhancing from the photo and keeping the turn. - Parity: ocr.background-removal, ocr.edge-shadow-removal and ocr.despeckle are partial (camera images only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M10: Enhance camera image cleans the photo up and chooses its look (#1034) After Enhance page the bar offers a look (Original, Colour, Greyscale, Black and white) and a Clean-up slider (0-100, default Colour at 50). Choosing a look or letting go of the slider enhances the page again from the straightened photo and turns it as before, so the history keeps one enhancement (and one turn), never a pile of them. camera_clean, pure Rust: - clean: the paper's illumination is estimated per channel on a coarse grid (each block's 90th percentile, lifted to the 75th percentile of the 5x5 blocks around it so a stamp or picture isn't taken for paper, then smoothed) and divided out, so casts, shadows and darker edges go and the paper turns white; a contrast stretch grows with the level, and from 60 isolated dark pixels are removed. Colour ink stays. - apply(look): Original is the photo as taken; Greyscale is the cleaned page in grey; Black and white evens the lighting fully, thresholds the whole page (the level sets the threshold: higher keeps fainter strokes) and despeckles. Black and white is stored as PNG (lossless): JPEG would smear grey around every letter. - Session::enhance_camera_page_at(look, level); page_enhance_camera takes `mode` (original, colour, greyscale, bw) and `level` (0-100), refusing anything else. - "Clean-up", "Original", "Greyscale" and "Black and white" in every catalog with UI coverage, plus es, pl and zh-hant. - Tests: shadow and yellow cast become white paper with dark text, a blue stamp stays blue, strength grows with the level, specks go but text stays, the four looks (black and white is only black and white, the threshold moves with the level), bad sizes; a shadowed sheet through the engine; level and mode through the tool; the slider and the looks re-enhancing from the photo and keeping the turn. - Parity: ocr.background-removal, ocr.edge-shadow-removal and ocr.despeckle are partial (camera images only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Camera level: when another edit broke the run, redo what was undone instead of warping the page again --------- Co-authored-by: magdale76 <16279778+magdale76@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>
393 lines
16 KiB
Rust
393 lines
16 KiB
Rust
//! Clean up a straightened camera photo (Enhance ▸ Camera image ▸ enhancement level): even out
|
||
//! the lighting so the paper turns white (room-light colour casts, a hand's shadow, darker
|
||
//! edges go with it), then raise the contrast and drop isolated specks. Colour ink stays colour.
|
||
//!
|
||
//! The paper's illumination is estimated per channel on a coarse grid of blocks, from each
|
||
//! block's bright end (the paper, not the ink), smoothed into a continuous map and divided out.
|
||
//! Pure Rust and deterministic.
|
||
|
||
/// The strongest a level can be.
|
||
pub const MAX_LEVEL: u8 = 100;
|
||
|
||
/// How an enhanced camera page looks.
|
||
#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
|
||
pub enum Look {
|
||
/// The straightened photo as it was taken.
|
||
Original,
|
||
/// Cleaned up, colour ink kept.
|
||
#[default]
|
||
Colour,
|
||
/// Cleaned up, in shades of grey.
|
||
Greyscale,
|
||
/// Black ink on white paper only, each pixel one or the other.
|
||
BlackWhite,
|
||
}
|
||
|
||
impl Look {
|
||
pub const ALL: [Look; 4] = [Look::Original, Look::Colour, Look::Greyscale, Look::BlackWhite];
|
||
|
||
/// The name tools use.
|
||
pub fn name(self) -> &'static str {
|
||
match self {
|
||
Look::Original => "original",
|
||
Look::Colour => "colour",
|
||
Look::Greyscale => "greyscale",
|
||
Look::BlackWhite => "bw",
|
||
}
|
||
}
|
||
|
||
pub fn from_name(name: &str) -> Option<Look> {
|
||
Look::ALL.into_iter().find(|l| l.name() == name)
|
||
}
|
||
}
|
||
|
||
/// A page's pixels after [`apply`]: RGB8, or one grey byte per pixel.
|
||
#[derive(Clone, Debug, PartialEq)]
|
||
pub enum Pixels {
|
||
Rgb(Vec<u8>),
|
||
Grey(Vec<u8>),
|
||
}
|
||
|
||
/// Give a straightened photo (`rgb`, RGB8) the `look` at `level`. For black and white the level
|
||
/// sets the threshold: higher keeps fainter strokes black. `None` when the buffer doesn't match
|
||
/// the size.
|
||
pub fn apply(rgb: &[u8], width: u32, height: u32, look: Look, level: u8) -> Option<Pixels> {
|
||
let (w, h) = (width as usize, height as usize);
|
||
if w == 0 || h == 0 || w.checked_mul(h)?.checked_mul(3)? != rgb.len() {
|
||
return None;
|
||
}
|
||
let lum = |p: &[u8; 3]| ((p[0] as u32 * 299 + p[1] as u32 * 587 + p[2] as u32 * 114) / 1000) as u8;
|
||
Some(match look {
|
||
Look::Original => Pixels::Rgb(rgb.to_vec()),
|
||
Look::Colour => Pixels::Rgb(clean(rgb, width, height, level)?),
|
||
Look::Greyscale => Pixels::Grey(clean(rgb, width, height, level)?.as_chunks::<3>().0.iter().map(lum).collect()),
|
||
Look::BlackWhite => {
|
||
// The lighting evened out fully, then one threshold for the whole page.
|
||
let even = clean(rgb, width, height, 50)?;
|
||
let t = 0.45 + 0.4 * level.min(MAX_LEVEL) as f32 / MAX_LEVEL as f32;
|
||
let mut grey: Vec<u8> = even.as_chunks::<3>().0.iter().map(|p| if (lum(p) as f32 / 255.0) < t { 0 } else { 255 }).collect();
|
||
despeckle_grey(&mut grey, w, h);
|
||
Pixels::Grey(grey)
|
||
}
|
||
})
|
||
}
|
||
|
||
/// Clean `rgb` (RGB8, `width` × `height`) at `level` (0 = unchanged … 100 = strongest).
|
||
/// Returns `None` when the buffer doesn't match the size.
|
||
pub fn clean(rgb: &[u8], width: u32, height: u32, level: u8) -> Option<Vec<u8>> {
|
||
let (w, h) = (width as usize, height as usize);
|
||
if w == 0 || h == 0 || w.checked_mul(h)?.checked_mul(3)? != rgb.len() {
|
||
return None;
|
||
}
|
||
let level = level.min(MAX_LEVEL);
|
||
if level == 0 {
|
||
return Some(rgb.to_vec());
|
||
}
|
||
let k = level as f32 / MAX_LEVEL as f32;
|
||
let background = background(rgb, w, h);
|
||
// Lighting is evened out fully from half strength on; contrast keeps growing to the top.
|
||
let flatten = (2.0 * k).min(1.0);
|
||
let white = 1.0 - 0.12 * k; // what reaches white
|
||
let black = 0.30 * k; // what reaches black
|
||
let mut out = Vec::with_capacity(rgb.len());
|
||
for (i, px) in rgb.as_chunks::<3>().0.iter().enumerate() {
|
||
let (x, y) = (i % w, i / w);
|
||
let bg = background.at(x, y);
|
||
for (c, &v) in px.iter().enumerate() {
|
||
let v = v as f32 / 255.0;
|
||
let b = bg.get(c).copied().unwrap_or(1.0).max(0.05);
|
||
let even = (v / b).min(1.0);
|
||
let flat = v + (even - v) * flatten;
|
||
let stretched = ((flat - black) / (white - black).max(0.05)).clamp(0.0, 1.0);
|
||
out.push((stretched * 255.0).round() as u8);
|
||
}
|
||
}
|
||
if level >= 60 {
|
||
despeckle(&mut out, w, h);
|
||
}
|
||
Some(out)
|
||
}
|
||
|
||
/// The paper's illumination: a grid of per-channel values, read back with bilinear
|
||
/// interpolation.
|
||
struct Background {
|
||
cols: usize,
|
||
rows: usize,
|
||
block: f32,
|
||
cells: Vec<[f32; 3]>,
|
||
}
|
||
|
||
impl Background {
|
||
fn cell(&self, cx: isize, cy: isize) -> [f32; 3] {
|
||
let cx = cx.clamp(0, self.cols as isize - 1) as usize;
|
||
let cy = cy.clamp(0, self.rows as isize - 1) as usize;
|
||
self.cells.get(cy * self.cols + cx).copied().unwrap_or([1.0; 3])
|
||
}
|
||
|
||
fn at(&self, x: usize, y: usize) -> [f32; 3] {
|
||
// Cell centres sit at (i + 0.5) × block.
|
||
let fx = (x as f32 + 0.5) / self.block - 0.5;
|
||
let fy = (y as f32 + 0.5) / self.block - 0.5;
|
||
let (x0, y0) = (fx.floor(), fy.floor());
|
||
let (ax, ay) = (fx - x0, fy - y0);
|
||
let (x0, y0) = (x0 as isize, y0 as isize);
|
||
let (a, b, c, d) = (self.cell(x0, y0), self.cell(x0 + 1, y0), self.cell(x0, y0 + 1), self.cell(x0 + 1, y0 + 1));
|
||
std::array::from_fn(|i| {
|
||
let top = a[i] * (1.0 - ax) + b[i] * ax;
|
||
let bottom = c[i] * (1.0 - ax) + d[i] * ax;
|
||
top * (1.0 - ay) + bottom * ay
|
||
})
|
||
}
|
||
}
|
||
|
||
/// Estimate the paper's illumination: per block, the 90th percentile of each channel (bright
|
||
/// paper, not dark ink); blocks that are mostly ink borrow from their neighbours; then smoothed.
|
||
fn background(rgb: &[u8], w: usize, h: usize) -> Background {
|
||
let block = (w.min(h) / 16).clamp(8, 128);
|
||
let (cols, rows) = (w.div_ceil(block), h.div_ceil(block));
|
||
let mut cells = Vec::with_capacity(cols * rows);
|
||
let mut hist = [[0u32; 256]; 3];
|
||
for by in 0..rows {
|
||
for bx in 0..cols {
|
||
hist.iter_mut().for_each(|hh| hh.fill(0));
|
||
let mut n = 0u32;
|
||
for y in by * block..((by + 1) * block).min(h) {
|
||
for x in bx * block..((bx + 1) * block).min(w) {
|
||
if let Some(p) = rgb.get((y * w + x) * 3..(y * w + x) * 3 + 3) {
|
||
for (c, &v) in p.iter().enumerate() {
|
||
if let Some(slot) = hist.get_mut(c).and_then(|hh| hh.get_mut(v as usize)) {
|
||
*slot += 1;
|
||
}
|
||
}
|
||
n += 1;
|
||
}
|
||
}
|
||
}
|
||
let want = (n as f32 * 0.9) as u32;
|
||
cells.push(std::array::from_fn(|c| {
|
||
let mut seen = 0;
|
||
let v = hist.get(c).and_then(|hh| {
|
||
hh.iter().position(|&count| {
|
||
seen += count;
|
||
seen > want
|
||
})
|
||
});
|
||
v.unwrap_or(255) as f32 / 255.0
|
||
}));
|
||
}
|
||
}
|
||
// A block darker than its neighbourhood's paper is mostly ink, a stamp or a picture: take
|
||
// the brighter of itself and the 75th percentile of the 5 × 5 blocks around it (so a
|
||
// coloured area up to about half that neighbourhood isn't taken for paper), then smooth.
|
||
let get = |cells: &Vec<[f32; 3]>, x: isize, y: isize| -> [f32; 3] {
|
||
let x = x.clamp(0, cols as isize - 1) as usize;
|
||
let y = y.clamp(0, rows as isize - 1) as usize;
|
||
cells.get(y * cols + x).copied().unwrap_or([1.0; 3])
|
||
};
|
||
let mut lifted = Vec::with_capacity(cells.len());
|
||
for y in 0..rows as isize {
|
||
for x in 0..cols as isize {
|
||
let own = get(&cells, x, y);
|
||
lifted.push(std::array::from_fn(|c| {
|
||
let mut around: Vec<f32> =
|
||
(-2..=2).flat_map(|dy| (-2..=2).map(move |dx| (dx, dy))).map(|(dx, dy)| get(&cells, x + dx, y + dy)[c]).collect();
|
||
around.sort_by(f32::total_cmp);
|
||
let paper = around.get(18).copied().unwrap_or(1.0);
|
||
own[c].max(paper)
|
||
}));
|
||
}
|
||
}
|
||
let mut cells = lifted;
|
||
for _ in 0..2 {
|
||
let mut next = Vec::with_capacity(cells.len());
|
||
for y in 0..rows as isize {
|
||
for x in 0..cols as isize {
|
||
let mut sum = [0.0f32; 3];
|
||
for dy in -1..=1 {
|
||
for dx in -1..=1 {
|
||
let v = get(&cells, x + dx, y + dy);
|
||
for c in 0..3 {
|
||
sum[c] += v[c] / 9.0;
|
||
}
|
||
}
|
||
}
|
||
next.push(sum);
|
||
}
|
||
}
|
||
cells = next;
|
||
}
|
||
Background { cols, rows, block: block as f32, cells }
|
||
}
|
||
|
||
/// [`despeckle`] for one grey byte per pixel.
|
||
fn despeckle_grey(grey: &mut [u8], w: usize, h: usize) {
|
||
let mut rgb: Vec<u8> = grey.iter().flat_map(|&v| [v, v, v]).collect();
|
||
despeckle(&mut rgb, w, h);
|
||
for (g, p) in grey.iter_mut().zip(rgb.as_chunks::<3>().0.iter()) {
|
||
*g = p[0];
|
||
}
|
||
}
|
||
|
||
/// Lighten dark pixels with at most one dark neighbour (specks), in place.
|
||
fn despeckle(rgb: &mut [u8], w: usize, h: usize) {
|
||
let lum = |p: &[u8; 3]| (p[0] as u32 * 299 + p[1] as u32 * 587 + p[2] as u32 * 114) / 1000;
|
||
let dark: Vec<bool> = rgb.as_chunks::<3>().0.iter().map(|p| lum(p) < 128).collect();
|
||
let is_dark = |x: isize, y: isize| {
|
||
x >= 0 && y >= 0 && (x as usize) < w && (y as usize) < h && dark.get(y as usize * w + x as usize).copied().unwrap_or(false)
|
||
};
|
||
for y in 0..h as isize {
|
||
for x in 0..w as isize {
|
||
if !is_dark(x, y) {
|
||
continue;
|
||
}
|
||
let neighbours =
|
||
(-1..=1).flat_map(|dy| (-1..=1).map(move |dx| (dx, dy))).filter(|&(dx, dy)| (dx, dy) != (0, 0) && is_dark(x + dx, y + dy)).count();
|
||
if neighbours <= 1
|
||
&& let Some(p) = rgb.get_mut((y as usize * w + x as usize) * 3..(y as usize * w + x as usize) * 3 + 3)
|
||
{
|
||
p.fill(255);
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
#[cfg(test)]
|
||
mod tests {
|
||
use super::*;
|
||
|
||
/// A synthetic photo of a page: paper lit by `light(x, y)` (per channel, 0–1), with dark
|
||
/// text bars, a blue stamp and a few specks.
|
||
fn photo(w: usize, h: usize, light: impl Fn(usize, usize) -> [f32; 3]) -> Vec<u8> {
|
||
let mut out = Vec::with_capacity(w * h * 3);
|
||
for y in 0..h {
|
||
for x in 0..w {
|
||
let text = (y / 12) % 3 == 1 && x > w / 10 && x < 9 * w / 10 && (x / 9) % 6 != 0;
|
||
let stamp = (x as isize - (3 * w / 4) as isize).pow(2) + (y as isize - (3 * h / 4) as isize).pow(2) < (h as isize / 12).pow(2);
|
||
let speck = (x * 7919 + y * 104729) % 997 == 0;
|
||
let ink: [f32; 3] = if text || speck {
|
||
[0.12, 0.12, 0.12]
|
||
} else if stamp {
|
||
[0.15, 0.25, 0.75]
|
||
} else {
|
||
[0.97, 0.97, 0.95]
|
||
};
|
||
let l = light(x, y);
|
||
for c in 0..3 {
|
||
out.push((ink[c] * l[c] * 255.0).round().clamp(0.0, 255.0) as u8);
|
||
}
|
||
}
|
||
}
|
||
out
|
||
}
|
||
|
||
fn px(img: &[u8], w: usize, x: usize, y: usize) -> [u8; 3] {
|
||
let i = (y * w + x) * 3;
|
||
[img[i], img[i + 1], img[i + 2]]
|
||
}
|
||
|
||
/// A paper point (between text rows, away from the stamp).
|
||
fn paper_points(w: usize, h: usize) -> Vec<(usize, usize)> {
|
||
[(0.05, 0.03), (0.5, 0.03), (0.95, 0.03), (0.05, 0.53), (0.5, 0.53), (0.97, 0.98), (0.03, 0.98)]
|
||
.iter()
|
||
.map(|&(fx, fy)| ((fx * w as f64) as usize, (fy * h as f64) as usize))
|
||
.map(|(x, y)| (x.min(w - 1), (y - y % 36 + 4).min(h - 1)))
|
||
.collect()
|
||
}
|
||
|
||
#[test]
|
||
fn a_shadow_and_a_yellow_cast_become_white_paper() {
|
||
let (w, h) = (480, 640);
|
||
// Warm room light, falling off to a third towards the bottom right (a hand's shadow).
|
||
let light = |x: usize, y: usize| {
|
||
let f = 1.0 - 0.66 * ((x + y) as f32 / (w + h) as f32);
|
||
[0.95 * f, 0.85 * f, 0.6 * f]
|
||
};
|
||
let img = photo(w, h, light);
|
||
let out = clean(&img, w as u32, h as u32, 60).unwrap();
|
||
for (x, y) in paper_points(w, h) {
|
||
let before = px(&img, w, x, y);
|
||
let after = px(&out, w, x, y);
|
||
assert!(after.iter().all(|&v| v >= 235), "({x}, {y}) {before:?} → {after:?}");
|
||
}
|
||
// The text stays dark everywhere, also in the shadow.
|
||
for (x, y) in [(w / 2, 13), (w / 2, 3 * 12 + 13), (w * 8 / 10, h - 40 - (h - 40) % 36 + 13)] {
|
||
let after = px(&out, w, x, y);
|
||
if (x / 9) % 6 != 0 {
|
||
assert!(after.iter().all(|&v| v <= 90), "text at ({x}, {y}): {after:?}");
|
||
}
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn a_blue_stamp_stays_blue() {
|
||
let (w, h) = (480, 640);
|
||
let img = photo(w, h, |_, _| [0.9, 0.85, 0.7]);
|
||
let out = clean(&img, w as u32, h as u32, 100).unwrap();
|
||
// The stamp's centre, on a row without text.
|
||
let [r, g, b] = px(&out, w, 3 * w / 4, 3 * h / 4 + 12);
|
||
assert!(b as i32 - r as i32 > 60 && b as i32 - g as i32 > 40, "{:?}", [r, g, b]);
|
||
}
|
||
|
||
#[test]
|
||
fn level_zero_changes_nothing_and_strength_grows_with_the_level() {
|
||
let (w, h) = (240, 320);
|
||
let img = photo(w, h, |x, _| [0.6 + 0.3 * x as f32 / w as f32; 3]);
|
||
assert_eq!(clean(&img, w as u32, h as u32, 0).unwrap(), img);
|
||
let mean = |v: &[u8]| v.iter().map(|&c| c as f64).sum::<f64>() / v.len() as f64;
|
||
let (a, b, c) = (mean(&img), mean(&clean(&img, w as u32, h as u32, 30).unwrap()), mean(&clean(&img, w as u32, h as u32, 100).unwrap()));
|
||
assert!(a < b && b < c, "{a} {b} {c}");
|
||
}
|
||
|
||
#[test]
|
||
fn specks_go_at_high_levels_but_text_stays() {
|
||
let (w, h) = (240, 320);
|
||
let img = photo(w, h, |_, _| [1.0; 3]);
|
||
let out = clean(&img, w as u32, h as u32, 100).unwrap();
|
||
let specks: Vec<(usize, usize)> = (0..h)
|
||
.flat_map(|y| (0..w).map(move |x| (x, y)))
|
||
// Specks away from the text rows (one touching a letter isn't isolated).
|
||
.filter(|&(x, y)| (x * 7919 + y * 104729) % 997 == 0 && (y / 12) % 3 == 0 && (2..10).contains(&(y % 12)))
|
||
.collect();
|
||
assert!(!specks.is_empty());
|
||
for (x, y) in specks {
|
||
assert!(px(&out, w, x, y).iter().all(|&v| v > 200), "speck at ({x}, {y})");
|
||
}
|
||
assert!(px(&out, w, w / 2 + 1, 13).iter().all(|&v| v < 60), "text");
|
||
}
|
||
|
||
#[test]
|
||
fn the_looks() {
|
||
let (w, h) = (240, 320);
|
||
let img = photo(w, h, |x, _| [0.95 - 0.4 * x as f32 / w as f32, 0.85 - 0.4 * x as f32 / w as f32, 0.65]);
|
||
assert_eq!(apply(&img, w as u32, h as u32, Look::Original, 80), Some(Pixels::Rgb(img.clone())));
|
||
let Some(Pixels::Rgb(colour)) = apply(&img, w as u32, h as u32, Look::Colour, 80) else { panic!("colour") };
|
||
assert_eq!(Some(colour), clean(&img, w as u32, h as u32, 80));
|
||
let Some(Pixels::Grey(grey)) = apply(&img, w as u32, h as u32, Look::Greyscale, 80) else { panic!("grey") };
|
||
assert_eq!(grey.len(), w * h);
|
||
let Some(Pixels::Grey(bw)) = apply(&img, w as u32, h as u32, Look::BlackWhite, 50) else { panic!("bw") };
|
||
assert!(bw.iter().all(|&v| v == 0 || v == 255), "only black and white");
|
||
// Paper (between rows, across the shadow) is white; text is black.
|
||
for x in [5, w / 2, w - 6] {
|
||
assert_eq!(bw[3 * w + x], 255, "paper at x {x}");
|
||
}
|
||
assert_eq!(bw[13 * w + w / 2 + 1], 0, "text");
|
||
// The level moves the threshold: more black at the top than at the bottom.
|
||
let black = |level| match apply(&img, w as u32, h as u32, Look::BlackWhite, level) {
|
||
Some(Pixels::Grey(g)) => g.iter().filter(|&&v| v == 0).count(),
|
||
_ => 0,
|
||
};
|
||
assert!(black(0) <= black(50) && black(50) <= black(100), "{} {} {}", black(0), black(50), black(100));
|
||
for look in Look::ALL {
|
||
assert_eq!(Look::from_name(look.name()), Some(look));
|
||
}
|
||
assert_eq!(apply(&[0; 5], 2, 1, Look::BlackWhite, 50), None);
|
||
}
|
||
|
||
#[test]
|
||
fn bad_sizes_are_none_not_a_panic() {
|
||
assert_eq!(clean(&[], 0, 0, 50), None);
|
||
assert_eq!(clean(&[0; 12], 2, 3, 50), None);
|
||
assert_eq!(clean(&[9; 3], 1, 1, 255).map(|v| v.len()), Some(3));
|
||
}
|
||
}
|