mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-25 10:39:01 -06:00
Four ui_group harnesses waited at most one wall-clock second (200 x 5 ms) for the page to render, and stopped as soon as nothing was pending, which can be before the text layer is even asked for. Under load the text layer came later and column-select, identity and update-check tests failed. They now wait through support::wait_until for what they use (a glyph on screen, the highlight in the document), with its 30-second deadline. The highlighter quick-click test of #1277 itself did not fail on this base in 256 runs. Claude-Session: https://claude.ai/code/session_01PCdPYhYkggLJVYoME2kr5R Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
104 lines
4.2 KiB
Rust
104 lines
4.2 KiB
Rust
//! Help ▸ Check for updates (issue #28), with stand-in release sources (no network).
|
|
|
|
use std::sync::Arc;
|
|
|
|
use egui_kittest::Harness;
|
|
use egui_kittest::kittest::Queryable;
|
|
use pdfcraft_ui_egui::PdfCraftApp;
|
|
use pdfcraft_ui_egui::updates::{Release, UpdateSource, is_newer};
|
|
|
|
fn source(answer: Result<&str, &str>) -> UpdateSource {
|
|
let answer = answer.map(str::to_string).map_err(str::to_string);
|
|
Arc::new(move || answer.clone().map(|v| Release { url: format!("https://github.com/storytold/pdfcraft/releases/tag/{v}"), version: v }))
|
|
}
|
|
|
|
fn harness(answer: Result<&str, &str>) -> Harness<'static, PdfCraftApp> {
|
|
Harness::builder().with_size(egui::vec2(1200.0, 800.0)).build_eframe(move |_cc| {
|
|
let mut app = PdfCraftApp::new();
|
|
app.set_option("language", "en").unwrap();
|
|
app.update_source = Some(source(answer));
|
|
app
|
|
})
|
|
}
|
|
|
|
/// Run frames until the background check has reported. By what the dialog shows, with the
|
|
/// same 30-second deadline as `support::wait_until`, not for a fixed second: under load the
|
|
/// check's thread can take longer (#1277).
|
|
fn settle(h: &mut Harness<'static, PdfCraftApp>) {
|
|
let deadline = std::time::Instant::now() + std::time::Duration::from_secs(30);
|
|
loop {
|
|
h.run_steps(2);
|
|
if h.query_by_label_contains("Checking for a newer version").is_none() {
|
|
break;
|
|
}
|
|
assert!(std::time::Instant::now() < deadline, "timed out waiting for the update check");
|
|
std::thread::sleep(std::time::Duration::from_millis(5));
|
|
}
|
|
h.run_steps(2);
|
|
}
|
|
|
|
#[test]
|
|
fn versions_compare_by_number() {
|
|
assert!(is_newer("v0.2.0", "0.1.1"));
|
|
assert!(is_newer("v0.1.10", "0.1.9"));
|
|
assert!(is_newer("1", "0.9.9"));
|
|
assert!(!is_newer("v0.1.1", "0.1.1"));
|
|
assert!(!is_newer("v0.1.0", "0.1.1"));
|
|
assert!(!is_newer("v0.1.1-beta.2", "0.1.1"), "suffixes are ignored");
|
|
assert!(!is_newer("nightly", "0.1.1"), "a tag that isn't a version is never newer");
|
|
assert!(!is_newer("v1.2.3.4", "0.1.1"));
|
|
assert!(!is_newer("v99999999999999999999.0.0", "0.1.1"), "out of range");
|
|
}
|
|
|
|
#[test]
|
|
fn a_newer_release_is_offered_for_download() {
|
|
let mut h = harness(Ok("v99.0.0"));
|
|
h.state_mut().execute("help.check_updates");
|
|
settle(&mut h);
|
|
h.get_by_label_contains("PdfCraft 99.0.0 is available");
|
|
h.get_by_label("Download");
|
|
h.get_by_label("Later").click();
|
|
h.run_steps(3);
|
|
assert!(h.query_by_label_contains("is available").is_none(), "Later closes the dialog");
|
|
}
|
|
|
|
#[test]
|
|
fn an_up_to_date_or_failed_check_says_so() {
|
|
let mut h = harness(Ok(concat!("v", env!("CARGO_PKG_VERSION"))));
|
|
h.state_mut().execute("help.check_updates");
|
|
settle(&mut h);
|
|
h.get_by_label_contains("is up to date");
|
|
assert!(h.query_by_label("Download").is_none());
|
|
|
|
let mut h = harness(Err("couldn't reach GitHub"));
|
|
h.state_mut().execute("help.check_updates");
|
|
settle(&mut h);
|
|
h.get_by_label_contains("Couldn't check for updates: couldn't reach GitHub");
|
|
}
|
|
|
|
#[test]
|
|
fn nothing_is_asked_until_the_user_checks() {
|
|
// No check at start (the owner's decision): the source is only called from the command.
|
|
let calls = Arc::new(std::sync::atomic::AtomicUsize::new(0));
|
|
let counted = calls.clone();
|
|
let mut h = Harness::builder().with_size(egui::vec2(1200.0, 800.0)).build_eframe(move |_cc| {
|
|
let mut app = PdfCraftApp::new();
|
|
app.set_option("language", "en").unwrap();
|
|
// Settings from a build that had the startup option are ignored.
|
|
app.restore(r#"{"check_updates_at_start": true}"#);
|
|
let counted = counted.clone();
|
|
app.update_source = Some(Arc::new(move || {
|
|
counted.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
|
|
Ok(Release { version: "v99.0.0".into(), url: "https://github.com/storytold/pdfcraft/releases/tag/v99.0.0".into() })
|
|
}));
|
|
app
|
|
});
|
|
settle(&mut h);
|
|
assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 0);
|
|
assert!(h.query_by_label_contains("is available").is_none());
|
|
h.state_mut().execute("help.check_updates");
|
|
settle(&mut h);
|
|
assert_eq!(calls.load(std::sync::atomic::Ordering::SeqCst), 1);
|
|
h.get_by_label_contains("PdfCraft 99.0.0 is available");
|
|
}
|