mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-10-24 10:08:00 -06:00
M14: Arabic and Hebrew file names render in the tab strip, recent files and Properties (#285)
A tab named in Arabic showed replacement boxes: no interface font had the glyphs, and egui joins the letters of a right-to-left word but places the runs in logical order. - Fonts: the interface takes `Arab` faces from the craft-fonts build input (also on wasm), and on desktop adds one font already installed on the machine as the last fallback of every family. It is read at runtime, never embedded; PDFCRAFT_SYSTEM_FONTS=0 turns it off and `cargo xtask screenshots` sets that. AGENTS.md §1.4 records the rule. - Order: bidi::visual puts single-line text in display order with a left-to-right base, used for the painted tab label and hover text, the recent-files name and path, and the Properties File and Location rows. Accessibility names keep the logical text. misc.rtl-ui stays planned: multi-line text, text input and a mirrored layout are not done. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
879d5174c2
commit
d30bb111db
@@ -70,6 +70,8 @@ pub fn run(args: &[String]) -> Result<()> {
|
||||
.arg(PDF)
|
||||
.args(["--size", "1440x900", "--scale", "2", "--width", "1600"])
|
||||
.args(*scene)
|
||||
// Published images show only the embedded, openly licensed fonts (AGENTS.md §1.2).
|
||||
.env("PDFCRAFT_SYSTEM_FONTS", "0")
|
||||
.current_dir(&root)
|
||||
.status()
|
||||
.with_context(|| format!("running shot for {name}"))?;
|
||||
|
||||
Reference in New Issue
Block a user