aleleba/pdfcraft
1
0
Fork 0
mirror of https://github.com/storytold/pdfcraft.git synced 2026-10-26 02:58:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Preferences ▸ Identity: the name on new comments, remembered

Browse Source 
Comments were signed with the login name (or set_option author), with no way
to change it in the app. Preferences gains an Identity section whose name
field (labelled for screen readers) sets the author of new comments; it is
saved with the settings and restored (an empty name keeps the login-name
default; restored names are capped at 200 characters). Japanese labels
added. Test: identity.rs. Parity comment.author-identity: shipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Brandon Thomas
2026-10-05 19:31:23 -04:00
co-authored by Claude Opus 5.5
parent b4e1d488de
commit b315eff24d
5 changed files with 77 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
parity/acrobat-features.toml
+4 -4
View File
@@ -3803,11 +3803,11 @@ title = "Author name from identity preferences"
area = "E"
tier = "P1"
milestone = "M5"
status = "partial"
status = "shipped"
commands = []
tools = ["comment_add"]
evidence = ["crates/ui-egui/tests/comments.rs::dragging_over_text_with_the_highlighter_highlights_it"]
notes = "the login name, as Acrobat defaults to; no Identity preferences yet"
evidence = ["crates/ui-egui/tests/comments.rs::dragging_over_text_with_the_highlighter_highlights_it", "crates/ui-egui/tests/identity.rs::the_identity_name_signs_new_comments_and_is_remembered"]
notes = "Preferences ▸ Identity: the name on new comments (default the login name, as Acrobat), remembered across restarts"
[[feature]]
id = "comment.reply"
@@ -9639,7 +9639,7 @@ status = "partial"
commands = ["app.preferences"]
tools = ["js_enabled"]
evidence = ["crates/ui-egui/tests/javascript.rs::document_scripts_and_preferences"]
notes = "Preferences dialog with the JavaScript category; other categories still live in their tools."
notes = "Preferences dialog with Interface language, Identity and JavaScript; other categories still live in their tools, and it isn't generated from a schema yet."
[[feature]]
id = "misc.prefs-general"