M2.6: draw Highlight annotations that have no appearance stream (#274)

mirror of https://github.com/storytold/pdfcraft.git synced 2026-11-03 06:51:50 -06:00

A Highlight annotation (ISO 32000-2 §12.5.6.10) whose /AP is missing, as
many older and generated files have, was not drawn at all: the vendored
interpreter only draws annotations through their normal appearance.
MuPDF, Poppler and PDFium all draw such highlights.

When there is no usable /AP /N, the interpreter now fills the
/QuadPoints quadrilaterals with /C at /CA opacity, blended with
Multiply, the way pdfcraft-annot draws PdfCraft's own highlights. It
uses the interpreter's own fill path, so clipping, layers and the device
see an ordinary fill. pdfcraft-annot itself can't be reused here: render
and annot are both L3, and it builds pdfcraft-cos objects while hayro
reads hayro-syntax ones. Nothing changes when an /AP exists. Malformed
/QuadPoints (not a non-empty multiple of eight numbers) and an absent,
empty or malformed /C draw nothing, as pdfcraft-annot does. Hidden,
NoView and "Hide all comments" are checked before this point and still
apply. Only Highlight changes; the source PDF is not modified.

Test: raster::tests::highlights_without_an_appearance_are_drawn. On
main the quad stays white; now it is yellow over white and black over
black (Multiply), two quads leave their gap white, /CA 0.5 and gray /C
match MuPDF, Poppler and PDFium. An /AP still wins, and ten malformed or
hidden variants draw nothing. Vendored patch (13) in vendor/README.md;
the parity entry view.render-annotation-appearances cites the test and
notes that other comment types without /AP are still not drawn.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This commit is contained in:

cyfung1031

2026-10-08 09:23:55 -04:00

committed by

GitHub

co-authored by

Claude Opus 5.5

parent 7965b497ff

commit 8c281b39b2

4 changed files with 144 additions and 6 deletions

									
										parity/acrobat-features.toml
									
		+2
		-2
	
												View File
												
				@@ -770,8 +770,8 @@ milestone = "M2"

				status = "shipped"

				commands = []

				tools = []

				evidence = ["crates/render/src/raster.rs::widget_appearance_states"]

				notes = ""

				evidence = ["crates/render/src/raster.rs::widget_appearance_states", "crates/render/src/raster.rs::highlights_without_an_appearance_are_drawn"]

				notes = "a Highlight without /AP is drawn from /QuadPoints, /C and /CA; other comment types without /AP are not drawn yet"

				[[feature]]

				id = "view.render-error-isolation"