From 5e4ca789b8cf07d1463c57f440005686fd3c9687 Mon Sep 17 00:00:00 2001
From: mtlcl410 <2368091+mtlcl410@users.noreply.github.com>
Date: Fri, 23 Oct 2026 07:52:38 +0800
Subject: [PATCH] M6: note why a dotted move that fails half way never reaches
 the document; the parity note says the table tool still refuses periods
 (#2696)

Review on #2957 (benandez, points 2 and 3).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 crates/forms/src/author.rs   | 4 ++++
 parity/acrobat-features.toml | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/crates/forms/src/author.rs b/crates/forms/src/author.rs
index 33a2374409..5370f2590d 100644
--- a/crates/forms/src/author.rs
+++ b/crates/forms/src/author.rs
@@ -1126,6 +1126,10 @@ pub fn set_props(doc: &mut Document, name: &str, props: &FieldProps) -> Result<S
             // Checked before anything changes, so a refused move leaves the field as it was.
             let add = inherited(doc, f.obj);
             check_place(doc, af, f.obj, &parts, &add)?;
+            // From here a failure (a write that `check_place` couldn't foresee) would leave the
+            // field half moved in `doc`. The engine runs every edit on a copy of the document and
+            // keeps it only when the edit succeeds (`Session::apply`), so the open document never
+            // sees that.
             own_inherited(doc, f.obj, &add)?;
             detach(doc, f.obj)?;
             attach(doc, af, f.obj, &parts)?;
diff --git a/parity/acrobat-features.toml b/parity/acrobat-features.toml
index c7f1606650..542ba47505 100644
--- a/parity/acrobat-features.toml
+++ b/parity/acrobat-features.toml
@@ -5070,7 +5070,7 @@ status = "shipped"
 commands = ["form.prepare"]
 tools = ["form_set_props"]
 evidence = ["crates/forms/src/tests.rs::locked_fields_only_take_unlocking", "crates/ui-egui/tests/it/prepare.rs::preview_fills_the_form_and_locked_fields_keep_their_properties", "crates/forms/src/tests.rs::renaming_a_kid_is_checked_against_the_full_name_it_takes", "crates/forms/src/tests.rs::renaming_a_top_level_field_is_still_checked_against_top_level_names", "crates/forms/src/tests.rs::dotted_field_names_are_made_with_parent_fields"]
-notes = "rename in Field Properties ▸ General, which shows the full name; a dotted name (MASTER.first) is a full name and makes or joins parent fields, as Acrobat does, moving a renamed field with what it inherited (#2696); a plain name renames the field within its parent, so the GUI cannot yet move a nested field to the top level; Locked sets the widgets' annotation Locked flag (/F bit 8) and greys out the properties until unlocked; values can still be filled in"
+notes = "rename in Field Properties ▸ General, which shows the full name; a dotted name (MASTER.first) is a full name and makes or joins parent fields, as Acrobat does, moving a renamed field with what it inherited (#2696); Prepare a form's table tool still refuses a period in the cell names it makes; a plain name renames the field within its parent, so the GUI cannot yet move a nested field to the top level; Locked sets the widgets' annotation Locked flag (/F bit 8) and greys out the properties until unlocked; values can still be filled in"
 
 [[feature]]
 id = "form.tab-order"