From 48c1849142cdd7a6cc18d14960c2f8323ab4b791 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Fri, 9 Oct 2026 21:31:45 -0400 Subject: [PATCH] Test: let the About modal settle before clicking (contributors refresh) The 0.5.0 contributors refresh (fb46909) went from 5 to 78 names, so the Grab bag wraps and the self-sizing About modal re-centres for a frame or two without requesting a repaint. The test clicked Table at its previous position and missed. Users aren't affected (it settles within 1-2 frames). Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/tests/links.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/crates/ui-egui/tests/links.rs b/crates/ui-egui/tests/links.rs index d3ee78196..d9e1dc257 100644 --- a/crates/ui-egui/tests/links.rs +++ b/crates/ui-egui/tests/links.rs @@ -70,14 +70,17 @@ fn help_commands_open_each_link() { fn about_dialog_has_contributors_and_models_tabs() { let mut h = harness(|app| app.dialog = Some(Dialog::About)); h.get_by_label("Contributors").click(); - h.run_steps(2); + // The modal sizes to its content and re-centres over the next frames (the grab bag of 70+ + // names wraps, the table grid has a sizing pass) without asking for a repaint, so `run()` + // stops early; run enough frames that the next click lands where the widget now is. + h.run_steps(6); // The owner is always in the compiled-in credits (contributors/contributors.json), shown by username. h.get_by_label("@echelon"); h.get_by_label("Table").click(); - h.run_steps(2); + h.run_steps(6); h.get_by_label("PRs"); h.get_by_label("Display name").click(); - h.run_steps(2); + h.run_steps(6); h.get_by_label("Brandon Thomas"); h.get_by_label("Models").click(); h.run_steps(2);