Comments: a new highlight opens its note for typing (#475) (#481)

Adding a highlight selected its card in the Comments panel but left the
note closed; the text field only appeared after double-clicking the card.
Acrobat opens the note for typing as soon as the highlight is made.

apply_edit now opens the inline editor for a new highlight (text drag,
selection then tool, area highlight all pass through it), unless a note
typed into another card is still unsaved, so that text is never dropped.
This commit is contained in:
MarekSpodBiedry
2026-10-09 09:14:40 -04:00
committed by GitHub
parent bc1d67cb61
commit 271139bd3b
3 changed files with 33 additions and 2 deletions
+2 -2
View File
@@ -3494,8 +3494,8 @@ milestone = "M5"
status = "shipped"
commands = ["comment.highlight"]
tools = ["comment_add"]
evidence = ["crates/ui-egui/tests/comments.rs::dragging_over_text_with_the_highlighter_highlights_it", "crates/engine/src/tests.rs::highlight_multiplies_over_text"]
notes = "drag over text, or pick the tool with text selected; agents can highlight by text search"
evidence = ["crates/ui-egui/tests/comments.rs::dragging_over_text_with_the_highlighter_highlights_it", "crates/ui-egui/tests/comments.rs::a_new_highlight_opens_its_note_for_typing", "crates/engine/src/tests.rs::highlight_multiplies_over_text"]
notes = "drag over text, or pick the tool with text selected; a new highlight opens its note for typing in the Comments panel; agents can highlight by text search"
[[feature]]
id = "comment.underline"