mirror of
https://github.com/storytold/lightcraft.git
synced 2026-10-29 12:37:51 -06:00
skylar taylor-barrickandClaude
e6587c3f82
Unrelated to the #2135 security fix in the commit before this one: both lines predate this branch and are rustc/clippy 1.96 lint churn. `cargo clippy --workspace --all-targets` only warns about them, but `cargo xtask ci` runs it with `-D warnings` (xtask/src/main.rs), so the gate fails before any test runs. - `clippy::nonminimal_bool` in `slide_overlay::shadow` (reported twice, two overlapping suggestions on the one expression): `!(A && B) || !C || !D` is `!(A && B && C && D)` by De Morgan, which is what the line now says. The operands are pure float comparisons and `is_finite` guards with no side effects, so this is an exact rewrite — a NaN or infinite `mx0`/`my0` still makes `shadow` return without drawing, as before. (Clippy's second suggestion drops the `my0.is_finite()` term and is *not* equivalent; it is not used.) - `clippy::drop_non_drop` on `drop(write)` in `same_folder_as_original_refuses_photos_without_a_folder`. The line is not dead: `write` is a closure holding a mutable borrow of `written`, and the `drop` ended that borrow so the next assertion could read it. The closure now lives in a block of its own instead, which ends the borrow at the brace rather than relying on `drop` of a non-`Drop` type. Every assertion of the test is unchanged. Co-Authored-By: Claude <noreply@anthropic.com>