mirror of
https://github.com/storytold/lightcraft.git
synced 2026-10-28 20:17:18 -06:00
Matthew James SivakandClaude Opus 5.5
cf085041ed
Cause: Settings > General > "Confirm before moving photos to Recently Deleted" defaulted to off, so Delete never asked unless the person found the setting; and the grid/filmstrip photo menu's Delete Photo ran photo.delete directly, skipping menus::confirm_delete even with the setting on. Fix: the setting is on by default; the photo menu's Delete Photo goes through menus::confirm_delete like the key and the menu bar. The setting is now saved as `askBeforeDelete`: every earlier version wrote `confirmDelete: false` for people who never opened Settings, so that key is no longer read and those installs ask too. Turning it off still works and survives a restart. ui.menu.invoke / engine.execute (agents) still run the command directly. Test: tests_panels::deleting_a_photo_asks_first_from_the_key_the_menu_and_ the_right_click_menu (failed: off by default, then the right-click menu deleted without asking) and tests_appearance::delete_asks_first_by_default_ also_for_settings_saved_by_earlier_versions (failed: default off). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>