mirror of
https://github.com/storytold/lightcraft.git
synced 2026-10-27 03:27:14 -06:00
Brandon ThomasandClaude Opus 5.5
882a059fac
Saving (Cmd+S or auto-write) now merges LightCraft's properties into an existing sidecar (lightcraft_meta::merge_xmp): owned properties (rating, label, dc/IPTC/rights fields, lc:*) are replaced or removed, capture time and GPS only when LightCraft has a value; everything else (crs:, xmpMM:History, unknown namespaces, packet wrapper) is kept byte for byte. The result is re-parsed and checked before it is written (temp + fsync + rename). A sidecar that isn't valid XMP is copied to .xmp.bak-<time> (never overwriting) before it is replaced; one that can't be read at all is left alone and the save fails. Shared stems: when several catalogued files map to one stem sidecar (IMG.CR3 + IMG.JPG), it belongs to the raw (else the first by name) and the others write and read <file>.xmp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
54 lines
2.5 KiB
Rust
54 lines
2.5 KiB
Rust
use lightcraft_meta::{MergeRules, Metadata, extract, merge_xmp, parse_iptc, parse_xmp, read_exif, write_xmp};
|
|
use proptest::prelude::*;
|
|
|
|
proptest! {
|
|
#![proptest_config(ProptestConfig { cases: 1500, .. ProptestConfig::default() })]
|
|
|
|
#[test]
|
|
fn random_containers_never_panic(mut data in proptest::collection::vec(any::<u8>(), 0..600), kind in 0usize..5) {
|
|
let heads: [&[u8]; 5] = [b"\xff\xd8\xff\xe1", b"\x89PNG\r\n\x1a\n", b"RIFF\0\0\0\0WEBP", b"II*\0", b"MM\0*"];
|
|
let h = heads[kind];
|
|
if data.len() >= h.len() {
|
|
data[..h.len()].copy_from_slice(h);
|
|
}
|
|
let _ = extract(&data);
|
|
let _ = read_exif(&data);
|
|
let _ = parse_iptc(&data);
|
|
}
|
|
|
|
#[test]
|
|
fn random_text_xmp_never_panics(s in ".{0,400}") {
|
|
let _ = parse_xmp(&s);
|
|
}
|
|
|
|
/// Merging into arbitrary (also damaged) packets never panics, and a merge that succeeds
|
|
/// reads back with the written values.
|
|
#[test]
|
|
fn merge_never_panics(cut in 0usize..900, junk in ".{0,20}", rating in 0i8..=5) {
|
|
let base = write_xmp(&Metadata { title: Some("t".into()), rating: Some(1), ..Default::default() }, Some("{}"));
|
|
let mut s: String = base.chars().take(cut).collect();
|
|
s.push_str(&junk);
|
|
s.extend(base.chars().skip(cut));
|
|
let fresh = write_xmp(&Metadata { rating: Some(rating), ..Default::default() }, Some("{\"x\":1}"));
|
|
let rules = MergeRules { owned: &["xmp:Rating", "dc:title", "lc:*"], owned_if_present: &[] };
|
|
if let Ok(out) = merge_xmp(&s, &fresh, rules) {
|
|
let d = parse_xmp(&out).unwrap();
|
|
prop_assert_eq!(d.metadata.rating, Some(rating));
|
|
prop_assert_eq!(d.lc_settings.as_deref(), Some("{\"x\":1}"));
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn user_text_roundtrips(title in "[a-zA-Z0-9 &<>\"'éü€;|/\\\\]{1,40}", kw in proptest::collection::vec("[a-zA-Z0-9 &<>\"'|]{1,12}", 0..5), rating in -1i8..=5) {
|
|
let title = title.trim().to_string();
|
|
prop_assume!(!title.is_empty());
|
|
let kw: Vec<String> = kw.into_iter().map(|k| k.trim().to_string()).filter(|k| !k.is_empty()).collect();
|
|
let m = Metadata { title: Some(title.clone()), keywords: kw.clone(), rating: Some(rating), ..Default::default() };
|
|
let d = parse_xmp(&write_xmp(&m, Some(&title))).unwrap();
|
|
prop_assert_eq!(d.metadata.title, Some(title.clone()));
|
|
prop_assert_eq!(d.metadata.keywords, kw);
|
|
prop_assert_eq!(d.metadata.rating, Some(rating));
|
|
prop_assert_eq!(d.lc_settings, Some(title));
|
|
}
|
|
}
|