Commit Graph
1984 Commits
Author SHA1 Message Date
aiongg e8566e839a Merge PR #2952: LR-EDIT-COLOR-TEMP: a one-field white balance partial keeps the other field's look (#2910)
Conflicts: docs unioned
2026-10-31 02:09:50 +00:00
aiongg b28ef86773 Merge PR #2724: fix(codecs): validate JPEG ICC APP2 chunk sequences
Conflicts: docs/gaps.md header merged (newer date, both change lists), rows kept; other docs unioned
2026-10-31 02:09:46 +00:00
aiongg 0cc014c79a Merge PR #2514: Kelvin for Fujifilm X-Trans III bodies from the RAF's own neutral pair (#730) 2026-10-31 02:09:20 +00:00
aiongg 8241145ba7 Merge PR #3332: LR-BEHAV-TITLEBAR: a dialog leaves the macOS title bar undimmed
Conflicts: docs unioned
2026-10-31 02:09:20 +00:00
aiongg f597811c3b Merge PR #3273: LR-BEHAV-ACCESS: panels and bars are named as landmarks and toolbars
Conflicts: docs unioned, locales/ru.json and sv.json keys unioned
2026-10-31 02:09:13 +00:00
aiongg 538a77e841 Merge PR #3260: LR-BEHAV-ACCESS: a dialog is exposed to screen readers as a dialog, not a group
Conflicts: docs unioned
2026-10-31 02:09:02 +00:00
aiongg 24b817fc26 Merge PR #3253: LR-BEHAV-ACCESS: an icon button's accessible name is its label, with the shortcut as its description
Conflicts: ui-egui/tests/it/accessibility.rs (both tests kept), docs unioned
2026-10-31 02:08:57 +00:00
aiongg 9f587f69d8 Merge PR #3220: MENU-HELP-HELP: on macOS the Help menu is registered with AppKit after the menu bar is installed
Conflicts: apps/lightcraft/src/native_menu.rs (both added lines kept: RowIds and help_menu), docs unioned
2026-10-31 02:08:47 +00:00
aiongg 2933f667fd Merge PR #3214: LR-BEHAV-ACCESS: a slider's value field is named "<slider> value" and describes how to use it
Conflicts: docs/whats-new.md and docs/parity-checklist.md (both sides unioned)
2026-10-31 02:08:26 +00:00
aiongg ef3dff08bc Merge PR #3200: MENU-BAR: shortcuts list their modifiers in one order everywhere on macOS
Conflicts: docs/whats-new.md and docs/parity-checklist.md (both sides unioned), locales/ru.json (both keys kept)
2026-10-31 02:08:10 +00:00
aiongg 21a57ff79a Merge PR #3196: MENU-BAR: the macOS menu bar keeps every row when two rows run the same command
Conflicts: docs/whats-new.md (both entries kept), docs/parity-checklist.md (header change list and revision rows unioned)
2026-10-31 02:07:56 +00:00
aiongg 7c0ec706c4 Merge PR #3167: LR-BEHAV-DIALOGS: a one-line prompt that's refused stays open and says why
Conflicts: docs/whats-new.md (both entries kept), docs/parity-checklist.md (header change list and revision rows unioned; LR-BEHAV-DIALOGS row keeps main's dialog_copy text plus this PR's addition)
2026-10-31 02:07:26 +00:00
aiongg 08fa7ca279 Merge PR #2691: LR-PREF-GENERAL: Esc in a Settings text box gives the text back instead of closing Settings 2026-10-31 02:06:58 +00:00
aiongg 8fb464f8f8 Merge PR #2075: LR-BEHAV-DIALOGS: dialog confirm buttons name their action 2026-10-31 02:06:57 +00:00
Brandon Thomas cfdf63c6e4 Merge PR #2917
# Conflicts:
#	docs/parity-checklist.md
#	docs/whats-new.md
2026-10-30 15:24:59 -04:00
Brandon Thomas 13711ace2b Merge PR #2155 2026-10-30 15:24:41 -04:00
Brandon Thomas 7e8bf5cd9e Merge PR #2831 2026-10-30 15:24:41 -04:00
Brandon Thomas ddbc218ad1 Merge PR #3213
# Conflicts:
#	docs/parity-checklist.md
2026-10-30 15:24:40 -04:00
Nathaniel Ledford 08a70fa7c3 LR-BEHAV-ACCESS: the What's New entry and the revision row name the alert dialog's description 2026-10-29 14:02:02 -04:00
Nathaniel Ledford 62c3344d3c LR-BEHAV-TITLEBAR: a dialog leaves the integrated title bar undimmed
On macOS the window buttons are drawn by the OS above our content, so a backdrop over the
top bar left them bright on a dimmed bar. As under a sheet, the backdrop now stops below the
bar, the bar keeps its color with its controls inactive, a click on it is not a click outside
the dialog, and its empty space still moves the window.
2026-10-29 13:47:52 -04:00
Nathaniel Ledford 4860892332 LR-BEHAV-ACCESS: panels and bars are named as landmarks and toolbars for screen readers 2026-10-29 13:38:03 -04:00
Nathaniel Ledford c9aa1d3b81 LR-BEHAV-ACCESS: the dialog-role comments and docs say what is exposed, not what VoiceOver does 2026-10-29 13:36:43 -04:00
Nathaniel Ledford 443bc5ae03 LR-BEHAV-ACCESS: every dialog is announced as a modal dialog (an alert dialog for the prompts) instead of a group with the title 2026-10-29 13:36:43 -04:00
Nathaniel Ledford c2529503fd LR-BEHAV-DIALOGS: the Move confirm counts restored photos apart from moved ones 2026-10-29 12:22:43 -04:00
Nathaniel Ledford b1d3aa8d6b Merge branch 'main' into mac-glyph-order 2026-10-29 09:08:35 -04:00
Nathaniel Ledford f1a53e29b2 MENU-BAR: the no-photos line in the grid shows the Import shortcut as bound, in the menu bar's modifier order
The line under "No photos" spelled Cmd+Shift+I on every platform and followed no rebinding. It now goes through shortcut_text like every other place the app shows a shortcut.
2026-10-29 08:43:39 -04:00
radialmonsterandClaude Opus 5.5 6188590675 Docs: link gap 8 and roadmap priority 7 to lens profile issue #329
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014ti8KemZbjE2ZgHgV1q1BM
2026-10-28 13:58:49 -04:00
radialmonsterandClaude Sonnet 5.5 b881b20b72 Kelvin for Fujifilm X-Trans III bodies from the RAF's own neutral pair (#730)
X-T20, X-T2, X-Pro2, X-E3, X-H1 and X100F have no measured colour matrix, so
As Shot showed on the relative scale. Their RAFs store the camera's own
neutral multipliers for Illuminant A and D65 (tag 0xf00c). Two points
give a line in (ln R/G, ln B/G); mired is linear along it, isotherms are
perpendicular, tint is scaled by the CIE locus spacing. Only the file's pair
and CIE colorimetry are used. Bodies with matrices are unchanged. The look
stays the per-file JPEG fit.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014ti8KemZbjE2ZgHgV1q1BM
2026-10-28 13:50:56 -04:00
Nathaniel Ledford 17a9e97a38 LR-BEHAV-DIALOGS: a one-line prompt that's refused stays open and says why
A refused Rename Folder, New Folder on Disk or other name prompt closed without a word.
It now stays open with the typed text and toasts the engine's message. A New Folder on
Disk that works says where the folder is.
2026-10-28 11:42:23 -04:00
Nathaniel Ledford 3613a85dcb LR-BEHAV-ACCESS: icon buttons are named by their label, the shortcut is their description 2026-10-28 10:14:39 -04:00
Nathaniel LedfordandClaude Opus 5.5 039a44ea8c LR-BEHAV-DIALOGS: an unusable denoise model closes, export guide names the real button
The unsupported AI Denoise model dialog only closes, but its button said Install or Accept & Download; it now says Close, like the face model dialog. The export guide no longer bolds Export, which is not the label: the button names the photo count (Export 3 Photos).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-28 08:53:55 -04:00
Nathaniel LedfordandClaude e4f16fa90c LR-BEHAV-DIALOGS: own verbs for Auto-Stack and Capture Time, test the button itself
Auto-Stack and Capture Time confirms reused the translation keys of a
noun ("Stack") and a field label ("Change"), so other languages showed
"Stapel" or "変更方法" on the button. They now have their own keys,
"Create Stacks" and "Change Time", in all 13 catalogs. Rename Keyword
says "Merge Keywords" when the new name already exists, as Rename
Person does. The Polish rename help says the file name changes.

The confirm label match is exhaustive now (no unreachable "OK" arm).
User guides, the Apple Photos note and the parity rows no longer tell
people to press OK in Export.

Tests read the text painted inside button:dialogOk, reach the plural
Export label, cover Auto-Stack and Slideshow Export plurals, Rename
Person, smart album Save, and check the German translation of the
verbs.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-28 08:53:55 -04:00
Nathaniel LedfordandClaude 023ee0ef5b LR-BEHAV-DIALOGS: dialog confirm buttons name their action
The confirm button was "OK" in every dialog that had no special case:
New Album, Rename Photos, Auto-Stack, Capture Time, Export and more.
It now says what it does: Create, Rename, Stack, Change, Cull, Copy,
Paste, Export N Photos, and a verb per one-field prompt command.
"OK" stays only for a prompt opened with a command that has no verb.
The automation id button:dialogOk is unchanged.

Rename Photos' help text pointed at the Tags button without saying
what it does; it now says it lists template placeholders, and that
each file is renamed on disk with its XMP sidecar. Contact Sheet,
Auto-Stack and Slideshow Export said "1 photos" / "1 stacks"; their
nouns now agree with the count. All 13 catalogs updated.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-10-28 08:53:55 -04:00
Nathaniel Ledford 71be070a2f LR-PREF-GENERAL: Esc in a Settings text box gives the text back and stays in Settings 2026-10-28 08:24:30 -04:00
Nathaniel Ledford e60b7d1787 MENU-EDIT-SELECTNONE: Edit lists Select Only Active Photo and Paste Settings from Previous with their kin, and the native Edit menu keeps single separators 2026-10-27 22:50:05 -04:00
Nathaniel Ledford 9fabf58cf3 MENU-HELP-HELP: on macOS the Help menu is registered with AppKit after the menu bar is installed 2026-10-27 21:17:14 -04:00
Nathaniel Ledford 4f6f4c4ee8 MENU-FILE-CLOSE: the page says saving at quit can fail 2026-10-27 19:53:43 -04:00
Nathaniel Ledford cb710b8146 LR-BEHAV-ACCESS: a slider's value field is named "<slider> value" and describes how to use it 2026-10-27 18:53:02 -04:00
Nathaniel Ledford e472ffd6a4 MENU-FILE-CLOSE: document that closing the window quits the app 2026-10-27 18:29:56 -04:00
Jeremy 5dea67e348 docs(installer): say that an upgrade reuses the recorded folder even if it was deleted
The restore actions use the recorded folder without checking that it still
exists, so an upgrade creates it again rather than using the default folder.
2026-10-27 21:13:30 +00:00
Nathaniel Ledford ebfd198ea0 MENU-BAR: give each native menu row its own id so repeated commands keep their rows and labels 2026-10-27 16:57:12 -04:00
Nathaniel Ledford e2ccefa1cc MENU-BAR: shortcut hints on macOS list modifiers in the menu bar's order (⌃⌥⇧⌘) 2026-10-27 16:30:18 -04:00
Jeremy 51ecbfece8 docs(installer): note that the 32-bit all-users folder is Program Files (x86); tidy wording 2026-10-27 12:25:19 +00:00
Jeremy 3d40cf08e7 docs(installer): describe the per-user default install location and scope 2026-10-27 12:09:03 +00:00
aiongg 69048937d0 docs: update source paths after the layout moves 2026-10-26 21:39:56 +00:00
softwaregames1andClaude Opus 5.5 22b963f262 Merge storytold/lightcraft main into LR-FILT-SEARCH-META
Conflict only in the docs/parity-checklist.md "Last updated" line: upstream's
line kept, with the LR-FILT-SEARCH-META entry added in front.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SqKgSkHi5MfTQFrZvDKBjm
Co-authored-by: softwaregames1 <167585946+softwaregames1@users.noreply.github.com>
2026-10-26 12:25:52 +00:00
aiongg 21a53cf61f Merge title-bar-movable (lightcraft#2930) into docking-adoption; every craft-libs crate at craft-libs main 1e6f127 2026-10-26 02:20:20 +00:00
aiongg 1952d4fd3c Merge upstream main into docking-adoption 2026-10-26 02:18:38 +00:00
aiongg 003779ce51 Merge upstream main into title-bar-movable; craft-window at craft-libs main 1e6f127 2026-10-26 02:18:22 +00:00
Dylan M. Taylor 8020cd081c showcase: check the file is readable without an empty with-block (#3001) 2026-10-25 21:13:45 -04:00