mirror of
https://github.com/storytold/lightcraft.git
synced 2026-10-24 10:09:01 -06:00
Merge PR #1173: LRC-LIB-REFVIEW: fix Escape and catalog-local reference lifecycle
docs/parity-checklist.md: header and revision rows from both sides
This commit is contained in:
File diff suppressed because one or more lines are too long
+20
-1
@@ -1,6 +1,6 @@
|
||||
# UI parity
|
||||
|
||||
> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-14 · **Change:** minor (zoom row: soft proofing sharp at 1:1; canvas tools by keyboard; focus-order test; ~50 unnamed hand-drawn widgets named) · **Target:** Adobe Lightroom Classic 15.5 / Lightroom 9.6
|
||||
> **Last reviewed:** 2026-10-11 · **Last updated:** 2026-10-21 · **Change:** minor (Reference Escape, catalog-local pins and deleted-photo handling verified on Windows; earlier: zoom row soft proofing sharp at 1:1, canvas tools by keyboard, focus-order test, ~50 unnamed hand-drawn widgets named) · **Target:** Adobe Lightroom Classic 15.5 / Lightroom 9.6
|
||||
|
||||
How LightCraft's interaction compares with Lightroom's: views, panels, tools and handles, modifier
|
||||
keys, shortcuts, zoom, context menus and feel. Rows for individual menu items and shortcuts live in
|
||||
@@ -126,6 +126,24 @@ unnamed was in the way.
|
||||
Not done: brush strokes and red-eye ellipses still need a pointer. Nobody has tried the app with
|
||||
a real screen reader on any platform yet.
|
||||
|
||||
## Reference view lifecycle
|
||||
|
||||
Escape leaves Reference for Detail, preserving the active photo and its edits; a second Escape
|
||||
returns to the grid. Existing dialogs, tools and Lights Out retain their higher-priority Escape
|
||||
handling. The reference stays pinned when leaving the view, but a successful Open/New Library
|
||||
clears it: numeric photo IDs are local to each catalog. A refused switch keeps the current pin,
|
||||
including Open/New refused while an import or its folder scan is running.
|
||||
|
||||
`photo.setReference` refuses missing or Recently Deleted photos without replacing the current
|
||||
pin. Deleting a pinned reference stops drawing it; re-entering Reference falls back to a live
|
||||
active photo. Restoring the photo permits pinning it again. An empty catalog cannot supply one.
|
||||
|
||||
Verification: four new behavioral regressions failed on upstream `76b5377` before the fix.
|
||||
The patched Windows x64 app on RTX 5080 / DX12 passed Escape, edit preservation, delete/restore,
|
||||
and New/Open Library checks using isolated catalogs. Saved exposure survived reopening. Native
|
||||
1400 × 900 captures did not fall back to headless rendering. Control-channel input does not
|
||||
establish OS keyboard delivery or cross-platform acceptance.
|
||||
|
||||
## Revision history
|
||||
|
||||
| Date | Change | Summary |
|
||||
@@ -138,5 +156,6 @@ a real screen reader on any platform yet.
|
||||
| 2026-10-13 | minor | Shortcuts: Home / End and Shift+Left / Right in the two library grids, Cmd+O (Open Library…) and Shift+H (Visualize HDR) get bindings and keyboard tests; percentages and the dated counts above are unchanged |
|
||||
| 2026-10-14 | minor | Zoom row: soft proofing gets zoom windows; LR-VIEW-ZOOM gap closed |
|
||||
| 2026-10-12 | minor | Accessibility: an AccessKit tree audit test over every view, Develop tool and 13 dialogs; unnamed fields, slider ranges and the Auto Stack slider fixed; 30% → 55%; UI remaining 40–70 h → 34–58 h |
|
||||
| 2026-10-21 | minor | Reference Escape exits to Detail; catalog-local pins and missing/deleted reference handling verified with regressions and native Windows smoke |
|
||||
| 2026-10-11 | minor | Zoom row: Compare and Reference get zoom windows; what remains of LR-VIEW-ZOOM is overlays and soft proofing |
|
||||
| 2026-10-10 | major | Created: measured command and shortcut counts, assessment by area, estimates; moved the shortcut conflicts section here from the checklist |
|
||||
|
||||
@@ -1,5 +1,20 @@
|
||||
# What's new in LightCraft
|
||||
|
||||
## 2026-10-21
|
||||
|
||||
### Reference view reliability
|
||||
- Escape now leaves Reference for Detail without changing the active photo or its edits; the next
|
||||
Escape returns to the grid. A dialog, tool or Lights Out still handles Escape first.
|
||||
- Opening or creating a different library clears the pinned reference. Photo IDs belong to one
|
||||
catalog; a pin no longer silently becomes another library's photo with the same numeric ID.
|
||||
- Missing or Recently Deleted photos cannot be pinned. Deleting the pinned reference stops drawing
|
||||
it; re-entering Reference chooses a live photo, and restoring the deleted photo makes it pinnable again.
|
||||
In Recently Deleted, Set as Reference Photo is greyed out, and a refusal says to restore the photo.
|
||||
- Switching library from Reference view goes to the grid instead of an empty Reference canvas. A refused
|
||||
or failed switch keeps both the reference and the Compare pair.
|
||||
- `photo.setReference` refuses an `id` that is not a photo id (a string, a negative or fractional
|
||||
number) instead of pinning the active photo; only an absent or null `id` means the active photo.
|
||||
|
||||
## 2026-10-19
|
||||
|
||||
### The Before label stays in view when zoomed in
|
||||
|
||||
Reference in New Issue
Block a user