From 15bacc76602ef7e8ffbe3a6f7227e942ebfe43c6 Mon Sep 17 00:00:00 2001 From: Chad Elliott Date: Fri, 30 Oct 2026 12:45:13 -0500 Subject: [PATCH] docs(gpu): #1050 the skip-log check catches every GPU skip and logs to a private directory The check grepped for "no GPU adapter" only, so the ctx unit tests' "no GPU device" skips (and nn's "no GPU runner here") went unseen. It now lists every "need":"gpu" line except the expected device-loss one. On the 2026-10-30 lavapipe logs it shows all 24 GPU skips without the opt-in (the old grep showed 21) and nothing with it. The log goes in a new mktemp -d directory instead of a fixed /tmp name another local user could plant a symlink at. Co-Authored-By: Claude Opus 5.5 --- docs/gpu-pipeline.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/gpu-pipeline.md b/docs/gpu-pipeline.md index 736c20871..cd7fd03e3 100644 --- a/docs/gpu-pipeline.md +++ b/docs/gpu-pipeline.md @@ -280,9 +280,9 @@ machine without a hardware GPU (a VM, a container) every GPU test skips. `LIGHTCRAFT_GPU_ALLOW_SOFTWARE=1` lets them through for one run (tests only: the app never sets it): ```sh -rm -f /tmp/gpu-skips.jsonl # the log is appended to; an absolute path, as tests run in crates/gpu -LIGHTCRAFT_GPU_ALLOW_SOFTWARE=1 LIGHTCRAFT_SKIP_LOG=/tmp/gpu-skips.jsonl cargo test -p lightcraft-gpu --tests -grep '"reason":"no GPU adapter' /tmp/gpu-skips.jsonl # no output: nothing skipped for want of an adapter +log="$(mktemp -d)/gpu-skips.jsonl" # a new private directory; an absolute path, as tests run in crates/gpu +LIGHTCRAFT_GPU_ALLOW_SOFTWARE=1 LIGHTCRAFT_SKIP_LOG="$log" cargo test -p lightcraft-gpu --tests +grep '"need":"gpu"' "$log" | grep -v 'lost on purpose' # no output: no GPU test skipped but the device-loss one ``` - **Linux:** Mesa's lavapipe (Vulkan; `mesa-vulkan-drivers` on Debian and Ubuntu). Its storage