mirror of
https://github.com/storytold/gridcraft.git
synced 2026-10-29 13:16:50 -06:00
xc4pr
d046ba6aa7
A Ctrl+click went to the add-to-selection branch, so the link under the pointer was never followed. It now goes through follow_link like a plain click (asks before opening web addresses, jumps to references).
71 lines
2.6 KiB
Rust
71 lines
2.6 KiB
Rust
//! Ctrl+click on a hyperlink cell follows the link (#1198), like a plain click does.
|
|
|
|
use egui::{Event, Modifiers, PointerButton, Pos2};
|
|
use gridcraft_engine::Session;
|
|
use gridcraft_engine::core::CellRef;
|
|
use gridcraft_ui_egui::{SheetApp, grid::Geo};
|
|
use serde_json::json;
|
|
|
|
type Harness = egui_kittest::Harness<'static, SheetApp>;
|
|
|
|
fn harness() -> Harness {
|
|
let mut session = Session::new();
|
|
session.new_workbook();
|
|
session.execute("cell.set", json!({"cell": "B2", "input": "web"})).unwrap();
|
|
session.execute("insert.link", json!({"cell": "B2", "target": "https://example.org/a"})).unwrap();
|
|
session.execute("cell.set", json!({"cell": "B4", "input": "jump"})).unwrap();
|
|
session.execute("insert.link", json!({"cell": "B4", "target": "Sheet1!F9"})).unwrap();
|
|
let mut h = egui_kittest::Harness::builder().with_size(egui::vec2(1200.0, 800.0)).build_ui_state(
|
|
|ui, app: &mut SheetApp| {
|
|
app.logic(ui.ctx());
|
|
app.ui(ui);
|
|
},
|
|
SheetApp::new(session, Default::default()),
|
|
);
|
|
h.run_steps(4);
|
|
h
|
|
}
|
|
|
|
fn left_of_cell(h: &Harness, cell: &str) -> Pos2 {
|
|
let app = h.state();
|
|
let sheet = app.session.active().unwrap().wb.active().unwrap();
|
|
let geo = Geo::new(sheet, app.grid.rect.unwrap(), app.view().scroll);
|
|
let r = geo.cell_rect(sheet, CellRef::parse(cell).unwrap());
|
|
egui::pos2(r.left() + r.width() * 0.3, r.center().y)
|
|
}
|
|
|
|
fn click(h: &mut Harness, cell: &str, modifiers: Modifiers) {
|
|
let pos = left_of_cell(h, cell);
|
|
h.input_mut().events.push(Event::ModifiersChanged(modifiers));
|
|
h.input_mut().events.extend([
|
|
Event::PointerMoved(pos),
|
|
Event::PointerButton { pos, button: PointerButton::Primary, pressed: true, modifiers },
|
|
Event::PointerButton { pos, button: PointerButton::Primary, pressed: false, modifiers },
|
|
]);
|
|
h.run_steps(3);
|
|
h.input_mut().events.push(Event::ModifiersChanged(Modifiers::NONE));
|
|
h.run_steps(1);
|
|
}
|
|
|
|
#[test]
|
|
fn ctrl_click_on_a_web_link_asks_to_open_it() {
|
|
let mut h = harness();
|
|
click(&mut h, "B2", Modifiers::COMMAND);
|
|
let d = h.state().dialog.as_ref().expect("Ctrl+click on a web link opens the confirmation");
|
|
assert_eq!(d.name, "openLink");
|
|
}
|
|
|
|
#[test]
|
|
fn ctrl_click_on_an_internal_link_goes_there() {
|
|
let mut h = harness();
|
|
click(&mut h, "B4", Modifiers::COMMAND);
|
|
assert_eq!(h.state().session.active().unwrap().selection.active.a1(), "F9");
|
|
}
|
|
|
|
#[test]
|
|
fn plain_click_still_follows() {
|
|
let mut h = harness();
|
|
click(&mut h, "B4", Modifiers::NONE);
|
|
assert_eq!(h.state().session.active().unwrap().selection.active.a1(), "F9");
|
|
}
|