mirror of
https://github.com/storytold/gridcraft.git
synced 2026-10-24 10:46:50 -06:00
# Conflicts: # ROADMAP.md # crates/calc/src/tests.rs # crates/chart/src/tests.rs # crates/engine/src/tests.rs # crates/xlsx/src/tests/mod.rs # docs/chart-parity.md
4246 lines
224 KiB
Rust
4246 lines
224 KiB
Rust
use gridcraft_core::{CellRef, Value};
|
||
use serde_json::json;
|
||
|
||
use crate::Session;
|
||
|
||
fn s() -> Session {
|
||
let mut s = Session::new();
|
||
s.new_workbook();
|
||
s
|
||
}
|
||
|
||
fn v(s: &Session, a: &str) -> Value {
|
||
s.doc().unwrap().wb.active().unwrap().value(CellRef::parse(a).unwrap())
|
||
}
|
||
|
||
#[test]
|
||
fn entering_empty_cells_preserves_whole_sheet_formatting() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "existing"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A1:XFD1048576"})).unwrap();
|
||
s.execute("home.alignCenter", json!({})).unwrap();
|
||
let border = gridcraft_model::BorderLine { style: gridcraft_model::BorderStyle::Thin, color: gridcraft_model::Color::Auto };
|
||
s.execute("home.formatCells", json!({"style": {"borders": {"top": border, "bottom": border, "left": border, "right": border}}})).unwrap();
|
||
let expected = {
|
||
let d = s.doc().unwrap();
|
||
d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse("B1").unwrap())).clone()
|
||
};
|
||
assert_eq!(expected.align.h, gridcraft_model::HAlign::Center);
|
||
for (cell, input) in [("A1", "edited"), ("B1", "new"), ("C1", "=1+2"), ("XFD1048576", "edge")] {
|
||
s.execute("cell.set", json!({"cell": cell, "input": input})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse(cell).unwrap())), &expected, "{cell}");
|
||
}
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [["text", 7, true]]})).unwrap();
|
||
for cell in ["D1", "E1", "F1"] {
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse(cell).unwrap())), &expected, "{cell}");
|
||
}
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert!(v(&s, "D1").is_empty());
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse("D1").unwrap())), &expected);
|
||
assert_eq!(d.wb.active().unwrap().cells.len(), 7);
|
||
let (reopened, _) = gridcraft_xlsx::read_xlsx(&gridcraft_xlsx::write_xlsx(&d.wb).unwrap()).unwrap();
|
||
for cell in ["A1", "B1", "C1", "D1", "E1", "F1", "G1", "XFD1048576"] {
|
||
assert_eq!(
|
||
reopened.styles.get(reopened.active().unwrap().style_id(CellRef::parse(cell).unwrap())),
|
||
&expected,
|
||
"{cell} after XLSX round trip"
|
||
);
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn pasted_currency_text_keeps_the_number_from_the_clipboard_html() {
|
||
// #257: "Rp10,000.00" copied from Excel for the web / LibreOffice Calc pasted as text. Their
|
||
// clipboard HTML records the number (x:num, sdval); paste keeps it and shows the same text.
|
||
let mut s = s();
|
||
let text = "Rp10,000.00\tRp2,500.50\tLabel\n";
|
||
let html =
|
||
r#"<table><tr><td x:num="10000">Rp10,000.00</td><td sdval="2500.5" sdnum="1033;0;x"><font>Rp2,500.50</font></td><td>Label</td></tr></table>"#;
|
||
s.execute("edit.paste", json!({"at": "A1", "text": text, "html": html})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::number(10000.0));
|
||
assert_eq!(v(&s, "B1"), Value::number(2500.5));
|
||
assert_eq!(v(&s, "C1"), Value::text("Label"));
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(crate::display::cell_text(&d.wb, sh, CellRef::parse("A1").unwrap()), "Rp10,000.00");
|
||
assert_eq!(crate::display::cell_text(&d.wb, sh, CellRef::parse("B1").unwrap()), "Rp2,500.50");
|
||
|
||
// HTML that doesn't show the same text (left over from another copy) changes nothing; without
|
||
// HTML the text stays text, as typing it would in an en-US locale.
|
||
let stale = r#"<table><tr><td x:num="7">Rp7.00</td></tr></table>"#;
|
||
s.execute("edit.paste", json!({"at": "A3", "text": "Rp10,000.00", "html": stale})).unwrap();
|
||
s.execute("edit.paste", json!({"at": "A4", "text": "Rp10,000.00"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::text("Rp10,000.00"));
|
||
assert_eq!(v(&s, "A4"), Value::text("Rp10,000.00"));
|
||
}
|
||
|
||
#[test]
|
||
fn pasting_html_with_huge_spans_reads_only_the_text_shape() {
|
||
// #2171: a web page's clipboard HTML with enormous colspan/rowspan crashed paste (OOM). The
|
||
// HTML is now read only as far as the tab-separated text reaches; its numbers still apply.
|
||
let mut s = s();
|
||
let row = "<tr><td colspan=16384 rowspan=1048576 x:num='5'>Rp5</td><td colspan=999999999999>x</td></tr>";
|
||
let html = format!("<table>{}</table>", row.repeat(100_000));
|
||
let r = s.execute("edit.paste", json!({"at": "B2", "text": "Rp5\tnext\nlast", "html": html})).unwrap();
|
||
assert_eq!(r, json!({"rows": 2, "cols": 2}));
|
||
assert_eq!(v(&s, "B2"), Value::number(5.0));
|
||
assert_eq!(v(&s, "C2"), Value::text("next"));
|
||
assert_eq!(v(&s, "B3"), Value::text("last"));
|
||
}
|
||
|
||
#[test]
|
||
fn editing_a_name_renames_it_in_formulas() {
|
||
// Name Manager › Edit…: `oldName` edits the name in place; formulas that use it follow.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "21"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Price", "refersTo": "=Sheet1!$A$1"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Other", "refersTo": "=1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=Price*2"})).unwrap();
|
||
let err = s.execute("formulas.defineName", json!({"name": "Other", "refersTo": "=Sheet1!$A$1", "oldName": "Price"}));
|
||
assert!(err.is_err(), "renaming onto another existing name is refused");
|
||
s.execute("formulas.defineName", json!({"name": "Cost", "refersTo": "=Sheet1!$A$1", "comment": "unit", "oldName": "Price"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let names: Vec<&str> = d.wb.names.iter().map(|n| n.name.as_str()).collect();
|
||
assert_eq!(names, ["Other", "Cost"]);
|
||
let b1 = d.wb.active().unwrap().cell(CellRef::parse("B1").unwrap()).and_then(|c| c.formula.clone()).unwrap();
|
||
assert_eq!(b1.text, "Cost*2");
|
||
assert_eq!(v(&s, "B1"), Value::number(42.0));
|
||
assert!(s.execute("formulas.defineName", json!({"name": "X", "oldName": "Missing"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn chart_recommendations_follow_the_data_shape() {
|
||
// #215: Recommended Charts lists chart types for the data; programmatic insert stays dialog-free.
|
||
let mut s = s();
|
||
let kinds = |s: &mut Session, range: &str| -> Vec<String> {
|
||
let r = s.execute("insert.chartRecommendations", json!({"range": range})).unwrap();
|
||
r.as_array().unwrap().iter().map(|x| format!("{}{}", x["type"].as_str().unwrap(), x["subtype"].as_str().unwrap())).collect()
|
||
};
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Fruit", "Sales"], ["Apples", 5], ["Pears", 3], ["Plums", 2]]})).unwrap();
|
||
assert_eq!(kinds(&mut s, "A1:B4"), ["column", "bar", "pie", "doughnut", "linemarkers"]);
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [[1, 2], [2, 4.5], [3, 5.5], [4, 9]]})).unwrap();
|
||
assert_eq!(kinds(&mut s, "D1:E4").first().map(String::as_str), Some("scatter"), "two numeric columns: scatter first");
|
||
s.execute("range.setValues", json!({"range": "G1", "values": [["Q", "North", "South"], ["Q1", 1, -2], ["Q2", 3, 4]]})).unwrap();
|
||
let multi = kinds(&mut s, "G1:I3");
|
||
assert_eq!(multi.first().map(String::as_str), Some("column"));
|
||
assert!(!multi.iter().any(|k| k == "pie"), "several series: no pie");
|
||
assert!(s.execute("insert.chartRecommendations", json!({"range": "K1:K3"})).is_err(), "no numbers, no chart");
|
||
|
||
// Without a type the command inserts the first recommendation; with one, that type.
|
||
s.execute("insert.recommendedCharts", json!({"range": "D1:E4"})).unwrap();
|
||
s.execute("insert.recommendedCharts", json!({"range": "A1:B4", "type": "pie"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let kinds: Vec<_> = d.wb.active().unwrap().charts.iter().map(|c| c.kind).collect();
|
||
assert_eq!(kinds, [gridcraft_model::ChartKind::Scatter, gridcraft_model::ChartKind::Pie]);
|
||
assert!(s.ui_requests.is_empty(), "programmatic calls never open the dialog");
|
||
}
|
||
|
||
#[test]
|
||
fn chart_uses_text_first_area_as_categories_for_later_areas() {
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["Mes", "x", "y", "z", "Ventas"], ["Ene", 1, 1, 1, 10], ["Feb", 1, 1, 1, 20], ["Mar", 1, 1, 1, 30], ["Abr", 1, 1, 1, 40]]}),
|
||
)
|
||
.unwrap();
|
||
|
||
s.execute("insert.chart", json!({"range": "A1:A5,E1:E5", "type": "pie", "at": "G2"})).unwrap();
|
||
let multi = s.doc().unwrap().wb.active().unwrap().charts.last().unwrap().clone();
|
||
assert_eq!(multi.series.len(), 1);
|
||
assert_eq!(multi.series[0].name.as_deref(), Some("Sheet1!$E$1"));
|
||
assert_eq!(multi.series[0].categories.as_deref(), Some("Sheet1!$A$2:$A$5"));
|
||
assert_eq!(multi.series[0].values, "Sheet1!$E$2:$E$5");
|
||
|
||
s.execute("insert.chart", json!({"range": "D1:E5", "type": "pie", "at": "G20"})).unwrap();
|
||
let contiguous = s.doc().unwrap().wb.active().unwrap().charts.last().unwrap().clone();
|
||
assert_eq!(contiguous.series.len(), 2);
|
||
assert_eq!(contiguous.series[0].name.as_deref(), Some("Sheet1!$D$1"));
|
||
assert_eq!(contiguous.series[0].values, "Sheet1!$D$2:$D$5");
|
||
assert_eq!(contiguous.series[1].name.as_deref(), Some("Sheet1!$E$1"));
|
||
assert_eq!(contiguous.series[1].values, "Sheet1!$E$2:$E$5");
|
||
}
|
||
|
||
#[test]
|
||
fn chart_category_axis_from_blank_corner_and_select_data() {
|
||
// #287: numeric X values must be the category axis, not a series of their own.
|
||
let mut s = s();
|
||
let series = |s: &Session| -> Vec<(Option<String>, String)> {
|
||
let d = s.doc().unwrap();
|
||
d.wb.active().unwrap().charts.last().unwrap().series.iter().map(|x| (x.categories.clone(), x.values.clone())).collect()
|
||
};
|
||
// A blank top-left cell marks the first column as category labels, numbers or not.
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[null, "Sales"], [2020, 5], [2021, 7], [2022, 9]]})).unwrap();
|
||
s.execute("insert.chart", json!({"range": "A1:B4", "type": "line"})).unwrap();
|
||
assert_eq!(series(&s), [(Some("Sheet1!$A$2:$A$4".to_string()), "Sheet1!$B$2:$B$4".to_string())]);
|
||
|
||
// With a "Year" header the year column is a series, as before; Select Data fixes it:
|
||
// Horizontal (Category) Axis Labels and Remove on the year series.
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [["Year", "Sales"], [2020, 5], [2021, 7], [2022, 9]]})).unwrap();
|
||
s.execute("insert.chart", json!({"range": "D1:E4", "type": "line"})).unwrap();
|
||
assert_eq!(series(&s).len(), 2);
|
||
assert!(s.execute("chart.selectData", json!({})).is_err(), "nothing to change");
|
||
assert!(s.execute("chart.selectData", json!({"categories": "not a range"})).is_err());
|
||
s.execute("chart.selectData", json!({"categories": "=D2:D4", "removeSeries": [0, 7]})).unwrap();
|
||
assert_eq!(series(&s), [(Some("Sheet1!$D$2:$D$4".to_string()), "Sheet1!$E$2:$E$4".to_string())]);
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
let data = gridcraft_chart::resolve(&d.wb, d.wb.active_sheet, sh.charts.last().unwrap());
|
||
assert_eq!(data.categories, ["2020", "2021", "2022"]);
|
||
// The last series can't be removed; "" clears the labels.
|
||
s.execute("chart.selectData", json!({"categories": "", "removeSeries": [0]})).unwrap();
|
||
assert_eq!(series(&s), [(None, "Sheet1!$E$2:$E$4".to_string())]);
|
||
}
|
||
|
||
#[test]
|
||
fn entry_and_text_paste_use_inherited_formats_and_cell_overrides() {
|
||
let mut s = s();
|
||
s.execute("home.bold", json!({"range": "B:B", "on": true})).unwrap();
|
||
s.execute("home.formatCells", json!({"range": "3:3", "style": {"num_fmt": "@", "font": {"italic": true}}})).unwrap();
|
||
s.execute("home.fontColor", json!({"range": "B3", "color": "#FF0000"})).unwrap();
|
||
let expected = {
|
||
let d = s.doc().unwrap();
|
||
d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse("B3").unwrap())).clone()
|
||
};
|
||
s.execute("cell.set", json!({"cell": "B3", "input": "=1+2"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C3", "input": "00123"})).unwrap();
|
||
s.execute("edit.paste", json!({"at": "D3", "text": "=2+3\t00456"})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::text("=1+2"));
|
||
assert_eq!(v(&s, "C3"), Value::text("00123"));
|
||
assert_eq!(v(&s, "D3"), Value::text("=2+3"));
|
||
assert_eq!(v(&s, "E3"), Value::text("00456"));
|
||
s.execute("cell.set", json!({"cell": "B4", "input": "12%"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(d.wb.styles.get(sh.style_id(CellRef::parse("B3").unwrap())), &expected);
|
||
for cell in ["C3", "D3", "E3"] {
|
||
let st = d.wb.styles.get(sh.style_id(CellRef::parse(cell).unwrap()));
|
||
assert!(st.font.italic);
|
||
assert!(!st.font.bold, "row style takes precedence over column style");
|
||
assert_eq!(st.num_fmt.as_str(), "@");
|
||
}
|
||
let percent = d.wb.styles.get(sh.style_id(CellRef::parse("B4").unwrap()));
|
||
assert!(percent.font.bold);
|
||
assert_ne!(percent.num_fmt.as_str(), "General");
|
||
}
|
||
|
||
#[test]
|
||
fn enter_values_and_formulas() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "10"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A2", "input": "32"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A3", "input": "=sum(a1:a2"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::Number(42.0));
|
||
assert!(s.execute("cell.set", json!({"cell": "A4", "input": "=1+*2"})).is_err());
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "12%"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(crate::display::cell_text(&d.wb, sh, CellRef::parse("B1").unwrap()), "12%");
|
||
}
|
||
|
||
#[test]
|
||
fn formulas_with_the_wrong_argument_count_are_refused_on_entry() {
|
||
// #363: =DATEDIF(start, end) was stored and showed #VALUE!. Like Excel, entry refuses it and
|
||
// the message gives the signature, so the missing unit argument is visible.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "kept"})).unwrap();
|
||
for (input, word) in [
|
||
("=DATEDIF(DATE(2024,1,1),DATE(2024,3,15))", "few"),
|
||
("=1+DATE(2024,1)", "few"),
|
||
("=SUM()", "few"),
|
||
("=IFERROR(1,LEFT(\"a\",1,2,3))", "many"),
|
||
("=datedif(1,2,\"D\",4)", "many"),
|
||
] {
|
||
let e = s.execute("cell.set", json!({"cell": "A1", "input": input})).unwrap_err().to_string();
|
||
assert!(e.contains(&format!("too {word} arguments")), "{input}: {e}");
|
||
assert_eq!(v(&s, "A1"), Value::text("kept"), "{input} must not replace the cell");
|
||
}
|
||
let e = s.execute("cell.set", json!({"cell": "A1", "input": "=DATEDIF(1,2)"})).unwrap_err().to_string();
|
||
assert!(e.contains("DATEDIF(start_date, end_date, unit)"), "{e}");
|
||
// Correct counts, optional arguments left empty, special forms, LAMBDA names and unknown
|
||
// functions (#NAME?) still enter.
|
||
s.execute("formulas.defineName", json!({"name": "TWICE", "refersTo": "=LAMBDA(x,x*2)"})).unwrap();
|
||
for (cell, input) in [
|
||
("B1", "=DATEDIF(DATE(2024,1,1),DATE(2024,3,15),\"D\")"),
|
||
("B2", "=IF(TRUE,1)"),
|
||
("B3", "=LET(a,1,b,2,a+b)"),
|
||
("B4", "=TWICE(4)"),
|
||
("B5", "=NOSUCHFUNCTION(1,2,3)"),
|
||
("B6", "=ROUND(2.5,)"),
|
||
] {
|
||
s.execute("cell.set", json!({"cell": cell, "input": input})).unwrap_or_else(|e| panic!("{input}: {e}"));
|
||
}
|
||
assert_eq!(v(&s, "B1"), Value::Number(74.0));
|
||
assert_eq!(v(&s, "B4"), Value::Number(8.0));
|
||
// Pasted text that isn't a valid formula stays text, as it does for a parse error.
|
||
s.execute("edit.paste", json!({"at": "C1", "text": "=DATEDIF(1,2)\n"})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::text("=DATEDIF(1,2)"));
|
||
}
|
||
|
||
#[test]
|
||
fn evaluate_refuses_what_entry_refuses_and_says_why() {
|
||
// `formulas.evaluate` (the CLI's `eval`, MCP's evaluate_formula) gave #NAME? for any formula
|
||
// that didn't parse, which hid the cause: `=SUM(1;2)`, with the `;` a French or German Excel
|
||
// uses, looked like an unknown function.
|
||
let mut s = s();
|
||
let eval = |s: &mut Session, f: &str| s.execute("formulas.evaluate", json!({"formula": f}));
|
||
let e = eval(&mut s, "=SUM(1;2)").unwrap_err().to_string();
|
||
assert!(e.contains("There's a problem with this formula") && e.contains("expected `,`"), "{e}");
|
||
let e = eval(&mut s, "=DATEDIF(1,2)").unwrap_err().to_string();
|
||
assert!(e.contains("too few arguments"), "{e}");
|
||
// What entry accepts evaluates: an unknown function is #NAME?, as in Excel, missing closing
|
||
// parentheses are added, and the `=` is optional.
|
||
assert_eq!(eval(&mut s, "=SOMME(1,2)").unwrap(), json!({"error": "#NAME?"}));
|
||
assert_eq!(eval(&mut s, "=SUM(1,2").unwrap(), json!(3.0));
|
||
assert_eq!(eval(&mut s, "1/4").unwrap(), json!(0.25));
|
||
}
|
||
|
||
#[test]
|
||
fn an_incomplete_formula_is_refused_with_an_error_about_what_was_typed() {
|
||
// #2030: `=1+` said "unexpected `)`", although no `)` was typed: entry closes missing
|
||
// parentheses and reported the error of its last retry.
|
||
let mut s = s();
|
||
for (input, msg) in [("=1+", "unexpected end of formula"), ("=SUM(1,+", "unexpected end of formula")] {
|
||
let e = s.execute("cell.set", json!({"cell": "A1", "input": input})).unwrap_err().to_string();
|
||
assert!(e.contains("problem with this formula") && e.contains(msg), "{input}: {e}");
|
||
assert!(!e.contains('`'), "{input}: {e}");
|
||
}
|
||
// Missing closing parentheses are still added.
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SUM(1,(2+3"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(6.0));
|
||
}
|
||
|
||
#[test]
|
||
fn undo_redo() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "2"})).unwrap();
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(2.0));
|
||
assert!(s.doc().unwrap().is_dirty());
|
||
}
|
||
|
||
#[test]
|
||
fn redo_selects_the_redone_cell() {
|
||
// #1855: type into A1..A3, click A1, undo, redo: the selection follows the edit to A3.
|
||
let mut s = s();
|
||
for (cell, text) in [("A1", "first"), ("A2", "second"), ("A3", "third")] {
|
||
s.execute("selection.set", json!({"cell": cell})).unwrap();
|
||
s.execute("cell.set", json!({"cell": cell, "input": text})).unwrap();
|
||
}
|
||
s.execute("selection.set", json!({"cell": "A1"})).unwrap();
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(s.doc().unwrap().selection.a1(), "A3");
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::from("third"));
|
||
assert_eq!(s.doc().unwrap().selection.a1(), "A3");
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_edit_undo_redo_and_noop() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"at": "C4", "width": 210, "height": 90, "text": "Original"})).unwrap()["shape"].clone();
|
||
let original = s.doc().unwrap().wb.active().unwrap().shapes[0].clone();
|
||
let mut changed = original.clone();
|
||
changed.text = "First line\n\nSecond line & <text>".into();
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
s.execute("shape.setText", json!({"id": id, "text": changed.text})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], changed);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len + 1);
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], original);
|
||
|
||
let before_noop = s.doc().unwrap().wb.clone();
|
||
let revision = s.doc().unwrap().revision;
|
||
s.execute("shape.setText", json!({"id": id, "text": "Original"})).unwrap();
|
||
assert!(std::sync::Arc::ptr_eq(&s.doc().unwrap().wb, &before_noop));
|
||
assert_eq!(s.doc().unwrap().revision, revision);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
assert_eq!(s.doc().unwrap().redo.len(), 1);
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], changed);
|
||
|
||
s.execute("shape.setText", json!({"id": id, "text": ""})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text, "");
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], changed);
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_rejects_invalid_targets_and_params() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"text": "Original"})).unwrap()["shape"].clone();
|
||
let rectangle = s.execute("insert.shape", json!({"kind": "rectangle", "text": "Rectangle"})).unwrap()["shape"].clone();
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
for params in [
|
||
json!({}),
|
||
json!({"id": id}),
|
||
json!({"id": id, "text": 12}),
|
||
json!({"id": "1", "text": "bad id"}),
|
||
json!({"id": -1, "text": "bad id"}),
|
||
json!({"id": 1.5, "text": "bad id"}),
|
||
json!({"id": u64::from(u32::MAX) + 1, "text": "bad id"}),
|
||
json!({"id": 999, "text": "unknown"}),
|
||
json!({"id": rectangle, "text": "not a text box"}),
|
||
] {
|
||
assert!(matches!(s.execute("shape.setText", params), Err(crate::EngineError::BadParams { .. })));
|
||
assert!(std::sync::Arc::ptr_eq(&s.doc().unwrap().wb, &before));
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
}
|
||
s.execute("home.insertSheet", json!({})).unwrap();
|
||
assert!(matches!(s.execute("shape.setText", json!({"id": id, "text": "wrong sheet"})), Err(crate::EngineError::BadParams { .. })));
|
||
assert_eq!(s.doc().unwrap().wb.sheet(0).unwrap().shapes[0].text, "Original");
|
||
assert!(s.doc().unwrap().wb.active().unwrap().shapes.is_empty());
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_respects_sheet_protection() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"text": "Original"})).unwrap()["shape"].clone();
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
assert!(s.execute("shape.setText", json!({"id": id, "text": "Changed"})).is_err());
|
||
assert!(std::sync::Arc::ptr_eq(&s.doc().unwrap().wb, &before));
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
s.execute("review.unprotectSheet", json!({})).unwrap();
|
||
s.execute("shape.setText", json!({"id": id, "text": "Changed"})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text, "Changed");
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_is_capped_like_a_cell() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"text": "Original"})).unwrap()["shape"].clone();
|
||
// The cap counts characters, not bytes.
|
||
let longest = "é".repeat(32_767);
|
||
s.execute("shape.setText", json!({"id": id, "text": longest})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text.chars().count(), 32_767);
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
let too_long = "x".repeat(32_768);
|
||
assert!(matches!(s.execute("shape.setText", json!({"id": id, "text": too_long})), Err(crate::EngineError::BadParams { .. })));
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text.chars().count(), 32_767);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_edit_survives_xlsx_roundtrip() {
|
||
let mut s = s();
|
||
s.execute("insert.textBox", json!({"text": "Imported"})).unwrap();
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "text-box.xlsx", "base64": saved["base64"]})).unwrap();
|
||
let id = s.doc().unwrap().wb.active().unwrap().shapes[0].id;
|
||
let text = "Edited & <escaped>\n\nLast line\n";
|
||
s.execute("shape.setText", json!({"id": id, "text": text})).unwrap();
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "edited.xlsx", "base64": saved["base64"]})).unwrap();
|
||
let shape = &s.doc().unwrap().wb.active().unwrap().shapes[0];
|
||
assert_eq!(shape.kind, gridcraft_model::ShapeKind::TextBox);
|
||
assert_eq!(shape.text, text);
|
||
}
|
||
|
||
#[test]
|
||
fn no_border_clears_only_shared_edges_and_undo_restores_them() {
|
||
use gridcraft_core::RangeRef;
|
||
use gridcraft_model::{BorderLine, Borders};
|
||
|
||
for (range, neighbors) in [
|
||
("B2", &[("B1", "bottom"), ("B3", "top"), ("A2", "right"), ("C2", "left")][..]),
|
||
(
|
||
"B2:C3",
|
||
&[("B1", "bottom"), ("C1", "bottom"), ("B4", "top"), ("C4", "top"), ("A2", "right"), ("A3", "right"), ("D2", "left"), ("D3", "left")][..],
|
||
),
|
||
] {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2, 3, 4], [5, 6, 7, 8], [9, 10, 11, 12], [13, 14, 15, 16]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "D4", "input": "=SUM(A1:C1)"})).unwrap();
|
||
s.execute("home.bold", json!({"range": "A1:D4", "on": true})).unwrap();
|
||
for preset in ["all", "diagonalDown"] {
|
||
s.execute("home.borders", json!({"range": "A1:D4", "preset": preset, "style": "double", "color": "#CC3344"})).unwrap();
|
||
}
|
||
let before: Vec<_> = RangeRef::parse("A1:D4").unwrap().iter().map(|c| s.execute("cell.get", json!({"cell": c.a1()})).unwrap()).collect();
|
||
s.execute("home.borders", json!({"range": range, "preset": "none"})).unwrap();
|
||
let selected = RangeRef::parse(range).unwrap();
|
||
for original in &before {
|
||
let address = original["cell"].as_str().unwrap();
|
||
let mut expected = original.clone();
|
||
if selected.contains(CellRef::parse(address).unwrap()) {
|
||
expected["style"]["borders"] = json!(Borders::default());
|
||
} else if let Some((_, edge)) = neighbors.iter().find(|(cell, _)| *cell == address) {
|
||
expected["style"]["borders"][*edge] = json!(BorderLine::default());
|
||
}
|
||
assert_eq!(s.execute("cell.get", json!({"cell": address})).unwrap(), expected, "clearing {range}, cell {address}");
|
||
}
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
for original in before {
|
||
assert_eq!(s.execute("cell.get", json!({"cell": original["cell"]})).unwrap(), original);
|
||
}
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn no_border_handles_sheet_corners_without_creating_out_of_bounds_cells() {
|
||
for (range, corner, neighbors) in [
|
||
("A1:B2", "A1", [("B1", "left"), ("A2", "top")]),
|
||
("XFC1048575:XFD1048576", "XFD1048576", [("XFC1048576", "right"), ("XFD1048575", "bottom")]),
|
||
] {
|
||
let mut s = s();
|
||
s.execute("home.borders", json!({"range": range, "preset": "all"})).unwrap();
|
||
s.execute("home.borders", json!({"range": corner, "preset": "none"})).unwrap();
|
||
for (neighbor, edge) in neighbors {
|
||
assert_eq!(s.execute("cell.get", json!({"cell": neighbor})).unwrap()["style"]["borders"][edge]["style"], "None");
|
||
}
|
||
let sh = s.doc().unwrap().wb.active().unwrap();
|
||
assert!(sh.cells.iter().all(|(c, _)| c.is_valid()));
|
||
assert!(sh.cells.iter().count() <= 4);
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn borders_respect_sheet_formatting_protection() {
|
||
let mut s = s();
|
||
s.execute("home.borders", json!({"range": "A1:B2", "preset": "all"})).unwrap();
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let undo_count = s.doc().unwrap().undo.len();
|
||
for preset in ["none", "left"] {
|
||
assert!(s.execute("home.borders", json!({"range": "A1", "preset": preset})).is_err());
|
||
assert_eq!(s.doc().unwrap().wb.styles, before.styles);
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().cells, before.active().unwrap().cells);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_count);
|
||
}
|
||
s.execute("review.protectSheet", json!({"formatCells": true})).unwrap();
|
||
s.execute("home.borders", json!({"range": "A1", "preset": "none"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "B1"})).unwrap()["style"]["borders"]["left"]["style"], "None");
|
||
}
|
||
|
||
#[test]
|
||
fn copy_paste_shifts_formulas() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2], [3, 4]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=A1+B1"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "C1"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "C2"})).unwrap();
|
||
s.execute("edit.paste", json!({})).unwrap();
|
||
assert_eq!(v(&s, "C2"), Value::Number(7.0));
|
||
s.execute("edit.cut", json!({"range": "A1"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "E5"})).unwrap();
|
||
s.execute("edit.paste", json!({})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(1.0));
|
||
let f = s.execute("cell.get", json!({"cell": "C1"})).unwrap();
|
||
assert_eq!(f["formula"], "=E5+B1");
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_copies_selected_displayed_cells_and_styles() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "outside selection"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "B2", "values": [[0.125, "<tag>&\"\nnext"], [0.25, "last"]]})).unwrap();
|
||
s.execute("home.numberFormat", json!({"range": "B2:B3", "code": "0.0%"})).unwrap();
|
||
s.execute("home.bold", json!({"range": "B2", "on": true})).unwrap();
|
||
s.execute("home.italic", json!({"range": "B2", "on": true})).unwrap();
|
||
s.execute("home.fontColor", json!({"range": "B2", "color": "#123456"})).unwrap();
|
||
s.execute("home.fillColor", json!({"range": "B2", "color": "#FEDCBA"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "B2:C3", "html": true})).unwrap();
|
||
let html = copied["html"].as_str().expect("copy publishes HTML as well as plain text");
|
||
assert_eq!(copied["text"], "12.5%\t\"<tag>&\"\"\nnext\"\n25.0%\tlast\n");
|
||
assert!(html.starts_with("<table "));
|
||
assert!(html.ends_with("</table>"));
|
||
assert_eq!(html.matches("<tr>").count(), 2);
|
||
assert_eq!(html.matches("<td ").count(), 4);
|
||
assert!(html.contains("<tag>&"<br>next"));
|
||
for content in ["12.5%", "25.0%", "font-weight:bold;", "font-style:italic;", "color:#123456;", "background:#FEDCBA;", "text-align:right;"] {
|
||
assert!(html.contains(content), "missing {content}");
|
||
}
|
||
assert!(!html.contains("outside selection"));
|
||
assert!(!html.contains("<html"));
|
||
|
||
let cut = s.execute("edit.cut", json!({"range": "B2:C3", "html": true})).unwrap();
|
||
assert_eq!(cut["html"], copied["html"]);
|
||
assert_eq!(cut["text"], copied["text"]);
|
||
s.execute("edit.paste", json!({"at": "E5", "text": cut["text"]})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(0.125));
|
||
assert_eq!(v(&s, "B2"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn copy_and_cut_return_html_only_when_requested() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "x"})).unwrap();
|
||
for cmd in ["edit.copy", "edit.cut"] {
|
||
for params in [json!({"range": "A1"}), json!({"range": "A1", "html": false})] {
|
||
let r = s.execute(cmd, params).unwrap();
|
||
assert_eq!(r["text"], "x\n");
|
||
assert!(r.get("html").is_none(), "{cmd} must not bloat programmatic responses with HTML");
|
||
}
|
||
let r = s.execute(cmd, json!({"range": "A1", "html": true})).unwrap();
|
||
assert!(r["html"].as_str().is_some_and(|h| h.contains(">x</td>")));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_clips_merges_and_skips_hidden_rows() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "merged"})).unwrap();
|
||
s.execute("home.mergeCenter", json!({"range": "B2:D5"})).unwrap();
|
||
s.execute("home.hideRows", json!({"rows": "3:3"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E4", "input": "side"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "B2:C4", "html": true})).unwrap();
|
||
let html = copied["html"].as_str().expect("merged copy publishes HTML");
|
||
assert_eq!(copied["text"], "merged\t\n\t\n");
|
||
assert_eq!(html.matches("<tr>").count(), 2);
|
||
assert_eq!(html.matches("<td ").count(), 1);
|
||
assert!(html.contains("rowspan=\"2\" colspan=\"2\""));
|
||
assert!(html.contains(">merged</td>"));
|
||
|
||
// A selection beginning inside a merge must keep its shape without copying
|
||
// the original anchor's value from outside the selected rectangle.
|
||
let copied = s.execute("edit.copy", json!({"range": "C3:E5", "html": true})).unwrap();
|
||
let html = copied["html"].as_str().expect("partially selected merge publishes HTML");
|
||
assert_eq!(html.matches("<tr>").count(), 2);
|
||
assert_eq!(html.matches("<td ").count(), 3);
|
||
assert!(html.contains("rowspan=\"2\" colspan=\"2\""));
|
||
assert!(!html.contains("merged"));
|
||
assert!(html.contains(">side</td>"));
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_omits_html_for_large_ranges_without_truncating_text() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A10001", "input": "last cell"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "A1:A10001", "html": true})).unwrap();
|
||
assert!(copied.get("html").is_none(), "oversized HTML must be omitted, not partially copied");
|
||
let text = copied["text"].as_str().unwrap();
|
||
assert_eq!(text.lines().count(), 10_001);
|
||
assert!(text.ends_with("last cell\n"));
|
||
let copied = s.execute("edit.copy", json!({"range": "A10001", "html": true})).unwrap();
|
||
assert!(copied["html"].as_str().is_some_and(|html| html.contains("last cell")));
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_omits_html_when_escaping_exceeds_byte_budget() {
|
||
let mut s = s();
|
||
let text = "&".repeat(1_000_000);
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[text]]})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "A1", "html": true})).unwrap();
|
||
assert!(copied.get("html").is_none(), "an oversized escaped value must not produce partial HTML");
|
||
assert_eq!(copied["text"].as_str().unwrap().len(), 1_000_001);
|
||
assert!(copied["text"].as_str().unwrap().ends_with("&\n"));
|
||
}
|
||
|
||
#[test]
|
||
fn insert_delete_rows_adjust() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=SUM(A1:A3)"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "2:2"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "B1"})).unwrap()["formula"], "=SUM(A1:A4)");
|
||
s.execute("cell.set", json!({"cell": "A2", "input": "10"})).unwrap();
|
||
assert_eq!(v(&s, "B1"), Value::Number(16.0));
|
||
s.execute("home.deleteRows", json!({"rows": "1:1"})).unwrap();
|
||
assert_eq!(v(&s, "B1"), Value::Empty);
|
||
assert_eq!(v(&s, "A1"), Value::Number(10.0));
|
||
}
|
||
|
||
#[test]
|
||
fn deleting_a_multi_area_row_selection_removes_every_area_and_undoes_once() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3], [4], [5], [6]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=A6"})).unwrap();
|
||
// Ctrl-select rows 2, 4 and 5:6 (A1 refs are 1-based).
|
||
let sel = &mut s.doc_mut().unwrap().selection;
|
||
sel.ranges = vec![gridcraft_core::RangeRef::rows(1, 1), gridcraft_core::RangeRef::rows(3, 3), gridcraft_core::RangeRef::rows(4, 5)];
|
||
sel.active = CellRef::new(4, 0);
|
||
s.doc_mut().unwrap().undo.clear();
|
||
s.execute("home.deleteRows", json!({})).unwrap();
|
||
assert_eq!((v(&s, "A1"), v(&s, "A2"), v(&s, "A3")), (Value::Number(1.0), Value::Number(3.0), Value::Empty));
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "B1"})).unwrap()["formula"], "=#REF!");
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!((1..=6).map(|r| v(&s, &format!("A{r}"))).collect::<Vec<_>>(), (1..=6).map(|n| Value::Number(n as f64)).collect::<Vec<_>>());
|
||
assert!(s.doc().unwrap().undo.is_empty(), "one undo step restored all rows");
|
||
// The explicit list form behaves the same, for columns too.
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2, 3, 4]]})).unwrap();
|
||
s.execute("home.deleteColumns", json!({"cols": "A:A,C:C"})).unwrap();
|
||
assert_eq!((v(&s, "A1"), v(&s, "B1"), v(&s, "C1")), (Value::Number(2.0), Value::Number(4.0), Value::Empty));
|
||
}
|
||
|
||
#[test]
|
||
fn move_columns_reorders_without_overwriting_and_undoes_once() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2, 3, 4, 5, 6, 7, 8]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "H2", "input": "=B1+D1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "H3", "input": "=SUM(B:B)"})).unwrap();
|
||
s.execute("home.columnWidth", json!({"cols": "B:B", "width": 101})).unwrap();
|
||
s.execute("home.columnWidth", json!({"cols": "C:C", "width": 102})).unwrap();
|
||
let before = s.doc().unwrap().wb.clone();
|
||
s.doc_mut().unwrap().undo.clear();
|
||
|
||
let result = s.execute("sheet.moveColumns", json!({"cols": "B:C", "before": 4})).unwrap();
|
||
assert_eq!(result["cols"], "C:D");
|
||
assert_eq!(
|
||
(0..8).map(|col| v(&s, &CellRef::new(0, col).a1())).collect::<Vec<_>>(),
|
||
vec![
|
||
Value::Number(1.0),
|
||
Value::Number(4.0),
|
||
Value::Number(2.0),
|
||
Value::Number(3.0),
|
||
Value::Number(5.0),
|
||
Value::Number(6.0),
|
||
Value::Number(7.0),
|
||
Value::Number(8.0),
|
||
]
|
||
);
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "H2"})).unwrap()["formula"], "=C1+B1");
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "H3"})).unwrap()["formula"], "=SUM(C:C)");
|
||
let sh = s.doc().unwrap().wb.active().unwrap();
|
||
assert_eq!(sh.col_width(2), 101.0);
|
||
assert_eq!(sh.col_width(3), 102.0);
|
||
assert_eq!(s.doc().unwrap().selection.current().a1(), "C:D");
|
||
assert_eq!(s.doc().unwrap().undo.len(), 1);
|
||
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(*s.doc().unwrap().wb, *before);
|
||
}
|
||
|
||
#[test]
|
||
fn move_columns_can_reorder_left_and_ignores_drops_inside_the_selection() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["A", "B", "C", "D", "E"]]})).unwrap();
|
||
s.execute("sheet.moveColumns", json!({"cols": "D:E", "before": 1})).unwrap();
|
||
assert_eq!(
|
||
(0..5).map(|col| v(&s, &CellRef::new(0, col).a1())).collect::<Vec<_>>(),
|
||
vec!["A".into(), "D".into(), "E".into(), "B".into(), "C".into()]
|
||
);
|
||
let undo = s.doc().unwrap().undo.len();
|
||
s.execute("sheet.moveColumns", json!({"cols": "B:C", "before": 2})).unwrap();
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo);
|
||
}
|
||
|
||
#[test]
|
||
fn insert_copied_cells_inserts_rows_columns_and_blocks() {
|
||
// Issue #21: Insert Copied Cells.
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3], [4], [5]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "=A2*10"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "2:2"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "C4"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A4"), Value::Number(2.0));
|
||
assert_eq!(v(&s, "B4"), Value::Number(20.0), "the formula follows its new row");
|
||
assert_eq!(v(&s, "A5"), Value::Number(4.0));
|
||
assert_eq!(v(&s, "A6"), Value::Number(5.0));
|
||
assert_eq!(s.doc().unwrap().selection.current(), gridcraft_core::RangeRef::rows(3, 3));
|
||
// One undo step puts everything back.
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A4"), Value::Number(4.0));
|
||
assert_eq!(v(&s, "A6"), Value::Empty);
|
||
// Whole columns.
|
||
s.execute("edit.copy", json!({"range": "A:A"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "A1"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::Number(3.0));
|
||
assert_eq!(v(&s, "B3"), Value::Number(3.0));
|
||
assert_eq!(v(&s, "C2"), Value::Number(20.0), "the old column B moved right");
|
||
// A block shifts cells right.
|
||
s.execute("cell.set", json!({"cell": "F1", "input": "x"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "G1", "input": "y"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "F1"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "G1", "shift": "right"})).unwrap();
|
||
assert_eq!(v(&s, "G1"), Value::from("x"));
|
||
assert_eq!(v(&s, "H1"), Value::from("y"));
|
||
assert!(s.clipboard.is_none(), "inserting ends copy mode");
|
||
s.execute("edit.copy", json!({"range": "F1"})).unwrap();
|
||
assert!(s.execute("home.insertCopiedCells", json!({"shift": "up"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn insert_cut_cells_moves_whole_rows() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3], [4], [5]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=A5"})).unwrap();
|
||
// Up: row 5 goes above row 2.
|
||
s.execute("edit.cut", json!({"range": "5:5"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "A2"})).unwrap();
|
||
let col: Vec<Value> = (1..=6).map(|r| v(&s, &format!("A{r}"))).collect();
|
||
assert_eq!(col, [1.0, 5.0, 2.0, 3.0, 4.0].map(Value::Number).into_iter().chain([Value::Empty]).collect::<Vec<_>>());
|
||
assert_eq!(v(&s, "C1"), Value::Number(5.0), "references follow the moved cells");
|
||
assert!(s.clipboard.is_none());
|
||
// Down: row 1 goes above row 4.
|
||
s.execute("edit.cut", json!({"range": "1:1"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "A4"})).unwrap();
|
||
let col: Vec<Value> = (1..=5).map(|r| v(&s, &format!("A{r}"))).collect();
|
||
assert_eq!(col, [5.0, 2.0, 1.0, 3.0, 4.0].map(Value::Number).to_vec());
|
||
assert_eq!(s.doc().unwrap().selection.current(), gridcraft_core::RangeRef::rows(2, 2));
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
// Inside itself, and a cut block, are refused without changing anything.
|
||
s.execute("edit.cut", json!({"range": "2:4"})).unwrap();
|
||
assert!(s.execute("home.insertCopiedCells", json!({"at": "A3"})).is_err());
|
||
s.execute("edit.cut", json!({"range": "A1:A2"})).unwrap();
|
||
assert!(s.execute("home.insertCopiedCells", json!({"at": "B5"})).is_err());
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "B5"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn inserting_or_deleting_cells_cancels_copy_mode() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3]]})).unwrap();
|
||
s.execute("edit.cut", json!({"range": "3:3"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "3:3"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
// The cut data is now in row 4; a paste must not move the new blank row 3 instead.
|
||
assert!(s.execute("edit.paste", json!({"at": "A10"})).is_err());
|
||
assert_eq!(v(&s, "A4"), Value::Number(3.0));
|
||
s.execute("edit.copy", json!({"range": "A:A"})).unwrap();
|
||
s.execute("home.deleteColumns", json!({"cols": "B:B"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
s.execute("edit.copy", json!({"range": "A1"})).unwrap();
|
||
s.execute("home.insertCells", json!({"range": "A1", "shift": "down"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
s.execute("edit.copy", json!({"range": "A2"})).unwrap();
|
||
s.execute("home.deleteCells", json!({"range": "A1", "shift": "up"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [3]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1:A2", "target": "A1:A6"})).unwrap();
|
||
assert_eq!(v(&s, "A6"), Value::Number(11.0));
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "Mon"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "B1", "target": "B1:B3"})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::from("Wed"));
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "Item 9"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "C1", "target": "C1:C2"})).unwrap();
|
||
assert_eq!(v(&s, "C2"), Value::from("Item 10"));
|
||
}
|
||
|
||
#[test]
|
||
fn ctrl_drag_fill_swaps_copy_and_series() {
|
||
// Issue #264: Ctrl+drag fills a lone number as a series, and copies what a plain drag extends.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "7"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1", "target": "A1:A4"})).unwrap();
|
||
assert_eq!(v(&s, "A4"), Value::Number(7.0), "a plain drag copies a lone number");
|
||
s.execute("edit.autoFill", json!({"source": "A1", "target": "A1:A4", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Number(8.0));
|
||
assert_eq!(v(&s, "A4"), Value::Number(10.0));
|
||
// Upward too.
|
||
s.execute("cell.set", json!({"cell": "B5", "input": "7"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "B5", "target": "B3:B5", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::Number(5.0));
|
||
// A two-number series, a list entry and text with a number are copied.
|
||
s.execute("range.setValues", json!({"range": "C1", "values": [[1], [3]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "C1:C2", "target": "C1:C4", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "C3"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "C4"), Value::Number(3.0));
|
||
s.execute("cell.set", json!({"cell": "D1", "input": "Mon"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "D1", "target": "D1:D3", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "D3"), Value::from("Mon"));
|
||
s.execute("cell.set", json!({"cell": "E1", "input": "Item 9"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "E1", "target": "E1:E2", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "E2"), Value::from("Item 9"));
|
||
// Plain text copies either way; an empty source clears.
|
||
s.execute("cell.set", json!({"cell": "F1", "input": "abc"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "F1", "target": "F1:F2", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "F2"), Value::from("abc"));
|
||
s.execute("edit.autoFill", json!({"source": "G1", "target": "G1:G3", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "G3"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_from_the_right_drag_menu_counts_a_lone_number() {
|
||
// Excel's right-drag Fill Series: a lone number counts up, everything else extends as a plain drag.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "7"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1", "target": "A1:A3", "mode": "extend"})).unwrap();
|
||
assert_eq!([v(&s, "A2"), v(&s, "A3")], [Value::Number(8.0), Value::Number(9.0)]);
|
||
s.execute("range.setValues", json!({"range": "B1", "values": [[1], [3]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "B1:B2", "target": "B1:B4", "mode": "extend"})).unwrap();
|
||
assert_eq!([v(&s, "B3"), v(&s, "B4")], [Value::Number(5.0), Value::Number(7.0)]);
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "Item 9"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "C1", "target": "C1:C2", "mode": "extend"})).unwrap();
|
||
assert_eq!(v(&s, "C2"), Value::from("Item 10"));
|
||
// A source with no common pattern continues each cell's own series, as a plain drag does.
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [["Product 1"], ["On backorder"]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "D1:D2", "target": "D1:D4", "mode": "extend"})).unwrap();
|
||
assert_eq!([v(&s, "D3"), v(&s, "D4")], [Value::from("Product 2"), Value::from("On backorder")]);
|
||
}
|
||
|
||
#[test]
|
||
fn fill_without_formatting_extends_the_series_and_keeps_the_target_formats() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [null], [9]]})).unwrap();
|
||
s.execute("home.bold", json!({"range": "A1:A2", "on": true})).unwrap();
|
||
s.execute("home.italic", json!({"range": "A4", "on": true})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1:A2", "target": "A1:A4", "mode": "values"})).unwrap();
|
||
assert_eq!([v(&s, "A3"), v(&s, "A4")], [Value::Number(3.0), Value::Number(4.0)]);
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
let a4 = d.wb.styles.get(sh.style_id(CellRef::parse("A4").unwrap()));
|
||
assert!(a4.font.italic && !a4.font.bold, "A4 keeps its own formats");
|
||
assert!(!d.wb.styles.get(sh.style_id(CellRef::parse("A3").unwrap())).font.bold);
|
||
s.execute("range.setValues", json!({"range": "B1", "values": [["Product 1"], ["On backorder"]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "B1:B2", "target": "B1:B4", "mode": "values"})).unwrap();
|
||
assert_eq!([v(&s, "B3"), v(&s, "B4")], [Value::from("Product 2"), Value::from("On backorder")]);
|
||
}
|
||
|
||
#[test]
|
||
fn insert_delete_cells_adjust() {
|
||
let formula = |s: &mut Session, a: &str| s.execute("cell.get", json!({"cell": a})).unwrap()["formula"].clone();
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3], [4], [5]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=SUM(A1:A5)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C2", "input": "=A4*10"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C3", "input": "=SUM(A1:B5)"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Fourth", "refersTo": "=Sheet1!$A$4"})).unwrap();
|
||
s.execute(
|
||
"home.conditionalFormat",
|
||
json!({"range": "A4:A5", "rule": {"type": "cellIs", "operator": "greater", "value": "3", "preset": "redText"}}),
|
||
)
|
||
.unwrap();
|
||
s.execute("data.validation", json!({"range": "A5", "type": "whole", "operator": "greater", "formula1": "0"})).unwrap();
|
||
s.execute("insert.chart", json!({"range": "A1:A5", "type": "line"})).unwrap();
|
||
// Insert A3 shifting down: ranges across the insertion grow, references below move.
|
||
s.execute("home.insertCells", json!({"range": "A3", "shift": "down"})).unwrap();
|
||
assert_eq!(formula(&mut s, "C1"), "=SUM(A1:A6)");
|
||
assert_eq!(formula(&mut s, "C2"), "=A5*10");
|
||
assert_eq!(formula(&mut s, "C3"), "=SUM(A1:B5)");
|
||
assert_eq!(v(&s, "C2"), Value::Number(40.0));
|
||
let sh = s.doc().unwrap().wb.active().unwrap().clone();
|
||
assert_eq!(s.doc().unwrap().wb.names[0].formula, "Sheet1!$A$5");
|
||
assert_eq!(sh.cond_formats[0].ranges[0].a1(), "A5:A6");
|
||
assert_eq!(sh.validations[0].ranges[0].a1(), "A6");
|
||
assert_eq!(sh.charts[0].series[0].values, "Sheet1!$A$1:$A$6");
|
||
// Delete A5 (the 4) shifting up: references to it become #REF!, those below move up.
|
||
s.execute("home.deleteCells", json!({"range": "A5", "shift": "up"})).unwrap();
|
||
assert_eq!(formula(&mut s, "C1"), "=SUM(A1:A5)");
|
||
assert_eq!(formula(&mut s, "C2"), "=#REF!*10");
|
||
assert_eq!(s.doc().unwrap().wb.names[0].formula, "#REF!");
|
||
assert_eq!(v(&s, "C1"), Value::Number(11.0));
|
||
let sh = s.doc().unwrap().wb.active().unwrap().clone();
|
||
assert_eq!(sh.cond_formats[0].ranges[0].a1(), "A5");
|
||
assert_eq!(sh.validations[0].ranges[0].a1(), "A5");
|
||
assert_eq!(sh.charts[0].series[0].values, "Sheet1!$A$1:$A$5");
|
||
// Shifting right and left.
|
||
s.execute("range.setValues", json!({"range": "E1", "values": [[1, 2, 3]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E3", "input": "=G1+SUM(E1:G1)"})).unwrap();
|
||
s.execute("home.insertCells", json!({"range": "F1", "shift": "right"})).unwrap();
|
||
assert_eq!(formula(&mut s, "E3"), "=H1+SUM(E1:H1)");
|
||
s.execute("home.deleteCells", json!({"range": "E1:F1", "shift": "left"})).unwrap();
|
||
assert_eq!(formula(&mut s, "E3"), "=F1+SUM(E1:F1)");
|
||
assert_eq!(v(&s, "E3"), Value::Number(8.0));
|
||
}
|
||
|
||
#[test]
|
||
fn sort_and_filter() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
s.execute("selection.set", json!({"cell": "B2"})).unwrap();
|
||
s.execute("data.sortDescending", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::from("c"));
|
||
assert_eq!(v(&s, "A1"), Value::from("Name"));
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
let r = s.execute("data.filterBy", json!({"column": "B", "custom": {"op": ">", "value": "1"}})).unwrap();
|
||
assert_eq!(r["hiddenRows"], 1);
|
||
}
|
||
|
||
/// Top 10 keeps the top or bottom N items or percent, ties at the threshold included.
|
||
#[test]
|
||
fn filter_top10_items_and_percent() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Score"], [5], [1], [9], [3], [9], [7], ["x"]]})).unwrap();
|
||
s.execute("selection.set", json!({"cell": "A1"})).unwrap();
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
// Top 2 items: 9, 9 (the "x" text row is hidden too).
|
||
let r = s.execute("data.filterBy", json!({"column": "A", "top": {"count": 2}})).unwrap();
|
||
assert_eq!(r["hiddenRows"], 5);
|
||
// Bottom 2 items: 1, 3.
|
||
let r = s.execute("data.filterBy", json!({"column": "A", "top": {"count": 2, "bottom": true}})).unwrap();
|
||
assert_eq!(r["hiddenRows"], 5);
|
||
// Top 50 percent of 6 numbers = 3 items; the threshold 7 keeps 9, 9, 7.
|
||
let r = s.execute("data.filterBy", json!({"column": "A", "top": {"count": 50, "percent": true}})).unwrap();
|
||
assert_eq!(r["hiddenRows"], 4);
|
||
}
|
||
|
||
/// Two Top 10 criteria on one column (possible in a native JSON file) each keep their own
|
||
/// cutoff: Top 3 and Bottom 4 of 1..5 keep 3 and 4.
|
||
#[test]
|
||
fn filter_top10_two_criteria_on_one_column() {
|
||
use gridcraft_model::FilterCriterion;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["N"], [1], [2], [3], [4], [5]]})).unwrap();
|
||
s.execute("selection.set", json!({"cell": "A1"})).unwrap();
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
let sh = std::sync::Arc::make_mut(&mut s.doc_mut().unwrap().wb).sheet_mut(0).unwrap();
|
||
if let Some(af) = sh.autofilter.as_mut() {
|
||
af.criteria = vec![
|
||
(0, FilterCriterion::Top10 { bottom: false, percent: false, count: 3 }),
|
||
(0, FilterCriterion::Top10 { bottom: true, percent: false, count: 4 }),
|
||
];
|
||
}
|
||
s.execute("data.reapply", json!({})).unwrap();
|
||
let hidden: Vec<u32> = s.active().unwrap().wb.sheet(0).unwrap().rows.iter().filter(|(_, r)| r.hidden).map(|(k, _)| *k).collect();
|
||
// Rows are 0-based: values 1, 2 and 5 sit on rows 1, 2 and 5.
|
||
assert_eq!(hidden, vec![1, 2, 5]);
|
||
}
|
||
|
||
/// Turning the filter on with only the header row selected filters the data below it (#201).
|
||
#[test]
|
||
fn filter_on_a_selected_header_row_covers_the_data_below() {
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["Name", "City"], ["Ana", "SP"], ["Bia", "RJ"], ["Caio", "SP"], ["Duda", "BH"], ["Eva", "RJ"]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("selection.set", json!({"range": "A1:B1"})).unwrap();
|
||
let r = s.execute("data.filter", json!({})).unwrap();
|
||
assert_eq!(r["range"], "A1:B6");
|
||
let r = s.execute("data.filterBy", json!({"column": "B", "values": ["SP"]})).unwrap();
|
||
assert_eq!(r["hiddenRows"], 3);
|
||
// An explicit range is taken as given.
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
let r = s.execute("data.filter", json!({"range": "A1:B1"})).unwrap();
|
||
assert_eq!(r["range"], "A1:B1");
|
||
}
|
||
|
||
#[test]
|
||
fn protection_passwords_stay_out_of_the_journal_and_recorded_scripts() {
|
||
const PW: &str = "synthetic-pw-7319";
|
||
let mut s = s();
|
||
s.execute("automate.recordActions", json!({})).unwrap();
|
||
s.execute("review.protectSheet", json!({"password": PW, "formatCells": true})).unwrap();
|
||
// The password still protects the sheet; the refused attempt isn't journaled.
|
||
assert!(s.execute("review.unprotectSheet", json!({})).is_err());
|
||
s.execute("review.unprotectSheet", json!({"password": PW})).unwrap();
|
||
s.execute("automate.recordActions", json!({"stop": true, "name": "Lock"})).unwrap();
|
||
|
||
let journal = serde_json::to_string(&s.journal).unwrap();
|
||
assert!(!journal.contains(PW), "{journal}");
|
||
let params = |s: &Session, id: &str| s.journal.iter().find(|(c, _)| c == id).map(|(_, p)| p.clone());
|
||
assert_eq!(params(&s, "review.protectSheet"), Some(json!({"formatCells": true})));
|
||
assert_eq!(params(&s, "review.unprotectSheet"), Some(json!({})));
|
||
|
||
// The recorded script is stored in the workbook, so it is saved with the file.
|
||
let bytes = crate::io::save_bytes(&s.doc().unwrap().wb, "book.xlsx").unwrap();
|
||
let (reopened, _) = crate::io::open_bytes("book.xlsx", &bytes).unwrap();
|
||
let script = reopened.names.iter().find(|n| n.name == "_sc_scripts").map(|n| n.formula.clone()).unwrap();
|
||
assert!(script.contains("review.protectSheet"), "{script}");
|
||
assert!(!script.contains(PW), "{script}");
|
||
|
||
// The journal still replays: protection without a password, then unprotection.
|
||
let mut r = self::s();
|
||
for (id, p) in s.journal.iter().filter(|(id, _)| !id.starts_with("automate.")) {
|
||
r.execute(id, p.clone()).unwrap_or_else(|e| panic!("{id}: {e}"));
|
||
let prot = r.doc().unwrap().wb.active().unwrap().protection.clone();
|
||
if id == "review.protectSheet" {
|
||
assert!(prot.as_ref().is_some_and(|p| p.format_cells && p.password.is_none()), "{prot:?}");
|
||
}
|
||
}
|
||
assert!(r.doc().unwrap().wb.active().unwrap().protection.is_none());
|
||
s.execute("automate.runScript", json!({"name": "Lock"})).unwrap();
|
||
}
|
||
|
||
/// A sheet with locked data in A1:B3, unlocked cells in D1:D3 and row 10, then protected.
|
||
fn protected(extra: serde_json::Value) -> Session {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=A1+D1"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [[10], [20], [30]]})).unwrap();
|
||
s.execute("home.lockCell", json!({"range": "D1:D3", "on": false})).unwrap();
|
||
s.execute("home.lockCell", json!({"range": "10:10", "on": false})).unwrap();
|
||
s.execute("review.protectSheet", extra).unwrap();
|
||
s
|
||
}
|
||
|
||
#[test]
|
||
fn protection_refuses_edits_of_locked_cells() {
|
||
let refused = |s: &mut Session, id: &str, p: serde_json::Value| {
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let e = s.execute(id, p).expect_err(id).to_string();
|
||
assert!(e.contains("protected sheet"), "{id}: {e}");
|
||
assert_eq!(*s.doc().unwrap().wb, *before, "{id} changed the workbook");
|
||
};
|
||
let mut s = protected(json!({}));
|
||
refused(&mut s, "cell.set", json!({"cell": "A1", "input": "9"}));
|
||
refused(&mut s, "edit.clearContents", json!({"range": "A1:A3"}));
|
||
refused(&mut s, "edit.clearAll", json!({"range": "A1"}));
|
||
refused(&mut s, "range.setValues", json!({"range": "A2", "values": [[9]]}));
|
||
refused(&mut s, "range.fill", json!({"range": "A5:A6", "input": "x"}));
|
||
refused(&mut s, "edit.fillDown", json!({"range": "A1:A3"}));
|
||
refused(&mut s, "edit.fillRight", json!({"range": "A1:B1"}));
|
||
refused(&mut s, "edit.fillUp", json!({"range": "A1:A3"}));
|
||
refused(&mut s, "edit.fillLeft", json!({"range": "A1:B1"}));
|
||
refused(&mut s, "edit.autoFill", json!({"source": "A1", "target": "A1:A5"}));
|
||
s.execute("edit.copy", json!({"range": "D1"})).unwrap();
|
||
refused(&mut s, "edit.paste", json!({"at": "A2"}));
|
||
refused(&mut s, "edit.paste", json!({"at": "A2", "text": "x\ty"}));
|
||
refused(&mut s, "home.deleteRows", json!({"rows": "2:2"}));
|
||
refused(&mut s, "home.deleteColumns", json!({"cols": "A:A"}));
|
||
refused(&mut s, "home.insertRows", json!({"rows": "1:1"}));
|
||
refused(&mut s, "home.deleteCells", json!({"range": "A1", "shift": "up"}));
|
||
refused(&mut s, "home.insertCells", json!({"range": "A1", "shift": "down"}));
|
||
refused(&mut s, "edit.replace", json!({"what": "2", "with": "5"}));
|
||
refused(&mut s, "data.goalSeek", json!({"set": "B1", "to": 50, "changing": "A1"}));
|
||
// Unlocked cells stay editable.
|
||
s.execute("edit.paste", json!({"at": "D2"})).unwrap();
|
||
assert_eq!(v(&s, "D2"), Value::Number(10.0));
|
||
s.execute("range.setValues", json!({"range": "D2", "values": [[5]]})).unwrap();
|
||
s.execute("edit.fillDown", json!({"range": "D1:D3"})).unwrap();
|
||
assert_eq!(v(&s, "D3"), Value::Number(10.0));
|
||
s.execute("edit.clearContents", json!({"range": "D3"})).unwrap();
|
||
assert_eq!(v(&s, "D3"), Value::Empty);
|
||
s.execute("data.goalSeek", json!({"set": "B1", "to": 50, "changing": "D1"})).unwrap();
|
||
assert!((v(&s, "B1").as_f64().unwrap() - 50.0).abs() < 0.001);
|
||
s.execute("edit.replace", json!({"what": "49", "with": "48", "wholeCell": true})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
}
|
||
|
||
#[test]
|
||
fn protection_allows_permitted_row_and_column_edits() {
|
||
let mut s = protected(json!({"insertRows": true, "deleteRows": true, "insertColumns": true}));
|
||
// Inserting shifts locked cells, which the protection allows.
|
||
s.execute("home.insertRows", json!({"rows": "1:1"})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Number(1.0));
|
||
s.execute("home.insertColumns", json!({"cols": "A:A"})).unwrap();
|
||
// Deleting a row with locked cells isn't; deleting an unlocked row is.
|
||
assert!(s.execute("home.deleteRows", json!({"rows": "2:2"})).is_err());
|
||
s.execute("home.deleteRows", json!({"rows": "11:11"})).unwrap();
|
||
assert!(s.execute("home.deleteColumns", json!({"cols": "Z:Z"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn hidden_formulas_stay_hidden_on_protected_sheets() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(3)*7"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=1+1"})).unwrap();
|
||
s.execute("home.formatCells", json!({"range": "A1", "style": {"protection": {"locked": true, "hidden": true}}})).unwrap();
|
||
s.execute("formulas.showFormulas", json!({"on": true})).unwrap();
|
||
let text = |s: &Session, a: &str| {
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
crate::display::cell_text(&d.wb, sh, CellRef::parse(a).unwrap())
|
||
};
|
||
assert_eq!(text(&s, "A1"), "=SEQUENCE(3)*7");
|
||
assert_eq!(s.execute("edit.find", json!({"what": "SEQUENCE", "all": true})).unwrap()["count"], 1);
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
assert_eq!(text(&s, "A1"), "7");
|
||
assert_eq!(text(&s, "B1"), "=1+1");
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert!(crate::display::formula_hidden(&d.wb, sh, CellRef::parse("A2").unwrap()));
|
||
assert!(!crate::display::formula_hidden(&d.wb, sh, CellRef::parse("B1").unwrap()));
|
||
assert!(s.execute("edit.find", json!({"what": "SEQUENCE", "all": true})).is_err());
|
||
let r = s.execute("edit.find", json!({"what": "7", "all": true})).unwrap();
|
||
assert_eq!(r["results"][0]["value"], "7");
|
||
}
|
||
|
||
#[test]
|
||
fn case_sensitive_sort_puts_lowercase_first() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["b"], ["B"], ["Ab"], ["a"], ["aB"], ["A"]]})).unwrap();
|
||
s.execute("data.sort", json!({"range": "A1:A6", "header": false, "matchCase": true, "keys": [{"column": "A"}]})).unwrap();
|
||
let col: Vec<Value> = (1..=6).map(|r| v(&s, &format!("A{r}"))).collect();
|
||
assert_eq!(col, ["a", "A", "aB", "Ab", "b", "B"].map(Value::from));
|
||
}
|
||
|
||
#[test]
|
||
fn sort_with_a_sheet_prefix_sorts_the_named_sheet() {
|
||
let col = |s: &Session, sheet: &str| -> Vec<Value> {
|
||
let wb = &s.doc().unwrap().wb;
|
||
let sh = wb.sheet(wb.sheet_index(sheet).unwrap()).unwrap();
|
||
(1..=3).map(|r| sh.value(CellRef::new(r, 0))).collect()
|
||
};
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Qty"], ["a", 3], ["b", 1], ["c", 2]]})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Prices"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "Prices!A1", "values": [["Item", "Price"], ["p1", 10], ["p2", 30], ["p3", 20]]})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Sheet1"})).unwrap();
|
||
let r = s.execute("data.sort", json!({"range": "Prices!A1:B4", "header": true, "keys": [{"column": "B", "order": "desc"}]})).unwrap();
|
||
assert_eq!(r["sorted"], "A2:B4");
|
||
assert_eq!(col(&s, "Prices"), ["p2", "p3", "p1"].map(Value::from));
|
||
assert_eq!(col(&s, "Sheet1"), ["a", "b", "c"].map(Value::from));
|
||
s.execute("data.sortAscending", json!({"range": "Prices!A2:B4", "column": "B"})).unwrap();
|
||
assert_eq!(col(&s, "Prices"), ["p1", "p3", "p2"].map(Value::from));
|
||
assert_eq!(col(&s, "Sheet1"), ["a", "b", "c"].map(Value::from));
|
||
// The selection belongs to the active sheet, so another sheet needs its range.
|
||
assert!(s.execute("data.sort", json!({"sheet": "Prices", "keys": [{"column": "B"}]})).is_err());
|
||
assert!(s.execute("data.sort", json!({"range": "Nowhere!A1:B4", "keys": [{"column": "B"}]})).is_err());
|
||
assert_eq!(col(&s, "Sheet1"), ["a", "b", "c"].map(Value::from));
|
||
}
|
||
|
||
#[test]
|
||
fn remove_duplicates_compares_shown_text() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Date", "Price"], ["2006-03-08", 1.01], ["2006-03-08", 1.02]]})).unwrap();
|
||
s.execute("home.numberFormat", json!({"range": "A3", "code": "mmm d, yyyy"})).unwrap();
|
||
s.execute("home.numberFormat", json!({"range": "B2:B3", "code": "0.0"})).unwrap();
|
||
let r = s.execute("data.removeDuplicates", json!({"range": "A1:A3", "header": true})).unwrap();
|
||
assert_eq!(r["removed"], 0);
|
||
let r = s.execute("data.removeDuplicates", json!({"range": "B1:B3", "header": true})).unwrap();
|
||
assert_eq!(r["removed"], 1);
|
||
}
|
||
|
||
#[test]
|
||
fn remove_duplicates_with_a_sheet_prefix_works_on_the_named_sheet() {
|
||
let col = |s: &Session, sheet: &str| -> Vec<Value> {
|
||
let wb = &s.doc().unwrap().wb;
|
||
let sh = wb.sheet(wb.sheet_index(sheet).unwrap()).unwrap();
|
||
(1..=3).map(|r| sh.value(CellRef::new(r, 0))).collect()
|
||
};
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name"], ["a"], ["a"], ["a"]]})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Prices"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "Prices!A1", "values": [["Item"], ["p1"], ["p1"], ["p2"]]})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Sheet1"})).unwrap();
|
||
let r = s.execute("data.removeDuplicates", json!({"range": "Prices!A1:A4", "header": true})).unwrap();
|
||
assert_eq!(r["removed"], 1);
|
||
assert_eq!(col(&s, "Prices"), [Value::from("p1"), Value::from("p2"), Value::Empty]);
|
||
assert_eq!(col(&s, "Sheet1"), ["a", "a", "a"].map(Value::from));
|
||
// The selection belongs to the active sheet, so another sheet needs its range.
|
||
assert!(s.execute("data.removeDuplicates", json!({"sheet": "Prices", "header": true})).is_err());
|
||
assert!(s.execute("data.removeDuplicates", json!({"sheet": "Sheet1", "range": "Prices!A1:A4", "header": true})).is_err());
|
||
assert!(s.execute("data.removeDuplicates", json!({"range": "Nowhere!A1:A4", "header": true})).is_err());
|
||
assert_eq!(col(&s, "Sheet1"), ["a", "a", "a"].map(Value::from));
|
||
}
|
||
|
||
#[test]
|
||
fn filter_with_a_sheet_prefix_toggles_the_named_sheet() {
|
||
let sheet = |s: &Session, name: &str| -> gridcraft_model::Sheet {
|
||
let wb = &s.doc().unwrap().wb;
|
||
wb.sheet(wb.sheet_index(name).unwrap()).unwrap().clone()
|
||
};
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Qty"], ["a", 3], ["b", 1]]})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Prices"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "Prices!A1", "values": [["Item", "Price"], ["p1", 10], ["p2", 30]]})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Sheet1"})).unwrap();
|
||
let r = s.execute("data.filter", json!({"range": "Prices!A1:B3"})).unwrap();
|
||
assert_eq!(r["range"], "A1:B3");
|
||
assert_eq!(sheet(&s, "Prices").autofilter.map(|a| a.range.a1()), Some("A1:B3".to_string()));
|
||
assert!(sheet(&s, "Sheet1").autofilter.is_none());
|
||
s.execute("data.filter", json!({"range": "Prices!A1:B3"})).unwrap();
|
||
assert!(sheet(&s, "Prices").autofilter.is_none());
|
||
assert!(sheet(&s, "Sheet1").autofilter.is_none());
|
||
assert!(s.execute("data.filter", json!({"sheet": "Prices"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn filter_with_a_sheet_prefix_toggles_the_table_at_the_range() {
|
||
let mut s = s();
|
||
s.execute("home.insertSheet", json!({"name": "Prices"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "Prices!A1", "values": [["Item", "Price"], ["p1", 10], ["p2", 30]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B3", "header": true})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Sheet1"})).unwrap();
|
||
// The active cell is outside the table's cells, so only `range` can find the table.
|
||
s.execute("selection.set", json!({"range": "E10"})).unwrap();
|
||
let prices = |s: &Session| {
|
||
let wb = &s.doc().unwrap().wb;
|
||
wb.sheet(wb.sheet_index("Prices").unwrap()).unwrap().clone()
|
||
};
|
||
assert!(prices(&s).tables[0].filter_button);
|
||
s.execute("data.filter", json!({"range": "Prices!A2:B3"})).unwrap();
|
||
assert!(!prices(&s).tables[0].filter_button);
|
||
assert!(prices(&s).autofilter.is_none());
|
||
assert!(s.doc().unwrap().wb.active().unwrap().autofilter.is_none());
|
||
}
|
||
|
||
#[test]
|
||
fn subtotal_with_a_sheet_prefix_works_on_the_named_sheet() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Qty"], ["x", 1], ["x", 2], ["y", 3]]})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Prices"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "Prices!A1", "values": [["Item", "Qty"], ["a", 1], ["a", 2], ["b", 4]]})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Sheet1"})).unwrap();
|
||
let r = s.execute("data.subtotal", json!({"range": "Prices!A1:B4", "groupBy": "A", "columns": ["B"]})).unwrap();
|
||
assert_eq!(r["groups"], 2);
|
||
let wb = &s.doc().unwrap().wb;
|
||
let prices = wb.sheet(wb.sheet_index("Prices").unwrap()).unwrap();
|
||
let col = |sh: &gridcraft_model::Sheet, c: u32| -> Vec<Value> { (0..7).map(|r| sh.value(CellRef::new(r, c))).collect() };
|
||
assert_eq!(col(prices, 0), ["Item", "a", "a", "a Total", "b", "b Total", "Grand Total"].map(Value::from));
|
||
assert_eq!(col(prices, 1)[1..], [1.0, 2.0, 3.0, 4.0, 4.0, 7.0].map(Value::from));
|
||
assert!(wb.styles.get(prices.style_id(CellRef::new(3, 0))).font.bold);
|
||
assert_eq!(prices.rows.get(&1).map(|l| l.outline), Some(1));
|
||
let sheet1 = wb.sheet(wb.sheet_index("Sheet1").unwrap()).unwrap();
|
||
assert_eq!(col(sheet1, 0)[..4], ["Name", "x", "x", "y"].map(Value::from));
|
||
assert!(sheet1.value(CellRef::new(4, 0)).is_empty());
|
||
assert!(sheet1.rows.values().all(|l| l.outline == 0));
|
||
assert!(s.execute("data.group", json!({"sheet": "Prices"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn formatting_and_styles() {
|
||
let mut s = s();
|
||
s.execute("selection.set", json!({"range": "A1:B2"})).unwrap();
|
||
s.execute("home.bold", json!({})).unwrap();
|
||
s.execute("home.fillColor", json!({"color": "#FFFF00"})).unwrap();
|
||
s.execute("home.mergeCenter", json!({})).unwrap();
|
||
let c = s.execute("cell.get", json!({"cell": "B2"})).unwrap();
|
||
assert_eq!(c["style"]["font"]["bold"], true);
|
||
assert_eq!(c["merge"], "A1:B2");
|
||
s.execute("home.cellStyle", json!({"range": "D1", "name": "Good"})).unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn spill_references_roundtrip_through_xlsx() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=SEQUENCE(4)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=sum(b1#)"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Seq", "refersTo": "=Sheet1!$B$1#"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C2", "input": "=MAX(Seq)"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "C1"})).unwrap()["formula"], "=SUM(B1#)");
|
||
assert_eq!((v(&s, "C1"), v(&s, "C2")), (Value::Number(10.0), Value::Number(4.0)));
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "C1"})).unwrap()["formula"], "=SUM(B1#)");
|
||
assert_eq!(s.doc().unwrap().wb.names[0].formula, "Sheet1!$B$1#");
|
||
assert_eq!((v(&s, "C1"), v(&s, "C2")), (Value::Number(10.0), Value::Number(4.0)));
|
||
}
|
||
|
||
/// Fixture for the open-time row fit (issue #833): `row_info` = (size, custom, hidden) for
|
||
/// row 5 (index 4), `None` = no row entry at all. Cell A5 = "plain big bold" — whole-cell
|
||
/// font 20pt with `big_font`, plain 11pt without (a tall plain row's fit removes its entry).
|
||
/// 11pt cell in A1 for contrast rows. Built with the model API, never through commands —
|
||
/// commands would auto-fit the rows — and exported with `write_xlsx`, which omits `ht` for
|
||
/// rows without a size: exactly the bug's input.
|
||
fn big_font_workbook(row_info: Option<(f32, bool, bool)>, big_font: bool) -> Vec<u8> {
|
||
let mut wb = gridcraft_model::Workbook::new();
|
||
let big = wb.styles.derive(gridcraft_model::StyleId::DEFAULT, |s| s.font.size = 20.0);
|
||
let sh = wb.sheet_mut(0).unwrap();
|
||
sh.set_value(CellRef::new(0, 0), Value::text("small"));
|
||
sh.set_value(CellRef::new(4, 0), Value::text("plain big bold"));
|
||
if big_font {
|
||
sh.set_style(CellRef::new(4, 0), big);
|
||
}
|
||
if let Some((size, custom, hidden)) = row_info {
|
||
let e = sh.rows.entry(4).or_default();
|
||
e.size = Some(size);
|
||
e.custom = custom;
|
||
e.hidden = hidden;
|
||
}
|
||
gridcraft_xlsx::write_xlsx(&wb).unwrap()
|
||
}
|
||
|
||
#[test] // A — the issue's repro
|
||
fn open_grows_default_height_rows_to_their_font() {
|
||
let default_h = gridcraft_model::Workbook::new().active().unwrap().row_height(0);
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"name": "bigfont.xlsx", "base64": crate::io::base64_encode(&big_font_workbook(None, true))})).unwrap();
|
||
let h = s.doc().unwrap().wb.active().unwrap().row_height(4);
|
||
assert!(h >= 30.0, "20pt cell must grow its default-height row on open, got {h}");
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().row_height(0), default_h, "11pt row stays default");
|
||
}
|
||
|
||
#[test]
|
||
fn line_breaks_grow_a_row_only_when_the_cell_wraps() {
|
||
// Excel: a cell holding "a\nb" with Wrap Text off displays on one line and AutoFit gives a
|
||
// one-line row; with Wrap Text on it gets one line per break.
|
||
// Typing a break (Alt+Enter) turns wrap on, as in Excel, so the unwrapped case comes from a
|
||
// file, built with the model API and exported without row heights.
|
||
let text = "first line\n\n\nfourth line";
|
||
let bytes = {
|
||
let mut wb = gridcraft_model::Workbook::new();
|
||
let sh = wb.sheet_mut(0).unwrap();
|
||
sh.set_value(CellRef::new(1, 1), Value::text(text));
|
||
gridcraft_xlsx::write_xlsx(&wb).unwrap()
|
||
};
|
||
let default_h = gridcraft_model::Workbook::new().active().unwrap().row_height(1);
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"name": "notes.xlsx", "base64": crate::io::base64_encode(&bytes)})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().row_height(1), default_h, "an unwrapped multi-line cell keeps the default row height on open");
|
||
// Turning wrap on lays the text out over its lines and the row grows to hold them.
|
||
s.execute("home.wrapText", json!({"range": "B2", "on": true})).unwrap();
|
||
let wrapped_h = s.doc().unwrap().wb.active().unwrap().row_height(1);
|
||
assert!(wrapped_h > default_h * 2.5, "wrapped four-line text grows the row, got {wrapped_h} vs default {default_h}");
|
||
// Turning it off again returns the row to one line.
|
||
s.execute("home.wrapText", json!({"range": "B2", "on": false})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().row_height(1), default_h, "wrap off: back to a one-line row");
|
||
// Entering a break by hand wraps the cell (Alt+Enter), so that row does grow.
|
||
s.execute("cell.set", json!({"cell": "D4", "input": text})).unwrap();
|
||
assert!(s.doc().unwrap().wb.active().unwrap().row_height(3) > default_h * 2.5, "typed line breaks turn wrap on and grow the row");
|
||
}
|
||
|
||
#[test] // B — Review Focus 1
|
||
fn open_keeps_custom_height_rows() {
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"name": "custom.xlsx", "base64": crate::io::base64_encode(&big_font_workbook(Some((25.0, true, false)), true))}))
|
||
.unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().row_height(4), 25.0, "custom-height rows are left alone on open");
|
||
}
|
||
|
||
#[test] // C — Review Focus 2 (Some→Some: the fit shrinks the row, the clamp keeps the taller height)
|
||
fn open_never_shrinks_taller_auto_rows() {
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"name": "tall.xlsx", "base64": crate::io::base64_encode(&big_font_workbook(Some((60.0, false, false)), true))}))
|
||
.unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().row_height(4), 60.0, "open is grow-only: a 60px auto-height row keeps its height");
|
||
}
|
||
|
||
#[test] // C′ — Review Focus 2 (Some→None: a plain tall row's entry is removed by the fit, the clamp restores it)
|
||
fn open_restores_height_of_plain_rows_the_fit_removed() {
|
||
let mut s = Session::new();
|
||
s.execute(
|
||
"file.open",
|
||
json!({"name": "tall-plain.xlsx", "base64": crate::io::base64_encode(&big_font_workbook(Some((60.0, false, false)), false))}),
|
||
)
|
||
.unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().row_height(4), 60.0, "a tall plain row keeps its height after the fit removes its entry");
|
||
}
|
||
|
||
#[test] // D — Review Focus 5
|
||
fn open_fitting_keeps_hidden_rows_hidden() {
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"name": "hidden.xlsx", "base64": crate::io::base64_encode(&big_font_workbook(Some((20.0, false, true)), true))}))
|
||
.unwrap();
|
||
let sh = s.doc().unwrap().wb.active().unwrap();
|
||
let info = sh.rows.get(&4).unwrap();
|
||
assert!(info.size.is_some_and(|h| h >= 20.0), "hidden row grows or keeps its height, got {:?}", info.size);
|
||
assert!(info.hidden, "fitting a hidden row must not unhide it");
|
||
}
|
||
|
||
#[test] // E — Review Focus 4
|
||
fn open_leaves_plain_workbooks_untouched() {
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"name": "plain.xlsx", "base64": crate::io::base64_encode(&big_font_workbook(None, false))})).unwrap();
|
||
let sh = s.doc().unwrap().wb.active().unwrap();
|
||
assert!(sh.rows.get(&0).is_none_or(|i| i.size.is_none()), "11pt default rows get no height entry");
|
||
assert!(sh.rows.values().all(|i| i.size.is_none()), "no row gains a height entry");
|
||
}
|
||
|
||
/// Merged cells never auto-fit their rows, like Excel (issue #1605): a wrapped merged
|
||
/// header keeps the default height instead of growing to its column-A wrap width, while an
|
||
/// unmerged wrapped cell in the same sheet still fits.
|
||
#[test]
|
||
fn autofit_skips_merged_cells() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "This is a long sentence that should wrap across the merged width of five columns"}))
|
||
.unwrap();
|
||
s.execute("home.mergeCells", json!({"range": "A1:E1"})).unwrap();
|
||
s.execute("home.wrapText", json!({"range": "A1:E1", "on": true})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A3", "input": "This is a long sentence that should wrap across the merged width of five columns"}))
|
||
.unwrap();
|
||
s.execute("home.wrapText", json!({"range": "A3", "on": true})).unwrap();
|
||
let sh = s.doc().unwrap().wb.active().unwrap();
|
||
assert!(sh.rows.get(&0).is_none_or(|i| i.size.is_none()), "merged wrap must not auto-fit row 1, got {:?}", sh.rows.get(&0));
|
||
assert!(sh.rows.get(&2).is_some_and(|i| i.size.is_some_and(|h| h > 15.0)), "unmerged wrap still fits its row");
|
||
// The save writes no height for the merged row.
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let bytes = crate::io::base64_decode(r["base64"].as_str().unwrap()).unwrap();
|
||
let mut zip = zip::ZipArchive::new(std::io::Cursor::new(bytes)).unwrap();
|
||
let mut xml = String::new();
|
||
std::io::Read::read_to_string(&mut zip.by_name("xl/worksheets/sheet1.xml").unwrap(), &mut xml).unwrap();
|
||
let row1 = xml.split("<row").skip(1).map(|r| format!("<row{r}")).find(|r| r.starts_with("<row r=\"1\"")).unwrap();
|
||
assert!(!row1.split('>').next().unwrap().contains("ht="), "merged row 1 must be saved without ht, got {row1}");
|
||
assert!(xml.contains("<mergeCell ref=\"A1:E1\"/>"), "the merge itself is saved");
|
||
}
|
||
|
||
#[test]
|
||
fn open_fits_big_font_rows_from_the_font_not_the_sheet_default() {
|
||
// Excel saves a sheet whose rows hold 16pt text with a 21pt (28px) default row height and no
|
||
// `ht` on rows of that height. Those rows already fit their font: they open at about 28px,
|
||
// not scaled up again by 16/11 to 41px.
|
||
let mut wb = gridcraft_model::Workbook::new();
|
||
let big = wb.styles.derive(gridcraft_model::StyleId::DEFAULT, |s| s.font.size = 16.0);
|
||
let sh = wb.sheet_mut(0).unwrap();
|
||
sh.default_row_height = 28.0;
|
||
sh.set_value(CellRef::new(4, 0), Value::text("SANTANDER"));
|
||
sh.set_style(CellRef::new(4, 0), big);
|
||
let bytes = gridcraft_xlsx::write_xlsx(&wb).unwrap();
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"name": "tall-default.xlsx", "base64": crate::io::base64_encode(&bytes)})).unwrap();
|
||
let sh = s.doc().unwrap().wb.active().unwrap();
|
||
assert_eq!(sh.default_row_height, 28.0);
|
||
let h = sh.row_height(4);
|
||
assert!((28.0..30.0).contains(&h), "a 16pt row on a 28px-default sheet opens at about 28px, got {h}");
|
||
}
|
||
|
||
#[test]
|
||
fn tables_and_structured_refs() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Item", "Qty"], ["x", 2], ["y", 5]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "D1", "input": "=SUM(Table1[Qty])"})).unwrap();
|
||
assert_eq!(v(&s, "D1"), Value::Number(7.0));
|
||
s.execute("table.totalRow", json!({"on": true, "table": "Table1"})).unwrap();
|
||
assert_eq!(v(&s, "B4"), Value::Number(7.0));
|
||
}
|
||
|
||
#[test]
|
||
fn structured_refs_to_columns_with_edge_spaces() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Item", "Qty "], ["a", 2], ["b", 3]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B3", "hasHeaders": true})).unwrap();
|
||
s.execute("table.totalRow", json!({"on": true, "table": "Table1"})).unwrap();
|
||
assert_eq!(v(&s, "B4"), Value::Number(5.0));
|
||
for (cell, input) in [
|
||
("F1", "=SUM(Table1[Qty ])"),
|
||
("F2", "=Table1[[#Totals],[Qty ]]"),
|
||
("F3", "=SUBTOTAL(109,Table1[Qty ])"),
|
||
("F4", "=SUM(Table1[[Qty ]])"),
|
||
("F5", "=SUM(Table1[Qty])"),
|
||
("C2", "=Table1[@[Qty ]]*10"),
|
||
] {
|
||
s.execute("cell.set", json!({"cell": cell, "input": input})).unwrap();
|
||
}
|
||
let n = Value::Number;
|
||
assert_eq!([v(&s, "F1"), v(&s, "F2"), v(&s, "F3"), v(&s, "F4")], [n(5.0), n(5.0), n(5.0), n(5.0)]);
|
||
assert_eq!(v(&s, "F5"), Value::Error(gridcraft_core::CellError::Ref));
|
||
assert_eq!(v(&s, "C2"), n(20.0));
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "F3"})).unwrap()["formula"], "=SUBTOTAL(109,Table1[[Qty ]])");
|
||
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "F3"})).unwrap()["formula"], "=SUBTOTAL(109,Table1[[Qty ]])");
|
||
assert_eq!([v(&s, "F1"), v(&s, "F2"), v(&s, "F3")], [n(5.0), n(5.0), n(5.0)]);
|
||
}
|
||
|
||
#[test]
|
||
fn table_rename_keeps_a_defined_name_with_the_same_name() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Qty"], [7]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "D1", "input": "100"})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:A2", "header": true, "name": "Data"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Data", "refersTo": "=Sheet1!$D$1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E1", "input": "=Data"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "F1", "input": "=SUM(Data[Qty])"})).unwrap();
|
||
s.execute("table.rename", json!({"table": "Data", "name": "Later"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "E1"})).unwrap()["formula"], "=Data");
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "F1"})).unwrap()["formula"], "=SUM(Later[Qty])");
|
||
assert_eq!((v(&s, "E1"), v(&s, "F1")), (Value::Number(100.0), Value::Number(7.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn table_names_are_limited_to_255_characters() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Qty"], [7]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:A2", "header": true, "name": "Original"})).unwrap();
|
||
|
||
let name_255 = "ع".repeat(255);
|
||
s.execute("table.rename", json!({"table": "Original", "name": name_255})).unwrap();
|
||
assert!(s.doc().unwrap().wb.table(&"ع".repeat(255)).is_some());
|
||
|
||
let name_256 = "ع".repeat(256);
|
||
let error = s.execute("table.rename", json!({"table": &"ع".repeat(255), "name": name_256})).unwrap_err();
|
||
assert!(error.to_string().contains("not valid"), "{error}");
|
||
assert!(s.doc().unwrap().wb.table(&"ع".repeat(255)).is_some());
|
||
|
||
let name_200 = "ع".repeat(200);
|
||
s.execute("table.rename", json!({"table": &"ع".repeat(255), "name": name_200})).unwrap();
|
||
assert!(s.doc().unwrap().wb.table(&"ع".repeat(200)).is_some());
|
||
}
|
||
|
||
#[test]
|
||
fn slicer_finds_a_named_table_on_another_sheet() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Region", "Qty"], ["East", 2], ["West", 5]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B3", "name": "Sales"})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Report"})).unwrap();
|
||
let report = s.doc().unwrap().wb.sheet_index("Report").unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active_sheet, report);
|
||
|
||
// With another sheet active, `table` still names the table, and the slicer goes on the table's sheet.
|
||
let r = s.execute("insert.slicer", json!({"table": "Sales", "column": "Region", "at": "D2"})).unwrap();
|
||
let id = r["slicer"].as_u64().unwrap();
|
||
let home = s.doc().unwrap().wb.sheet_index("Sheet1").unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.sheet(home).unwrap().slicers.len(), 1);
|
||
assert!(s.doc().unwrap().wb.sheet(report).unwrap().slicers.is_empty());
|
||
// It filters the table: "East" leaves the East row.
|
||
s.execute("selection.set", json!({"range": "Sheet1!A1"})).unwrap();
|
||
s.execute("slicer.toggle", json!({"slicer": id, "value": "East"})).unwrap();
|
||
let sh = s.doc().unwrap().wb.sheet(home).unwrap();
|
||
assert!(!sh.is_row_hidden(1) && sh.is_row_hidden(2));
|
||
|
||
// `at` may name the table's sheet, and a table that isn't there is named in the error.
|
||
s.execute("home.insertSheet", json!({"name": "Notes"})).unwrap();
|
||
s.execute("table.insertSlicer", json!({"table": "sales", "column": "Qty", "at": "Sheet1!G2"})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.sheet(home).unwrap().slicers.len(), 2);
|
||
let e = s.execute("insert.slicer", json!({"table": "Missing", "column": "Region"})).unwrap_err();
|
||
assert!(e.to_string().contains("Missing"), "{e}");
|
||
}
|
||
|
||
#[test]
|
||
fn slicer_filters_table() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Region", "Qty"], ["East", 2], ["West", 5], ["East", 3], ["North", 1]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B5", "name": "Sales"})).unwrap();
|
||
s.execute("selection.set", json!({"cell": "A2"})).unwrap();
|
||
|
||
// A new slicer on the Region column filters nothing (all values selected).
|
||
let r = s.execute("insert.slicer", json!({})).unwrap();
|
||
let id = r["slicer"].as_u64().unwrap() as u32;
|
||
let hidden = |s: &Session| {
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
(1..=4).filter(|row| sh.is_row_hidden(*row)).count() // data rows are sheet rows 1..=4 (0-based header at 0)
|
||
};
|
||
assert_eq!(hidden(&s), 0);
|
||
{
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(sh.slicers.len(), 1);
|
||
assert_eq!(sh.slicers[0].column, "Region");
|
||
}
|
||
|
||
// Single-click "East": only the two East rows remain (West row 2 and North row 4 hidden).
|
||
s.execute("slicer.toggle", json!({"slicer": id, "value": "East"})).unwrap();
|
||
assert_eq!(hidden(&s), 2);
|
||
{
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert!(sh.is_row_hidden(2) && sh.is_row_hidden(4));
|
||
assert!(!sh.is_row_hidden(1) && !sh.is_row_hidden(3));
|
||
}
|
||
|
||
// Ctrl-click "West" adds it: East + West visible, only North hidden.
|
||
s.execute("slicer.toggle", json!({"slicer": id, "value": "West", "multi": true})).unwrap();
|
||
assert_eq!(hidden(&s), 1);
|
||
|
||
// Clear restores everything.
|
||
s.execute("slicer.clear", json!({"slicer": id})).unwrap();
|
||
assert_eq!(hidden(&s), 0);
|
||
assert!(s.doc().unwrap().wb.active().unwrap().slicers[0].selected.is_none());
|
||
|
||
// Deleting the slicer drops it and clears its filter.
|
||
s.execute("slicer.toggle", json!({"slicer": id, "value": "East"})).unwrap();
|
||
assert_eq!(hidden(&s), 2);
|
||
s.execute("slicer.delete", json!({"slicer": id})).unwrap();
|
||
assert_eq!(hidden(&s), 0);
|
||
assert!(s.doc().unwrap().wb.active().unwrap().slicers.is_empty());
|
||
|
||
// A bad value is rejected, not panicked.
|
||
assert!(s.execute("slicer.toggle", json!({"value": "Nowhere"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn table_header_formatted_as_accounting_keeps_its_text_as_the_column_name() {
|
||
// Found by the command-sequence fuzzer: the accounting format pads text (` 172.4 `), and that
|
||
// padded text became the column name, which the XLSX writer then put in the header cell.
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[172.4, "Qty"], [1, 2]]})).unwrap();
|
||
s.execute("home.accounting", json!({"range": "A1:B2"})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B2", "header": true})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let t = &d.wb.sheet(0).unwrap().tables[0];
|
||
let names: Vec<_> = t.columns.iter().map(|c| c.name.as_str()).collect();
|
||
assert_eq!(names, ["172.4", "Qty"]);
|
||
assert_eq!(v(&s, "A1"), Value::text("172.4"));
|
||
reopen(&mut s);
|
||
assert_eq!(v(&s, "A1"), Value::text("172.4"));
|
||
}
|
||
|
||
#[test]
|
||
fn a_formula_moved_into_a_table_header_becomes_its_text() {
|
||
// Found by the command-sequence fuzzer: deleting a header row moved a formula into the
|
||
// header, which kept it while the XLSX writer wrote the column name there instead.
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Item", "Qty"], ["x", "=1+1"], ["y", 5]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B3", "header": true})).unwrap();
|
||
s.execute("home.deleteRows", json!({"rows": "1:1"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.sheet(0).unwrap();
|
||
assert_eq!(sh.cell(CellRef::new(0, 1)).and_then(|x| x.formula.clone()), None);
|
||
assert_eq!(v(&s, "B1"), Value::text("2"));
|
||
let names: Vec<_> = sh.tables[0].columns.iter().map(|c| c.name.as_str()).collect();
|
||
assert_eq!(names, ["x", "2"]);
|
||
}
|
||
|
||
#[test]
|
||
fn a_whole_column_table_without_headers_stays_on_the_sheet() {
|
||
// Found by the command-sequence fuzzer: the inserted header row pushed the table's end past
|
||
// the last row, so the table had an invalid range and was dropped from the XLSX file.
|
||
let mut s = s();
|
||
s.execute("insert.table", json!({"range": "A:C", "header": false})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.wb.sheet(0).unwrap().tables[0].range.a1(), "A:C");
|
||
s.execute("cell.set", json!({"cell": "E1", "input": "=ROWS(Table1)"})).unwrap();
|
||
assert_eq!(v(&s, "E1"), Value::Number(1_048_575.0));
|
||
reopen(&mut s);
|
||
assert_eq!(v(&s, "E1"), Value::Number(1_048_575.0));
|
||
s.execute("cell.set", json!({"cell": "F1048576", "input": "x"})).unwrap();
|
||
let e = s.execute("insert.table", json!({"range": "F:F", "header": false})).unwrap_err();
|
||
assert!(e.to_string().contains("pushed off the end"), "{e}");
|
||
}
|
||
|
||
#[test]
|
||
fn inserting_cells_refuses_to_push_values_off_the_sheet() {
|
||
for (shift, edge, last_fit, last_ok) in [("right", "XFD1", "XFC1", "XFD1"), ("down", "A1048576", "A1048575", "A1048576")] {
|
||
let mut sess = s();
|
||
sess.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
sess.execute("cell.set", json!({"cell": edge, "input": "2"})).unwrap();
|
||
let e = sess.execute("home.insertCells", json!({"range": "A1", "shift": shift})).unwrap_err();
|
||
assert!(e.to_string().contains("loss of data"), "{e}");
|
||
assert_eq!(v(&sess, "A1"), Value::Number(1.0));
|
||
assert_eq!(v(&sess, edge), Value::Number(2.0));
|
||
// A value that still fits moves to the last valid cell.
|
||
let mut sess = s();
|
||
sess.execute("cell.set", json!({"cell": last_fit, "input": "2"})).unwrap();
|
||
sess.execute("home.insertCells", json!({"range": "A1", "shift": shift})).unwrap();
|
||
assert_eq!(v(&sess, last_ok), Value::Number(2.0));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn autosum_over_whole_rows_is_one_undo_step_within_the_data() {
|
||
// Found by the command-sequence fuzzer: AutoSum over rows `3:5` ran one `cell.set` per column
|
||
// (16,384 undo steps, so undo never got back to the start).
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A3", "values": [[1, 2], [3, 4], [5, 6]]})).unwrap();
|
||
s.execute("formulas.autoSum", json!({"range": "3:5"})).unwrap();
|
||
assert_eq!(v(&s, "A6"), Value::Number(9.0));
|
||
assert_eq!(v(&s, "B6"), Value::Number(12.0));
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.undo.len(), 2);
|
||
assert_eq!(d.wb.active().unwrap().cells.used_range().unwrap().a1(), "A3:B6");
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A6"), Value::Empty);
|
||
assert_eq!(v(&s, "B6"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn insert_and_delete_cells_never_shift_part_of_a_table() {
|
||
// Found by the command-sequence fuzzer: Delete Cells moved part of a table's cells (so two
|
||
// tables overlapped) or narrowed a table without dropping its columns, and a table without
|
||
// headers pushed the cells of another table down from under it.
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "D8", "values": [["a", "b", "c"], [1, 2, 3], [4, 5, 6]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "D8:F10", "header": true})).unwrap();
|
||
for (cmd, range, shift) in [
|
||
("home.deleteCells", "E9:G9", "left"),
|
||
("home.deleteCells", "E9", "up"),
|
||
("home.insertCells", "C9:D9", "down"),
|
||
("home.deleteCells", "D8:F8", "up"),
|
||
("home.insertCells", "A9:B9", "right"),
|
||
] {
|
||
let e = s.execute(cmd, json!({"range": range, "shift": shift})).unwrap_err();
|
||
assert!(e.to_string().contains("shift cells in a table"), "{cmd} {range} {shift}: {e}");
|
||
}
|
||
// Whole table columns: the table loses (or gains) columns with them.
|
||
s.execute("home.deleteCells", json!({"range": "E7:E12", "shift": "left"})).unwrap();
|
||
let names = |s: &Session| -> Vec<String> { s.doc().unwrap().wb.sheet(0).unwrap().tables[0].columns.iter().map(|c| c.name.clone()).collect() };
|
||
assert_eq!(names(&s), ["a", "c"]);
|
||
assert_eq!(s.doc().unwrap().wb.sheet(0).unwrap().tables[0].range.a1(), "D8:E10");
|
||
s.execute("home.insertCells", json!({"range": "E8:E10", "shift": "right"})).unwrap();
|
||
assert_eq!(names(&s), ["a", "Column2", "c"]);
|
||
assert_eq!(v(&s, "E8"), Value::text("Column2"));
|
||
let e = s.execute("insert.table", json!({"range": "H1:H2", "name": "T1"})).unwrap_err();
|
||
assert!(e.to_string().contains("not valid"), "a cell reference isn't a table name: {e}");
|
||
let e = s.execute("insert.table", json!({"range": "D5:F6", "header": false})).unwrap_err();
|
||
assert!(e.to_string().contains("shift cells in a table"), "{e}");
|
||
}
|
||
|
||
#[test]
|
||
fn table_names_with_a_hyphen_are_rejected() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Qty"], [7]]})).unwrap();
|
||
let e = s.execute("insert.table", json!({"range": "A1:A2", "header": true, "name": "A-B"})).unwrap_err();
|
||
assert!(e.to_string().contains("not valid"), "{e}");
|
||
assert!(s.doc().unwrap().wb.table("A-B").is_none());
|
||
s.execute("insert.table", json!({"range": "A1:A2", "header": true, "name": "Sales"})).unwrap();
|
||
let e = s.execute("table.rename", json!({"table": "Sales", "name": "A-B"})).unwrap_err();
|
||
assert!(e.to_string().contains("not valid"), "{e}");
|
||
assert!(s.doc().unwrap().wb.table("Sales").is_some());
|
||
assert!(s.execute("table.rename", json!({"table": "Sales", "name": ".AB"})).is_err());
|
||
s.execute("table.rename", json!({"table": "Sales", "name": "A_B"})).unwrap();
|
||
assert!(s.doc().unwrap().wb.table("A_B").is_some());
|
||
}
|
||
|
||
#[test]
|
||
fn undo_and_redo_keep_the_watch_window_list() {
|
||
// Found by the command-sequence fuzzer: the list lives in the workbook but isn't an edit, so
|
||
// undoing an earlier edit swapped in a snapshot without it.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
s.execute("formulas.watchWindow", json!({"add": "Sheet1!A1"})).unwrap();
|
||
let watched = |s: &mut Session| -> Vec<String> {
|
||
let rows = s.execute("formulas.watchWindow", json!({})).unwrap();
|
||
rows.as_array().unwrap().iter().map(|r| r["cell"].as_str().unwrap().to_string()).collect()
|
||
};
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(watched(&mut s), ["Sheet1!A1"], "kept after undo");
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
assert_eq!(watched(&mut s), ["Sheet1!A1"], "kept after redo");
|
||
}
|
||
|
||
#[test]
|
||
fn merging_over_a_spill_blocks_it_and_unmerging_unblocks_it() {
|
||
// Found by the command-sequence fuzzer: merges changed no cell the spill depended on, so the
|
||
// spill went on as if the merged cells were free (a full recalc gave #SPILL!).
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(3)"})).unwrap();
|
||
s.execute("home.mergeCenter", json!({"range": "A2:B3"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Error(gridcraft_core::CellError::Spill));
|
||
s.execute("home.mergeCenter", json!({"range": "A2:B3"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "A3"), Value::Number(3.0));
|
||
}
|
||
|
||
#[test]
|
||
fn multi_cell_array_formulas_and_tables_dont_overlap() {
|
||
// Found by the command-sequence fuzzer: an array over a table header lost its value to the
|
||
// header name written as text, then showed #SPILL! (and reloaded from XLSX differently).
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "B2", "values": [["Item", "Qty"], ["x", 2]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "B2:C3", "header": true})).unwrap();
|
||
s.execute("selection.set", json!({"range": "B1:B2"})).unwrap();
|
||
let e = s.execute("cell.set", json!({"input": "=1", "array": true})).unwrap_err();
|
||
assert!(e.to_string().contains("aren't allowed in tables"), "{e}");
|
||
assert_eq!(v(&s, "B2"), Value::text("Item"));
|
||
s.execute("selection.set", json!({"range": "E1:E2"})).unwrap();
|
||
s.execute("cell.set", json!({"input": "=1", "array": true})).unwrap();
|
||
let e = s.execute("insert.table", json!({"range": "E2:F3"})).unwrap_err();
|
||
assert!(e.to_string().contains("aren't allowed in tables"), "{e}");
|
||
// One-cell arrays are fine.
|
||
s.execute("selection.set", json!({"range": "C3"})).unwrap();
|
||
s.execute("cell.set", json!({"input": "=5", "array": true})).unwrap();
|
||
assert_eq!(v(&s, "C3"), Value::Number(5.0));
|
||
}
|
||
|
||
#[test]
|
||
fn copies_of_a_long_named_sheet_get_unique_names() {
|
||
// Found by the command-sequence fuzzer: `name (2)` was cut to 31 characters, so the second
|
||
// copy of a 30-character name took the first copy's name.
|
||
let mut s = s();
|
||
s.execute("sheet.rename", json!({"sheet": 0, "name": "Long name of a sheet 31 chars!"})).unwrap();
|
||
s.execute("sheet.move", json!({"sheet": 0, "to": 1, "copy": true})).unwrap();
|
||
s.execute("sheet.move", json!({"sheet": 0, "to": 2, "copy": true})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let names: Vec<&str> = d.wb.sheets.iter().map(|x| x.name.as_str()).collect();
|
||
assert_eq!(names, ["Long name of a sheet 31 chars!", "Long name of a sheet 31 cha (2)", "Long name of a sheet 31 cha (3)"]);
|
||
}
|
||
|
||
#[test]
|
||
fn row_and_column_inserts_move_legacy_array_ranges() {
|
||
// Found by the command-sequence fuzzer: the formula cell moved but its array range stayed,
|
||
// so the array covered the wrong cells (and read back from XLSX as #SPILL!).
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "7"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "C3:D3"})).unwrap();
|
||
s.execute("cell.set", json!({"input": "=$A$1*2", "array": true})).unwrap();
|
||
s.execute("home.insertColumns", json!({"cols": "B:B"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "1:1"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let f = d.wb.sheet(0).unwrap().cell(CellRef::new(3, 3)).and_then(|x| x.formula.clone()).unwrap();
|
||
assert_eq!(f.array, Some(gridcraft_core::RangeRef::parse("D4:E4").unwrap()));
|
||
assert_eq!(v(&s, "E4"), Value::Number(14.0));
|
||
reopen(&mut s);
|
||
assert_eq!(v(&s, "E4"), Value::Number(14.0));
|
||
}
|
||
|
||
#[test]
|
||
fn part_of_a_legacy_array_cant_be_changed() {
|
||
// Found by the command-sequence fuzzer: a value typed into an array cell showed in the
|
||
// workbook, but the file kept the array there (Excel refuses the edit).
|
||
let mut s = s();
|
||
s.execute("selection.set", json!({"range": "A1:A3"})).unwrap();
|
||
s.execute("cell.set", json!({"input": "=5", "array": true})).unwrap();
|
||
let e = s.execute("range.setValues", json!({"range": "A2", "values": [[13]]})).unwrap_err();
|
||
assert!(e.to_string().contains("part of an array"), "{e}");
|
||
assert_eq!(v(&s, "A2"), Value::Number(5.0));
|
||
// Replacing the whole array is fine.
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3]]})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Number(2.0));
|
||
}
|
||
|
||
#[test]
|
||
fn create_names_from_selection() {
|
||
let names = |s: &Session| -> Vec<(String, String)> {
|
||
let mut v: Vec<_> = s.doc().unwrap().wb.names.iter().map(|n| (n.name.clone(), n.formula.clone())).collect();
|
||
v.sort();
|
||
v
|
||
};
|
||
let named = |n: &str, f: &str| (n.to_string(), f.to_string());
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["", "Jan", "Feb", ""], ["North", 1, 2, "N"], ["South", 3, 4, "S"], ["", "First", "Second", ""]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("formulas.createFromSelection", json!({"range": "A1:D4", "top": false, "bottom": true, "right": true})).unwrap();
|
||
assert_eq!(
|
||
names(&s),
|
||
[named("First", "Sheet1!$B$1:$B$3"), named("N", "Sheet1!$A$2:$C$2"), named("S", "Sheet1!$A$3:$C$3"), named("Second", "Sheet1!$C$1:$C$3")]
|
||
);
|
||
// Existing names are kept unless replacing is asked for.
|
||
let r = s.execute("formulas.createFromSelection", json!({"range": "A1:C3", "top": true, "left": true})).unwrap();
|
||
assert_eq!(r["created"], 4);
|
||
let r = s.execute("formulas.createFromSelection", json!({"range": "B1:C3", "top": true})).unwrap();
|
||
assert_eq!((r["created"].clone(), r["skipped"].clone()), (json!(0), json!(["Jan", "Feb"])));
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "N"})).unwrap();
|
||
let r = s.execute("formulas.createFromSelection", json!({"range": "B1:B3", "replace": true})).unwrap();
|
||
assert_eq!(r["created"], 1);
|
||
assert!(names(&s).contains(&named("N", "Sheet1!$B$2:$B$3")));
|
||
assert!(names(&s).contains(&named("North", "Sheet1!$B$2:$C$2")));
|
||
}
|
||
|
||
#[test]
|
||
fn names_that_look_like_references_are_refused() {
|
||
let mut s = s();
|
||
for bad in ["R1C1", "r2", "C3", "RC", "R", "c", "rc12", "A1", "XFD1048576", "1st"] {
|
||
assert!(s.execute("formulas.defineName", json!({"name": bad, "refersTo": "=1"})).is_err(), "{bad}");
|
||
}
|
||
for good in ["R1C1X", "Rate", "RCx", "Rx", "_R1", "Cost"] {
|
||
s.execute("formulas.defineName", json!({"name": good, "refersTo": "=1"})).unwrap();
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn lambda_names_keep_their_case_in_calls() {
|
||
let mut s = s();
|
||
s.execute("formulas.defineName", json!({"name": "Double", "refersTo": "=LAMBDA(x,x*2)"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Quad", "refersTo": "=LAMBDA(x,Double(Double(x)))"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=double(4)+Quad(1)+sum(1)"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "A1"})).unwrap()["formula"], "=Double(4)+Quad(1)+SUM(1)");
|
||
assert_eq!(v(&s, "A1"), Value::Number(13.0));
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "A1"})).unwrap()["formula"], "=Double(4)+Quad(1)+SUM(1)");
|
||
let quad = s.doc().unwrap().wb.names.iter().find(|n| n.name == "Quad").unwrap().formula.clone();
|
||
assert_eq!(quad, "LAMBDA(x,Double(Double(x)))");
|
||
assert_eq!(v(&s, "A1"), Value::Number(13.0));
|
||
}
|
||
|
||
#[test]
|
||
fn sheets() {
|
||
let mut s = s();
|
||
s.execute("home.insertSheet", json!({})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "5"})).unwrap();
|
||
s.execute("sheet.rename", json!({"name": "Data"})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": 0})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=Data!A1*2"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(10.0));
|
||
s.execute("sheet.rename", json!({"sheet": "Data", "name": "My Data"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "A1"})).unwrap()["formula"], "='My Data'!A1*2");
|
||
}
|
||
|
||
#[test]
|
||
fn sheet_operations_keep_names_on_their_sheets() {
|
||
let names = |s: &Session| -> Vec<(String, Option<String>, String)> {
|
||
let wb = &s.doc().unwrap().wb;
|
||
let mut v: Vec<_> =
|
||
wb.names.iter().map(|n| (n.name.clone(), n.scope.and_then(|i| wb.sheet(i)).map(|s| s.name.clone()), n.formula.clone())).collect();
|
||
v.sort();
|
||
v
|
||
};
|
||
let named = |n: &str, scope: Option<&str>, f: &str| (n.to_string(), scope.map(str::to_string), f.to_string());
|
||
let mut s = s();
|
||
s.execute("home.insertSheet", json!({"name": "Data"})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Notes"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Rate", "refersTo": "=Data!$A$1", "scope": "Data"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Rate", "refersTo": "=Notes!$B$1", "scope": "Notes"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Total", "refersTo": "=Data!$C$1"})).unwrap();
|
||
// Moving Data (index 1) to the end: its names go with it.
|
||
s.execute("sheet.move", json!({"sheet": "Data", "to": 2})).unwrap();
|
||
assert_eq!(names(&s), [named("Rate", Some("Data"), "Data!$A$1"), named("Rate", Some("Notes"), "Notes!$B$1"), named("Total", None, "Data!$C$1")]);
|
||
// Copying Data to the front copies its sheet-level names, referring to the copy.
|
||
s.execute("sheet.move", json!({"sheet": "Data", "to": 0, "copy": true})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.sheets[0].name, "Data (2)");
|
||
assert_eq!(
|
||
names(&s),
|
||
[
|
||
named("Rate", Some("Data"), "Data!$A$1"),
|
||
named("Rate", Some("Data (2)"), "'Data (2)'!$A$1"),
|
||
named("Rate", Some("Notes"), "Notes!$B$1"),
|
||
named("Total", None, "Data!$C$1")
|
||
]
|
||
);
|
||
// Deleting Data removes its names; names referring to it become #REF!.
|
||
s.execute("home.deleteSheet", json!({"sheet": "Data"})).unwrap();
|
||
assert_eq!(
|
||
names(&s),
|
||
[named("Rate", Some("Data (2)"), "'Data (2)'!$A$1"), named("Rate", Some("Notes"), "Notes!$B$1"), named("Total", None, "#REF!")]
|
||
);
|
||
// Deleting a name in one scope keeps the others.
|
||
s.execute("formulas.deleteName", json!({"name": "rate", "scope": "Notes"})).unwrap();
|
||
assert_eq!(names(&s), [named("Rate", Some("Data (2)"), "'Data (2)'!$A$1"), named("Total", None, "#REF!")]);
|
||
assert!(s.execute("formulas.deleteName", json!({"name": "Total", "scope": "Notes"})).is_err());
|
||
s.execute("formulas.deleteName", json!({"name": "Total", "scope": "Workbook"})).unwrap();
|
||
assert_eq!(names(&s).len(), 1);
|
||
}
|
||
|
||
#[test]
|
||
fn deleting_a_3d_span_end_sheet_keeps_the_rest() {
|
||
let book = || {
|
||
let mut s = s();
|
||
for name in ["Sheet2", "Sheet3", "Results"] {
|
||
s.execute("home.insertSheet", json!({"name": name})).unwrap();
|
||
}
|
||
for (sheet, n) in [("Sheet1", 3), ("Sheet2", 5), ("Sheet3", 7)] {
|
||
s.execute("sheet.activate", json!({"sheet": sheet})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": n.to_string()})).unwrap();
|
||
}
|
||
s.execute("sheet.activate", json!({"sheet": "Results"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SUM(Sheet1:Sheet3!A1)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=Sheet1!A1"})).unwrap();
|
||
s
|
||
};
|
||
let gone = Value::Error(gridcraft_core::CellError::Ref);
|
||
for (deleted, total, direct) in [("Sheet1", 12.0, gone), ("Sheet3", 8.0, Value::Number(3.0)), ("Sheet2", 10.0, Value::Number(3.0))] {
|
||
let mut s = book();
|
||
s.execute("home.deleteSheet", json!({"sheet": deleted})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Results"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(total), "deleting {deleted}");
|
||
assert_eq!(v(&s, "B1"), direct, "deleting {deleted}");
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn xlsx_roundtrip_through_engine() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["a", 1], ["b", 2]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B3", "input": "=SUM(B1:B2)"})).unwrap();
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::Number(3.0));
|
||
}
|
||
|
||
fn ods_fixture() -> Vec<u8> {
|
||
use std::io::{Cursor, Write};
|
||
let mut zip = zip::ZipWriter::new(Cursor::new(Vec::new()));
|
||
let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
|
||
for (name, data) in [
|
||
("mimetype", "application/vnd.oasis.opendocument.spreadsheet"),
|
||
(
|
||
"META-INF/manifest.xml",
|
||
r#"<manifest:manifest xmlns:manifest="urn:oasis:names:tc:opendocument:xmlns:manifest:1.0" manifest:version="1.3"><manifest:file-entry manifest:full-path="/" manifest:media-type="application/vnd.oasis.opendocument.spreadsheet"/><manifest:file-entry manifest:full-path="content.xml" manifest:media-type="text/xml"/></manifest:manifest>"#,
|
||
),
|
||
(
|
||
"content.xml",
|
||
r#"<office:document-content xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" office:version="1.3"><office:body><office:spreadsheet><table:table table:name="Data"><table:table-row><table:table-cell office:value-type="float" office:value="42" table:formula="of:=SUM([.B1:.B2])"/><table:table-cell office:value-type="string"><text:p>Original data</text:p></table:table-cell></table:table-row></table:table></office:spreadsheet></office:body></office:document-content>"#,
|
||
),
|
||
] {
|
||
zip.start_file(name, options).unwrap();
|
||
zip.write_all(data.as_bytes()).unwrap();
|
||
}
|
||
zip.finish().unwrap().into_inner()
|
||
}
|
||
|
||
#[test]
|
||
fn ods_import_keeps_cached_values_and_reports_limits() {
|
||
let bytes = ods_fixture();
|
||
assert_eq!(gridcraft_xlsx::sniff(&bytes), gridcraft_xlsx::Format::Ods);
|
||
for name in ["source.ods", "source.xlsx"] {
|
||
let mut s = s();
|
||
let r = s.execute("file.open", json!({"name": name, "base64": crate::io::base64_encode(&bytes)})).unwrap();
|
||
assert!(!r["warnings"].as_array().unwrap().is_empty());
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Message(_))));
|
||
assert!(s.doc().unwrap().path.is_none());
|
||
assert!(s.doc().unwrap().display_title().ends_with(".xlsx"));
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
assert_eq!(v(&s, "B1"), Value::from("Original data"));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("A1").unwrap()).unwrap().formula.is_none());
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "imported.xlsx", "base64": saved["base64"]})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn ods_import_never_reuses_source_as_save_target() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-ods-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let bytes = ods_fixture();
|
||
for name in ["source.ods", "disguised.xlsx"] {
|
||
let path = dir.join(name);
|
||
std::fs::write(&path, &bytes).unwrap();
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": path})).unwrap();
|
||
s.take_ui_requests();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "43"})).unwrap();
|
||
s.execute("file.save", json!({})).unwrap();
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Dialog(name, _) if name == "saveAs")));
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
assert!(s.execute("file.saveAs", json!({"path": dir.join("source.ods")})).is_err());
|
||
assert!(s.execute("file.saveBytes", json!({"format": "ods"})).is_err());
|
||
let output = dir.join("converted.xlsx");
|
||
s.execute("file.saveAs", json!({"path": output})).unwrap();
|
||
assert!(!s.doc().unwrap().is_dirty());
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
s.execute("file.open", json!({"name": "converted.xlsx", "base64": crate::io::base64_encode(&std::fs::read(output).unwrap())})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(43.0));
|
||
}
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
/// Open a `;` CSV by path (a double-click), edit, Save: the file keeps its `;` separator.
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn saving_an_opened_semicolon_csv_keeps_semicolons() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-csv-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let path = dir.join("cut list.csv");
|
||
std::fs::write(&path, "1;511;184;P3_L1_led;2162PE;16;;1244121406FB\r\n1;562;510;P3_pod;2162PE;19;;124412140710\r\n").unwrap();
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": path})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "600"})).unwrap();
|
||
s.execute("file.save", json!({})).unwrap();
|
||
assert_eq!(
|
||
std::fs::read_to_string(&path).unwrap(),
|
||
"1;511;184;P3_L1_led;2162PE;16;;1244121406FB\r\n1;600;510;P3_pod;2162PE;19;;124412140710\r\n"
|
||
);
|
||
let exported = dir.join("export.csv");
|
||
s.execute("file.exportCsv", json!({"path": exported})).unwrap();
|
||
assert!(std::fs::read_to_string(&exported).unwrap().starts_with("1;511;184;"));
|
||
let saved = s.execute("file.saveBytes", json!({"format": "csv"})).unwrap();
|
||
let bytes = crate::io::base64_decode(saved["base64"].as_str().unwrap()).unwrap();
|
||
assert!(bytes.starts_with(b"1;511;184;"));
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
/// A workbook whose B1 is `=[1]Sheet1!A1`, linked to `link` (an external relationship target).
|
||
fn linked_workbook(link: &str) -> Vec<u8> {
|
||
use std::io::{Cursor, Write};
|
||
const NS_REL: &str = "http://schemas.openxmlformats.org/officeDocument/2006/relationships";
|
||
let types = r#"<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types"><Override PartName="/xl/workbook.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.sheet.main+xml"/><Override PartName="/xl/worksheets/sheet1.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.worksheet+xml"/><Override PartName="/xl/externalLinks/externalLink1.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.externalLink+xml"/></Types>"#.to_string();
|
||
let rels = format!(
|
||
r#"<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="rId1" Type="{NS_REL}/officeDocument" Target="xl/workbook.xml"/></Relationships>"#
|
||
);
|
||
let book = format!(
|
||
r#"<workbook xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="{NS_REL}"><sheets><sheet name="Sheet1" sheetId="1" r:id="rId1"/></sheets><externalReferences><externalReference r:id="rId2"/></externalReferences></workbook>"#
|
||
);
|
||
let book_rels = format!(
|
||
r#"<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="rId1" Type="{NS_REL}/worksheet" Target="worksheets/sheet1.xml"/><Relationship Id="rId2" Type="{NS_REL}/externalLink" Target="externalLinks/externalLink1.xml"/></Relationships>"#
|
||
);
|
||
let sheet = r#"<worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main"><sheetData><row r="1"><c r="B1"><f>[1]Sheet1!A1</f><v>10</v></c></row></sheetData></worksheet>"#.to_string();
|
||
let link_part = format!(
|
||
r#"<externalLink xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="{NS_REL}"><externalBook r:id="rId1"><sheetNames><sheetName val="Sheet1"/></sheetNames><sheetDataSet><sheetData sheetId="0"><row r="1"><cell r="A1"><v>10</v></cell></row></sheetData></sheetDataSet></externalBook></externalLink>"#
|
||
);
|
||
let link_rels = format!(
|
||
r#"<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="rId1" Type="{NS_REL}/externalLinkPath" Target="{link}" TargetMode="External"/></Relationships>"#
|
||
);
|
||
let mut zip = zip::ZipWriter::new(Cursor::new(Vec::new()));
|
||
for (name, data) in [
|
||
("[Content_Types].xml", types),
|
||
("_rels/.rels", rels),
|
||
("xl/workbook.xml", book),
|
||
("xl/_rels/workbook.xml.rels", book_rels),
|
||
("xl/worksheets/sheet1.xml", sheet),
|
||
("xl/externalLinks/externalLink1.xml", link_part),
|
||
("xl/externalLinks/_rels/externalLink1.xml.rels", link_rels),
|
||
] {
|
||
zip.start_file(name, zip::write::SimpleFileOptions::default()).unwrap();
|
||
zip.write_all(data.as_bytes()).unwrap();
|
||
}
|
||
zip.finish().unwrap().into_inner()
|
||
}
|
||
|
||
/// The target of the linked workbook in a saved file.
|
||
fn link_target(path: &std::path::Path) -> String {
|
||
use std::io::Read;
|
||
let mut zip = zip::ZipArchive::new(std::io::Cursor::new(std::fs::read(path).unwrap())).unwrap();
|
||
let mut rels = String::new();
|
||
zip.by_name("xl/externalLinks/_rels/externalLink1.xml.rels").unwrap().read_to_string(&mut rels).unwrap();
|
||
let (_, after) = rels.split_once("Target=\"").unwrap();
|
||
after.split_once('"').unwrap().0.to_string()
|
||
}
|
||
|
||
/// Save As into another folder keeps the link on the same file, as Excel does: the relative path
|
||
/// is rewritten from the new folder (#801).
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn save_as_into_another_folder_keeps_linked_workbooks_on_the_same_file() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let a = std::env::temp_dir().join(format!("gridcraft-links-{}-{nonce}", std::process::id()));
|
||
let b = a.join("b");
|
||
std::fs::create_dir_all(&b).unwrap();
|
||
let dest = a.join("Dest.xlsx");
|
||
std::fs::write(&dest, linked_workbook("Source.xlsx")).unwrap();
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": dest})).unwrap();
|
||
s.execute("file.saveAs", json!({"path": b.join("Dest.xlsx")})).unwrap();
|
||
assert_eq!(link_target(&b.join("Dest.xlsx")), "../Source.xlsx");
|
||
// Saved again into the folder it was read from, the path is the one it was read with.
|
||
s.execute("file.saveAs", json!({"path": a.join("Copy.xlsx")})).unwrap();
|
||
assert_eq!(link_target(&a.join("Copy.xlsx")), "Source.xlsx");
|
||
// Read from a subfolder and saved into its parent, the path goes down into the subfolder.
|
||
let deep = b.join("Deep.xlsx");
|
||
std::fs::write(&deep, linked_workbook("Source.xlsx")).unwrap();
|
||
let mut s = Session::new();
|
||
s.execute("file.open", json!({"path": deep})).unwrap();
|
||
s.execute("file.saveAs", json!({"path": a.join("Deep.xlsx")})).unwrap();
|
||
assert_eq!(link_target(&a.join("Deep.xlsx")), "b/Source.xlsx");
|
||
std::fs::remove_dir_all(a).unwrap();
|
||
}
|
||
|
||
/// A typo like `report.cvs` must not quietly write an XLSX under that name and adopt it as the
|
||
/// document's file.
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn saving_to_an_unknown_extension_is_refused() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-unknown-ext-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
for name in ["report.cvs", "report"] {
|
||
let path = dir.join(name);
|
||
let e = s.execute("file.save", json!({"path": path})).unwrap_err().to_string();
|
||
assert!(e.contains(".xlsx"), "{name}: {e}");
|
||
assert!(!path.exists(), "{name} was written");
|
||
}
|
||
let d = s.doc().unwrap();
|
||
assert!(d.path.is_none());
|
||
assert!(d.is_dirty());
|
||
assert!(s.execute("file.saveBytes", json!({"format": "foo"})).is_err());
|
||
s.execute("file.save", json!({"path": dir.join("report.csv")})).unwrap();
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
/// An XLSX opened by its content under an unknown extension (`budget.dat`) saves back to its own
|
||
/// file as XLSX; a Save As to another unknown extension is still refused.
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn an_xlsx_opened_under_an_unknown_extension_saves_back_as_xlsx() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-dat-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let path = dir.join("budget.dat");
|
||
let mut src = s();
|
||
src.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
std::fs::write(&path, crate::io::save_bytes(&src.doc().unwrap().wb, "book.xlsx").unwrap()).unwrap();
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": path})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "2"})).unwrap();
|
||
s.execute("file.save", json!({})).unwrap();
|
||
assert!(!s.doc().unwrap().is_dirty());
|
||
let bytes = std::fs::read(&path).unwrap();
|
||
assert_eq!(gridcraft_xlsx::sniff(&bytes), gridcraft_xlsx::Format::Xlsx);
|
||
let (wb, _) = crate::io::open_bytes("book.xlsx", &bytes).unwrap();
|
||
assert_eq!(wb.active().unwrap().value(CellRef::parse("A1").unwrap()), Value::Number(2.0));
|
||
assert!(s.execute("file.saveAs", json!({"path": dir.join("copy.foo")})).is_err());
|
||
assert!(!dir.join("copy.foo").exists());
|
||
// A text file under an unknown extension opens as CSV: Save doesn't turn it into an XLSX.
|
||
let notes = dir.join("notes.dat");
|
||
std::fs::write(¬es, "a,b\r\n").unwrap();
|
||
s.execute("file.open", json!({"path": notes})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "c"})).unwrap();
|
||
assert!(s.execute("file.save", json!({})).is_err());
|
||
assert_eq!(std::fs::read_to_string(¬es).unwrap(), "a,b\r\n");
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn validation_formulas_are_relative_and_see_the_new_value() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "B1", "values": [[1], [100]]})).unwrap();
|
||
s.execute("data.validation", json!({"range": "A1:A2", "type": "custom", "formula1": "=A1>10"})).unwrap();
|
||
s.execute("data.validation", json!({"range": "C1:C2", "type": "whole", "operator": "lessOrEqual", "formula1": "=B1"})).unwrap();
|
||
let ok = |s: &mut Session, cell: &str, input: &str| s.execute("data.validate", json!({"cell": cell, "input": input})).unwrap()["ok"] == true;
|
||
assert!(ok(&mut s, "A1", "20"));
|
||
assert!(!ok(&mut s, "A2", "5"));
|
||
assert!(ok(&mut s, "C2", "50"));
|
||
assert!(!ok(&mut s, "C1", "50"));
|
||
}
|
||
|
||
#[test]
|
||
fn samples_build() {
|
||
for (name, _) in crate::sample::SAMPLES {
|
||
let wb = crate::sample::build(name).unwrap_or_else(|| panic!("sample {name}"));
|
||
assert!(!wb.sheets[0].cells.is_empty());
|
||
}
|
||
}
|
||
|
||
/// Original minimal BIFF12 records, built in source rather than a vendor workbook fixture.
|
||
fn xlsb_fixture() -> Vec<u8> {
|
||
use std::io::{Cursor, Write};
|
||
fn wide(s: &str) -> Vec<u8> {
|
||
let units: Vec<_> = s.encode_utf16().collect();
|
||
(units.len() as u32).to_le_bytes().into_iter().chain(units.into_iter().flat_map(u16::to_le_bytes)).collect()
|
||
}
|
||
fn record(out: &mut Vec<u8>, id: u16, payload: &[u8]) {
|
||
if id < 128 {
|
||
out.push(id as u8);
|
||
} else {
|
||
out.extend([(id as u8 & 127) | 128, (id >> 7) as u8]);
|
||
}
|
||
let mut size = payload.len();
|
||
while size >= 128 {
|
||
out.push((size as u8 & 127) | 128);
|
||
size >>= 7;
|
||
}
|
||
out.push(size as u8);
|
||
out.extend(payload);
|
||
}
|
||
let mut book = vec![];
|
||
record(&mut book, 131, &[]); // BeginBook
|
||
record(&mut book, 143, &[]); // BeginBundleShs
|
||
let mut bundle = vec![0; 4]; // Visible
|
||
bundle.extend(1u32.to_le_bytes());
|
||
bundle.extend(wide("rId1"));
|
||
bundle.extend(wide("Imported"));
|
||
record(&mut book, 156, &bundle);
|
||
record(&mut book, 144, &[]);
|
||
record(&mut book, 132, &[]);
|
||
let mut sheet = vec![];
|
||
record(&mut sheet, 129, &[]); // BeginSheet
|
||
record(&mut sheet, 145, &[]); // BeginSheetData
|
||
record(&mut sheet, 0, &[0; 17]); // Row 0, no spans
|
||
let mut numeric = vec![0; 8]; // A1, default style
|
||
numeric.extend(42.0f64.to_le_bytes());
|
||
numeric.extend([0; 2]); // Formula flags
|
||
numeric.extend(3u32.to_le_bytes());
|
||
numeric.extend([0x1e, 42, 0]); // PtgInt(42)
|
||
numeric.extend(0u32.to_le_bytes());
|
||
record(&mut sheet, 9, &numeric); // FmlaNum
|
||
let mut text = 1u32.to_le_bytes().to_vec(); // B1
|
||
text.extend(0u32.to_le_bytes());
|
||
text.extend(wide("Original data"));
|
||
record(&mut sheet, 6, &text);
|
||
record(&mut sheet, 146, &[]);
|
||
record(&mut sheet, 130, &[]);
|
||
let mut zip = zip::ZipWriter::new(Cursor::new(Vec::new()));
|
||
let types = br#"<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types"><Override PartName="/xl/workbook.bin" ContentType="application/vnd.ms-excel.sheet.binary.macroEnabled.main"/><Override PartName="/xl/worksheets/sheet1.bin" ContentType="application/vnd.ms-excel.worksheet"/></Types>"#;
|
||
let rels = br#"<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument" Target="xl/workbook.bin"/></Relationships>"#;
|
||
let book_rels = br#"<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet" Target="worksheets/sheet1.bin"/></Relationships>"#;
|
||
for (name, data) in [
|
||
("[Content_Types].xml", types.as_slice()),
|
||
("_rels/.rels", rels.as_slice()),
|
||
("xl/_rels/workbook.bin.rels", book_rels.as_slice()),
|
||
("xl/workbook.bin", book.as_slice()),
|
||
("xl/worksheets/sheet1.bin", sheet.as_slice()),
|
||
] {
|
||
zip.start_file(name, zip::write::SimpleFileOptions::default()).unwrap();
|
||
zip.write_all(data).unwrap();
|
||
}
|
||
zip.finish().unwrap().into_inner()
|
||
}
|
||
|
||
#[test]
|
||
fn replacing_a_spilling_formula_clears_its_spill() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(3)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=SUM(A1:A3)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "2"})).unwrap();
|
||
assert_eq!((v(&s, "A2"), v(&s, "A3"), v(&s, "B1")), (Value::Empty, Value::Empty, Value::Number(2.0)));
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(3)"})).unwrap();
|
||
s.execute("edit.clearContents", json!({"range": "A1"})).unwrap();
|
||
assert_eq!((v(&s, "A2"), v(&s, "B1")), (Value::Empty, Value::Number(0.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn clearing_a_spill_past_65536_cells_updates_a_late_dependent() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(65537)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=A65536"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C2", "input": "=A65537"})).unwrap();
|
||
assert_eq!(v(&s, "C2"), Value::Number(65537.0));
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "5"})).unwrap();
|
||
assert_eq!((v(&s, "C1"), v(&s, "C2")), (Value::Number(0.0), Value::Number(0.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn range_ending_in_index_recalculates() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B6", "input": "=SUM(C3:INDEX(B9:C11,2,2))"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C5", "input": "2"})).unwrap();
|
||
assert_eq!(v(&s, "B6"), Value::Number(2.0));
|
||
}
|
||
|
||
#[test]
|
||
fn structural_edits_move_spills_with_their_formula() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A5", "input": "=SEQUENCE(3)"})).unwrap();
|
||
s.execute("home.deleteRows", json!({"rows": "1:1"})).unwrap();
|
||
let col = |s: &Session| (4..=7).map(|r| v(s, &format!("A{r}"))).collect::<Vec<_>>();
|
||
assert_eq!(col(&s), [Value::Number(1.0), Value::Number(2.0), Value::Number(3.0), Value::Empty]);
|
||
s.execute("home.deleteRows", json!({"rows": "4:4"})).unwrap();
|
||
assert_eq!(col(&s), [Value::Empty, Value::Empty, Value::Empty, Value::Empty]);
|
||
}
|
||
|
||
#[test]
|
||
fn clearing_a_distant_blocker_unblocks_the_spill() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(100)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A90", "input": "x"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Error(gridcraft_core::CellError::Spill));
|
||
s.execute("edit.clearContents", json!({"range": "A90"})).unwrap();
|
||
assert_eq!((v(&s, "A1"), v(&s, "A100")), (Value::Number(1.0), Value::Number(100.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn a_spill_that_goes_away_unblocks_another() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "F8", "input": "=SEQUENCE(5)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E10", "input": "=SEQUENCE(1,3)"})).unwrap();
|
||
assert_eq!(v(&s, "E10"), Value::Error(gridcraft_core::CellError::Spill));
|
||
// Blocking F8's array frees F10 for E10's.
|
||
s.execute("cell.set", json!({"cell": "F9", "input": "0"})).unwrap();
|
||
assert_eq!(v(&s, "F8"), Value::Error(gridcraft_core::CellError::Spill));
|
||
assert_eq!((v(&s, "E10"), v(&s, "G10")), (Value::Number(1.0), Value::Number(3.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn an_array_reading_another_arrays_spill_is_updated() {
|
||
// G5 is evaluated before D11 in the same pass, so it first reads D11's old spill.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "D11", "input": "=SEQUENCE(1,3,A1)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "G5", "input": "=UNIQUE(VSTACK(F9:F12,A1))"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "10"})).unwrap();
|
||
assert_eq!((v(&s, "G6"), v(&s, "G7")), (Value::Number(12.0), Value::Number(10.0)));
|
||
s.execute("formulas.calculateNow", json!({})).unwrap();
|
||
assert_eq!((v(&s, "G6"), v(&s, "G7")), (Value::Number(12.0), Value::Number(10.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn indirect_reads_a_spill_laid_out_in_the_same_pass() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "F5", "input": "=SEQUENCE(2,2,7)"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "3:3"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E5", "input": "=INDIRECT(\"F7\")"})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(9.0));
|
||
s.execute("formulas.calculateNow", json!({})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(9.0));
|
||
}
|
||
|
||
#[test]
|
||
fn every_command_survives_empty_params() {
|
||
let mut s = Session::new();
|
||
s.execute("file.new", json!({"sample": "sales"})).unwrap();
|
||
for spec in crate::command_specs() {
|
||
if matches!(spec.id, "file.close" | "file.open" | "file.save" | "file.saveAs" | "file.exportCsv" | "file.exportHtml" | "insert.picture") {
|
||
continue;
|
||
}
|
||
let _ = s.execute(spec.id, json!({}));
|
||
let _ = s.execute(spec.id, json!([1, 2]));
|
||
let _ = s.execute(spec.id, json!({"range": "ZZZ999999999", "cell": "", "sheet": 99}));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn non_object_params_do_not_panic_in_wrapper_commands() {
|
||
// Issue #516.
|
||
for cmd in ["pageLayout.themeColors", "pageLayout.background", "home.drawBorder"] {
|
||
for params in [json!([]), json!(5), json!("x"), json!(true)] {
|
||
let mut s = s();
|
||
let r = s.execute(cmd, params.clone());
|
||
assert!(!matches!(r, Err(crate::EngineError::Internal(..))), "{cmd} {params}: {r:?}");
|
||
}
|
||
}
|
||
// A saved script step forwards its params unchanged into the same call.
|
||
let mut s = s();
|
||
s.execute("automate.newScript", json!({"name": "bad", "commands": [{"command": "home.drawBorder", "params": []}]})).unwrap();
|
||
let r = s.execute("automate.runScript", json!({"name": "bad"}));
|
||
assert!(!matches!(r, Err(crate::EngineError::Internal(..))), "script: {r:?}");
|
||
}
|
||
|
||
fn fmt_of(s: &Session, a: &str) -> String {
|
||
let wb = &s.doc().unwrap().wb;
|
||
let sh = wb.active().unwrap();
|
||
wb.styles.get(sh.style_id(CellRef::parse(a).unwrap())).num_fmt.as_str().to_string()
|
||
}
|
||
|
||
#[test]
|
||
fn checkboxes_keep_values_toggle_and_delete_in_two_passes() {
|
||
// Issue #196.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "hi"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "TRUE"})).unwrap();
|
||
s.execute("insert.checkbox", json!({"range": "A1:B2"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Bool(false), "an empty cell starts unchecked");
|
||
assert_eq!(v(&s, "B1"), Value::from("hi"), "other values stay");
|
||
s.execute("cell.toggleCheckbox", json!({"cell": "A1"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Bool(true));
|
||
// Space over a selection toggles only checkbox cells; an emptied checkbox counts as FALSE.
|
||
s.execute("cell.set", json!({"cell": "A2", "input": ""})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A2:C2"})).unwrap();
|
||
s.execute("cell.toggleCheckbox", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Bool(true));
|
||
s.execute("selection.set", json!({"range": "C1"})).unwrap();
|
||
s.execute("cell.toggleCheckbox", json!({})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::Bool(true), "a plain TRUE is not a checkbox");
|
||
// Delete: checked boxes are unchecked first, then the boxes go.
|
||
s.execute("edit.clearContents", json!({"range": "A1:A2"})).unwrap();
|
||
assert_eq!((v(&s, "A1"), v(&s, "A2")), (Value::Bool(false), Value::Bool(false)));
|
||
assert_eq!(fmt_of(&s, "A1"), "checkbox");
|
||
s.execute("edit.clearContents", json!({"range": "A1:A2"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Empty);
|
||
assert_ne!(fmt_of(&s, "A1"), "checkbox");
|
||
// Clear Formats removes the box and keeps the value (B2 was checked by the selection toggle).
|
||
s.execute("edit.clearFormats", json!({"range": "B2"})).unwrap();
|
||
assert_eq!(v(&s, "B2"), Value::Bool(true));
|
||
assert_ne!(fmt_of(&s, "B2"), "checkbox");
|
||
}
|
||
|
||
#[test]
|
||
fn checkboxes_survive_xlsx_as_cell_controls() {
|
||
let mut s = s();
|
||
s.execute("insert.checkbox", json!({"range": "A1:A2"})).unwrap();
|
||
s.execute("cell.toggleCheckbox", json!({"cell": "A1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "0.5"})).unwrap();
|
||
reopen(&mut s);
|
||
assert_eq!(fmt_of(&s, "A1"), "checkbox");
|
||
assert_eq!(fmt_of(&s, "A2"), "checkbox");
|
||
assert_eq!(fmt_of(&s, "B1"), "General");
|
||
assert_eq!(v(&s, "A1"), Value::Bool(true));
|
||
assert_eq!(v(&s, "A2"), Value::Bool(false));
|
||
}
|
||
|
||
#[test]
|
||
fn file_options_reports_settings_and_asks_for_the_options_page() {
|
||
let mut s = Session::new();
|
||
// No workbook: nothing to report, but still no error.
|
||
assert_eq!(s.execute("file.options", json!({})).unwrap(), json!({"calculation": null}));
|
||
s.take_ui_requests();
|
||
s.new_workbook();
|
||
s.execute("formulas.calculationOptions", json!({"mode": "manual", "iterative": true})).unwrap();
|
||
let before = s.active().unwrap().wb.clone();
|
||
let r = s.execute("file.options", json!({})).unwrap();
|
||
assert_eq!(r["calculation"]["mode"], "manual");
|
||
assert_eq!(r["calculation"]["iterative"], true);
|
||
assert!(matches!(s.take_ui_requests().as_slice(), [crate::UiRequest::Dialog(name, _)] if name == "options"));
|
||
assert_eq!(s.active().unwrap().wb, before, "Options never changes the workbook");
|
||
}
|
||
|
||
fn reopen(s: &mut Session) {
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn calculation_options_enable_iterative_calculation() {
|
||
let mut s = s();
|
||
let near = |s: &Session, a: &str, want: f64| {
|
||
let got = v(s, a).as_f64().unwrap_or(f64::NAN);
|
||
assert!((got - want).abs() < 0.002, "{a} = {:?}", v(s, a));
|
||
};
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=(A2+10)/2"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A2", "input": "=A1"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Error(gridcraft_core::CellError::Circ));
|
||
assert!(!s.doc().unwrap().calc.circular.is_empty());
|
||
// Switching it on recalculates the loop.
|
||
let r = s.execute("formulas.calculationOptions", json!({"iterative": true})).unwrap();
|
||
assert_eq!(r, json!({"mode": "Automatic", "iterative": true, "maxIterations": 100, "maxChange": 0.001}));
|
||
near(&s, "A1", 10.0);
|
||
near(&s, "A2", 10.0);
|
||
assert!(s.doc().unwrap().calc.circular.is_empty());
|
||
// Empty params change nothing and report the settings.
|
||
let r = s.execute("formulas.calculationOptions", json!({})).unwrap();
|
||
assert_eq!(r["iterative"], true);
|
||
// Limits are kept within Excel's: 1–32767 iterations, a non-negative change.
|
||
let r = s.execute("formulas.calculationOptions", json!({"maxIterations": 0, "maxChange": -0.5})).unwrap();
|
||
assert_eq!((r["maxIterations"].as_u64(), r["maxChange"].as_f64()), (Some(1), Some(0.5)));
|
||
let r = s.execute("formulas.calculationOptions", json!({"maxIterations": 100000, "maxChange": 0.0001})).unwrap();
|
||
assert_eq!((r["maxIterations"].as_u64(), r["maxChange"].as_f64()), (Some(32767), Some(0.0001)));
|
||
// Saved with the workbook.
|
||
reopen(&mut s);
|
||
let calc = s.doc().unwrap().wb.calc.clone();
|
||
assert_eq!((calc.iterative, calc.max_iterations, calc.max_change), (true, 32767, 0.0001));
|
||
near(&s, "A1", 10.0);
|
||
// Undo brings the previous settings back.
|
||
s.execute("formulas.calculationOptions", json!({"iterative": false})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Error(gridcraft_core::CellError::Circ));
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert!(s.doc().unwrap().wb.calc.iterative);
|
||
near(&s, "A1", 10.0);
|
||
}
|
||
|
||
fn chart_data(s: &mut Session) {
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["", "Open", "High", "Low", "Close"], ["Mon", 10, 14, 9, 12], ["Tue", 12, 15, 11, 14], ["Wed", 14, 16, 10, 11], ["Thu", 11, 13, 8, 9], ["Fri", 9, 12, 7, 11], ["Sat", 11, 15, 10, 14]]}),
|
||
)
|
||
.unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn every_chart_kind_survives_xlsx() {
|
||
use gridcraft_model::ChartKind;
|
||
let kinds = [
|
||
("combo", ChartKind::Combo),
|
||
("stock", ChartKind::Stock),
|
||
("histogram", ChartKind::Histogram),
|
||
("boxWhisker", ChartKind::BoxWhisker),
|
||
("waterfall", ChartKind::Waterfall),
|
||
("funnel", ChartKind::Funnel),
|
||
("treemap", ChartKind::Treemap),
|
||
("sunburst", ChartKind::Sunburst),
|
||
("column", ChartKind::ColumnClustered),
|
||
("line", ChartKind::Line),
|
||
("scatter", ChartKind::Scatter),
|
||
];
|
||
for (t, kind) in kinds {
|
||
let mut s = s();
|
||
chart_data(&mut s);
|
||
s.execute("insert.chart", json!({"type": t, "range": "A1:E7", "title": "Week"})).unwrap();
|
||
let before = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert_eq!(before.kind, kind);
|
||
reopen(&mut s);
|
||
assert!(s.doc().unwrap().wb.names.is_empty(), "{t}");
|
||
let after = &s.doc().unwrap().wb.active().unwrap().charts[0];
|
||
assert_eq!(after.kind, kind, "{t}");
|
||
assert_eq!(after.title.as_deref(), Some("Week"), "{t}");
|
||
assert_eq!(after.series.len(), before.series.len(), "{t}");
|
||
for (a, b) in after.series.iter().zip(&before.series) {
|
||
assert_eq!((&a.name, &a.values, &a.color), (&b.name, &b.values, &b.color), "{t}");
|
||
// A histogram bins its values; it has no categories in the file.
|
||
if kind != ChartKind::Histogram {
|
||
assert_eq!(a.categories, b.categories, "{t}");
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn scatter_of_two_columns_is_one_series_with_the_first_as_x() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["X", "Y"], [1, 10], [2, 20], [3, 30]]})).unwrap();
|
||
s.execute("insert.chart", json!({"type": "scatter", "range": "A1:B4"})).unwrap();
|
||
let c = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert_eq!(c.series.len(), 1);
|
||
assert_eq!(c.series[0].values, "Sheet1!$B$2:$B$4");
|
||
assert_eq!(c.series[0].categories.as_deref(), Some("Sheet1!$A$2:$A$4"));
|
||
// Select Data on the scatter chart and Switch Row/Column rebuild the series the same way.
|
||
s.execute("chart.selectData", json!({"range": "A2:B4"})).unwrap();
|
||
let c = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert_eq!(c.series.len(), 1);
|
||
assert_eq!(c.series[0].categories.as_deref(), Some("Sheet1!$A$2:$A$4"));
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [[1, 2, 3, 4], [10, 20, 30, 40]]})).unwrap();
|
||
s.execute("chart.selectData", json!({"range": "D1:G2"})).unwrap();
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
let c = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert!(c.by_rows);
|
||
assert_eq!(c.series.len(), 1);
|
||
assert_eq!(c.series[0].values, "Sheet1!$D$2:$G$2");
|
||
assert_eq!(c.series[0].categories.as_deref(), Some("Sheet1!$D$1:$G$1"));
|
||
}
|
||
|
||
#[test]
|
||
fn whole_sheet_selection_stays_within_the_data() {
|
||
// On an empty sheet with everything selected these filled or scanned every cell of the
|
||
// sheet, running out of memory or time.
|
||
let mut s = s();
|
||
s.execute("edit.selectAll", json!({})).unwrap();
|
||
for cmd in ["edit.fillDown", "edit.fillRight", "edit.fillUp", "edit.fillLeft", "data.removeDuplicates"] {
|
||
s.execute(cmd, json!({})).unwrap();
|
||
}
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2], [3, 4], [5, 6]]})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A1:XFD1048576"})).unwrap();
|
||
s.execute("edit.fillUp", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(5.0));
|
||
assert!(s.execute("edit.fillDown", json!({"range": "A1:Z1000000"})).is_err(), "too large to fill");
|
||
assert!(s.execute("edit.autoFill", json!({"source": "A1:XFD1048576", "target": "A1"})).is_err(), "too large to fill");
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [[1], [1], [2]]})).unwrap();
|
||
let r = s.execute("data.removeDuplicates", json!({"range": "D:D", "header": false})).unwrap();
|
||
assert_eq!((r["removed"].clone(), r["remaining"].clone()), (json!(1), json!(2)));
|
||
assert!(s.execute("data.removeDuplicates", json!({"range": "A1:XFD1048576", "header": false})).is_ok());
|
||
}
|
||
|
||
#[test]
|
||
fn whole_columns_and_rows_ignore_merges_but_cell_ranges_take_them_whole() {
|
||
// As in Excel: a merged A2:C2 doesn't widen a click on column B's header to A:C, nor a
|
||
// merged B2:B4 a click on row 3's header to rows 2:4; a cell range still takes them whole.
|
||
let mut s = s();
|
||
s.execute("home.mergeCenter", json!({"range": "A2:C2"})).unwrap();
|
||
s.execute("home.mergeCenter", json!({"range": "E2:E4"})).unwrap();
|
||
let sel = |s: &mut Session, range: &str| s.execute("selection.set", json!({"range": range})).unwrap()["selection"].clone();
|
||
assert_eq!(sel(&mut s, "B:B"), "B:B");
|
||
assert_eq!(sel(&mut s, "A:B"), "A:B");
|
||
assert_eq!(sel(&mut s, "3:3"), "3:3");
|
||
assert_eq!(sel(&mut s, "B1:B3"), "A1:C3");
|
||
assert_eq!(sel(&mut s, "E3"), "E2:E4");
|
||
}
|
||
|
||
#[test]
|
||
fn parity_counts() {
|
||
let (done, total) = crate::catalog::parity();
|
||
assert!(total > 250);
|
||
assert!(done > 150, "parity {done}/{total}");
|
||
}
|
||
|
||
#[test]
|
||
fn switch_row_column_on_a_chart_read_from_a_file() {
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["", "North", "South", "East", "West"], ["Mon", 10, 14, 9, 12], ["Tue", 12, 15, 11, 14], ["Wed", 14, 16, 10, 11], ["Thu", 11, 13, 8, 9], ["Fri", 9, 12, 7, 11], ["Sat", 11, 15, 10, 14]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("insert.chart", json!({"type": "column", "range": "A1:E7"})).unwrap();
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
let chart = |s: &Session| s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert_eq!((chart(&s).source, chart(&s).series.len()), (None, 4));
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
let c = chart(&s);
|
||
assert!(c.by_rows);
|
||
assert_eq!(c.source.as_deref(), Some("Sheet1!A1:E7"));
|
||
assert_eq!(c.series.len(), 6);
|
||
assert_eq!(c.series[0].name.as_deref(), Some("Sheet1!$A$2"));
|
||
assert_eq!(c.series[0].categories.as_deref(), Some("Sheet1!$B$1:$E$1"));
|
||
assert_eq!(c.series[0].values, "Sheet1!$B$2:$E$2");
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
assert_eq!(chart(&s).series.len(), 4);
|
||
}
|
||
|
||
#[test]
|
||
fn chart_trendlines_are_added_saved_and_removed() {
|
||
use gridcraft_model::TrendlineKind;
|
||
let mut s = s();
|
||
chart_data(&mut s);
|
||
s.execute("insert.chart", json!({"type": "line", "range": "A1:E7"})).unwrap();
|
||
let chart = |s: &Session| s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
s.execute("chart.addElement", json!({"element": "trendline", "series": 1, "type": "linearForecast", "displayEquation": true})).unwrap();
|
||
s.execute("chart.addElement", json!({"element": "trendline", "series": 1, "type": "polynomial", "order": 9})).unwrap();
|
||
s.execute("chart.addElement", json!({"element": "trendline", "series": 3, "type": "movingAverage", "period": 3})).unwrap();
|
||
let c = chart(&s);
|
||
assert!(c.series[0].trendlines.is_empty());
|
||
let t = &c.series[1].trendlines;
|
||
assert_eq!((t.len(), t[0].kind, t[0].forward, t[0].display_equation), (2, TrendlineKind::Linear, 2.0, true));
|
||
assert_eq!(t[1].kind, TrendlineKind::Polynomial(6), "order clamps to Excel's 2..6");
|
||
assert_eq!(c.series[3].trendlines[0].kind, TrendlineKind::MovingAverage(3));
|
||
let info = s.execute("document.inspect", json!({})).unwrap();
|
||
assert_eq!(info["sheets"][0]["charts"][0]["trendlines"], json!(["Linear", "Polynomial(6)", "MovingAverage(3)"]));
|
||
assert!(s.execute("chart.addElement", json!({"element": "trendline", "series": 9})).is_err());
|
||
assert!(s.execute("chart.addElement", json!({"element": "trendline", "type": "cubic"})).is_err());
|
||
reopen(&mut s);
|
||
let after = chart(&s);
|
||
assert_eq!(after.series[1].trendlines, c.series[1].trendlines);
|
||
assert_eq!(after.series[3].trendlines, c.series[3].trendlines);
|
||
s.execute("chart.addElement", json!({"element": "trendline", "on": false})).unwrap();
|
||
assert!(chart(&s).series.iter().all(|se| se.trendlines.is_empty()));
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(chart(&s).series[1].trendlines.len(), 2);
|
||
}
|
||
|
||
#[test]
|
||
fn trendlines_are_refused_on_charts_that_cannot_show_them() {
|
||
let mut s = s();
|
||
chart_data(&mut s);
|
||
s.execute("insert.chart", json!({"type": "pie", "range": "A1:B7"})).unwrap();
|
||
assert!(s.execute("chart.addElement", json!({"element": "trendline"})).is_err());
|
||
assert!(s.doc().unwrap().wb.active().unwrap().charts[0].series[0].trendlines.is_empty());
|
||
}
|
||
|
||
#[test]
|
||
fn switch_row_column_with_whole_column_refs_is_bounded() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["", "North", "South"], ["Mon", 10, 14], ["Tue", 12, 15], ["Wed", 14, 16]]}))
|
||
.unwrap();
|
||
s.execute("insert.chart", json!({"type": "column", "range": "A1:C4"})).unwrap();
|
||
// As read from a file: no source block, series over whole columns.
|
||
let whole = |s: &mut Session| {
|
||
let c = &mut std::sync::Arc::make_mut(&mut s.doc_mut().unwrap().wb).sheet_mut(0).unwrap().charts[0];
|
||
c.source = None;
|
||
c.by_rows = false;
|
||
c.series.truncate(2);
|
||
for (i, col) in ["B", "C"].iter().enumerate() {
|
||
c.series[i].name = None;
|
||
c.series[i].categories = Some("Sheet1!$A:$A".into());
|
||
c.series[i].values = format!("Sheet1!${col}:${col}");
|
||
}
|
||
};
|
||
whole(&mut s);
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
let c = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert!(c.by_rows);
|
||
// Clipped to the used rows, not a million series.
|
||
assert_eq!(c.series.len(), 3);
|
||
// A used range that is itself enormous is refused rather than charted.
|
||
s.execute("cell.set", json!({"cell": "C1048576", "input": "1"})).unwrap();
|
||
whole(&mut s);
|
||
assert!(s.execute("chart.switchRowColumn", json!({})).is_err());
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().charts[0].series.len(), 2);
|
||
}
|
||
|
||
#[test]
|
||
fn switch_row_column_follows_inserted_and_deleted_lines() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["", "Q1", "Q2"], ["North", 1, 2], ["South", 3, 4]]})).unwrap();
|
||
s.execute("insert.chart", json!({"range": "A1:C3", "type": "column", "at": "F1"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "1:1"})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().charts[0].source.as_deref(), Some("Sheet1!A2:C4"));
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
let c = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
let values: Vec<&str> = c.series.iter().map(|x| x.values.as_str()).collect();
|
||
assert_eq!(values, ["Sheet1!$B$3:$C$3", "Sheet1!$B$4:$C$4"]);
|
||
let names: Vec<Option<&str>> = c.series.iter().map(|x| x.name.as_deref()).collect();
|
||
assert_eq!(names, [Some("Sheet1!$A$3"), Some("Sheet1!$A$4")]);
|
||
assert_eq!(c.series[0].categories.as_deref(), Some("Sheet1!$B$2:$C$2"));
|
||
// Columns shift the source too.
|
||
s.execute("home.insertColumns", json!({"cols": "A:A"})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().charts[0].source.as_deref(), Some("Sheet1!B2:D4"));
|
||
// Deleting the whole block leaves no stale source behind.
|
||
s.execute("home.deleteRows", json!({"rows": "2:4"})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().charts[0].source, None);
|
||
}
|
||
|
||
#[test]
|
||
fn ink_strokes_and_ink_to_shape() {
|
||
let mut s = s();
|
||
// A rough closed box.
|
||
let pts: Vec<[f64; 2]> = vec![[100.0, 100.0], [200.0, 102.0], [201.0, 180.0], [99.0, 181.0], [101.0, 104.0]];
|
||
s.execute("draw.stroke", json!({"points": pts})).unwrap();
|
||
let sh = s.doc().unwrap().wb.active().unwrap().clone();
|
||
assert_eq!(sh.shapes.len(), 1);
|
||
assert_eq!(sh.shapes[0].kind, gridcraft_model::ShapeKind::Ink);
|
||
let r = s.execute("draw.inkToShape", json!({})).unwrap();
|
||
assert_eq!(r["kind"], "Rectangle");
|
||
// An open stroke becomes a line.
|
||
s.execute("draw.stroke", json!({"points": [[0.0, 0.0], [50.0, 10.0], [120.0, 30.0]]})).unwrap();
|
||
assert_eq!(s.execute("draw.inkToShape", json!({})).unwrap()["kind"], "Line");
|
||
assert!(s.execute("draw.stroke", json!({"points": [[1.0, 1.0]]})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn xlsb_import_keeps_cached_values_and_reports_limits() {
|
||
let bytes = xlsb_fixture();
|
||
assert_eq!(gridcraft_xlsx::sniff(&bytes), gridcraft_xlsx::Format::Xlsb);
|
||
for name in ["source.xlsb", "source.xlsx"] {
|
||
let mut s = s();
|
||
let r = s.execute("file.open", json!({"name": name, "base64": crate::io::base64_encode(&bytes)})).unwrap();
|
||
assert!(!r["warnings"].as_array().unwrap().is_empty());
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Message(_))));
|
||
assert!(s.doc().unwrap().path.is_none());
|
||
assert!(s.doc().unwrap().display_title().ends_with(".xlsx"));
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
assert_eq!(v(&s, "B1"), Value::from("Original data"));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("A1").unwrap()).unwrap().formula.is_none());
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "Changed"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0)); // Imported formula caches are constants.
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "imported.xlsx", "base64": saved["base64"]})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn xlsb_import_never_reuses_source_as_save_target() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-xlsb-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let bytes = xlsb_fixture();
|
||
for name in ["source.xlsb", "disguised.xlsx"] {
|
||
let path = dir.join(name);
|
||
std::fs::write(&path, &bytes).unwrap();
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": path})).unwrap();
|
||
s.take_ui_requests();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "43"})).unwrap();
|
||
s.execute("file.save", json!({})).unwrap();
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Dialog(name, _) if name == "saveAs")));
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
assert!(s.execute("file.saveAs", json!({"path": dir.join("source.xlsb")})).is_err());
|
||
assert!(s.execute("file.saveBytes", json!({"format": "xlsb"})).is_err());
|
||
let output = dir.join("converted.xlsx");
|
||
s.execute("file.saveAs", json!({"path": output})).unwrap();
|
||
assert!(!s.doc().unwrap().is_dirty());
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
s.execute("file.open", json!({"name": "converted.xlsx", "base64": crate::io::base64_encode(&std::fs::read(output).unwrap())})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(43.0));
|
||
}
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
/// A one-sheet Excel 97-2003 workbook ([MS-CFB] container, [MS-XLS] BIFF8 stream) built in code:
|
||
/// A1 = 42 and A2 = `A1*2` with its cached result.
|
||
fn xls_fixture() -> Vec<u8> {
|
||
fn rec(id: u16, payload: &[u8]) -> Vec<u8> {
|
||
[&id.to_le_bytes()[..], &(payload.len() as u16).to_le_bytes(), payload].concat()
|
||
}
|
||
let bof = |dt: u16| rec(0x0809, &[&0x0600u16.to_le_bytes()[..], &dt.to_le_bytes(), &[0; 12]].concat());
|
||
let sheet = [
|
||
bof(0x0010),
|
||
rec(0x0203, &[&[0u8, 0, 0, 0, 0, 0][..], &42f64.to_le_bytes()].concat()),
|
||
rec(0x0006, &[&[1u8, 0, 0, 0, 0, 0][..], &84f64.to_le_bytes(), &[0; 6], &[9, 0, 0x44, 0, 0, 0, 0xC0, 0x1E, 2, 0, 0x05]].concat()),
|
||
rec(0x000A, &[]),
|
||
]
|
||
.concat();
|
||
let globals = |pos: u32| [bof(0x0005), rec(0x0085, &[&pos.to_le_bytes()[..], &[0, 0, 3, 0], b"Old"].concat()), rec(0x000A, &[])].concat();
|
||
let stream = [globals(globals(0).len() as u32), sheet].concat();
|
||
// Sectors: 0 FAT, 1 directory, 2 mini FAT, 3 mini stream container.
|
||
let mut b = vec![0u8; 512 * 5];
|
||
let mut put = |at: usize, v: &[u8]| b[at..at + v.len()].copy_from_slice(v);
|
||
put(0, &[0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1]);
|
||
put(26, &3u16.to_le_bytes());
|
||
put(30, &9u16.to_le_bytes());
|
||
put(32, &6u16.to_le_bytes());
|
||
put(44, &1u32.to_le_bytes());
|
||
put(48, &1u32.to_le_bytes());
|
||
put(56, &4096u32.to_le_bytes());
|
||
put(60, &2u32.to_le_bytes());
|
||
put(64, &1u32.to_le_bytes());
|
||
put(68, &0xFFFF_FFFEu32.to_le_bytes());
|
||
for i in 1..109 {
|
||
put(76 + i * 4, &0xFFFF_FFFFu32.to_le_bytes());
|
||
}
|
||
for (i, v) in [0xFFFF_FFFDu32, 0xFFFF_FFFE, 0xFFFF_FFFE, 0xFFFF_FFFE].iter().enumerate() {
|
||
put(512 + i * 4, &v.to_le_bytes());
|
||
}
|
||
for i in 4..128 {
|
||
put(512 + i * 4, &0xFFFF_FFFFu32.to_le_bytes());
|
||
}
|
||
let minis = stream.len().div_ceil(64);
|
||
for i in 0..128 {
|
||
let next = if i + 1 < minis {
|
||
i as u32 + 1
|
||
} else if i + 1 == minis {
|
||
0xFFFF_FFFE
|
||
} else {
|
||
0xFFFF_FFFF
|
||
};
|
||
put(512 * 3 + i * 4, &next.to_le_bytes());
|
||
}
|
||
let entry = |k: usize, name: &str, kind: u8, child: u32, start: u32, size: u32, put: &mut dyn FnMut(usize, &[u8])| {
|
||
let at = 512 * 2 + k * 128;
|
||
let units: Vec<u8> = name.encode_utf16().flat_map(u16::to_le_bytes).collect();
|
||
put(at, &units);
|
||
put(at + 64, &(units.len() as u16 + 2).to_le_bytes());
|
||
put(at + 66, &[kind, 1]);
|
||
put(at + 68, &[0xFF; 8]);
|
||
put(at + 76, &child.to_le_bytes());
|
||
put(at + 116, &start.to_le_bytes());
|
||
put(at + 120, &size.to_le_bytes());
|
||
};
|
||
entry(0, "Root Entry", 5, 1, 3, 512, &mut put);
|
||
entry(1, "Workbook", 2, 0xFFFF_FFFF, 0, stream.len() as u32, &mut put);
|
||
put(512 * 4, &stream);
|
||
b
|
||
}
|
||
|
||
#[test]
|
||
fn xls_import_keeps_formulas_and_never_saves_back_to_xls() {
|
||
let bytes = xls_fixture();
|
||
assert_eq!(gridcraft_xlsx::sniff(&bytes), gridcraft_xlsx::Format::Xls);
|
||
let mut s = s();
|
||
let r = s.execute("file.open", json!({"name": "legacy.xls", "base64": crate::io::base64_encode(&bytes)})).unwrap();
|
||
assert!(r["warnings"][0].as_str().unwrap().contains("97-2003"));
|
||
assert_eq!(r["sheets"], json!(["Old"]));
|
||
let d = s.doc().unwrap();
|
||
assert!(d.path.is_none());
|
||
assert_eq!(d.display_title(), "legacy (imported).xlsx");
|
||
assert_eq!(v(&s, "A2"), Value::Number(84.0));
|
||
// The formula is live: editing its input recalculates it.
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "50"})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Number(100.0));
|
||
assert!(s.execute("file.saveBytes", json!({"format": "xls"})).is_err());
|
||
assert!(s.execute("file.saveBytes", json!({"format": "xlsx"})).is_ok());
|
||
}
|
||
|
||
#[test]
|
||
fn malformed_xlsb_keeps_the_current_workbook() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "Keep me"})).unwrap();
|
||
assert!(s.execute("file.open", json!({"name": "bad.xlsb", "base64": crate::io::base64_encode(b"not a workbook")})).is_err());
|
||
assert_eq!(s.documents().len(), 1);
|
||
assert_eq!(v(&s, "A1"), Value::from("Keep me"));
|
||
assert!(s.doc().unwrap().is_dirty());
|
||
}
|
||
|
||
/// A 2×2 PNG, so objects can be injected into a workbook in tests.
|
||
fn tiny_png() -> Vec<u8> {
|
||
let img = image::RgbaImage::from_raw(2, 2, vec![255, 0, 0, 255, 0, 255, 0, 128, 0, 0, 255, 255, 0, 0, 0, 0]).unwrap();
|
||
let mut png = Vec::new();
|
||
image::DynamicImage::ImageRgba8(img).write_to(&mut std::io::Cursor::new(&mut png), image::ImageFormat::Png).unwrap();
|
||
png
|
||
}
|
||
|
||
fn add_image(s: &mut Session, cell: &str, mode: gridcraft_model::AnchorMode) -> u32 {
|
||
let d = s.doc_mut().unwrap();
|
||
let wb = std::sync::Arc::make_mut(&mut d.wb);
|
||
let id = wb.next_object_id();
|
||
wb.sheet_mut(0).unwrap().images.push(gridcraft_model::Image {
|
||
id,
|
||
anchor: gridcraft_model::Anchor { cell: CellRef::parse(cell).unwrap(), dx: 0.0, dy: 0.0, width: 40.0, height: 40.0, mode },
|
||
data: tiny_png().into(),
|
||
mime: "image/png".into(),
|
||
alt: String::new(),
|
||
});
|
||
id
|
||
}
|
||
|
||
fn image_cell(s: &Session, id: u32) -> Option<CellRef> {
|
||
s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id).map(|i| i.anchor.cell)
|
||
}
|
||
|
||
/// Every undo step holds a copy of the workbook. A picture's bytes and the VBA project are shared
|
||
/// between those copies instead of copied into each: a 20 MB picture used to cost another 20 MB
|
||
/// for every cell typed on its sheet, up to 100 steps (2 GB).
|
||
#[test]
|
||
fn undo_steps_share_picture_and_macro_bytes() {
|
||
let mut s = s();
|
||
s.execute("insert.picture", json!({"base64": crate::io::base64_encode(&tiny_png()), "at": "C3"})).unwrap();
|
||
std::sync::Arc::make_mut(&mut s.doc_mut().unwrap().wb).vba_project = Some(b"vba".to_vec().into());
|
||
for i in 1..=3 {
|
||
s.execute("cell.set", json!({"cell": format!("A{i}"), "input": i.to_string()})).unwrap();
|
||
}
|
||
let d = s.doc().unwrap();
|
||
let live = &d.wb.active().unwrap().images[0].data;
|
||
let vba = d.wb.vba_project.as_ref().unwrap();
|
||
assert_eq!(**live, tiny_png());
|
||
assert!(d.undo.len() >= 3);
|
||
for step in d.undo.iter().filter(|h| !h.wb.active().unwrap().images.is_empty()) {
|
||
assert!(std::sync::Arc::ptr_eq(&step.wb.active().unwrap().images[0].data, live), "{}", step.label);
|
||
}
|
||
for step in d.undo.iter().rev().take(3) {
|
||
assert!(std::sync::Arc::ptr_eq(step.wb.vba_project.as_ref().unwrap(), vba), "{}", step.label);
|
||
}
|
||
// Undo and redo still give the picture back as it was.
|
||
s.execute("edit.undo", json!({"steps": 3})).unwrap();
|
||
assert_eq!(*s.doc().unwrap().wb.active().unwrap().images[0].data, tiny_png());
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
assert_eq!(*s.doc().unwrap().wb.active().unwrap().images[0].data, tiny_png());
|
||
}
|
||
|
||
/// Issue #5: images anchored in cells follow their row when the sheet is sorted.
|
||
#[test]
|
||
fn sort_moves_anchored_images_with_their_rows() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
// One picture per data row, in its own row.
|
||
let ib = add_image(&mut s, "A2", AnchorMode::MoveAndSize);
|
||
let ic = add_image(&mut s, "A3", AnchorMode::MoveAndSize);
|
||
let ia = add_image(&mut s, "A4", AnchorMode::MoveAndSize);
|
||
s.execute("selection.set", json!({"range": "A1:B4"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"header": true, "column": "A"})).unwrap();
|
||
// Ascending by name: b, c, a → a, b, c. Each picture lands in its row's new home.
|
||
assert_eq!(image_cell(&s, ib), Some(CellRef::parse("A3").unwrap()));
|
||
assert_eq!(image_cell(&s, ic), Some(CellRef::parse("A4").unwrap()));
|
||
assert_eq!(image_cell(&s, ia), Some(CellRef::parse("A2").unwrap()));
|
||
}
|
||
|
||
/// An `absolute`-pinned object stays exactly where it was drawn across a sort and a row delete.
|
||
#[test]
|
||
fn absolute_objects_ignore_sort_and_structural_edits() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
let pinned = add_image(&mut s, "A3", AnchorMode::Absolute);
|
||
s.execute("selection.set", json!({"range": "A1:B4"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"header": true, "column": "A"})).unwrap();
|
||
assert_eq!(image_cell(&s, pinned), Some(CellRef::parse("A3").unwrap()));
|
||
s.execute("home.deleteRows", json!({"rows": "2:2"})).unwrap();
|
||
assert_eq!(image_cell(&s, pinned), Some(CellRef::parse("A3").unwrap()));
|
||
}
|
||
|
||
/// A "move but don't size" object follows its row across a sort but keeps its size.
|
||
#[test]
|
||
fn move_only_objects_follow_but_do_not_resize() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "N"], ["b", 2], ["a", 1]]})).unwrap();
|
||
let id = add_image(&mut s, "A2", AnchorMode::MoveOnly);
|
||
s.execute("selection.set", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"column": "A"})).unwrap();
|
||
// "a" moved to row 2 and "b" to row 3, so the image follows from A2 to A3.
|
||
assert_eq!(image_cell(&s, id), Some(CellRef::parse("A3").unwrap()));
|
||
let a = s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id).unwrap().anchor;
|
||
assert_eq!((a.width, a.height), (40.0, 40.0));
|
||
}
|
||
|
||
/// `object.setAnchorMode` changes how an object follows its cells.
|
||
#[test]
|
||
fn set_anchor_mode_changes_following() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "N"], ["b", 2], ["a", 1]]})).unwrap();
|
||
let id = add_image(&mut s, "A2", AnchorMode::MoveAndSize);
|
||
let r = s.execute("object.setAnchorMode", json!({"kind": "image", "id": id, "mode": "dontMoveOrSizeWithCells"})).unwrap();
|
||
assert_eq!(r["mode"], "absolute");
|
||
s.execute("selection.set", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"column": "A"})).unwrap();
|
||
// Pinned absolute: it stays put even though its row moved.
|
||
assert_eq!(image_cell(&s, id), Some(CellRef::parse("A2").unwrap()));
|
||
// A bad mode is rejected, not silently ignored.
|
||
assert!(s.execute("object.setAnchorMode", json!({"kind": "image", "id": id, "mode": "sideways"})).is_err());
|
||
}
|
||
|
||
/// A sort moves only objects anchored inside the sorted block on both axes: a picture beside
|
||
/// the block (same rows, other columns) stays where it is.
|
||
#[test]
|
||
fn sort_leaves_objects_outside_the_block_alone() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
let beside = add_image(&mut s, "Z3", AnchorMode::MoveAndSize);
|
||
let inside = add_image(&mut s, "B3", AnchorMode::MoveAndSize);
|
||
s.execute("selection.set", json!({"range": "A1:B4"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"header": true, "column": "A"})).unwrap();
|
||
assert_eq!(image_cell(&s, beside), Some(CellRef::parse("Z3").unwrap()));
|
||
// "c" moved from row 3 to row 4, taking the picture in B3 with it.
|
||
assert_eq!(image_cell(&s, inside), Some(CellRef::parse("B4").unwrap()));
|
||
}
|
||
|
||
/// Inserted pictures default to Excel's "Move but don't size with cells".
|
||
#[test]
|
||
fn inserted_pictures_move_but_do_not_size() {
|
||
let mut s = s();
|
||
let b64 = crate::io::base64_encode(&tiny_png());
|
||
let id = s.execute("insert.picture", json!({"base64": b64, "at": "C3"})).unwrap()["image"].as_u64().unwrap() as u32;
|
||
let mode = |s: &Session| s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id).unwrap().anchor.mode;
|
||
assert_eq!(mode(&s), gridcraft_model::AnchorMode::MoveOnly);
|
||
let b64 = crate::io::base64_encode(&tiny_png());
|
||
let id2 = s.execute("insert.picture", json!({"base64": b64, "mode": "absolute"})).unwrap()["image"].as_u64().unwrap() as u32;
|
||
let m2 = s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id2).unwrap().anchor.mode;
|
||
assert_eq!(m2, gridcraft_model::AnchorMode::Absolute);
|
||
}
|
||
|
||
/// `object.setAnchorMode` needs a real object kind.
|
||
#[test]
|
||
fn set_anchor_mode_rejects_unknown_kind() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
let id = add_image(&mut s, "A2", AnchorMode::MoveAndSize);
|
||
for kind in [json!(""), json!("widget"), serde_json::Value::Null] {
|
||
assert!(s.execute("object.setAnchorMode", json!({"kind": kind, "id": id, "mode": "absolute"})).is_err());
|
||
}
|
||
let mode = |s: &Session| s.doc().unwrap().wb.active().unwrap().images[0].anchor.mode;
|
||
assert_eq!(mode(&s), AnchorMode::MoveAndSize);
|
||
s.execute("object.setAnchorMode", json!({"kind": "image", "id": id, "mode": "moveOnly"})).unwrap();
|
||
assert_eq!(mode(&s), AnchorMode::MoveOnly);
|
||
}
|
||
|
||
fn original_cell_picture() -> Vec<u8> {
|
||
let image = image::RgbaImage::from_fn(4, 2, |x, _| if x < 2 { image::Rgba([240, 60, 40, 255]) } else { image::Rgba([20, 100, 240, 128]) });
|
||
let mut png = Vec::new();
|
||
image::DynamicImage::ImageRgba8(image).write_to(&mut std::io::Cursor::new(&mut png), image::ImageFormat::Png).unwrap();
|
||
png
|
||
}
|
||
|
||
fn insert_cell_picture(s: &mut Session, at: &str, alt: &str) {
|
||
s.execute("insert.picture", json!({"placement": "cell", "at": at, "base64": crate::io::base64_encode(&original_cell_picture()), "alt": alt}))
|
||
.unwrap();
|
||
}
|
||
|
||
fn cell_picture(s: &Session, at: &str) -> Option<std::sync::Arc<gridcraft_model::CellPicture>> {
|
||
s.doc().unwrap().wb.active().unwrap().cell_pictures.get(&CellRef::parse(at).unwrap()).cloned()
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_insert_validates_content_preserves_style_and_replaces_with_undo() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "old"})).unwrap();
|
||
s.execute("home.bold", json!({"range": "B2"})).unwrap();
|
||
for bytes in [b"not an image".as_slice(), b"GIF89a", &original_cell_picture()[..24]] {
|
||
assert!(s.execute("insert.picture", json!({"placement": "cell", "at": "B2", "base64": crate::io::base64_encode(bytes)})).is_err());
|
||
assert_eq!(v(&s, "B2"), Value::from("old"));
|
||
}
|
||
insert_cell_picture(&mut s, "B2", "Original picture");
|
||
assert_eq!(v(&s, "B2"), Value::Error(gridcraft_core::CellError::Value));
|
||
let state = s.execute("cell.get", json!({"cell": "B2"})).unwrap();
|
||
assert_eq!(state["type"], "picture");
|
||
assert_eq!(state["text"], "#VALUE!");
|
||
assert_eq!(state["input"], "");
|
||
assert_eq!(state["picture"]["alt"], "Original picture");
|
||
assert!(state["picture"].get("data").is_none());
|
||
assert_eq!(state["style"]["font"]["bold"], true);
|
||
assert!(s.doc().unwrap().wb.active().unwrap().images.is_empty());
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "=2+3"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
assert_eq!(v(&s, "B2"), Value::Number(5.0));
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(cell_picture(&s, "B2").unwrap().alt, "Original picture");
|
||
s.execute("range.setValues", json!({"range": "B2", "values": [[7]]})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
let mut jpeg = Vec::new();
|
||
image::DynamicImage::ImageRgb8(image::RgbImage::from_pixel(2, 1, image::Rgb([60, 80, 100])))
|
||
.write_to(&mut std::io::Cursor::new(&mut jpeg), image::ImageFormat::Jpeg)
|
||
.unwrap();
|
||
s.execute("insert.picture", json!({"placement": "cell", "at": "D2", "base64": crate::io::base64_encode(&jpeg), "mime": "wrong/client-mime"}))
|
||
.unwrap();
|
||
assert_eq!(cell_picture(&s, "D2").unwrap().mime, "image/jpeg");
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_clipboard_clear_and_structural_edits_keep_complete_payload() {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "moves with the row");
|
||
let original = cell_picture(&s, "B2").unwrap();
|
||
s.execute("edit.copy", json!({"range": "B2"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "values", "at": "D2"})).unwrap();
|
||
assert!(std::sync::Arc::ptr_eq(&original, &cell_picture(&s, "D2").unwrap()));
|
||
s.execute("home.bold", json!({"range": "C1"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "C1"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "formats", "at": "D2"})).unwrap();
|
||
assert_eq!(cell_picture(&s, "D2").unwrap().alt, original.alt);
|
||
s.execute("edit.clearFormats", json!({"range": "D2"})).unwrap();
|
||
assert!(cell_picture(&s, "D2").is_some());
|
||
s.execute("edit.clearContents", json!({"range": "D2"})).unwrap();
|
||
assert!(cell_picture(&s, "D2").is_none());
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "3"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "B2"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "values", "at": "C1", "operation": "add"})).unwrap();
|
||
assert!(cell_picture(&s, "C1").is_none());
|
||
assert_eq!(v(&s, "C1"), Value::Error(gridcraft_core::CellError::Value));
|
||
s.execute("home.insertRows", json!({"rows": "2:2"})).unwrap();
|
||
s.execute("home.insertColumns", json!({"cols": "B:B"})).unwrap();
|
||
assert_eq!(cell_picture(&s, "C3").unwrap().alt, original.alt);
|
||
s.execute("edit.cut", json!({"range": "C3"})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Destination"})).unwrap();
|
||
s.execute("edit.paste", json!({"at": "E4"})).unwrap();
|
||
assert_eq!(cell_picture(&s, "E4").unwrap().alt, original.alt);
|
||
assert!(s.doc().unwrap().wb.sheet(0).unwrap().cell(CellRef::parse("C3").unwrap()).is_none());
|
||
s.execute("home.deleteColumns", json!({"cols": "E:E"})).unwrap();
|
||
assert!(cell_picture(&s, "E4").is_none());
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(cell_picture(&s, "E4").unwrap().data, original.data);
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_follows_sort_filter_and_blocks_formula_spills() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Rank", "Picture"], [2], [1]]})).unwrap();
|
||
insert_cell_picture(&mut s, "B2", "rank two");
|
||
insert_cell_picture(&mut s, "B3", "rank one");
|
||
s.execute("data.sort", json!({"range": "A1:B3", "header": true, "keys": [{"column": "A", "order": "asc"}]})).unwrap();
|
||
assert_eq!(cell_picture(&s, "B2").unwrap().alt, "rank one");
|
||
assert_eq!(cell_picture(&s, "B3").unwrap().alt, "rank two");
|
||
s.execute("selection.set", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
s.execute("data.filterBy", json!({"column": "A", "values": ["1"]})).unwrap();
|
||
assert!(s.doc().unwrap().wb.active().unwrap().is_row_hidden(2));
|
||
assert!(cell_picture(&s, "B3").is_some());
|
||
insert_cell_picture(&mut s, "D2", "spill obstruction");
|
||
s.execute("cell.set", json!({"cell": "D1", "input": "=SEQUENCE(2)"})).unwrap();
|
||
assert_eq!(v(&s, "D1"), Value::Error(gridcraft_core::CellError::Spill));
|
||
s.execute("edit.clearContents", json!({"range": "D2"})).unwrap();
|
||
assert_eq!(v(&s, "D1"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "D2"), Value::Number(2.0));
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_json_save_retains_content_and_pdf_draws_without_error_text() {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "original pixels");
|
||
let saved = s.execute("file.saveBytes", json!({"format": "json"})).unwrap();
|
||
s.execute("file.open", json!({"name": "pictures.json", "base64": saved["base64"]})).unwrap();
|
||
assert_eq!(cell_picture(&s, "B2").unwrap().data, original_cell_picture());
|
||
let pdf = s.execute("file.exportPdf", json!({"range": "A1:C3"})).unwrap();
|
||
let data = crate::io::base64_decode(pdf["base64"].as_str().unwrap()).unwrap();
|
||
let pdf_text = String::from_utf8_lossy(&data);
|
||
assert!(pdf_text.contains("/Subtype /Image"));
|
||
assert!(!pdf_text.contains("(#VALUE!) Tj"));
|
||
s.execute("home.hideRows", json!({"rows": "2:2"})).unwrap();
|
||
let pdf = s.execute("file.exportPdf", json!({"range": "A1:C3"})).unwrap();
|
||
let data = crate::io::base64_decode(pdf["base64"].as_str().unwrap()).unwrap();
|
||
assert!(!String::from_utf8_lossy(&data).contains("/Subtype /Image"));
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_side_map_follows_fill_shift_merge_and_undo() {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "shared pixels");
|
||
let original = cell_picture(&s, "B2").unwrap();
|
||
s.execute("edit.fillDown", json!({"range": "B2:B4"})).unwrap();
|
||
for at in ["B2", "B3", "B4"] {
|
||
assert!(std::sync::Arc::ptr_eq(&original, &cell_picture(&s, at).unwrap()));
|
||
}
|
||
s.execute("edit.autoFill", json!({"source": "A2", "target": "A2:B2", "mode": "formats"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_some());
|
||
s.execute("edit.autoFill", json!({"source": "A3", "target": "A3:B3", "mode": "copy"})).unwrap();
|
||
assert!(cell_picture(&s, "B3").is_none());
|
||
s.execute("home.insertCells", json!({"range": "B2", "shift": "down"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
assert!(cell_picture(&s, "B3").is_some());
|
||
assert!(cell_picture(&s, "B5").is_some());
|
||
s.execute("home.deleteCells", json!({"range": "B3", "shift": "up"})).unwrap();
|
||
assert!(cell_picture(&s, "B3").is_none());
|
||
assert!(cell_picture(&s, "B4").is_some());
|
||
s.execute("home.mergeCells", json!({"range": "A4:B4"})).unwrap();
|
||
assert!(cell_picture(&s, "B4").is_none());
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert!(cell_picture(&s, "B4").is_some());
|
||
s.execute("edit.clearAll", json!({"range": "A1:C5"})).unwrap();
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell_pictures.is_empty());
|
||
insert_cell_picture(&mut s, "XFD1048576", "grid edge");
|
||
assert!(s.execute("home.insertRows", json!({"rows": "1048576:1048576"})).is_err());
|
||
assert_eq!(cell_picture(&s, "XFD1048576").unwrap().alt, "grid edge");
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_cut_uses_live_source_after_edit() {
|
||
for clear in [false, true] {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "original");
|
||
s.execute("edit.cut", json!({"range": "B2"})).unwrap();
|
||
if clear {
|
||
s.execute("edit.clearContents", json!({"range": "B2"})).unwrap();
|
||
} else {
|
||
insert_cell_picture(&mut s, "B2", "replacement");
|
||
}
|
||
s.execute("edit.paste", json!({"at": "D2"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
if clear {
|
||
assert!(cell_picture(&s, "D2").is_none());
|
||
assert_eq!(v(&s, "D2"), Value::Empty);
|
||
} else {
|
||
assert_eq!(cell_picture(&s, "D2").unwrap().alt, "replacement");
|
||
assert_eq!(v(&s, "D2"), Value::Error(gridcraft_core::CellError::Value));
|
||
}
|
||
}
|
||
}
|
||
|
||
fn ymd(y: i64, m: i64, d: i64) -> Value {
|
||
Value::Number(gridcraft_core::date::serial_from_ymd(gridcraft_core::DateSystem::D1900, y, m, d).unwrap())
|
||
}
|
||
|
||
fn series_date(seed: &str, range: &str, unit: &str) -> Session {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": seed})).unwrap();
|
||
s.execute("edit.fillSeries", json!({"range": range, "direction": "columns", "type": "date", "dateUnit": unit})).unwrap();
|
||
s
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_month_clamps_to_month_end() {
|
||
let s = series_date("2026-01-31", "A1:A4", "month");
|
||
assert_eq!(v(&s, "A1"), ymd(2026, 1, 31));
|
||
assert_eq!(v(&s, "A2"), ymd(2026, 2, 28));
|
||
assert_eq!(v(&s, "A3"), ymd(2026, 3, 31));
|
||
assert_eq!(v(&s, "A4"), ymd(2026, 4, 30));
|
||
// Mid-month seeds are untouched.
|
||
let s = series_date("2026-01-15", "A1:A4", "month");
|
||
assert_eq!(v(&s, "A4"), ymd(2026, 4, 15));
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_weekday_out_of_range_step_errors() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "45000"})).unwrap();
|
||
let r = s.execute("edit.fillSeries", json!({"range": "A1:A2", "direction": "columns", "type": "date", "dateUnit": "weekday", "step": 1e12}));
|
||
assert!(r.is_err());
|
||
assert_eq!(v(&s, "A2"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_month_leap_year() {
|
||
let s = series_date("2028-01-31", "A1:A3", "month");
|
||
assert_eq!(v(&s, "A2"), ymd(2028, 2, 29));
|
||
assert_eq!(v(&s, "A3"), ymd(2028, 3, 31));
|
||
let s = series_date("1996-01-31", "A1:A3", "month");
|
||
assert_eq!(v(&s, "A2"), ymd(1996, 2, 29));
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_year_clamps_leap_day() {
|
||
let s = series_date("2028-02-29", "A1:A5", "year");
|
||
assert_eq!(v(&s, "A2"), ymd(2029, 2, 28));
|
||
assert_eq!(v(&s, "A5"), ymd(2032, 2, 29));
|
||
}
|
||
|
||
#[test]
|
||
fn autofill_month_pattern_uses_workbook_date_system() {
|
||
use std::sync::Arc;
|
||
|
||
use gridcraft_core::date::serial_from_ymd;
|
||
use gridcraft_core::{DateSystem, RangeRef};
|
||
|
||
for sys in [DateSystem::D1900, DateSystem::D1904] {
|
||
for (source, target, seeds, expected) in [
|
||
("A1:A2", "A1:A6", ["2026-01-31", "2026-03-31"], ["2026-01-31", "2026-03-31", "2026-05-31", "2026-07-31", "2026-09-30", "2026-11-30"]),
|
||
("A5:A6", "A1:A6", ["2026-09-30", "2026-11-30"], ["2026-01-30", "2026-03-30", "2026-05-30", "2026-07-30", "2026-09-30", "2026-11-30"]),
|
||
] {
|
||
let mut s = s();
|
||
Arc::make_mut(&mut s.doc_mut().unwrap().wb).date_system = sys;
|
||
let start = RangeRef::parse(source).unwrap().start.a1();
|
||
s.execute("range.setValues", json!({"range": start, "values": [[seeds[0]], [seeds[1]]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": source, "target": target})).unwrap();
|
||
for (row, date) in expected.iter().enumerate() {
|
||
let parts: Vec<i64> = date.split('-').map(|p| p.parse().unwrap()).collect();
|
||
let expected = Value::Number(serial_from_ymd(sys, parts[0], parts[1], parts[2]).unwrap());
|
||
let cell = CellRef::new(row as u32, 0).a1();
|
||
assert_eq!(v(&s, &cell), expected, "{sys:?} {source} -> {target}, {cell}: {date}");
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn autofill_month_pattern_clamps_to_month_end() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["2026-01-31"], ["2026-03-31"]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1:A2", "target": "A1:A6"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), ymd(2026, 5, 31));
|
||
assert_eq!(v(&s, "A4"), ymd(2026, 7, 31));
|
||
assert_eq!(v(&s, "A5"), ymd(2026, 9, 30));
|
||
assert_eq!(v(&s, "A6"), ymd(2026, 11, 30));
|
||
}
|
||
|
||
#[test]
|
||
fn json_import_rebuilds_cell_store_bands_and_counts() {
|
||
// #1008: the JSON reader trusted serialized band keys and the cached length. A file written
|
||
// with a cell in the wrong band lost it from lookup, and a forged count underflowed on the
|
||
// next removal.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A5", "input": "keep"})).unwrap();
|
||
let wb = &s.doc().unwrap().wb;
|
||
let mut v: serde_json::Value = serde_json::to_value(&**wb).unwrap();
|
||
{
|
||
let cells = v["sheets"][0]["cells"].as_object_mut().unwrap();
|
||
let bands = cells["bands"].as_object_mut().unwrap();
|
||
let band = bands.remove("0").expect("the cell is in band 0");
|
||
let cell = band["rows"]["4"]["0"].clone();
|
||
// Off-grid rows never belong in a sheet, whatever band holds them.
|
||
bands.insert("1".into(), band);
|
||
bands.insert("16384".into(), json!({"rows": {"1048576": {"0": cell}}}));
|
||
cells.insert("len".into(), json!(0));
|
||
}
|
||
let bytes = serde_json::to_vec(&v).unwrap();
|
||
let (back, warnings) = crate::io::open_bytes("book.json", &bytes).unwrap();
|
||
let sh = back.active().unwrap();
|
||
let cell = sh.cell(CellRef::parse("A5").unwrap());
|
||
assert_eq!(cell.map(|c| c.value.clone()), Some(Value::text("keep")), "the cell is found where its row says");
|
||
assert_eq!(sh.cells.len(), 1, "the count is rebuilt from the cells");
|
||
assert!(warnings.iter().any(|w| w.contains("outside the 1,048,576")), "{warnings:?}");
|
||
// Removal stays consistent: the forged count used to underflow.
|
||
let mut cells = sh.cells.clone();
|
||
cells.remove(CellRef::parse("A5").unwrap());
|
||
assert_eq!(cells.len(), 0);
|
||
}
|
||
|
||
#[test]
|
||
fn notes_comments_and_links_survive_a_json_save() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "x"})).unwrap();
|
||
s.execute("review.newNote", json!({"cell": "A1", "text": "note", "author": "Example"})).unwrap();
|
||
s.execute("review.newComment", json!({"cell": "B2", "text": "comment", "author": "Example"})).unwrap();
|
||
s.execute("insert.link", json!({"cell": "C3", "target": "Sheet1!A1", "tooltip": "jump"})).unwrap();
|
||
let wb = &s.doc().unwrap().wb;
|
||
let bytes = crate::io::save_bytes(wb, "book.json").unwrap();
|
||
let (back, _) = crate::io::open_bytes("book.json", &bytes).unwrap();
|
||
let (before, after) = (wb.active().unwrap(), back.active().unwrap());
|
||
assert_eq!((before.comments.len(), before.hyperlinks.len()), (2, 1));
|
||
assert_eq!(after.comments, before.comments);
|
||
assert_eq!(after.hyperlinks, before.hyperlinks);
|
||
assert_eq!(after.cells, before.cells);
|
||
}
|
||
|
||
/// A cut moves the block's notes, hyperlinks and merged areas with it. The source's cells and
|
||
/// pictures were removed but the block's merges and notes were not, so one merged block became
|
||
/// two (an empty one left at the old place) and a note ended up on both the old and the new
|
||
/// cell. Hyperlinks were not transferred at all.
|
||
#[test]
|
||
fn a_cut_moves_the_sources_notes_hyperlinks_and_merges() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "x"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "y"})).unwrap();
|
||
s.execute("review.newNote", json!({"cell": "A1", "text": "note", "author": "Example"})).unwrap();
|
||
s.execute("insert.link", json!({"cell": "A1", "target": "https://example.com"})).unwrap();
|
||
s.execute("home.mergeCells", json!({"range": "A1:B1"})).unwrap();
|
||
|
||
s.execute("edit.cut", json!({"range": "A1:B1"})).unwrap();
|
||
s.execute("edit.paste", json!({"at": "D1"})).unwrap();
|
||
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
let (a1, d1) = (CellRef::parse("A1").unwrap(), CellRef::parse("D1").unwrap());
|
||
assert_eq!(sh.merges, vec![gridcraft_core::RangeRef::parse("D1:E1").unwrap()], "the old merge must not stay behind");
|
||
assert!(!sh.comments.contains_key(&a1), "the note moved");
|
||
assert!(sh.comments.contains_key(&d1), "the note is at the new cell");
|
||
assert!(!sh.hyperlinks.contains_key(&a1), "the hyperlink moved");
|
||
assert!(sh.hyperlinks.contains_key(&d1), "the hyperlink is at the new cell");
|
||
// The cells themselves moved as before; E1 is covered by the pasted merge (merging
|
||
// A1:B1 cleared B1, so only the anchor's content travels).
|
||
assert_eq!(v(&s, "D1"), Value::text("x"));
|
||
assert!(v(&s, "A1").is_empty() && v(&s, "B1").is_empty());
|
||
}
|
||
|
||
/// Page Layout ▸ Print Titles: naming one axis must not clear the other. `print_titles` read
|
||
/// both `rows` and `cols` into `Option`s and assigned both unconditionally, so
|
||
/// `{"rows":"2:2"}` silently dropped the repeated columns from every printed page.
|
||
#[test]
|
||
fn print_titles_keeps_the_axis_it_is_not_given() {
|
||
let mut s = s();
|
||
s.execute("pageLayout.printTitles", json!({"rows": "1:1", "cols": "A:A"})).unwrap();
|
||
let titles = |s: &Session| {
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
(sh.print.title_rows, sh.print.title_cols)
|
||
};
|
||
assert_eq!(titles(&s), (Some((0, 0)), Some((0, 0))));
|
||
// Only rows: the columns stay.
|
||
s.execute("pageLayout.printTitles", json!({"rows": "2:2"})).unwrap();
|
||
assert_eq!(titles(&s), (Some((1, 1)), Some((0, 0))), "rows alone must not clear the columns");
|
||
// Only columns: the rows stay.
|
||
s.execute("pageLayout.printTitles", json!({"cols": "B:B"})).unwrap();
|
||
assert_eq!(titles(&s), (Some((1, 1)), Some((1, 1))), "columns alone must not clear the rows");
|
||
// An empty value clears that axis on purpose.
|
||
s.execute("pageLayout.printTitles", json!({"cols": ""})).unwrap();
|
||
assert_eq!(titles(&s), (Some((1, 1)), None));
|
||
// A bad range is an error, not a silent wipe.
|
||
assert!(s.execute("pageLayout.printTitles", json!({"rows": "not a range"})).is_err());
|
||
assert_eq!(titles(&s), (Some((1, 1)), None));
|
||
}
|
||
|
||
/// Sorting and removing duplicates rewrite the rows of a range. The cells, pictures, row heights
|
||
/// and anchors travel with them, but the notes and hyperlinks hung off their old cells: a note
|
||
/// describing one record ended up annotating whatever landed on that row, and on a removed row it
|
||
/// annotated blank cells.
|
||
#[test]
|
||
fn sort_and_remove_duplicates_move_the_rows_notes_and_links() {
|
||
fn setup(values: [&str; 5]) -> Session {
|
||
let mut s = s();
|
||
for (row, text) in values.iter().enumerate() {
|
||
s.execute("cell.set", json!({"cell": format!("A{}", row + 1), "input": text})).unwrap();
|
||
}
|
||
s.execute("review.newNote", json!({"cell": "B5", "text": "late", "author": "Example"})).unwrap();
|
||
s.execute("insert.link", json!({"cell": "B4", "target": "https://example.com/4"})).unwrap();
|
||
s
|
||
}
|
||
let notes_and_links = |s: &Session| {
|
||
let sh = s.doc().unwrap().wb.active().unwrap().clone();
|
||
let cells = ["B2", "B3", "B4", "B5"].map(|c| CellRef::parse(c).unwrap());
|
||
(cells.map(|c| sh.comments.get(&c).map(|m| m.text.clone())), cells.map(|c| sh.hyperlinks.get(&c).map(|h| h.target.clone())))
|
||
};
|
||
|
||
// Sort ascending with unique keys d,a,e,b,c: the order becomes a(2), b(4), c(5), d(1), e(3).
|
||
// The note on B5 describes row 5's record ("c"), which lands on row 3; the link on B4
|
||
// describes row 4's record ("b"), which lands on row 2. Both must travel with their record.
|
||
let mut s = setup(["d", "a", "e", "b", "c"]);
|
||
s.execute("data.sort", json!({"range": "A1:B5", "keys": [{"column": "A"}]})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::text("c"));
|
||
assert_eq!(v(&s, "A5"), Value::text("e"));
|
||
let (notes, links) = notes_and_links(&s);
|
||
assert_eq!(notes[1], Some("late".to_string()), "the note moved with its record: {notes:?}");
|
||
assert_eq!(links[0], Some("https://example.com/4".to_string()), "the link moved with its record: {links:?}");
|
||
|
||
// Remove duplicates keeps the first of each value: rows 3 and 5 go, and row 4's record moves
|
||
// to row 3. The note on B5 described row 5 and goes with it.
|
||
let mut s = setup(["a", "b", "a", "c", "a"]);
|
||
s.execute("data.removeDuplicates", json!({"range": "A1:B5"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::text("c"));
|
||
let (notes, _) = notes_and_links(&s);
|
||
assert!(notes.iter().all(Option::is_none), "a note on a removed row goes with it: {notes:?}");
|
||
}
|
||
|
||
/// Insert › Link sorts a target as Excel's dialog does: a sheet reference, a defined name or `#…` is
|
||
/// a place in this document, anything else an existing file or web page. A file saved as a
|
||
/// `location` opens nothing in Excel (#800).
|
||
#[test]
|
||
fn links_to_files_are_saved_as_external_relationships() {
|
||
use std::io::Read;
|
||
let mut s = s();
|
||
s.execute("formulas.defineName", json!({"name": "Price", "refersTo": "=Sheet1!$A$1"})).unwrap();
|
||
s.execute("insert.table", json!({"range": "F1:G3", "name": "Sales"})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Q#1"})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": 0})).unwrap();
|
||
let links = [
|
||
("A1", "Source.xlsx", true),
|
||
("A2", r"C:\Temp\Book.xlsx", true),
|
||
("A3", r"..\Reports\Q1.xlsx", true),
|
||
("A4", "Other.xlsx#Sheet1!A2", true),
|
||
("A5", "https://example.com/a.xlsx", true),
|
||
("A6", "Sheet1!B2", false),
|
||
("A7", "#Sheet1!B3", false),
|
||
("A8", "Price", false),
|
||
("A9", "'Sheet1'!C4:D5", false),
|
||
("A10", "Sales", false),
|
||
("A11", "'Q#1'!B2", false),
|
||
];
|
||
for (cell, target, _) in links {
|
||
s.execute("insert.link", json!({"cell": cell, "target": target})).unwrap();
|
||
}
|
||
let bytes = gridcraft_xlsx::write_xlsx(&s.doc().unwrap().wb).unwrap();
|
||
let mut zip = zip::ZipArchive::new(std::io::Cursor::new(bytes.clone())).unwrap();
|
||
let mut part = |name: &str| {
|
||
let mut text = String::new();
|
||
zip.by_name(name).unwrap().read_to_string(&mut text).unwrap();
|
||
text
|
||
};
|
||
let (sheet, rels) = (part("xl/worksheets/sheet1.xml"), part("xl/worksheets/_rels/sheet1.xml.rels"));
|
||
for (cell, target, external) in links {
|
||
let file = target.split_once('#').map_or(target, |(f, _)| f);
|
||
let as_rel = format!("Target=\"{file}\" TargetMode=\"External\"");
|
||
let as_location = format!("location=\"{}\"", target.trim_start_matches('#'));
|
||
assert_eq!(rels.contains(&as_rel), external, "{cell} {target}: {rels}");
|
||
assert_eq!(sheet.contains(&as_location), !external, "{cell} {target}: {sheet}");
|
||
}
|
||
assert!(sheet.contains("location=\"Sheet1!A2\""), "{sheet}");
|
||
let (back, _) = gridcraft_xlsx::read_xlsx(&bytes).unwrap();
|
||
for (cell, target, external) in links {
|
||
let h = &back.sheet(0).unwrap().hyperlinks[&CellRef::parse(cell).unwrap()];
|
||
assert_eq!((h.target.as_str(), h.external), (target.trim_start_matches('#'), external), "{cell}");
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn vertical_alignment_commands_and_roundtrip() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "top"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A2", "input": "middle"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A3", "input": "bottom"})).unwrap();
|
||
|
||
s.execute("selection.set", json!({"range": "A1"})).unwrap();
|
||
s.execute("home.alignTop", json!({})).unwrap();
|
||
|
||
s.execute("selection.set", json!({"range": "A2"})).unwrap();
|
||
s.execute("home.alignMiddle", json!({})).unwrap();
|
||
|
||
s.execute("selection.set", json!({"range": "A3"})).unwrap();
|
||
s.execute("home.alignBottom", json!({})).unwrap();
|
||
|
||
let style_of = |s: &Session, cell: &str| {
|
||
let d = s.doc().unwrap();
|
||
d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse(cell).unwrap())).clone()
|
||
};
|
||
|
||
assert_eq!(style_of(&s, "A1").align.v, gridcraft_model::VAlign::Top);
|
||
assert_eq!(style_of(&s, "A2").align.v, gridcraft_model::VAlign::Center);
|
||
assert_eq!(style_of(&s, "A3").align.v, gridcraft_model::VAlign::Bottom);
|
||
|
||
let d = s.doc().unwrap();
|
||
let bytes = gridcraft_xlsx::write_xlsx(&d.wb).unwrap();
|
||
let (reopened, _) = gridcraft_xlsx::read_xlsx(&bytes).unwrap();
|
||
let reopen_style = |cell: &str| reopened.styles.get(reopened.active().unwrap().style_id(CellRef::parse(cell).unwrap())).clone();
|
||
assert_eq!(reopen_style("A1").align.v, gridcraft_model::VAlign::Top);
|
||
assert_eq!(reopen_style("A2").align.v, gridcraft_model::VAlign::Center);
|
||
assert_eq!(reopen_style("A3").align.v, gridcraft_model::VAlign::Bottom);
|
||
}
|
||
|
||
/// Icon-set thresholds as read from a file (one per icon, the first the lower bound) decide the
|
||
/// icon; a rule without thresholds uses Excel's defaults (percent 33 and 67) (#235).
|
||
#[test]
|
||
fn icon_set_thresholds_from_files_pick_the_icon() {
|
||
use gridcraft_model::{CfRule, CfValueKind, CondFormat};
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[0], [10], [20], [30], [100]]})).unwrap();
|
||
s.execute("home.conditionalFormat", json!({"range": "A1:A5", "rule": {"type": "iconSet", "set": "3Arrows"}})).unwrap();
|
||
let icon = |s: &Session, a: &str| {
|
||
let wb = &s.doc().unwrap().wb;
|
||
crate::cf::CfCache::new().look(wb, 0, CellRef::parse(a).unwrap()).and_then(|l| l.icon).map(|(_, i)| i)
|
||
};
|
||
// Defaults: percent of the 0..100 span, so 30 is still the lowest icon.
|
||
assert_eq!([icon(&s, "A1"), icon(&s, "A4"), icon(&s, "A5")], [Some(0), Some(0), Some(2)]);
|
||
let sh = std::sync::Arc::make_mut(&mut s.doc_mut().unwrap().wb).sheet_mut(0).unwrap();
|
||
sh.cond_formats = vec![CondFormat {
|
||
ranges: vec![gridcraft_core::RangeRef::parse("A1:A5").unwrap()],
|
||
rule: CfRule::IconSet {
|
||
set: "3Arrows".into(),
|
||
thresholds: vec![CfValueKind::Percent(0.0), CfValueKind::Number(10.0), CfValueKind::Number(25.0)],
|
||
reverse: false,
|
||
show_value: true,
|
||
},
|
||
priority: 1,
|
||
stop_if_true: false,
|
||
}];
|
||
assert_eq!([icon(&s, "A1"), icon(&s, "A2"), icon(&s, "A3"), icon(&s, "A4")], [Some(0), Some(1), Some(1), Some(2)]);
|
||
}
|
||
|
||
#[test]
|
||
fn row_height_and_column_width_take_a_list_of_areas() {
|
||
// Issue #341: header drags on a multi-area selection size every selected line in one step.
|
||
let mut s = s();
|
||
s.execute("home.columnWidth", json!({"cols": "B:B,D:E", "width": 120})).unwrap();
|
||
s.execute("home.rowHeight", json!({"rows": "2:2,4:5", "height": 40})).unwrap();
|
||
let widths: Vec<f32> = (0..6).map(|c| s.doc().unwrap().wb.active().unwrap().col_width(c)).collect();
|
||
let heights: Vec<f32> = (0..6).map(|r| s.doc().unwrap().wb.active().unwrap().row_height(r)).collect();
|
||
for c in [1, 3, 4] {
|
||
assert_eq!(widths[c], 120.0, "column {c}");
|
||
}
|
||
for c in [0, 2, 5] {
|
||
assert_ne!(widths[c], 120.0, "column {c}");
|
||
}
|
||
for r in [1, 3, 4] {
|
||
assert_eq!(heights[r], 40.0, "row {r}");
|
||
}
|
||
for r in [0, 2, 5] {
|
||
assert_ne!(heights[r], 40.0, "row {r}");
|
||
}
|
||
assert!(s.execute("home.columnWidth", json!({"cols": "B:B,nope", "width": 50})).is_err());
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().col_width(1), 120.0, "a bad list changes nothing");
|
||
}
|
||
|
||
/// Programmatic callers lay out a sheet that isn't the active one: `sheet` (or a `Sheet!` prefix on
|
||
/// `rows`, `cols` or `cell`) picks it, instead of being ignored in favour of the active sheet.
|
||
#[test]
|
||
fn line_sizes_and_freeze_panes_take_a_sheet() {
|
||
let mut s = s();
|
||
s.execute("home.insertSheet", json!({"name": "Data"})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Sheet1"})).unwrap();
|
||
let sheet = |s: &Session, i: usize| s.doc().unwrap().wb.sheets[i].clone();
|
||
let before = sheet(&s, 0);
|
||
|
||
s.execute("view.freezePanes", json!({"sheet": "Data", "cell": "A2"})).unwrap();
|
||
s.execute("home.columnWidth", json!({"sheet": "Data", "cols": "A:A", "width": 150})).unwrap();
|
||
s.execute("home.columnWidth", json!({"cols": "Data!B:B,D:D", "chars": 20})).unwrap();
|
||
// A null `sheet` is no `sheet`, as everywhere else: the prefix decides.
|
||
s.execute("home.columnWidth", json!({"sheet": null, "cols": "Data!C:C", "chars": 20})).unwrap();
|
||
s.execute("home.rowHeight", json!({"sheet": 1, "rows": "1:1", "height": 40})).unwrap();
|
||
s.execute("home.hideColumns", json!({"sheet": "Data", "cols": "E:E"})).unwrap();
|
||
s.execute("home.defaultWidth", json!({"sheet": "Data", "width": 80})).unwrap();
|
||
let data = sheet(&s, 1);
|
||
assert_eq!(data.freeze, Some((1, 0)));
|
||
assert_eq!((data.col_width(0), data.col_width(1), data.col_width(2), data.col_width(3)), (150.0, 145.0, 145.0, 145.0));
|
||
assert_eq!(data.row_height(0), 40.0);
|
||
assert!(data.cols.get(&4).is_some_and(|c| c.hidden));
|
||
assert_eq!(data.default_col_width, 80.0);
|
||
assert_eq!(sheet(&s, 0), before, "the active sheet is untouched");
|
||
assert_eq!(s.doc().unwrap().wb.active_sheet, 0);
|
||
|
||
s.execute("view.freezePanes", json!({"cell": "Data!B3"})).unwrap();
|
||
assert_eq!(sheet(&s, 1).freeze, Some((2, 1)));
|
||
s.execute("view.unfreezePanes", json!({"sheet": "Data"})).unwrap();
|
||
s.execute("view.freezeTopRow", json!({"sheet": "Data"})).unwrap();
|
||
assert_eq!(sheet(&s, 1).freeze, Some((1, 0)));
|
||
|
||
// The selection belongs to the active sheet: another sheet needs explicit lines or a cell, and
|
||
// a prefix can't contradict `sheet`.
|
||
assert!(s.execute("home.columnWidth", json!({"sheet": "Data", "width": 10})).is_err());
|
||
s.execute("view.unfreezePanes", json!({"sheet": "Data"})).unwrap();
|
||
assert!(s.execute("view.freezePanes", json!({"sheet": "Data"})).is_err());
|
||
assert!(s.execute("home.columnWidth", json!({"sheet": "Sheet1", "cols": "Data!B:B", "width": 10})).is_err());
|
||
assert!(s.execute("home.rowHeight", json!({"rows": "Nope!1:1", "height": 10})).is_err());
|
||
assert_eq!(sheet(&s, 0), before);
|
||
}
|
||
|
||
#[test]
|
||
fn row_height_and_column_width_take_pixels_or_excel_units() {
|
||
// `height` and `width` are pixels at 96 dpi (the model's unit); `points` and `chars` are
|
||
// Excel's units, those of its Row Height and Column Width dialogs. A row is saved in points.
|
||
let mut s = s();
|
||
s.execute("home.rowHeight", json!({"rows": "1:1", "points": 30})).unwrap();
|
||
s.execute("home.rowHeight", json!({"rows": "2:2", "height": 30})).unwrap();
|
||
s.execute("home.rowHeight", json!({"rows": "3:3", "points": 409.5})).unwrap();
|
||
s.execute("home.columnWidth", json!({"cols": "A:A", "chars": 8.43})).unwrap();
|
||
s.execute("home.columnWidth", json!({"cols": "B:B", "width": 100})).unwrap();
|
||
let sheet = s.doc().unwrap().wb.active().unwrap();
|
||
assert_eq!([sheet.row_height(0), sheet.row_height(1), sheet.row_height(2)], [40.0, 30.0, 546.0]);
|
||
assert_eq!([sheet.col_width(0), sheet.col_width(1)], [64.0, 100.0]);
|
||
let bytes = gridcraft_xlsx::write_xlsx(&s.doc().unwrap().wb).unwrap();
|
||
let mut zip = zip::ZipArchive::new(std::io::Cursor::new(bytes)).unwrap();
|
||
let mut xml = String::new();
|
||
std::io::Read::read_to_string(&mut zip.by_name("xl/worksheets/sheet1.xml").unwrap(), &mut xml).unwrap();
|
||
for row in [r#"<row r="1" ht="30" customHeight="1""#, r#"<row r="2" ht="22.5" customHeight="1""#, r#"<row r="3" ht="409.5" customHeight="1""#] {
|
||
assert!(xml.contains(row), "{row} missing from {xml}");
|
||
}
|
||
|
||
// Out of range, the message gives the limit in the unit that was passed.
|
||
for (id, params, message) in [
|
||
("home.rowHeight", json!({"height": 547}), "Row height must be between 0 and 546 pixels (409.5 points)."),
|
||
("home.rowHeight", json!({"points": 410}), "Row height must be between 0 and 409.5 points."),
|
||
("home.columnWidth", json!({"width": 1801}), "Column width must be between 0 and 1800 pixels."),
|
||
("home.columnWidth", json!({"chars": 256}), "Column width must be between 0 and 255 characters."),
|
||
] {
|
||
assert_eq!(s.execute(id, params).unwrap_err().to_string(), message);
|
||
}
|
||
|
||
// The parameter docs agents read (`list_commands`) name the unit.
|
||
for (id, unit) in [
|
||
("home.rowHeight", "height: 20 (pixels) | points: 15"),
|
||
("home.columnWidth", "width: 64 (pixels) | chars: 8.43"),
|
||
("home.defaultWidth", "width: 64 (pixels)"),
|
||
] {
|
||
let params = s.commands().into_iter().find(|c| c.id == id).map(|c| c.params).unwrap_or_default();
|
||
assert!(params.contains(unit), "{id}: {params}");
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn copying_areas_that_share_rows_or_columns_pastes_them_as_one_block() {
|
||
// Issue #348: Excel slides lined-up areas together; formulas travel as their values.
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["a1", "b1", "c1", "d1"], [1, 2, 3, 4], ["a3", "b3", "c3", "d3"], ["a4", "b4", "c4", "d4"]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("cell.set", json!({"cell": "C2", "input": "=A2+B2"})).unwrap();
|
||
|
||
// Same rows, selected right to left: pasted left to right, B left out.
|
||
s.execute("selection.set", json!({"range": "C1:C2,A1:A2"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({})).unwrap();
|
||
assert_eq!(copied["text"], "a1\tc1\n1\t3\n");
|
||
s.execute("edit.paste", json!({"at": "F1"})).unwrap();
|
||
assert_eq!(v(&s, "F1"), Value::text("a1"));
|
||
assert_eq!(v(&s, "G1"), Value::text("c1"));
|
||
assert_eq!(v(&s, "F2"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "G2"), Value::Number(3.0));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("G2").unwrap()).unwrap().formula.is_none());
|
||
assert!(v(&s, "H1").is_empty());
|
||
assert_eq!(s.doc().unwrap().selection.current().a1(), "F1:G2");
|
||
// The source is untouched.
|
||
assert_eq!(v(&s, "B1"), Value::text("b1"));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("C2").unwrap()).unwrap().formula.is_some());
|
||
|
||
// Same columns: stacked, row 2 left out.
|
||
s.execute("selection.set", json!({"range": "A1:B1,A3:B4"})).unwrap();
|
||
assert_eq!(s.execute("edit.copy", json!({})).unwrap()["text"], "a1\tb1\na3\tb3\na4\tb4\n");
|
||
s.execute("edit.paste", json!({"at": "F5"})).unwrap();
|
||
for (cell, want) in [("F5", "a1"), ("G5", "b1"), ("F6", "a3"), ("G7", "b4")] {
|
||
assert_eq!(v(&s, cell), Value::text(want), "{cell}");
|
||
}
|
||
assert!(v(&s, "F8").is_empty());
|
||
|
||
// Whole columns are trimmed to the used rows like a single-area copy.
|
||
s.execute("edit.undo", json!({"steps": 2})).unwrap();
|
||
s.execute("selection.set", json!({"range": "B:B,D:D"})).unwrap();
|
||
assert_eq!(s.execute("edit.copy", json!({})).unwrap()["text"], "b1\td1\n2\t4\nb3\td3\nb4\td4\n");
|
||
}
|
||
|
||
#[test]
|
||
fn copying_areas_that_do_not_line_up_is_refused_with_a_message() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2, 3], [4, 5, 6], [7, 8, 9]]})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A1"})).unwrap();
|
||
s.execute("edit.copy", json!({})).unwrap();
|
||
for (range, cut) in [("A1:A2,C2:C3", false), ("A1:A2,C1:D3", false), ("A1:A2,A2:A3", false), ("A1:A2,A1:A2", false), ("A1:A2,C1:C2", true)] {
|
||
s.execute("selection.set", json!({"range": range})).unwrap();
|
||
let e = s.execute(if cut { "edit.cut" } else { "edit.copy" }, json!({})).unwrap_err().to_string();
|
||
assert!(e.contains("This action won't work on multiple selections."), "{range}: {e}");
|
||
assert_eq!(s.clipboard.as_ref().map(|c| c.range.a1()), Some("A1".into()), "{range}: the earlier copy stays");
|
||
}
|
||
// Paste Link can't point at a slid-together block.
|
||
s.execute("selection.set", json!({"range": "A1:A2,C1:C2"})).unwrap();
|
||
s.execute("edit.copy", json!({})).unwrap();
|
||
assert!(s.execute("edit.pasteSpecial", json!({"what": "all", "link": true, "at": "E1"})).is_err());
|
||
assert!(v(&s, "E1").is_empty());
|
||
}
|
||
|
||
#[test]
|
||
fn editing_a_date_cell_shows_a_date_not_the_serial() {
|
||
let mut s = s();
|
||
let at = CellRef::parse("A1").unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "2026-03-04"})).unwrap();
|
||
{
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(crate::display::edit_text(&d.wb, sh, at), "2026-03-04");
|
||
}
|
||
// A format whose text cannot be typed back falls back to ISO.
|
||
s.execute("home.formatCells", json!({"range": "A1", "style": {"num_fmt": "dddd, mmmm d"}})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(crate::display::edit_text(&d.wb, sh, at), "2026-03-04");
|
||
// A time alone falls back to a time, not to day 0 of 1900 ("9 AM" would lose the 36 minutes).
|
||
let mut s3 = self::s();
|
||
s3.execute("cell.set", json!({"cell": "A1", "input": "0.4"})).unwrap();
|
||
s3.execute("home.formatCells", json!({"range": "A1", "style": {"num_fmt": "h AM/PM"}})).unwrap();
|
||
let d = s3.doc().unwrap();
|
||
assert_eq!(crate::display::edit_text(&d.wb, d.wb.active().unwrap(), at), "09:36:00");
|
||
// Plain numbers are untouched.
|
||
let mut s2 = self::s();
|
||
s2.execute("cell.set", json!({"cell": "A1", "input": "42"})).unwrap();
|
||
let d = s2.doc().unwrap();
|
||
assert_eq!(crate::display::edit_text(&d.wb, d.wb.active().unwrap(), at), "42");
|
||
}
|
||
|
||
/// A workbook with 42 in A1, saved as `.xlsx` and encrypted with `password`.
|
||
fn encrypted_book(password: &str) -> Vec<u8> {
|
||
let mut src = s();
|
||
src.execute("cell.set", json!({"cell": "A1", "input": "42"})).unwrap();
|
||
let xlsx = crate::io::save_bytes(&src.doc().unwrap().wb, "book.xlsx").unwrap();
|
||
gridcraft_xlsx::testing::encrypt_workbook(&xlsx, password)
|
||
}
|
||
|
||
#[test]
|
||
fn encrypted_workbooks_open_with_their_password() {
|
||
const PW: &str = "synthetic-pw-5521";
|
||
let b64 = crate::io::base64_encode(&encrypted_book(PW));
|
||
let open = |s: &mut Session, password: Option<&str>| {
|
||
let mut p = json!({"name": "Secret.xlsx", "base64": b64});
|
||
if let Some(pw) = password {
|
||
p["password"] = json!(pw);
|
||
}
|
||
s.execute("file.open", p)
|
||
};
|
||
let mut s = Session::new();
|
||
|
||
// Programmatic open without a password: an error carrying the marker, never a dialog.
|
||
let err = open(&mut s, None).unwrap_err().to_string();
|
||
assert!(err.contains(crate::io::PASSWORD_REQUIRED), "{err}");
|
||
assert!(err.contains("Secret.xlsx"), "{err}");
|
||
assert!(s.take_ui_requests().is_empty(), "programmatic calls never open dialogs");
|
||
assert!(s.documents().is_empty());
|
||
|
||
// Wrong and empty passwords are "incorrect", and the password is never quoted.
|
||
for wrong in ["not-it", ""] {
|
||
let err = open(&mut s, Some(wrong)).unwrap_err().to_string();
|
||
assert!(err.contains(crate::io::WRONG_PASSWORD), "{err}");
|
||
assert!(wrong.is_empty() || !err.contains(wrong), "{err}");
|
||
}
|
||
assert!(s.documents().is_empty());
|
||
|
||
// The right password opens it: no save path, the file name as title, the notice first.
|
||
let r = open(&mut s, Some(PW)).unwrap();
|
||
assert_eq!(r["warnings"][0], crate::io::DECRYPTED_NOTICE);
|
||
assert_eq!(r["title"], "Secret.xlsx");
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
assert_eq!(s.doc().unwrap().path, None);
|
||
// The notice belongs in the info bar, not a message box.
|
||
assert!(!s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Message(_))));
|
||
let journal = serde_json::to_string(&s.journal).unwrap();
|
||
assert!(!journal.contains(PW), "the password never reaches the journal");
|
||
}
|
||
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn a_decrypted_workbook_never_overwrites_its_encrypted_original() {
|
||
const PW: &str = "synthetic-pw-5522";
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-encrypted-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let path = dir.join("Secret.xlsx");
|
||
let bytes = encrypted_book(PW);
|
||
std::fs::write(&path, &bytes).unwrap();
|
||
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": path, "password": PW})).unwrap();
|
||
assert_eq!(s.doc().unwrap().path, None);
|
||
s.take_ui_requests();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "43"})).unwrap();
|
||
s.execute("file.save", json!({})).unwrap();
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Dialog(name, _) if name == "saveAs")));
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes, "the encrypted original is untouched");
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn link_open_refuses_every_scheme_but_http_https_and_mailto() {
|
||
let mut s = s();
|
||
s.execute("insert.link", json!({"cell": "A1", "target": "file:///etc/passwd"})).unwrap();
|
||
s.take_ui_requests();
|
||
for url in ["file:///etc/passwd", "smb://h/s", "\\\\h\\s", "JAVASCRIPT:1"] {
|
||
assert!(s.execute("link.open", json!({"url": url})).is_err(), "{url}");
|
||
}
|
||
assert!(s.execute("link.open", json!({"cell": "A1"})).is_err());
|
||
assert!(s.take_ui_requests().is_empty());
|
||
s.execute("link.open", json!({"url": "HTTPS://example.org/a"})).unwrap();
|
||
assert_eq!(s.take_ui_requests(), vec![crate::UiRequest::OpenUrl("HTTPS://example.org/a".into())]);
|
||
s.execute("link.open", json!({"url": "B2"})).unwrap();
|
||
assert!(s.take_ui_requests().is_empty());
|
||
}
|
||
|
||
#[test]
|
||
fn subtotal_109_recalculates_when_row_height_or_autofit_reveals_rows() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [4], [8]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=SUBTOTAL(109,A1:A4)"})).unwrap();
|
||
s.execute("home.hideRows", json!({"rows": "2:3"})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::Number(9.0));
|
||
// A non-zero height unhides the rows (the fuzz found the stale SUBTOTAL).
|
||
s.execute("home.rowHeight", json!({"rows": "2:3", "height": 60.0})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::Number(15.0));
|
||
s.execute("home.hideRows", json!({"rows": "2:3"})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::Number(9.0));
|
||
s.execute("home.autofitRowHeight", json!({"rows": "2:3"})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::Number(15.0));
|
||
}
|
||
|
||
#[test]
|
||
fn paste_special_validation_copies_the_rule() {
|
||
let mut s = s();
|
||
let ok = |s: &mut Session, cell: &str, input: &str| s.execute("data.validate", json!({"cell": cell, "input": input})).unwrap()["ok"] == true;
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "5"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C3", "input": "7"})).unwrap();
|
||
s.execute("data.validation", json!({"range": "A1", "type": "whole", "operator": "greater", "formula1": "0"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "A1"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "formats", "at": "E5"})).unwrap();
|
||
assert!(ok(&mut s, "E5", "-1"));
|
||
s.execute("edit.pasteSpecial", json!({"what": "validation", "at": "C3"})).unwrap();
|
||
assert!(!ok(&mut s, "C3", "-1"));
|
||
assert!(ok(&mut s, "C3", "1"));
|
||
assert!(!ok(&mut s, "A1", "-1"));
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "C3"})).unwrap()["text"], json!("7"));
|
||
}
|
||
|
||
#[test]
|
||
fn paste_special_validation_moves_relative_references() {
|
||
let mut s = s();
|
||
let ok = |s: &mut Session, cell: &str, input: &str| s.execute("data.validate", json!({"cell": cell, "input": input})).unwrap()["ok"] == true;
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "50"})).unwrap();
|
||
s.execute("data.validation", json!({"range": "A1", "type": "custom", "formula1": "=A1>10"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "A1"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "validation", "at": "C3"})).unwrap();
|
||
assert!(!ok(&mut s, "C3", "5"), "the pasted rule checks C3, not A1");
|
||
assert!(ok(&mut s, "C3", "20"));
|
||
}
|
||
|
||
#[test]
|
||
fn editing_quote_prefixed_text_keeps_it_text() {
|
||
let mut s = s();
|
||
for (i, input) in ["'00123", "'=1+1", "'TRUE", "''abc"].iter().enumerate() {
|
||
let cell = format!("A{}", i + 1);
|
||
s.execute("cell.set", json!({"cell": cell, "input": input})).unwrap();
|
||
let at = CellRef::parse(&cell).unwrap();
|
||
let before = v(&s, &cell);
|
||
let edit = {
|
||
let d = s.doc().unwrap();
|
||
crate::display::edit_text(&d.wb, d.wb.active().unwrap(), at)
|
||
};
|
||
assert_eq!(&edit, input, "edit text of {cell}");
|
||
// Committing the editor unchanged leaves the cell as it was.
|
||
s.execute("cell.set", json!({"cell": cell, "input": edit})).unwrap();
|
||
assert_eq!(v(&s, &cell), before, "{cell}");
|
||
}
|
||
// Plain text is shown as typed, without a prefix.
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "hello"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(crate::display::edit_text(&d.wb, d.wb.active().unwrap(), CellRef::parse("B1").unwrap()), "hello");
|
||
}
|
||
|
||
#[test]
|
||
fn csv_as_text_keeps_identifier_columns_as_written() {
|
||
let csv = "gtin,zip,flag,day\n8435392892278,01234,TRUE,2026-03-04\n";
|
||
let open = |s: &mut Session, extra: serde_json::Value| {
|
||
let mut p = json!({"name": "feed.csv", "base64": crate::io::base64_encode(csv.as_bytes())});
|
||
if let (Some(p), Some(extra)) = (p.as_object_mut(), extra.as_object()) {
|
||
p.extend(extra.clone());
|
||
}
|
||
s.execute("file.open", p).unwrap();
|
||
};
|
||
let value = |s: &mut Session, cell: &str| s.execute("cell.get", json!({"cell": cell})).unwrap()["value"].clone();
|
||
// By default fields are typed like typed input: the leading zero is lost and the GTIN is a number.
|
||
let mut s = s();
|
||
open(&mut s, json!({}));
|
||
assert!(value(&mut s, "A2").is_number());
|
||
assert_eq!(value(&mut s, "B2").as_f64(), Some(1234.0));
|
||
// With csvAsText every field stays the text the file holds, and saves back unchanged.
|
||
let mut s = self::s();
|
||
open(&mut s, json!({"csvAsText": true}));
|
||
for (cell, text) in [("A2", "8435392892278"), ("B2", "01234"), ("C2", "TRUE"), ("D2", "2026-03-04")] {
|
||
assert_eq!(value(&mut s, cell), json!(text), "{cell}");
|
||
}
|
||
let saved = s.execute("file.saveBytes", json!({"format": "csv"})).unwrap();
|
||
assert_eq!(crate::io::base64_decode(saved["base64"].as_str().unwrap()).unwrap(), csv.replace('\n', "\r\n").as_bytes());
|
||
}
|
||
|
||
/// Open a workbook by path, and `CELL("filename")` names the file it came from, as Excel does;
|
||
/// Save As makes the new file the one it names. The sheet-name formula of #1489 depends on it.
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn cell_filename_follows_the_file_the_workbook_lives_in() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-cellname-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let name = "=CELL(\"filename\",A1)";
|
||
let sheet_of = "=MID(CELL(\"filename\",A1),FIND(\"]\",CELL(\"filename\",A1))+1,31)";
|
||
|
||
// A new workbook has no file: empty, and the sheet-name formula cannot work yet.
|
||
let mut fresh = s();
|
||
fresh.execute("cell.set", json!({"cell": "A1", "input": name})).unwrap();
|
||
fresh.execute("cell.set", json!({"cell": "A2", "input": sheet_of})).unwrap();
|
||
assert_eq!(v(&fresh, "A1"), Value::from(""));
|
||
assert_eq!(v(&fresh, "A2"), Value::Error(gridcraft_core::CellError::Value));
|
||
|
||
// Saved: it names the file. `CELL` is volatile, so the cells holding it answer from the next
|
||
// recalculation (F9), the same as every other volatile function; the save itself is not one.
|
||
let first = dir.join("book one.xlsx");
|
||
fresh.execute("file.saveAs", json!({"path": first})).unwrap();
|
||
let sheet = fresh.doc().unwrap().wb.active().unwrap().name.clone();
|
||
// Saving did not leave the workbook looking modified.
|
||
assert!(!fresh.doc().unwrap().is_dirty());
|
||
fresh.execute("formulas.calculateNow", json!({})).unwrap();
|
||
assert_eq!(v(&fresh, "A1"), Value::from(dir.join(format!("[book one.xlsx]{sheet}")).to_string_lossy().into_owned().as_str()));
|
||
assert_eq!(v(&fresh, "A2"), Value::from(sheet.as_str()));
|
||
|
||
// Opened from that path in another session: the same answer, from the file alone.
|
||
let mut opened = s();
|
||
opened.execute("file.open", json!({"path": first})).unwrap();
|
||
opened.take_ui_requests();
|
||
assert_eq!(v(&opened, "A2"), Value::from(sheet.as_str()));
|
||
|
||
// Save As into another folder: it follows the new file, not the old one.
|
||
let other = dir.join("sub");
|
||
std::fs::create_dir(&other).unwrap();
|
||
opened.execute("file.saveAs", json!({"path": other.join("book two.xlsx")})).unwrap();
|
||
assert!(!opened.doc().unwrap().is_dirty());
|
||
opened.execute("formulas.calculateNow", json!({})).unwrap();
|
||
assert_eq!(v(&opened, "A1"), Value::from(other.join(format!("[book two.xlsx]{sheet}")).to_string_lossy().into_owned().as_str()));
|
||
|
||
// Opened from bytes there is no folder, only a name — still splittable on the `]`.
|
||
let saved = opened.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let mut from_bytes = s();
|
||
from_bytes.execute("file.open", json!({"name": "from bytes.xlsx", "base64": saved["base64"]})).unwrap();
|
||
from_bytes.take_ui_requests();
|
||
assert_eq!(v(&from_bytes, "A1"), Value::from(format!("[from bytes.xlsx]{sheet}").as_str()));
|
||
assert_eq!(v(&from_bytes, "A2"), Value::from(sheet.as_str()));
|
||
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
/// Protect Sheet's Sort and Use AutoFilter tick boxes are obeyed. They were read from the file and
|
||
/// written back but never consulted, so a protected sheet could still be sorted and filtered.
|
||
///
|
||
/// Sorting locked cells stays refused whichever way the box is set, which is Excel's rule too
|
||
/// ("users cannot sort ranges that contain locked cells on a protected worksheet"), so the box
|
||
/// decides for a range that has been unlocked. An AutoFilter changes no cell's contents, so there
|
||
/// the box is the only thing that decides.
|
||
#[test]
|
||
fn a_protected_sheet_allows_sorting_and_filtering_only_when_it_says_so() {
|
||
let allow = |s: &mut Session, f: fn(&mut gridcraft_model::SheetProtection)| {
|
||
let d = s.doc_mut().unwrap();
|
||
let mut wb = (*d.wb).clone();
|
||
if let Some(p) = wb.sheet_mut(0).and_then(|sh| sh.protection.as_mut()) {
|
||
f(p);
|
||
}
|
||
d.wb = std::sync::Arc::new(wb);
|
||
};
|
||
// Three rows under a header, and the cells unlocked so that the tick box is what decides.
|
||
let book = || {
|
||
let mut s = s();
|
||
for (c, v) in [("A1", "Head"), ("A2", "2"), ("A3", "1")] {
|
||
s.execute("cell.set", json!({"cell": c, "input": v})).unwrap();
|
||
}
|
||
s.execute("home.lockCell", json!({"range": "A1:A3", "on": false})).unwrap();
|
||
s
|
||
};
|
||
let order = |s: &Session| (v(s, "A2"), v(s, "A3"));
|
||
|
||
// Unprotected: both work, so the guard has not made the ordinary case stricter.
|
||
let mut s = book();
|
||
s.execute("data.sortAscending", json!({})).unwrap();
|
||
assert_eq!(order(&s), (Value::Number(1.0), Value::Number(2.0)));
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
|
||
// Protected with nothing ticked, which is what Excel's dialog opens with: both refused.
|
||
let mut s = book();
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
for (cmd, args) in [
|
||
("data.sortAscending", json!({})),
|
||
("data.sortDescending", json!({})),
|
||
// Sort… needs a key to be a sort at all: with none it does nothing either way.
|
||
("data.sort", json!({"keys": [{"column": "A", "order": "asc"}]})),
|
||
("data.filter", json!({})),
|
||
("data.filterBy", json!({})),
|
||
] {
|
||
let e = s.execute(cmd, args).expect_err(cmd).to_string();
|
||
assert!(e.contains("protected sheet"), "{cmd}: {e}");
|
||
}
|
||
// Refused, not half-applied: the rows are where they were.
|
||
assert_eq!(order(&s), (Value::Number(2.0), Value::Number(1.0)));
|
||
assert!(s.doc().unwrap().wb.sheet(0).unwrap().autofilter.is_none());
|
||
|
||
// Sort ticked: sorting works on the unlocked range; filtering is still refused.
|
||
let mut s = book();
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
allow(&mut s, |p| p.sort = true);
|
||
s.execute("data.sortAscending", json!({})).unwrap();
|
||
assert_eq!(order(&s), (Value::Number(1.0), Value::Number(2.0)), "sorted under the header");
|
||
assert!(s.execute("data.filter", json!({})).is_err(), "Use AutoFilter is still off");
|
||
|
||
// Use AutoFilter ticked: the filter goes on, and sorting is refused.
|
||
let mut s = book();
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
allow(&mut s, |p| p.autofilter = true);
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
assert!(s.doc().unwrap().wb.sheet(0).unwrap().autofilter.is_some(), "the AutoFilter is on");
|
||
assert!(s.execute("data.sortAscending", json!({})).is_err(), "Sort is still off");
|
||
// Unprotecting gives sorting back.
|
||
s.execute("review.unprotectSheet", json!({})).unwrap();
|
||
s.execute("data.sortAscending", json!({})).unwrap();
|
||
|
||
// Locked cells: ticking Sort does not let them be reordered, as in Excel.
|
||
let mut s = {
|
||
let mut t = super::tests::s();
|
||
for (c, v) in [("A1", "Head"), ("A2", "2"), ("A3", "1")] {
|
||
t.execute("cell.set", json!({"cell": c, "input": v})).unwrap();
|
||
}
|
||
t
|
||
};
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
allow(&mut s, |p| p.sort = true);
|
||
assert!(s.execute("data.sortAscending", json!({})).is_err(), "locked cells cannot be sorted");
|
||
assert_eq!(order(&s), (Value::Number(2.0), Value::Number(1.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn convert_to_number_turns_numbers_stored_as_text_into_numbers() {
|
||
let mut s = s();
|
||
let value = |s: &mut Session, cell: &str| s.execute("cell.get", json!({"cell": cell})).unwrap()["value"].clone();
|
||
for (cell, input) in [("A1", "'123"), ("A2", "'1,000.5"), ("A3", "'abc"), ("A4", "'3/4/2026"), ("A5", "=\"7\"")] {
|
||
s.execute("cell.set", json!({"cell": cell, "input": input})).unwrap();
|
||
}
|
||
s.execute("home.bold", json!({"range": "A1", "on": true})).unwrap();
|
||
let r = s.execute("formulas.convertToNumber", json!({"range": "A1:A5"})).unwrap();
|
||
assert_eq!(r["converted"], 2);
|
||
assert_eq!(value(&mut s, "A1"), json!(123.0));
|
||
assert_eq!(value(&mut s, "A2"), json!(1000.5));
|
||
// Words, date text and a formula's text result stay as they are.
|
||
assert_eq!(value(&mut s, "A3"), json!("abc"));
|
||
assert_eq!(value(&mut s, "A4"), json!("3/4/2026"));
|
||
assert_eq!(value(&mut s, "A5"), json!("7"));
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "A1"})).unwrap()["style"]["font"]["bold"], true, "the format is kept");
|
||
// SUM now counts them; undo brings the text back in one step.
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=SUM(A1:A2)"})).unwrap();
|
||
assert_eq!(value(&mut s, "B1"), json!(1123.5));
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(value(&mut s, "A1"), json!("123"));
|
||
// With no range it works on the selection.
|
||
s.execute("selection.set", json!({"range": "A2"})).unwrap();
|
||
assert_eq!(s.execute("formulas.convertToNumber", json!({})).unwrap()["converted"], 1);
|
||
assert_eq!(value(&mut s, "A1"), json!("123"));
|
||
}
|
||
|
||
#[test]
|
||
fn saving_csv_keeps_leading_empty_columns_and_rows() {
|
||
let wb = gridcraft_xlsx::read_csv(b",x\r\n\r\n,,y\r\n", &gridcraft_xlsx::CsvOptions::default()).unwrap();
|
||
let out = crate::io::save_bytes(&wb, "a.csv").unwrap();
|
||
assert_eq!(String::from_utf8(out).unwrap(), ",x,\r\n,,\r\n,,y\r\n");
|
||
}
|
||
|
||
#[test]
|
||
fn rotate_rejects_flip_param_instead_of_swapping_size() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.shape", json!({"kind": "rectangle"})).unwrap()["shape"].clone();
|
||
let size = |s: &Session| {
|
||
let a = &s.doc().unwrap().wb.active().unwrap().shapes[0].anchor;
|
||
(a.width, a.height)
|
||
};
|
||
let (w, h) = size(&s);
|
||
assert_ne!(w, h);
|
||
let before = s.doc().unwrap().wb.clone();
|
||
for flip in ["horizontal", "vertical", "sideways"] {
|
||
let r = s.execute("arrange.rotate", json!({"kind": "shape", "id": id, "flip": flip}));
|
||
assert!(matches!(r, Err(crate::EngineError::BadParams { .. })), "flip {flip}: {r:?}");
|
||
assert_eq!(size(&s), (w, h));
|
||
assert!(std::sync::Arc::ptr_eq(&s.doc().unwrap().wb, &before));
|
||
}
|
||
s.execute("arrange.rotate", json!({"kind": "shape", "id": id})).unwrap();
|
||
assert_eq!(size(&s), (h, w));
|
||
}
|
||
|
||
#[test]
|
||
fn box_whisker_quartile_methods_survive_xlsx() {
|
||
use gridcraft_model::QuartileMethod;
|
||
let mut s = s();
|
||
chart_data(&mut s);
|
||
s.execute("insert.chart", json!({"range": "A1:C5", "type": "boxWhisker"})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().charts[0].series[0].quartiles, QuartileMethod::Exclusive);
|
||
s.execute("chart.set", json!({"quartiles": "inclusive"})).unwrap();
|
||
assert!(s.doc().unwrap().wb.active().unwrap().charts[0].series.iter().all(|s| s.quartiles == QuartileMethod::Inclusive));
|
||
for invalid in [json!("median"), json!(null), json!(1)] {
|
||
assert!(s.execute("chart.set", json!({"quartiles": invalid, "title": "Changed"})).is_err());
|
||
}
|
||
assert_ne!(s.doc().unwrap().wb.active().unwrap().charts[0].title.as_deref(), Some("Changed"));
|
||
// Imported series can differ; changing a chart's setting applies to all its series.
|
||
let mut wb = (*s.doc().unwrap().wb).clone();
|
||
let sh = wb.sheet_mut(0).unwrap();
|
||
assert!(sh.charts[0].series.len() > 1);
|
||
sh.charts[0].series[1].quartiles = QuartileMethod::Exclusive;
|
||
let bytes = gridcraft_xlsx::write_xlsx(&wb).unwrap();
|
||
let (back, _) = gridcraft_xlsx::read_xlsx(&bytes).unwrap();
|
||
let series = &back.active().unwrap().charts[0].series;
|
||
assert_eq!(series[0].quartiles, QuartileMethod::Inclusive);
|
||
assert_eq!(series[1].quartiles, QuartileMethod::Exclusive);
|
||
s.execute("chart.set", json!({"quartiles": "exclusive"})).unwrap();
|
||
assert!(s.doc().unwrap().wb.active().unwrap().charts[0].series.iter().all(|s| s.quartiles == QuartileMethod::Exclusive));
|
||
}
|