mirror of
https://github.com/storytold/gridcraft.git
synced 2026-10-30 13:46:47 -06:00
prxnvt
b09a5502e3
The ribbon enabled them from the history lengths alone, so while an undo group was open on the document (an action spanning several calls) a click ran edit.undo and got its refusal. The buttons now ask cmd::can_undo and cmd::can_redo, the undo list is empty while a group is open, and the two buttons carry a name and their enabled state for assistive technology. A UI test opens a group, clicks both and checks the history and their state.
58 lines
2.2 KiB
Rust
58 lines
2.2 KiB
Rust
//! Undo and Redo on the Quick Access Toolbar follow the commands' own availability: while an undo
|
|
//! group is open on the document (an action that spans several calls is still running), both
|
|
//! buttons are off, and a click neither runs the command nor raises its refusal.
|
|
|
|
use egui_kittest::kittest::{NodeT as _, Queryable as _};
|
|
use gridcraft_engine::Session;
|
|
use gridcraft_ui_egui::SheetApp;
|
|
use serde_json::json;
|
|
|
|
type Harness = egui_kittest::Harness<'static, SheetApp>;
|
|
|
|
fn harness() -> Harness {
|
|
let mut s = Session::new();
|
|
s.new_workbook();
|
|
s.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
|
s.execute("cell.set", json!({"cell": "A1", "input": "2"})).unwrap();
|
|
s.execute("edit.undo", json!({})).unwrap();
|
|
let mut h = egui_kittest::Harness::builder().with_size(egui::vec2(1200.0, 800.0)).build_ui_state(
|
|
|ui, app: &mut SheetApp| {
|
|
app.logic(ui.ctx());
|
|
app.ui(ui);
|
|
},
|
|
SheetApp::new(s, Default::default()),
|
|
);
|
|
h.run_steps(4);
|
|
h
|
|
}
|
|
|
|
fn history(h: &Harness) -> (usize, usize) {
|
|
let d = h.state().session.active().unwrap();
|
|
(d.undo.len(), d.redo.len())
|
|
}
|
|
|
|
#[test]
|
|
fn undo_and_redo_wait_while_an_undo_group_is_open() {
|
|
let mut h = harness();
|
|
assert_eq!(history(&h), (1, 1));
|
|
let token = h.state_mut().session.group_begin("Long action").unwrap();
|
|
h.run_steps(2);
|
|
for button in ["Undo", "Redo"] {
|
|
assert!(h.get_by_label(button).accesskit_node().is_disabled(), "{button} is off while the group is open");
|
|
h.get_by_label(button).click();
|
|
h.run_steps(2);
|
|
assert!(h.state().message.is_none(), "{button}: no refusal is raised while the group is open");
|
|
assert_eq!(history(&h), (1, 1), "{button}: the history is as it was");
|
|
}
|
|
h.state_mut().session.group_end(token).unwrap();
|
|
h.run_steps(2);
|
|
assert!(!h.get_by_label("Undo").accesskit_node().is_disabled() && !h.get_by_label("Redo").accesskit_node().is_disabled());
|
|
// With the group ended, the buttons work again.
|
|
h.get_by_label("Undo").click();
|
|
h.run_steps(2);
|
|
assert_eq!(history(&h), (0, 2));
|
|
h.get_by_label("Redo").click();
|
|
h.run_steps(2);
|
|
assert_eq!(history(&h), (1, 1));
|
|
}
|