mirror of
https://github.com/storytold/gridcraft.git
synced 2026-10-25 11:16:49 -06:00
Dejan PortandClaude Sonnet 5
7ba3676f5f
CI failed with cargo clippy --workspace --all-targets -- -D warnings, not a test. The actual cause: I'd been validating locally against rustc/clippy 1.95.0 (the toolchain this machine had installed before now), while CI installs plain "stable" (1.99.0 as of this run) — two lints new since 1.95.0 fired there and nowhere in my local checks: - clippy::int_plus_one on `src.end.row + 1 <= cap` in grid.rs, simplified to `src.end.row < cap` (same meaning, no overflow risk change: row is a u32 and cap is already saturating-clamped below MAX_ROWS - 1, so src.end.row + 1 can't wrap). - clippy::disallowed_methods on the new fill_handle_perf example's three Instant::now() calls — the project's own lint from the time- panic fix (#125 history): reading the clock traps on wasm. This example is native-only (a `cargo run --release` benchmark, never built for wasm), so it gets the same #![allow(...)] perf.rs already carries, with the same justification. Updated the local toolchain to stable (rustup update stable) and re-ran cargo clippy --workspace --all-targets -- -D warnings clean before this push, to actually match what CI checks instead of guessing again. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
51 lines
1.9 KiB
Rust
51 lines
1.9 KiB
Rust
//! Times the fill-handle double-click scan against a densely-filled neighbour column: the old
|
|
//! row-by-row `value_ref` loop from `grid.rs` vs. `Sheet::last_contiguous_nonempty`.
|
|
//! `cargo run --release -p gridcraft-engine --example fill_handle_perf -- [rows]`
|
|
|
|
#![allow(clippy::disallowed_methods)] // a native-only benchmark: wasm never runs it
|
|
|
|
use std::time::Instant;
|
|
|
|
use gridcraft_engine::Session;
|
|
use gridcraft_engine::core::CellRef;
|
|
use serde_json::json;
|
|
|
|
fn main() {
|
|
let rows: u32 = std::env::args().nth(1).and_then(|s| s.parse().ok()).unwrap_or(1_000_000);
|
|
let mut s = Session::new();
|
|
s.new_workbook();
|
|
let t = Instant::now();
|
|
let chunk = 10_000u32;
|
|
let mut r = 0u32;
|
|
while r < rows {
|
|
let n = chunk.min(rows - r);
|
|
let vals: Vec<serde_json::Value> = (0..n).map(|i| json!([(r + i) as f64])).collect();
|
|
s.execute("range.setValues", json!({"range": format!("A{}", r + 1), "values": vals})).expect("set");
|
|
r += n;
|
|
}
|
|
println!("fill A1:A{rows}: {:?}", t.elapsed());
|
|
|
|
let d = s.doc().expect("doc");
|
|
let sh = d.wb.active().expect("sheet");
|
|
let neighbour = 0u32; // column A
|
|
let cap = (rows - 1).min(999_999);
|
|
|
|
let t = Instant::now();
|
|
let mut last = 0u32;
|
|
let mut iters = 0u64;
|
|
while last + 1 < gridcraft_engine::core::MAX_ROWS && sh.value_ref(CellRef::new(last + 1, neighbour)).is_some_and(|v| !v.is_empty()) && last < cap
|
|
{
|
|
last += 1;
|
|
iters += 1;
|
|
}
|
|
let old = t.elapsed();
|
|
println!("old row-by-row scan: {iters} iterations, {old:?} ({:.1} ns/iter)", old.as_nanos() as f64 / iters.max(1) as f64);
|
|
|
|
let t = Instant::now();
|
|
let new_last = sh.last_contiguous_nonempty(neighbour, 1, cap);
|
|
let new_t = t.elapsed();
|
|
println!("new last_contiguous_nonempty: last={new_last}, {new_t:?} ({:.2}x faster)", old.as_secs_f64() / new_t.as_secs_f64().max(1e-12));
|
|
|
|
assert_eq!(last, new_last, "old and new scans must agree");
|
|
}
|