aleleba/gridcraft
1
0
Fork 0
mirror of https://github.com/storytold/gridcraft.git synced 2026-11-03 08:51:30 -06:00
Code Issues Packages Projects Releases Wiki Activity
1,016 Commits 62 Branches 15 Tags
f8cbfb7cb602bd15a9c2a2cf70009fcf0af9cec6
Commit Graph
353 Commits
Author SHA1 Message Date
midasmatterhorn f8cbfb7cb6 engine: sort and remove duplicates move the rows' notes and hyperlinks 
do_sort moved cells, formulas, cell pictures, row heights and floating
object anchors through the sort permutation, and remove_duplicates moved
cells and pictures through the compaction, but neither touched
Sheet::comments or Sheet::hyperlinks (keyed by CellRef): a note that
described one record stayed behind and annotated whatever landed on that
row — 'late payment' on a paid invoice — and a note on a row removed by
Remove Duplicates annotated blank cells. Sheet::comments/hyperlinks are
exactly the range-scoped side data that row and column inserts already
remap and edit.clear already clears, so the omission looks unintended.

Both maps now travel through the same permutation the cells use (the
sort collects before re-inserting, so a swap cannot resurrect an entry
from a destination that is also a source; Remove Duplicates compacts the
kept rows and drops the rest).

Regression test: sort_and_remove_duplicates_move_the_rows_notes_and_links
— on main the note and link stay on their old cells; with the fix they
travel with their record.
 2026-10-15 17:40:18 +03:00
Brandon Thomas ebe0138d30 Merge main into #855 
# Conflicts:
#	ROADMAP.md
#	docs/gaps.md
#	docs/target-app-parity.md
 2026-10-13 01:52:08 -04:00
Brandon Thomas be003d44af Merge main into #863 
# Conflicts:
#	crates/xlsx/src/tests/passthrough_tests.rs
 2026-10-13 01:40:22 -04:00
Brandon Thomas be45ccab31 Merge main into #811 
# Conflicts:
#	ROADMAP.md
#	crates/numfmt/src/parse.rs
#	crates/numfmt/src/tests.rs
 2026-10-13 01:05:45 -04:00
Brandon Thomas 2d0a3f8a47 Merge main into #780 
# Conflicts:
#	ROADMAP.md
#	crates/engine/src/cmd/insert.rs
#	crates/engine/src/tests.rs
 2026-10-13 01:02:28 -04:00
Brandon Thomas 20d6923cb6 Merge main into #766 
# Conflicts:
#	ROADMAP.md
#	crates/engine/src/cmd/sheet.rs
 2026-10-13 01:00:59 -04:00
Brandon Thomas c6ab899259 Merge #824 fix-up 2026-10-13 00:57:02 -04:00
Brandon ThomasandClaude Opus 5.5 20309f6e99 Fix-up: close the Save As link test the merge left open 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-13 00:57:02 -04:00
Brandon Thomas 9c773166f9 Merge #594 fix-up 2026-10-13 00:55:57 -04:00
Brandon ThomasandClaude Opus 5.5 623997a19e Fix-up: close the CSV history-name test the merge left open 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-13 00:55:57 -04:00
Brandon Thomas 9972a75f10 Merge main into #824 
# Conflicts:
#	crates/engine/src/cmd/file.rs
#	crates/engine/src/tests.rs
#	crates/xlsx/src/tests/passthrough_tests.rs
 2026-10-13 00:53:41 -04:00
Brandon Thomas 0068c8f517 Merge main into #649 
# Conflicts:
#	crates/ui-egui/src/grid.rs
 2026-10-13 00:48:39 -04:00
Brandon Thomas b464a7f242 Merge main into #594 
# Conflicts:
#	crates/engine/src/io.rs
 2026-10-13 00:48:36 -04:00
Brandon Thomas 2f33d43546 Merge main into #591 
# Conflicts:
#	crates/engine/src/cmd/data.rs
 2026-10-13 00:41:59 -04:00
Brandon ThomasandClaude Opus 5.5 6405b00cf7 Fix-up: repair test files after merging the conflicting PRs 
- restore closing braces the line-level merges of side-by-side tests dropped
- new ChartData literals carry the palette field
- the filter-menu shortcut passes the row with the column
- #688's tab tests account for #851's All Sheets button
- Serbian margins for the ruler-margin labels

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-13 00:34:01 -04:00
Marco Arnulfo c7cb91ea53 Merge remote-tracking branch 'origin/main' into fix/xlsx-xml-maps 2026-10-13 06:33:03 +02:00
Brandon Thomas 94ee7efdf9 Merge main into #853 
# Conflicts:
#	ROADMAP.md
#	docs/file-format-parity.md
 2026-10-13 00:08:58 -04:00
Brandon Thomas 6dd8f7abe8 Merge main into #796 
# Conflicts:
#	ROADMAP.md
#	crates/engine/src/tests.rs
 2026-10-13 00:08:27 -04:00
Brandon Thomas e5f31a02f3 Merge main into #786 
# Conflicts:
#	ROADMAP.md
#	docs/gaps.md
 2026-10-13 00:08:15 -04:00
Brandon Thomas d2bd177b98 Merge main into #753 
# Conflicts:
#	crates/calc/src/tests.rs
 2026-10-13 00:08:09 -04:00
Brandon Thomas 04428cdfed Merge main into #749 
# Conflicts:
#	crates/engine/src/tests.rs
 2026-10-13 00:08:01 -04:00
Brandon Thomas 29775397ef Merge main into #712 
# Conflicts:
#	ROADMAP.md
#	crates/xlsx/src/tests/mod.rs
#	docs/file-format-parity.md
#	docs/gaps.md
 2026-10-13 00:07:50 -04:00
Brandon ThomasandClaude Opus 5.5 45221f5243 Fix-up: rustfmt extra.rs after merging 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-12 23:51:11 -04:00
Brandon Thomas 147db777b1 Merge pull request #879 from marcoarnulfo:fix/unknown-save-extension 2026-10-12 23:50:12 -04:00
Brandon Thomas efed7caa01 Merge pull request #826 from marcoarnulfo:fix/xlsx-external-file-hyperlinks 2026-10-12 23:49:53 -04:00
Brandon Thomas d6bb4bdf7a Merge pull request #763 from msaulc:fix/ctrl-shift-arrow-scroll 2026-10-12 23:49:25 -04:00
Brandon Thomas a435ef6ada Merge pull request #720 from dantebertuzzi:fix/cell-set-numeric-input 2026-10-12 23:49:02 -04:00
Brandon Thomas 98c85c6de4 Merge pull request #718 from neilcawse:fix/pivot-values-on-rows 2026-10-12 23:49:00 -04:00
Brandon Thomas 2f38d0162f Merge pull request #704 from isaac-levine:file-export-pdf-menu 2026-10-12 23:48:55 -04:00
Brandon Thomas 89f9e24aad Merge pull request #664 from richard1912:fix/top10-filter-threshold 2026-10-12 23:48:43 -04:00
Brandon Thomas 50853e3def Merge pull request #647 from MarekSpodBiedry:issue-508 2026-10-12 23:48:36 -04:00
Brandon Thomas f378bb9cc7 Merge pull request #641 from MarekSpodBiedry:issue-514 2026-10-12 23:48:27 -04:00
Brandon Thomas 02c973536b Merge pull request #640 from MarekSpodBiedry:issue-515 2026-10-12 23:48:26 -04:00
Brandon Thomas 8b845ebb6e Merge pull request #639 from MarekSpodBiedry:issue-516 2026-10-12 23:48:24 -04:00
Brandon Thomas 62100c2542 Merge pull request #638 from MarekSpodBiedry:issue-517 2026-10-12 23:48:23 -04:00
Brandon Thomas 6cddd36f48 Merge pull request #588 from MarekSpodBiedry:issue-576 2026-10-12 23:43:13 -04:00
Brandon ThomasandClaude Opus 5.5 9f9c0ac4a1 Test: open a workbook before setting values in the hyphenated table-name test 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-12 23:43:11 -04:00
Brandon Thomas e154960ce3 Merge pull request #602 from MarekSpodBiedry:issue-562 2026-10-12 23:35:51 -04:00
Brandon Thomas 24b1b60dbc Merge pull request #595 from MarekSpodBiedry:issue-569 2026-10-12 23:35:44 -04:00
Brandon Thomas 944e3818f6 Merge pull request #590 from MarekSpodBiedry:issue-574 2026-10-12 23:35:38 -04:00
Brandon Thomas 2d7988d057 Merge pull request #589 from MarekSpodBiedry:issue-575 2026-10-12 23:35:37 -04:00
Brandon Thomas a668b22833 Merge pull request #588 from MarekSpodBiedry:issue-576 2026-10-12 23:35:35 -04:00
Brandon Thomas 35668da062 Merge pull request #587 from MarekSpodBiedry:issue-577 2026-10-12 23:35:34 -04:00
Brandon Thomas ca9b3fbbe8 Merge pull request #586 from MarekSpodBiedry:issue-578 2026-10-12 23:35:32 -04:00
Brandon Thomas 92b1072ab8 Merge pull request #487 from nihilist-narwhal:fix-merge-across-values 2026-10-12 23:35:29 -04:00
Brandon Thomas 1868a58a6b Merge pull request #485 from nihilist-narwhal:fix-manage-rules-panic 2026-10-12 23:35:27 -04:00
Brandon Thomas 79fed48419 Merge pull request #483 from nihilist-narwhal:fix-autofill-series 2026-10-12 23:35:25 -04:00
Brandon Thomas 591040ce09 Merge pull request #475 from prxnvt:pr/solver-extras 2026-10-12 23:35:22 -04:00
Brandon Thomas 581a234456 Merge pull request #466 from webdevtodayjason:fix/offset-fn-overflow 2026-10-12 23:35:21 -04:00
Brandon Thomas f4acdcebe5 Merge pull request #450 from SteamSmith:fix/write-file-temp-cleanup 2026-10-12 23:35:12 -04:00