From 0019c2c5523bde83615f07451988065593cca48d Mon Sep 17 00:00:00 2001
From: MarekSpodBiedry <73122968+MarekSpodBiedry@users.noreply.github.com>
Date: Mon, 12 Oct 2026 08:31:39 +0200
Subject: [PATCH] Make check --json list warning messages instead of a count
 (#526)

---
 apps/gridcraft-cli/src/check.rs | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/apps/gridcraft-cli/src/check.rs b/apps/gridcraft-cli/src/check.rs
index 9fc81e30a..4b1c65991 100644
--- a/apps/gridcraft-cli/src/check.rs
+++ b/apps/gridcraft-cli/src/check.rs
@@ -134,7 +134,8 @@ pub struct FileReport {
     pub path: String,
     /// GridCraft couldn't open the file: its message.
     pub error: Option<String>,
-    pub warnings: usize,
+    /// Import warnings, in the order the importer produced them.
+    pub warnings: Vec<String>,
     pub calc: CalcReport,
     pub round_trip: RoundTrip,
 }
@@ -280,7 +281,7 @@ fn check_inner(path: &str, bytes: &[u8], opts: &Options) -> FileReport {
             return report;
         }
     };
-    report.warnings = warnings.len();
+    report.warnings = warnings;
     let mut fresh = cached.clone();
     let mut calc = Calc::new();
     calc.recalc_all(&mut fresh);
@@ -1342,6 +1343,15 @@ mod tests {
         assert_eq!(validate_package(&own).unwrap(), Vec::<String>::new());
     }
 
+    #[test]
+    fn json_lists_warning_messages() {
+        let with = FileReport { path: "a.ods".into(), warnings: vec!["ODS data-only import".into()], ..Default::default() };
+        let without = FileReport { path: "b.xlsx".into(), ..Default::default() };
+        let v = report_json(&[with, without], &Options::default());
+        assert_eq!(v["files"][0]["warnings"], json!(["ODS data-only import"]));
+        assert_eq!(v["files"][1]["warnings"], json!([]));
+    }
+
     #[test]
     fn unopenable_files_are_reported() {
         let r = check_bytes("broken.xlsx", b"PK\x03\x04 not really", &Options::default());