From ea5eb2ae3c7a163d77174efc29277c1e92cce6e4 Mon Sep 17 00:00:00 2001 From: prxnvt <53838599+prxnvt@users.noreply.github.com> Date: Sun, 25 Oct 2026 03:27:00 -0400 Subject: [PATCH] UI: Macro Options saves over the macro it changes Saving a macro over one with the same name now needs `replace: true`, so Macro Options, which changes the shortcut and description of a macro that exists, failed to save. It passes `replace: true`; `options_set_a_shortcut_that_runs_the_macro` covers it. --- crates/ui-egui/src/macro_ui.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/ui-egui/src/macro_ui.rs b/crates/ui-egui/src/macro_ui.rs index d80e4c800..ff303f586 100644 --- a/crates/ui-egui/src/macro_ui.rs +++ b/crates/ui-egui/src/macro_ui.rs @@ -574,7 +574,8 @@ pub fn save_options(app: &mut SheetApp, name: &str, letter: Option, descri }; o.insert("description".into(), json!(description)); } - match app.run("macro.save", json!({"macro": m})) { + // Macro Options changes a macro that exists, so the save replaces it. + match app.run("macro.save", json!({"macro": m, "replace": true})) { Ok(_) => true, Err(e) => { app.message = Some(("Macro Options".into(), crate::clean_error(&e)));