From 7e967f64897bca519a7e3456ee5bf9e44dd47ab6 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Wed, 4 Nov 2026 01:20:55 +0000 Subject: [PATCH] address review: check the web page size after each chart and before returning it --- crates/engine/src/io.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/engine/src/io.rs b/crates/engine/src/io.rs index 5c62c7de3..0f667f0c3 100644 --- a/crates/engine/src/io.rs +++ b/crates/engine/src/io.rs @@ -790,11 +790,17 @@ pub fn to_html(wb: &Workbook, sheet: usize) -> Result { for ch in &sh.charts { if let Some(svg) = crate::chart_svg::chart_svg(wb, sheet, ch, &place(&ch.anchor)) { out.push_str(&svg); + if out.len() > HTML_EXPORT_MAX_BYTES { + return Err(html_too_big()); + } } } out.push_str(""); } out.push_str(""); + if out.len() > HTML_EXPORT_MAX_BYTES { + return Err(html_too_big()); + } Ok(out) }