From 7c1ec1df7dbd27cacccc9b8333cb361a939f3d42 Mon Sep 17 00:00:00 2001
From: xc4pr <88853037+xc4pr@users.noreply.github.com>
Date: Fri, 23 Oct 2026 02:37:49 +0200
Subject: [PATCH] Fill handle: test the Auto Fill Options button on a
 right-to-left sheet, merge the duplicate fill handle row (#1403)

---
 crates/ui-egui/tests/fill_options_button.rs | 21 +++++++++++++++++++--
 docs/ui-parity.md                           |  3 +--
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/crates/ui-egui/tests/fill_options_button.rs b/crates/ui-egui/tests/fill_options_button.rs
index 8d5a21a18..2cb209fa9 100644
--- a/crates/ui-egui/tests/fill_options_button.rs
+++ b/crates/ui-egui/tests/fill_options_button.rs
@@ -35,14 +35,14 @@ fn corner(h: &Harness, cell: &str) -> Pos2 {
     let app = h.state();
     let sheet = app.session.active().unwrap().wb.active().unwrap();
     let geo = Geo::new(sheet, app.grid.rect.unwrap(), app.view().scroll);
-    geo.cell_rect(sheet, CellRef::parse(cell).unwrap()).right_bottom() - vec2(1.0, 1.0)
+    geo.mirror_pos(geo.cell_rect(sheet, CellRef::parse(cell).unwrap()).right_bottom() - vec2(1.0, 1.0))
 }
 
 fn center(h: &Harness, cell: &str) -> Pos2 {
     let app = h.state();
     let sheet = app.session.active().unwrap().wb.active().unwrap();
     let geo = Geo::new(sheet, app.grid.rect.unwrap(), app.view().scroll);
-    geo.cell_rect(sheet, CellRef::parse(cell).unwrap()).center()
+    geo.screen_cell_rect(sheet, CellRef::parse(cell).unwrap()).center()
 }
 
 fn press(h: &mut Harness, pos: Pos2, button: PointerButton) {
@@ -192,3 +192,20 @@ fn the_button_goes_away_once_the_workbook_changes() {
     assert_eq!(selection(&h), "B1:B6", "the selection did not move");
     assert!(h.query_by_label("Auto Fill Options").is_none(), "its undo would take the unrelated edit with it");
 }
+
+#[test]
+fn the_button_stays_inside_the_grid_on_a_right_to_left_sheet() {
+    let mut h = harness(|s| {
+        one_two(s);
+        s.execute("view.rightToLeft", json!({"on": true})).unwrap();
+    });
+    drag_handle(&mut h, "B2", "B6", PointerButton::Primary);
+
+    let button = h.get_by_label("Auto Fill Options").rect();
+    let app = h.state();
+    let sheet = app.session.active().unwrap().wb.active().unwrap();
+    let geo = Geo::new(sheet, app.grid.rect.unwrap(), app.view().scroll);
+    assert!(geo.cells.contains_rect(button), "{button:?} outside {:?}", geo.cells);
+    let filled = geo.screen_cell_rect(sheet, CellRef::parse("B6").unwrap());
+    assert!(button.center().x < filled.left() && button.top() >= filled.bottom() - 1.0, "below-left of the mirrored range's corner");
+}
diff --git a/docs/ui-parity.md b/docs/ui-parity.md
index f1c7d4d37..cf0ab377d 100644
--- a/docs/ui-parity.md
+++ b/docs/ui-parity.md
@@ -50,8 +50,7 @@ this logic, with one undo step.
 | Click/drag/Shift/Ctrl selection, multi-area selection | rectangular drag works in one direction only in some cases (#28) |
 | Cursor while dragging cells, headers, freeze handles and objects | stable for the active drag (#936); Draw tools keep their crosshair; header arrows and a custom cell cursor remain unimplemented |
 | Selection outline glides to a new selection (Excel: "Provide feedback with animation") | done (10-11): 0.12 s, decelerating, with the fill and fill handle; View ▸ Animations (`view.animations`) turns it off. The timing is an estimate, not yet measured against Excel; the system's reduced-motion setting isn't followed yet |
-| Fill handle: drag to fill series, double-click to fill down, right-drag menu | fill done (Ctrl+drag swaps copy and series); right-drag menu partial: Copy Cells, Fill Series, Fill Formatting Only, Fill Without Formatting, Series…; a left-drag leaves an Auto Fill Options button with the first four (gone once the workbook changes or the selection moves); Fill Days/Weekdays/Months/Years, Linear/Growth Trend and Flash Fill missing |
-| Fill handle: drag to fill series, double-click to fill down, right-drag menu | fill done (Ctrl+drag swaps copy and series); month patterns use the workbook's 1900 or 1904 date system; right-drag menu missing |
+| Fill handle: drag to fill series, double-click to fill down, right-drag menu | fill done (Ctrl+drag swaps copy and series; month patterns use the workbook's 1900 or 1904 date system); right-drag menu partial: Copy Cells, Fill Series, Fill Formatting Only, Fill Without Formatting, Series…; a left-drag leaves an Auto Fill Options button with the first four (gone once the workbook changes or the selection moves); Fill Days/Weekdays/Months/Years, Linear/Growth Trend and Flash Fill missing |
 | Drag-move and drag-copy cells (border drag, Ctrl/Option, Shift to insert) | done (M3) |
 | In-cell editing, Enter/Tab movement, Alt/Option+Enter line breaks | done |
 | Point mode (click/drag/arrow references), reference colouring, F4 | done; Command/Ctrl-click adds separate arguments with the edit's locale separator, and Shift-click extends the current reference from a fixed anchor on the same sheet. Pointer-event regressions cover repeated/reversed selections, manual separators, sheet switches and keyboard continuation. |