diff --git a/crates/engine/tests/line_count_overflow.rs b/crates/engine/tests/line_count_overflow.rs index 9ae58d1a9..99fcfeaf1 100644 --- a/crates/engine/tests/line_count_overflow.rs +++ b/crates/engine/tests/line_count_overflow.rs @@ -1,7 +1,7 @@ use gridcraft_engine::{EngineError, Session}; use serde_json::json; -fn session() -> Session { +fn new_session() -> Session { let mut session = Session::new(); session.new_workbook(); session @@ -10,7 +10,7 @@ fn session() -> Session { #[test] fn insert_with_an_out_of_range_count_is_a_normal_error() { for (id, key, at) in [("home.insertRows", "rows", "3:3"), ("home.insertColumns", "cols", "C:C")] { - let mut session = session(); + let mut session = new_session(); let err = session.execute(id, json!({ key: at, "count": u32::MAX })).unwrap_err(); assert!(matches!(err, EngineError::BadParams { .. }), "{id}: {err:?}"); } @@ -19,12 +19,12 @@ fn insert_with_an_out_of_range_count_is_a_normal_error() { #[test] fn insert_after_a_formatted_line_with_an_out_of_range_count_is_a_normal_error() { // A custom size on the preceding line and no cells: the used-range guard has nothing to check. - let mut session = session(); + let mut session = new_session(); session.execute("home.rowHeight", json!({"rows": "2:2", "height": 30})).unwrap(); let err = session.execute("home.insertRows", json!({"rows": "3:3", "count": u32::MAX})).unwrap_err(); assert!(matches!(err, EngineError::BadParams { .. }), "{err:?}"); - let mut session = session(); + let mut session = new_session(); session.execute("home.columnWidth", json!({"cols": "B:B", "width": 100})).unwrap(); let err = session.execute("home.insertColumns", json!({"cols": "C:C", "count": u32::MAX})).unwrap_err(); assert!(matches!(err, EngineError::BadParams { .. }), "{err:?}"); @@ -33,7 +33,7 @@ fn insert_after_a_formatted_line_with_an_out_of_range_count_is_a_normal_error() #[test] fn delete_with_an_out_of_range_count_does_not_panic() { for (id, key, at) in [("home.deleteRows", "rows", "3:3"), ("home.deleteColumns", "cols", "C:C")] { - let mut session = session(); + let mut session = new_session(); let res = session.execute(id, json!({ key: at, "count": u32::MAX })); assert!(!matches!(res, Err(EngineError::Internal(..))), "{id}: {res:?}"); } @@ -41,7 +41,7 @@ fn delete_with_an_out_of_range_count_does_not_panic() { #[test] fn insert_and_delete_with_a_small_count_still_work() { - let mut session = session(); + let mut session = new_session(); session.execute("home.insertRows", json!({"rows": "1:1", "count": 3})).unwrap(); session.execute("home.deleteRows", json!({"rows": "1:1", "count": 3})).unwrap(); }