mirror of
https://github.com/storytold/filmcraft.git
synced 2026-10-24 10:10:05 -06:00
aiongg
0a881266c8
* Tests: one integration-test binary per crate Each crate with several tests/*.rs files keeps them as modules of tests/it/, so cargo links one test executable per crate instead of one per file. Files that change process-wide state or time a workload stay binaries of their own. * Profiles: line tables for workspace crates, no debug info for dependencies * Windows ARM64: nightly and on release pushes instead of every push to main * xtask ci: clippy and tests in the dev profile The release profile's thin LTO and single codegen unit made linking the test binaries take most of the gate. The codec and audio crates stay at opt-level 3 in the dev profile, so their tests run at release speed. * xtask ci: nextest, doctests, no examples, one wasm check Tests run with cargo nextest when it is installed (cargo test otherwise) and build with --lib --bins --tests, so examples aren't linked; doctests run separately. The wasm check keeps going past the first failing crate. VP8 fixture generation locks across processes, since nextest runs each test in its own. * VP9 synthetic fixtures: write aside and rename A test in another process could read a fixture ffmpeg was still writing. * Fuzz tests: a third of each sweep by default, all of it with FILMCRAFT_FUZZ_ITERS Every seed, mutation kind and thread count still runs. Header bytes each get one overwrite value and two bit flips in rotation, so every value and bit index still occurs across the region. FILMCRAFT_FUZZ_ITERS=N runs the whole sweep plus N random rounds per seed, as before. * Platform fallback tests: one failure point per hybrid path The failure-anywhere test injected a failure at four points around every restart point; the hybrid's paths differ only in the first GOP, around the second and last restart points, at the end and never. The replay test needs the first two GOPs. * Export tests: shorter ranges with the same checks The bitrate test measures 0.5–1.5 s, where each preset reaches its own target (on 0–3 s the simple demo left two presets at the same rate). The every-preset test exports three frames per preset. * Audio tests: effects in parallel, a table-driven FFT for the Opus quality metric The extreme-settings test keeps both settings and the 40 s tail for every effect, one thread each. The Opus quality metric's FFT builds its twiddles once and allocates nothing per transform (same algorithm and summation order). * CI: dev-profile gate with nextest xtask ci no longer builds with --release, so the release-profile overrides go; nextest is installed for the test step. * CI: apt packages through the cached install-apt-packages action * Review fixes: fuzz tests with a panic hook in their own binaries, loud fixture lock The fuzz tests of av1, h264, hevc, mpeg2v, vp8 and vp9 count panics through a process-wide hook, so a panic in another test of the same process would fail them; they are binaries of their own again. The VP8 fixture lock fails the test instead of skipping it silently, and the full-sweep doc comments say how many truncation points the full run samples. * Fuzz tests: rotate the default subset per run (FILMCRAFT_FUZZ_SEED replays one) * platform tests: decode-switch tests in their own binaries, one NVENC lock
65 lines
2.4 KiB
Rust
65 lines
2.4 KiB
Rust
//! Decoded pictures are written into recycled plane buffers (`filmcraft_frame::pool`). A recycled
|
||
//! buffer still holds an old picture, so the decoder must overwrite every byte: here the pool is
|
||
//! primed with buffers full of 0xAA before decoding, and every frame must still match ffmpeg bit
|
||
//! for bit. (Its own process: the pool is global.)
|
||
|
||
#[path = "it/common/mod.rs"]
|
||
mod common;
|
||
|
||
use std::sync::Arc;
|
||
|
||
use common::*;
|
||
use filmcraft_frame::{Chroma, PixelData, VideoFrame};
|
||
use filmcraft_media::FrameRequest;
|
||
|
||
#[test]
|
||
fn dirty_recycled_planes_decode_bit_exact() {
|
||
let ff = filmcraft_testkit::require_ffmpeg!();
|
||
// 640×480: luma and chroma planes are both large enough to be pooled
|
||
let Some(file) = fixture(
|
||
&ff,
|
||
"pool_h264.mp4",
|
||
&[
|
||
"-f",
|
||
"lavfi",
|
||
"-i",
|
||
"testsrc2=s=640x480:r=24:d=1,noise=alls=10:allf=t",
|
||
"-c:v",
|
||
"libx264",
|
||
"-preset",
|
||
"fast",
|
||
"-x264-params",
|
||
"bframes=2:keyint=12",
|
||
"-pix_fmt",
|
||
"yuv420p",
|
||
],
|
||
) else {
|
||
return;
|
||
};
|
||
let (w, h) = (640usize, 480usize);
|
||
let raw = ffmpeg_frames(&ff, &file, "yuv420p");
|
||
let fsize = w * h * 3 / 2;
|
||
let n = raw.len() / fsize;
|
||
assert!(n >= 20, "{n} frames");
|
||
let reference = |i: usize| raw_planes(&raw[i * fsize..(i + 1) * fsize], w, h, w / 2, h / 2, 1);
|
||
|
||
// prime the pool with dirty buffers of exactly the plane sizes the decoder asks for
|
||
for _ in 0..8 {
|
||
let dirty = |len: usize| Arc::new(vec![0xAAu8; len]);
|
||
let f = VideoFrame {
|
||
data: PixelData::Yuv8 { planes: [dirty(w * h), dirty(w * h / 4), dirty(w * h / 4)], chroma: Chroma::C420, alpha: None },
|
||
..VideoFrame::rgba8(w as u32, h as u32, vec![0; w * h * 4])
|
||
};
|
||
filmcraft_frame::pool::recycle(Arc::new(f));
|
||
}
|
||
let reused_before = filmcraft_frame::pool::stats().reused;
|
||
|
||
let src = filmcraft_codecs::open_bytes("pool_h264.mp4", bytes(&file)).expect("open");
|
||
let rate = src.info().frame_rate();
|
||
for i in 0..n {
|
||
let f = src.video_frame(FrameRequest::full(rate.tick_of(i as i64))).expect("frame");
|
||
assert_eq!(max_diff(&planes(&f), &reference(i)), 0, "frame {i} decoded into a recycled buffer");
|
||
}
|
||
assert!(filmcraft_frame::pool::stats().reused > reused_before, "the decoder took the dirty pooled buffers");
|
||
}
|