mirror of
https://github.com/storytold/figcraft.git
synced 2026-10-29 12:56:47 -06:00
ahmed-226
dde193cbf4
A slice paints nothing itself, so thumbnail() rendered an empty pixmap of the slice's own box: expanding Preview for a slice showed only the transparency checkerboard while exporting the same slice wrote the artwork correctly. Give the preview the export's slice rule (drawn_layers + export_area in cmd/file.rs): draw every top-level layer of the slice's page over its world bounds. Regression tests cover a slice over artwork, a slice with nothing under it, and a plain layer. Signed-off-by: Ahmed Mahmoud <ahmedmhmouad41@gmail.com>
53 lines
2.3 KiB
Rust
53 lines
2.3 KiB
Rust
//! The Export section's Preview row: a slice paints nothing itself, so its preview must show the
|
|
//! page content under it — the same thing exporting the slice writes — and not a blank
|
|
//! transparency checkerboard next to a correct export.
|
|
|
|
use figcraft_doc::{Document, NodeId};
|
|
use figcraft_engine::Session;
|
|
use serde_json::{Value, json};
|
|
|
|
use crate::assets_panel::thumbnail_pixmap;
|
|
|
|
/// Run `commands`, returning the document and the id each one made.
|
|
fn doc_after(commands: &[(&str, Value)]) -> (Document, Vec<NodeId>) {
|
|
let mut s = Session::new();
|
|
let ids = commands.iter().map(|(cmd, params)| NodeId(s.execute(cmd, params).unwrap()["id"].as_u64().unwrap())).collect();
|
|
(s.doc().unwrap().clone(), ids)
|
|
}
|
|
|
|
/// Whether the pixmap paints anything (any pixel not fully transparent).
|
|
fn paints(pix: &figcraft_render::Pixmap) -> bool {
|
|
figcraft_render::to_rgba8(pix).as_chunks::<4>().0.iter().any(|p| p.get(3).copied().unwrap_or(0) > 0)
|
|
}
|
|
|
|
#[test]
|
|
fn a_slice_previews_the_content_under_it() {
|
|
let (doc, ids) = doc_after(&[
|
|
("shape.rectangle", json!({"x": 0, "y": 0, "width": 200, "height": 100})),
|
|
("node.create", json!({"type": "slice", "x": 0, "y": 0, "width": 200, "height": 100})),
|
|
]);
|
|
let slice = ids[1];
|
|
let pix = thumbnail_pixmap(&doc, slice, 200.0).expect("the slice previews");
|
|
assert_eq!([pix.width(), pix.height()], [200, 100], "the slice's area, not an empty node");
|
|
assert!(paints(&pix), "the rectangle under the slice shows");
|
|
}
|
|
|
|
#[test]
|
|
fn a_slice_with_nothing_under_it_is_blank() {
|
|
let (doc, ids) = doc_after(&[("node.create", json!({"type": "slice", "x": 0, "y": 0, "width": 200, "height": 100}))]);
|
|
let pix = thumbnail_pixmap(&doc, ids[0], 200.0).expect("the preview still has the slice's area");
|
|
assert_eq!([pix.width(), pix.height()], [200, 100]);
|
|
assert!(!paints(&pix), "nothing under it stays transparent");
|
|
}
|
|
|
|
#[test]
|
|
fn other_layers_preview_themselves() {
|
|
let (doc, ids) = doc_after(&[
|
|
("shape.rectangle", json!({"x": 0, "y": 0, "width": 200, "height": 100})),
|
|
("node.create", json!({"type": "slice", "x": 0, "y": 0, "width": 200, "height": 100})),
|
|
]);
|
|
let pix = thumbnail_pixmap(&doc, ids[0], 200.0).expect("the rectangle previews");
|
|
assert_eq!([pix.width(), pix.height()], [200, 100], "the layer's own area");
|
|
assert!(paints(&pix));
|
|
}
|