Files
effectcraft/packaging/windows
tylerjenningsw a26867fe4b Packaging: upgrading a custom-folder install from an earlier release keeps its folder (#466)
Cause: the folder search read only the App Paths "Path" value, which this
branch introduced. Releases before this installer change could already be
installed elsewhere with INSTALLFOLDER=..., but have no Path value, so an upgrade went to
Program Files while the wizard said it would stay in the same folder.

Fix: when there is no Path value, a second search reads the App Paths
default value (the full path of effectcraft.exe, written by every
release). A "file" registry search with no FileSearch inside yields the
folder of that file.

Tests: test-msi.ps1 installs a legacy package (the same .wxs without the
Path value) into a custom folder, then upgrades it without naming a
folder; it fails on the previous .wxs (the upgrade lands in Program
Files) and passes now. A further upgrade checks the Path value route.
2026-10-10 10:52:04 -04:00
..