mirror of
https://github.com/storytold/effectcraft.git
synced 2026-10-31 05:27:08 -06:00
FeiLiuEM
5344f304c3
Two things are one level deeper than the first pass at this review: - Nine of the call sites that pass the resolved language are inside test functions, where `app` is owned, so `crate::i18n::language(app)` needs `&app`. `cargo check --all-targets` (which compiles the test modules as well) is what reported them; a check without it does not, which is how they survived the first round. - `clippy -D warnings` rejects the explicit `'static` on `const KANA` / `const HAN`: a const already has one. On this branch `cargo fmt --all --check`, `cargo check -p effectcraft-ui-egui --all-targets`, `cargo clippy -p effectcraft-ui-egui --all-targets -- -D warnings` and `cargo test -p effectcraft-ui-egui` (40 targets, 113 lib tests) are clean.