Kaedo17 ada2357a94 review: the ALSA probe matches the pkg-config dependency's lookup ...

CodeRabbit and FredApps both flagged that the preflight probed only the plain
PKG_CONFIG variable, while the pkg-config crate alsa-sys pins resolves the
target-scoped variants first and falls back pkg-config -> pkgconf; on a host
with only pkgconf the ci stage failed a build that would succeed. The probe
now goes through the same crate (0.3.34, already pinned via alsa-sys), so the
semantics match by construction, and a probe that ran but said no stays
distinct from one that could not run.

Also from review: audio_backend_hint is gated to Linux (bflatastic: dead code
on Windows/macOS under -D warnings), the fake-tool regression runs the real
xtask audio-backend task in a child process with a controlled environment
(pkgconf-only host, a probe that says no, one that cannot run, a HOST_PKG_CONFIG
override), the rerun-if-env lines stay out of the ci log, and CONTRIBUTING.md
asks for a usable alsa.pc and runtime library rather than development headers.

2026-10-30 01:30:50 +08:00

..

it

review: the ALSA probe matches the pkg-config dependency's lookup

2026-10-30 01:30:50 +08:00

bench.rs

M0.37: resolve relocated test binaries and expose GPU failures

2026-10-26 16:22:51 +01:00