mirror of
https://github.com/storytold/effectcraft.git
synced 2026-10-27 03:28:22 -06:00
bflatasticandClaude Opus 5.5
8a415e03ca
Choosing Draft Settings (or any entry) in a Render Queue item's Render Settings menu did nothing when the menu had been moved up to fit the window. egui hit-tests a fixed-position Area where it was asked to go, not where it was moved, so the popup's "pressed outside" check was true over its own entries and the menu closed on the press, before the click. widgets::pressed_outside tests the press against the rect the popup was drawn at. Every popup with the same check uses it: popup_menu (Render Queue, Effect Controls, dropdowns), the colour popup, the Preview and viewer popups, the panel menu, the Flowchart, OpenType and font menus. Regression test: ui_render_queue.rs picks Draft Settings from a menu moved up to fit a 1000 px window; it failed before the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
47 lines
2.5 KiB
Rust
47 lines
2.5 KiB
Rust
//! Render Queue panel input: choosing a Render Settings template from an item's menu (#117).
|
|
|
|
use effectcraft_engine::Session;
|
|
use effectcraft_engine::project::render_queue::RenderQuality;
|
|
use effectcraft_ui_egui::EffectcraftApp;
|
|
use effectcraft_ui_egui::dock::PanelKind;
|
|
use egui::{Event, Modifiers, Pos2, pos2};
|
|
use egui_kittest::Harness;
|
|
use egui_kittest::kittest::Queryable;
|
|
use serde_json::json;
|
|
|
|
fn click_at(h: &mut Harness<'_, EffectcraftApp>, p: Pos2) {
|
|
h.input_mut().events.push(Event::PointerMoved(p));
|
|
h.input_mut().events.push(Event::PointerButton { pos: p, button: egui::PointerButton::Primary, pressed: true, modifiers: Modifiers::NONE });
|
|
h.step();
|
|
h.input_mut().events.push(Event::PointerButton { pos: p, button: egui::PointerButton::Primary, pressed: false, modifiers: Modifiers::NONE });
|
|
h.run_steps(2);
|
|
}
|
|
|
|
/// The Render Settings menu is taller than the room below the item, so it is moved up to fit
|
|
/// the window; its entries must still take the click instead of the menu closing on the press.
|
|
#[test]
|
|
fn render_settings_template_applies_from_a_menu_moved_to_fit_the_window() {
|
|
let mut s = Session::default();
|
|
s.execute("file.openDemoProject", json!({})).unwrap();
|
|
s.execute("renderQueue.add", json!({})).unwrap();
|
|
let id = s.project.render_queue[0].id;
|
|
assert_eq!(s.project.render_queue[0].settings.name, "Best Settings");
|
|
let mut app = Some(EffectcraftApp::new(s));
|
|
let mut h = Harness::builder().with_size(egui::vec2(1600.0, 1000.0)).build_eframe(|_| app.take().expect("app"));
|
|
// Twirl the item open, as clicking its twirl does.
|
|
h.ctx.data_mut(|d| d.insert_temp(egui::Id::new("rq-ui"), (vec![id], None::<u64>)));
|
|
h.state_mut().show_panel(PanelKind::RenderQueue);
|
|
h.run_steps(4);
|
|
let dd = h.state().auto.find(&format!("renderQueue.item.{id}.renderSettings")).expect("Render Settings menu").clone();
|
|
let dd_center = pos2(dd.rect[0] + dd.rect[2] / 2.0, dd.rect[1] + dd.rect[3] / 2.0);
|
|
click_at(&mut h, dd_center);
|
|
let entry = h.query_by_label_contains("Draft Settings").expect("the Draft Settings entry").rect();
|
|
assert!(entry.max.y < dd_center.y, "the menu was moved up to fit the window (entry {entry:?}, menu button at {dd_center:?})");
|
|
click_at(&mut h, entry.center());
|
|
let it = &h.state().session.project.render_queue[0];
|
|
assert_eq!(it.settings.name, "Draft Settings");
|
|
assert_eq!(it.settings.quality, RenderQuality::Draft);
|
|
assert_eq!(it.settings.resolution, 0.5);
|
|
assert!(h.query_by_label_contains("Quality: Draft").is_none(), "the menu closed after the choice");
|
|
}
|