Dylan M. Taylor
23f11ab7cf
expr: bound rewrite expansion and preserve assignment targets ( #2195 )
...
* expr: bound rewrite expansion and preserve assignment targets
* expr: bound rewritten output size and rewrite computed assignment targets
2026-10-23 09:14:49 -04:00
Dylan M. Taylor
09b9ebca34
roto: bound frozen matte decoding and serialization ( #2194 )
...
* roto: bound frozen matte decoding and serialization
* roto: address review (fallible RLE growth, pre-check plane bytes, saturate 32-bit limits)
2026-10-23 08:59:06 -04:00
Dylan M. Taylor
8a4ed77c4a
pdf: bound image sample and mask allocations ( #2191 )
...
* pdf: bound image sample and mask allocations
* pdf: fallible mask allocations and JPEG header pixel cap
2026-10-23 08:56:15 -04:00
Dylan M. Taylor
ca8043cbba
text: bound layout and variable font metadata ( #2193 )
...
* text: bound layout and variable font metadata
* text: address review (intern once, f64 prefix sums, bounded item search, name fallback, consistent variation fallback)
2026-10-23 08:55:07 -04:00
Dylan M. Taylor
4b48482e8f
ui: bound queued synthetic input gestures ( #2197 )
...
* ui: bound queued synthetic input gestures
* ui: reserve exact click event count
2026-10-23 08:45:10 -04:00
Dylan M. Taylor
2cf90507f3
svg: bound raster surfaces and handle duplicate gradient stops ( #2190 )
2026-10-23 08:38:10 -04:00
Dylan M. Taylor
0871135a6b
Merge pull request #2062 from storytold/sonar-fix/js-css-reliability
...
fix: JS reliability bugs (SonarCloud S1764/S9383/S4275)
2026-10-22 19:27:57 -04:00
skylar taylor-barrick
b55cb5bc15
Merge pull request #1363 from DWAA1660/fix/1237-comp-contains-cycles
...
Project: comp_contains walks precomps with a visited set, not recursion (#1237 )
2026-10-22 07:52:56 -06:00
skylar taylor-barrick
571aebd854
Merge pull request #1957 from Anubhav-Rai/script-value-dims
...
script: setValue rejects an array of the wrong dimension (#1936 )
2026-10-22 07:52:51 -06:00
skylar taylor-barrick
831e719fa2
Merge pull request #1855 from CharlesBaumer/fix/doc-path-stills-windows
...
Windows: two fixes so cargo xtask ci gets past clippy and the media tests
2026-10-22 07:52:46 -06:00
skylar taylor-barrick
70763d74c0
Merge pull request #1966 from Silvertree2010/fix/h930-deleting-the-first-vertex-of-a-c
...
Fix feather points when deleting first vertex of a closed mask path
2026-10-22 07:52:39 -06:00
skylar taylor-barrick
be4d2d7bb8
Merge pull request #1992 from Silvertree2010/fix/h1142-sampleimage-panics-with-integer
...
Fix integer overflow in sampleImage for huge sample points
2026-10-22 07:52:31 -06:00
skylar taylor-barrick
a9c2bfa6eb
Merge pull request #1902 from Silvertree2010/fix/h704-hsv-to-rgb-returns-magenta-for-a
...
Fix hsv_to_rgb returning magenta for tiny negative hues
2026-10-22 07:52:17 -06:00
Dylan M. Taylor
7983396692
fix: JS reliability bugs (SonarCloud S1764, S9383, S4275)
...
- scriptui.js: replace the self-comparison NaN check (o.max === o.max) with
the explicit Number.isNaN(o.max) (S1764).
- sw.js: mark the fire-and-forget cache.put() with void and a .catch() so the
promise rejection is handled (S9383).
- prelude.js: return __err(...) from the activeCamera getter so every path
yields a value (S4275); __err always throws, so behavior is unchanged.
2026-10-21 17:20:35 -04:00
NetterSilver and Claude Haiku 5.5
28f97be7ee
Fix integer overflow in sampleImage for huge sample points
...
Found while testing crates/expr/src/sample.rs:102
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com >
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com >
2026-10-21 02:39:20 +02:00
NetterSilver and Claude Haiku 5.5
798b8a98e6
Fix panic in path::rect when both size components are NaN
...
Found while testing crates/path/src/lib.rs:136
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com >
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com >
2026-10-20 23:31:13 +02:00
NetterSilver and Claude Haiku 5.5
b3ff5d4aa6
Fix feather points when deleting first vertex of a closed mask path
...
Found while testing crates/keyframe/src/value.rs:79-95 (ShapePath::feather_after_remove, called from crates/engine/src/commands/mask.rs:330)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com >
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com >
2026-10-20 18:51:57 +02:00
Anubhav-Rai and Claude Opus 5
a67ca11d1c
script: setValue rejects an array of the wrong dimension ( #1936 )
...
A 2-D point property took any array: `[1, 2, 3]` and `[1, 2, 3, 4]` were cut to `[1, 2]` and
`[1]` was broadcast to `[1, 1]`, each reported as success, so a script holding a wrong value
silently did something else instead of failing. After Effects raises "Array is not of the
correct dimension" and leaves the property unchanged.
The length must now match the property's dimension, with the one exception After Effects also
makes: two values for a 3-D property, where z stays 0, so `position.setValue([x, y])` keeps
working.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com >
2026-10-20 20:23:41 +05:30
NetterSilver and Claude Haiku 5.5
eca2c32793
Fix hsv_to_rgb returning magenta for tiny negative hues
...
Found while testing crates/color/src/lib.rs:143-158
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com >
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com >
2026-10-19 20:31:18 +02:00
Charles Baumer and Claude Opus 5.5
bd961131a4
Media tests: ffmpeg fixtures survive concurrent first runs on Windows
...
Tests that share a fixture each generate it on a first run and rename
their temp file into place. On Windows the losing rename fails with
PermissionDenied while the winner has the file open. Treat a failed
rename as "another test made it first" when the fixture exists, as
`png_sequence` already does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com >
2026-10-18 16:23:28 +00:00
Charles Baumer and Claude Opus 5.5
4fa31b5e5b
Engine tests: clippy passes on Windows (Stills is Unix-only)
...
`Stills` is only used by the `#[cfg(unix)]` part of
`footage_on_other_computers_is_never_looked_at`. On Windows it was dead
code, so `cargo xtask ci` stopped at clippy (`-D warnings`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com >
2026-10-18 16:12:55 +00:00
Brandon Thomas
22072d9f25
Merge pull request #1317
...
# Conflicts:
# crates/ui-egui/src/panels/effects_presets.rs
# crates/ui-egui/src/panels/timeline.rs
2026-10-18 11:12:44 -04:00
Brandon Thomas and Claude Opus 5.5
f3f24ef189
Land batch: fix clippy lints and the #1424 test after #1413 changed layer_menu
...
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com >
2026-10-18 09:42:33 -04:00
Brandon Thomas
7804cfd223
Format merged community PRs
2026-10-18 09:37:06 -04:00
Brandon Thomas
10cf6690c4
Merge pull request #1730
...
# Conflicts:
# crates/engine/src/commands/prop_groups.rs
2026-10-18 09:36:40 -04:00
Brandon Thomas
7c99ba6eeb
Merge pull request #1696
...
# Conflicts:
# contributors/people.toml
2026-10-18 09:36:05 -04:00
Brandon Thomas
a594abf4f7
Merge pull request #1652
...
# Conflicts:
# docs/gaps.md
2026-10-18 09:35:51 -04:00
Brandon Thomas
17c4b02149
Merge pull request #1790
2026-10-18 09:35:35 -04:00
Brandon Thomas
dfff3f9010
Merge pull request #1785
2026-10-18 09:35:35 -04:00
Brandon Thomas
1dac4c0e6b
Merge pull request #1759
2026-10-18 09:35:35 -04:00
Brandon Thomas
0867d837d4
Merge pull request #1753
2026-10-18 09:35:35 -04:00
Brandon Thomas
869ce1db39
Merge pull request #1752
2026-10-18 09:35:35 -04:00
Brandon Thomas
681d99c0e7
Merge pull request #1731
2026-10-18 09:35:35 -04:00
Brandon Thomas
d9e3c56404
Merge pull request #1721
2026-10-18 09:35:35 -04:00
Brandon Thomas
415e353dc0
Merge pull request #1711
2026-10-18 09:35:35 -04:00
Brandon Thomas
fcc9e853de
Merge pull request #1709
2026-10-18 09:35:35 -04:00
Brandon Thomas
a01f681551
Merge pull request #1704
2026-10-18 09:35:35 -04:00
Brandon Thomas
072a7f7af9
Merge pull request #1695
2026-10-18 09:35:34 -04:00
Brandon Thomas
30efc87a2a
Merge pull request #1694
2026-10-18 09:35:34 -04:00
Brandon Thomas
fc3d228616
Merge pull request #1688
2026-10-18 09:35:34 -04:00
Brandon Thomas
010065e290
Merge pull request #1679
2026-10-18 09:35:34 -04:00
Brandon Thomas
4d61409662
Merge pull request #1672
2026-10-18 09:35:34 -04:00
Brandon Thomas
b26b7ec968
Merge pull request #1664
2026-10-18 09:35:34 -04:00
Brandon Thomas
8c43fe7375
Merge pull request #1662
2026-10-18 09:35:34 -04:00
Brandon Thomas
972a2d21d2
Merge pull request #1659
2026-10-18 09:35:34 -04:00
Brandon Thomas
d4dd1491f0
Merge pull request #1649
2026-10-18 09:35:34 -04:00
Brandon Thomas
242e02d92d
Merge pull request #1627
2026-10-18 09:35:34 -04:00
Brandon Thomas
4c196ee8e5
Merge pull request #1620
2026-10-18 09:35:34 -04:00
Brandon Thomas
65d955c32a
Merge pull request #1572
2026-10-18 09:35:34 -04:00
Brandon Thomas
1ec5cca899
Merge pull request #1540
2026-10-18 09:35:34 -04:00