aleleba/effectcraft
1
0
Fork 0
mirror of https://github.com/storytold/effectcraft.git synced 2026-10-29 04:26:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #344 from MindlessRuff/fix/exr-over-range

Browse Source 
fix(export): keep values above 1.0 in EXR output (#339)
This commit is contained in:
Brandon Thomas
2026-10-09 09:31:40 -04:00
parent f87f3b3e1a 1b2c5d1944
commit d5beb4b3c4
4 changed files with 114 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/export/src/lib.rs
+3 -2
View File
@@ -297,6 +297,7 @@ fn write_still<W: std::io::Write + std::io::Seek>(
match fmt {
OutputFormat::ExrSequence => {
// Linear light, premultiplied (the EXR convention); RGB keeps alpha = 1 over the background.
// Colour is floored at 0 but not capped at 1: a 32 bpc frame's over-range values survive (#339).
let lin = |v: f32| if v <= 0.04045 { v / 12.92 } else { ((v + 0.055) / 1.055).powf(2.4) };
let mut data = Vec::with_capacity((w * h * 4) as usize);
for y in 0..h {
@@ -309,12 +310,12 @@ fn write_still<W: std::io::Write + std::io::Seek>(
}
Channels::Rgba => {
let a = p[3].clamp(0.0, 1.0);
let s = |c: f32| if a > 0.0 { lin((c / a).clamp(0.0, 1.0)) * a } else { 0.0 };
let s = |c: f32| if a > 0.0 { lin((c / a).max(0.0)) * a } else { 0.0 };
([s(p[0]), s(p[1]), s(p[2])], a)
}
Channels::Rgb => {
let k = 1.0 - p[3].clamp(0.0, 1.0);
let c = |i: usize| lin((p[i] + comp.background[i] * k).clamp(0.0, 1.0));
let c = |i: usize| lin((p[i] + comp.background[i] * k).max(0.0));
([c(0), c(1), c(2)], 1.0)
}
};