From 7c1183df56b83cc56a6ef60cf214b4a4232d8679 Mon Sep 17 00:00:00 2001 From: skylar taylor-barrick Date: Thu, 22 Oct 2026 18:55:49 -0600 Subject: [PATCH] #1497: test that double-clicking an effect property name reveals it in the timeline Double-clicking a property name in Effect Controls did nothing. The test double-clicks the name and checks the Timeline marks the property revealed and shows its row. Without the fix nothing is revealed. --- crates/ui-egui/tests/ui_effect_controls.rs | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/crates/ui-egui/tests/ui_effect_controls.rs b/crates/ui-egui/tests/ui_effect_controls.rs index cdf8c703..90f54931 100644 --- a/crates/ui-egui/tests/ui_effect_controls.rs +++ b/crates/ui-egui/tests/ui_effect_controls.rs @@ -778,6 +778,23 @@ fn effect_control_name_can_be_renamed_from_its_header() { assert_eq!(current_name(&h), "Point Control"); } +// Regression test for #1497: double-clicking an effect parameter's name in Effect Controls did +// nothing; it should reveal that property in the Timeline, as After Effects does. +#[test] +fn double_clicking_an_effect_property_name_reveals_it_in_the_timeline() { + let (app, x) = app(); + let mut h = Harness::builder().with_size(egui::vec2(1700.0, 1100.0)).with_step_dt(1.0 / 60.0).build_eframe(|_| app); + settle(&mut h); + let row = format!("timeline.prop.{}.name", x.point); + assert!(!ids(&h).contains(&row), "the effect's property is not in the Timeline before the double-click"); + assert!(!h.state().ui.timeline.reveal_props.contains(&x.point)); + let point = rect_of(&h, &format!("effectControls.prop.{}.name", x.point)).center(); + double_click(&mut h, point); + h.run_steps(4); + assert!(h.state().ui.timeline.reveal_props.contains(&x.point), "the property is marked revealed in the Timeline"); + assert!(ids(&h).contains(&row), "the Timeline shows the property's row"); +} + #[test] fn effect_rename_escape_keeps_the_name() { let (app, x) = app();