From 56ffc2e6423619c4808791c9f0f243fb07bff9ae Mon Sep 17 00:00:00 2001 From: ashokram-si <347905169+ashokram-si@users.noreply.github.com> Date: Wed, 28 Oct 2026 16:08:46 +0530 Subject: [PATCH] Test: the ellipse's Size chain keeps its ratio when linked Review follow-up: the shape Size test linked only the rectangle, so a change that handled rect and not ellipse would still pass. Link the ellipse too and check that its height follows its width. --- crates/ui-egui/tests/it/ui_timeline_shapes.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/ui-egui/tests/it/ui_timeline_shapes.rs b/crates/ui-egui/tests/it/ui_timeline_shapes.rs index 76830aa88..b57791997 100644 --- a/crates/ui-egui/tests/it/ui_timeline_shapes.rs +++ b/crates/ui-egui/tests/it/ui_timeline_shapes.rs @@ -211,6 +211,10 @@ fn shape_size_chain_starts_unlinked_and_keeps_the_ratio_when_linked() { click(&mut h, &format!("timeline.prop.{size}.link")); type_value(&mut h, size, 0, "40"); assert_eq!(value(&h, l, size), vec![40.0, 100.0], "unlinked again, H stays"); + // The ellipse's Size links the same way: 60x40 linked, W to 90 makes H 60. + click(&mut h, &format!("timeline.prop.{oval}.link")); + type_value(&mut h, oval, 0, "90"); + assert_eq!(value(&h, o, oval), vec![90.0, 60.0], "linked, the ellipse keeps its ratio too"); type_value(&mut h, scale, 0, "50"); assert_eq!(value(&h, l, scale)[..2], [50.0, 50.0], "Scale still starts linked"); }