From 01400f0a89774af7c5a36fe3fa00204cafe3d6cc Mon Sep 17 00:00:00 2001
From: pravdomil <2387356+pravdomil@users.noreply.github.com>
Date: Sun, 11 Oct 2026 17:37:57 +0200
Subject: [PATCH] =?UTF-8?q?UI:=20draw=20the=20=E2=96=B8=20menu-path=20sepa?=
 =?UTF-8?q?rator=20instead=20of=20a=20missing-glyph=20box?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Inter and egui's built-in fallbacks have no glyph for ▸ (U+25B8), so the
command palette's "EffectCraft ▸ Settings... ▸ Appearance..." and every
"File ▸ Import" hint drew a box. JetBrains Mono, already bundled, has it:
register it as a symbol fallback for the non-monospace families.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 crates/ui-egui/src/theme.rs | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/crates/ui-egui/src/theme.rs b/crates/ui-egui/src/theme.rs
index 953bf66d..abc6f576 100644
--- a/crates/ui-egui/src/theme.rs
+++ b/crates/ui-egui/src/theme.rs
@@ -340,6 +340,13 @@ pub fn install(ctx: &egui::Context, t: &Tokens, language: &str) {
     fonts.families.entry(FontFamily::Monospace).or_default().insert(0, "jbmono".into());
     fonts.families.insert(FontFamily::Name("semibold".into()), vec!["inter-semibold".into(), "inter".into()]);
     fonts.families.insert(FontFamily::Name("medium".into()), vec!["inter-medium".into(), "inter".into()]);
+    // Inter and egui's own fallbacks have no small triangles (the `▸` of "File ▸ Import"), which
+    // would draw as missing-glyph boxes: JetBrains Mono fills in the symbols the others lack.
+    for (family, stack) in &mut fonts.families {
+        if *family != FontFamily::Monospace {
+            stack.push("jbmono".into());
+        }
+    }
     install_script_fallbacks(&mut fonts, language);
     ctx.set_fonts(fonts);
     apply_visuals(ctx, t);
@@ -649,6 +656,19 @@ mod tests {
         install_script_fallbacks(&mut english, "en");
     }
 
+    #[test]
+    fn interface_symbols_have_a_glyph_in_every_family() {
+        let ctx = egui::Context::default();
+        install(&ctx, &Tokens::for_kind(Default::default()), "en");
+        ctx.run_ui(Default::default(), |_| {}).textures_delta.clear();
+        for family in [FontFamily::Proportional, FontFamily::Monospace, FontFamily::Name("medium".into()), FontFamily::Name("semibold".into())] {
+            let id = FontId::new(12.0, family);
+            for c in "▸•›·▶◀●○⚠…×".chars() {
+                assert!(ctx.fonts_mut(|f| f.has_glyph(&id, c)), "{c} has no glyph in {id:?}");
+            }
+        }
+    }
+
     #[test]
     fn hangul_gets_a_face_when_one_is_installed() {
         use effectcraft_text::fonts;