Files
designcraft/xtask/src/pdf_deps.rs
T
aiongg d77fdf2d4c fix(ui): dropdown menus grow back after a search with no matches (#1917)
* fix(ui): font menus grow back after a search with no matches

Every combo box is craft_ui::ComboBox (craft-libs pinned at 62bb0e1d), whose
menu follows its contents' height while open (egui#5225); clippy.toml bans
egui::ComboBox.

The Font menu splits into a header (search field, filters) and a list
(font_menu_header, font_menu_list). Font fields show it in a
craft_ui::combo::Menu and the style dialogs' Font Family combo boxes in
ComboBox::show_ui_with_header, so only the rows scroll and the search field
stays in place. The blank and Parent's Font rows sit in the header, above
the search.

* chore(deps): craft-libs 60d60d48 (dropdown fixes)

* chore(deps): craft-libs 4d7b82f7 (dropdown fixes)

* chore(deps): craft-libs 92d392cf (#387 merged)

* chore(xtask): pdf-deps expects craft-libs 92d392cf
2026-10-27 10:27:32 -04:00

119 lines
4.8 KiB
Rust

//! Check the shared reader source, including the parser reached through Krilla.
use std::path::Path;
use std::process::Command;
use serde_json::Value;
const REPO: &str = "https://github.com/storytold/craft-libs";
const REV: &str = "92d392cff132eaf53e13afff77f38b5c11b73aa0";
const PACKAGES: &[(&str, &str)] = &[
("craft-pdf", "0.1.0"),
("krilla", "0.8.2"),
("hayro", "0.7.1"),
("hayro-interpret", "0.7.0"),
("hayro-syntax", "0.7.2"),
("hayro-jbig2", "0.3.0"),
("hayro-cmap", "0.1.0"),
("hayro-postscript", "0.1.0"),
];
pub fn run(root: &Path) -> Result<(), String> {
let output = Command::new(std::env::var_os("CARGO").unwrap_or_else(|| "cargo".into()))
.current_dir(root)
.args(["metadata", "--locked", "--format-version", "1"])
.output()
.map_err(|e| format!("cargo metadata: {e}"))?;
if !output.status.success() {
return Err(format!("cargo metadata: {}", String::from_utf8_lossy(&output.stderr)));
}
let metadata: Value = serde_json::from_slice(&output.stdout).map_err(|e| format!("cargo metadata: {e}"))?;
validate(&metadata)?;
println!("PDF backend: facade, Krilla and Hayro resolve once to {REV}");
Ok(())
}
fn validate(metadata: &Value) -> Result<(), String> {
let packages = metadata.get("packages").and_then(Value::as_array).ok_or("cargo metadata has no packages")?;
let source = format!("git+{REPO}?rev={REV}#{REV}");
for (name, version) in PACKAGES {
let matching: Vec<_> = packages.iter().filter(|p| p.get("name").and_then(Value::as_str) == Some(name)).collect();
let [package] = matching.as_slice() else {
return Err(format!("{name}: expected one resolved package, found {}", matching.len()));
};
if package.get("version").and_then(Value::as_str) != Some(version) || package.get("source").and_then(Value::as_str) != Some(source.as_str()) {
return Err(format!("{name}: expected {version} from {source}; got {package}"));
}
}
let nodes = metadata.pointer("/resolve/nodes").and_then(Value::as_array).ok_or("cargo metadata has no resolved nodes")?;
let facade = packages.iter().find(|p| p["name"] == "craft-pdf").ok_or("craft-pdf: missing package")?;
let node = nodes.iter().find(|n| n["id"] == facade["id"]).ok_or("craft-pdf: missing resolved node")?;
let features = node["features"].as_array().ok_or("craft-pdf: missing features")?;
for required in ["read", "interpret", "raster", "write", "write-pdf"] {
if !features.iter().any(|f| f.as_str() == Some(required)) {
return Err(format!("craft-pdf: missing required {required} feature"));
}
}
Ok(())
}
#[cfg(test)]
mod tests {
use super::*;
use serde_json::json;
fn metadata() -> Value {
json!({"packages": PACKAGES.iter().map(|(name, version)| json!({"id":name,"name":name,"version":version,
"source":format!("git+{REPO}?rev={REV}#{REV}")})).collect::<Vec<_>>(), "resolve": {"nodes": [{"id": "craft-pdf", "features": ["read", "interpret", "raster", "write", "write-pdf"]}]}})
}
#[test]
fn accepts_one_pinned_facade_and_reader() {
assert!(validate(&metadata()).is_ok());
}
#[test]
fn rejects_unpatched_and_local_reader_sources() {
for source in [Value::Null, json!("registry+https://github.com/rust-lang/crates.io-index")] {
let mut m = metadata();
m["packages"][1]["source"] = source;
assert!(validate(&m).is_err());
}
}
#[test]
fn rejects_missing_duplicate_and_wrong_version_packages() {
for index in 0..PACKAGES.len() {
let mut m = metadata();
m["packages"][index]["version"] = json!("99.0.0");
assert!(validate(&m).is_err());
let mut m = metadata();
let duplicate = m["packages"][index].clone();
m["packages"].as_array_mut().unwrap().push(duplicate);
assert!(validate(&m).is_err());
let mut m = metadata();
m["packages"].as_array_mut().unwrap().remove(index);
assert!(validate(&m).is_err());
}
}
#[test]
fn rejects_missing_reader_or_writer_features() {
for index in 0..5 {
let mut m = metadata();
m["resolve"]["nodes"][0]["features"].as_array_mut().unwrap().remove(index);
assert!(validate(&m).is_err());
}
let mut m = metadata();
m["resolve"] = Value::Null;
assert!(validate(&m).is_err());
}
#[test]
fn rejects_facade_revision_drift_and_malformed_metadata() {
let mut m = metadata();
m["packages"][0]["source"] = json!("git+https://github.com/storytold/craft-libs?branch=main#other");
assert!(validate(&m).is_err());
assert!(validate(&json!({})).is_err());
}
}