Commit Graph
2855 Commits
Author SHA1 Message Date
Brandon Thomas 681e37d2cb Merge pull request #1615 from MarekSpodBiedry/issue-1591
Fix slice panics in the PDF post-passes on malformed page trees and metadata (#1591)
2026-10-23 17:26:46 -04:00
Brandon Thomas dc968ecdff Merge pull request #1629 from marcoarnulfo/feat/autoflow-existing-pages
Autoflow: fill the pages that follow before adding pages at the end
2026-10-23 17:26:42 -04:00
Brandon ThomasandClaude Opus 5.5 1e86a669ca table: the rotation comment names only the IDML import warning
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 17:18:56 -04:00
Brandon ThomasandClaude Opus 5.5 253be57a85 layout.pages.insert: range-check the count before narrowing to usize
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 17:18:46 -04:00
Brandon ThomasandClaude Opus 5.5 96a3290021 Tagged Text: decode only the escapes we write; other backslashes stay literal
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 17:16:26 -04:00
Brandon ThomasandClaude Opus 5.5 50161d0d42 Index: next-paragraph ranges saturate and read the paragraph list with get
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 17:15:22 -04:00
Brandon ThomasandClaude Opus 5.5 0d139559bd Place PDF: the page field takes one whole page number of 1 or more
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 17:11:13 -04:00
Brandon ThomasandClaude Opus 5.5 2aa2ef4b7c find: move the table id into the cell iterator (E0373)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 17:02:49 -04:00
Dylan M. Taylor e14123e83e ci(sonar): don't cancel superseded runs on main, so coverage is published (#1685) 2026-10-23 17:00:31 -04:00
Brandon ThomasandClaude Opus 5.5 45e30914fc Color Settings: reloading a profile moves it to the end of the replay list
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 16:59:41 -04:00
Brandon ThomasandClaude Opus 5.5 13d17e7a6d RTF: a group opening ends the \uN fallback skip
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 16:58:25 -04:00
Marco Arnulfo 005030404c Save dialogs: only a file name goes after the folder, and no name keeps no folder (#1653) 2026-10-23 21:41:16 +02:00
aiongg 1fd8463af9 i18n: missing translations are reported, never a failure (#1677)
A string without a translation shows in English, and an empty catalog row
counts as untranslated. Tests keep duplicate-key and placeholder checks and
the lookup, context, plural-caption and right-to-left mechanics; coverage,
stale-key, wording and per-language literal checks are removed.

`cargo xtask i18n-report`, also a `cargo xtask ci` step, runs the ignored
missing_translations_report test and prints the missing strings per language.
2026-10-23 15:39:24 -04:00
aiongg 2c32ee389b Engine: Export PDF and Print take a creation date, so the print test's two exports match (#1680) 2026-10-23 15:38:43 -04:00
Marco Arnulfo b5342e48cd Save and export dialogs start in the document's folder, or the last one used (#1653) 2026-10-23 21:32:05 +02:00
NetterSilverandClaude Opus 5.5 913bce948f Keep non-finite IDML numbers out of imported documents
Fixes #1589

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 18:48:11 +00:00
aiongg ae5a6d549c CI: run the gate through craft-common-actions' shared gate.yml; FreeBSD nightly and on release (#1645)
ci.yml calls the shared workflow (cached apt packages, nextest, main-only cache saves, Cargo.lock check). FreeBSD and Windows ARM64 run nightly and on pushes to release instead of on pull requests. Depends on storytold/craft-common-actions#69.
2026-10-23 14:21:51 -04:00
Marco Arnulfo 85552ca0f3 Selection: a key object needs at least two selected objects 2026-10-23 19:03:26 +02:00
NetterSilverandClaude Opus 5.5 55f9e690e3 Reload ICC profiles loaded in Color Settings at start-up
Fixes #1474

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-23 18:27:41 +02:00
MarekSpodBiedry 708feab5cd find: search and change text inside table cells in document scope (#1624) 2026-10-23 17:37:45 +02:00
MarekSpodBiedry f40aca9d37 Make the start screen scrollable on short windows (#1655) 2026-10-23 17:37:35 +02:00
MarekSpodBiedry 7b91a1eefc idml: explicit zero cell edge weights hide the default table border (#1623) 2026-10-23 17:35:51 +02:00
Dylan M. Taylor 2e36dcf909 packaging: harden shell scripts (SonarCloud S7688/S7679/S7682/S131) (#1640)
- Use bash's [[ ]] instead of [ ] for conditional tests (S7688).
- Copy positional parameters into named locals in render(), has() and
  sha256() (S7679).
- End the env.sh helper functions with an explicit return, which keeps
  the last command's status (S7682).
- Give the appimagetool checksum case a default branch for architectures
  without a pinned download (S131).

No behaviour change; shellcheck -x is clean.
2026-10-23 11:16:54 -04:00
Dylan M. Taylor df1db1646b web: let the browser zoom the page (SonarCloud Web:S7926) (#1641)
The viewport no longer sets user-scalable=no, so people who need to zoom
the page can (WCAG 1.4.4). The canvas takes touch-action: none, so pinch
and pan gestures on it still go to the app's own zoom, as eframe's touch
handlers expect, instead of zooming the page.
2026-10-23 11:16:49 -04:00
Marco Arnulfo 8eab33eba1 Align: no key object once the selection is down to one object (#1637) 2026-10-23 16:54:21 +02:00
Marco Arnulfo c764454ed3 Align: a click on one of several selected objects makes it the key object (fixes #1637) 2026-10-23 16:22:52 +02:00
MarekSpodBiedry c0daace441 Lay out the parent-page side lookup so rustfmt passes (#1577) 2026-10-23 16:08:36 +02:00
MarekSpodBiedry 5344faf9f0 IDML export: clip a table cell's graphic to the cell (#1551) 2026-10-23 16:08:12 +02:00
Dylan M. Taylor 08718d712c Merge pull request #1658 from dylanmtaylor/sonar/security-reliability
fix: keep package temp files owner-writable (SonarCloud rust:S2612)
2026-10-23 10:02:32 -04:00
Dylan M. Taylor bd7fb76d4c fix: annotate package output permissions (SonarCloud rust:S2612)
New packages are created with the ordinary 0666 request; the process umask
decides the effective mode. Annotated with that reason so the analyzer's
world-writable warning does not change the intended sharing behaviour.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
2026-10-23 09:53:28 -04:00
Marco Arnulfo e7d16aeaaa docs: autoflow drops the pages it added for unused frames; threading into grouped frames is no longer a gap 2026-10-23 11:40:25 +02:00
aiongg e74208dd7e Merge pull request #1642 from aiongg/ci-speed
CI: one test binary per crate, nextest, line tables only
2026-10-22 23:59:30 -04:00
aiongg 62148670bd CI: apt packages through craft-common-actions' cached install 2026-10-23 02:54:21 +00:00
aiongg 0fd6e06ad6 CI: install nextest for the test step 2026-10-23 01:17:55 +00:00
aiongg 3ee11391ae CI: one integration-test binary per crate 2026-10-23 01:17:48 +00:00
skylar taylor-barrick d9477695e2 #249: test that menu rows are selectable across their full width
A menu row only reacted over its text because the column used a plain top-down layout. The test renders a menu column with a short Preferences row and clicks near the right end of the row, expecting the dialog to open. Without the justified layout the click misses and the test fails.
2026-10-22 17:57:36 -06:00
skylar taylor-barrick fecf5906c3 #248: test that the start screen offers every print preset including A6
The start screen showed only the first ten presets and had no A6 sheet. The test checks that the start screen paints a card for each print preset, that A6 exists at 105 x 148 mm, and that the Properties page-size list agrees. Without the fix it fails because the B5 card is cut off by take(10) and there is no A6.
2026-10-22 17:57:36 -06:00
skylar taylor-barrick 15e4fdd124 #329: test that the Help menu works on the start screen
The Help menu's links were greyed out when no document was open, because UI commands outside app. and window. needed a document. The test checks every help.* UI command is enabled with an empty session while another UI command (view.rulers) stays disabled. Without the help. exemption it fails on "help.discord must work from the start screen".
2026-10-22 17:57:36 -06:00
aiongg 40e86d48a5 CI: xtask runs tests with nextest, doctests apart, wasm in one check 2026-10-22 23:35:30 +00:00
aiongg 079b5bea82 CI: dev profile keeps line tables only 2026-10-22 23:31:37 +00:00
Marco Arnulfo 2caa39e130 Autoflow: fill the pages that follow before adding pages at the end
Autoflow (Shift-click, autoflow on Place, text.thread with autoflow) inserted
new pages right after the story's last frame, in front of the document's own
pages. As in InDesign, it now threads one frame per column on each page that
follows, whatever else the page holds, and only then adds pages at the end of
the document. It fills whole pages, so an estimate that stops inside a page
can't leave its later columns out of the thread. Frames it set past the end
of the text are removed again; the pages they were on stay. Smart Text Reflow
of the primary text frame keeps adding pages after the story's last page.

Shrinks gap 26: flowing into the primary text frame of the following pages
is left.
2026-10-22 23:28:22 +02:00
Brandon ThomasandClaude Opus 5.5 5e8ef67832 Release 0.12.0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
v0.12.0
2026-10-22 15:38:12 -04:00
MarekSpodBiedry d292dd2acd IDML export: write the graphic placed in a table cell (#1551) 2026-10-22 21:06:54 +02:00
MarekSpodBiedry ce486fda63 Fix slice panics in the PDF post-passes on malformed page trees and metadata (#1591) 2026-10-22 21:05:48 +02:00
MarekSpodBiedry fd3d5087fc Cursors: paint the tool cursors in the window on Wayland, so they keep the system size (#1544) 2026-10-22 21:03:58 +02:00
MarekSpodBiedry 62c71d004a Align towards/away from spine on parent-page folios by page side (#1577) 2026-10-22 21:03:00 +02:00
NetterSilverandClaude Haiku 5.5 2ddcf6d2a1 Decode UTF-16 plain text files by BOM on import
Found while testing crates/textimport/src/lib.rs:117

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-22 20:08:56 +02:00
NetterSilverandClaude Haiku 5.5 bbb95930a2 Skip control words and symbols used as RTF \uN fallbacks
Found while testing crates/textimport/src/rtf.rs:197-243 (the \u handler at :235-242; control words never decrement `pending`)

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-22 19:26:49 +02:00
Davit MatchakhelidzeandClaude Opus 5.5 6c25107508 ui: the Discord button widens to fit its label instead of spilling out
The start screen's community card reserves the button's measured width, so
the line beside it wraps before the button. Georgian's label overflowed the
fixed 190 px.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YMTAbGNRxnMEzRvYnQGphF
2026-10-22 21:23:52 +04:00
Hamza e6d78a71d0 A right-to-left paragraph's first-line indent is at its right edge (#1448)
The first-line indent was added to the left indent whatever the paragraph's
direction, so a right-to-left paragraph's first line moved the wrong way. With
the hanging indent a numbered list uses — right indent 10 mm, first line
−10 mm — the first line went 10 mm outside the frame on the left while the
wrapped lines sat where it should have been.

It is the paragraph's start-side indent, which is the right one in a
right-to-left paragraph; the drop-cap case beside it already made that
distinction.

Measured on a 200 pt column with that hanging indent:

  first line    right edge 200     (the frame's edge, as InDesign sets it)
  wrapped       right edge 171.65  (10 mm in)
  every line    left edge >= 0     (nothing outside the frame)

and the same paragraph left to right is unchanged, first line at 0 and wrapped
lines 10 mm in.

The test checks both directions; the right-to-left half fails without the
change. 359 composition tests pass unchanged.
2026-10-22 22:20:41 +05:00