Commit Graph
2702 Commits
Author SHA1 Message Date
Haseom Shin 36000e75f5 Compose: don't panic when a hyphenated paragraph starts with a no-break letter 2026-10-08 14:58:08 +09:00
aiongg 0f52f3ba89 Text: stories made in a right-to-left-bound document fill their columns from the right (#100) 2026-10-08 01:57:30 -04:00
aiongg 3c83f4f477 Tables: new tables take their paragraph's direction, and the Table panel sets a table's direction (#100) 2026-10-08 01:54:14 -04:00
aiongg fa22e61f83 PDF: PDF/A exports keep placed PNG, JPEG, GIF and WebP images by writing them without interpolation (#71) 2026-10-08 01:51:30 -04:00
aiongg 1ccf4fbfbe File open: an .indd file is an unreadable file like any other
Remove the INDD signature check and message, and .indd/.indt from the
Open filters and drop routing. The alert tests use a generic unreadable
file.
2026-10-08 00:51:47 -04:00
aiongg b757687a41 Merge branch 'main' into fix/21-indd-message
# Conflicts:
#	apps/designcraft/src/main.rs
#	crates/engine/src/cmd/file.rs
2026-10-08 00:47:23 -04:00
Brandon ThomasandClaude Opus 5.5 38ec9ce7e0 Merge #106 (includes #83, #84, #81) into fix/empty-paragraph-mark
An empty paragraph's mark format now also supplies #83's first-baseline
heights through line_metrics.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 23:30:23 -04:00
Brandon ThomasandClaude Opus 5.5 01eef9ed21 Merge origin/main into fix/empty-paragraph-mark
The empty paragraph's mark metrics feed line_metrics alongside main's CJK
line reference.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 23:28:22 -04:00
Brandon ThomasandClaude Opus 5.5 bed9438612 Merge #81 (includes #83, #84) into fix/compose-baseline-frame-fit
#83's Keep Lines Together tests change expectation: with the last baseline
allowed on the bottom inset, the first frame holds one more line, so the
10-line paragraph splits 7/3 instead of 6/4 (the keep rule is unchanged).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 23:24:30 -04:00
Brandon ThomasandClaude Opus 5.5 0237d5de93 Merge origin/main into fix/compose-baseline-frame-fit
Vertical Type is now the story's direction: the full-descent check reads
FrameSpec::vertical, and the vertical-extent test sets the story vertical.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 23:20:01 -04:00
aiongg dc18c10448 Merge #84 into fix/29-kerning-across-runs 2026-10-07 23:14:02 -04:00
aiongg 0ae0dc7707 Merge the fork's fix/29-kerning-across-runs
# Conflicts:
#	crates/compose/src/shape.rs
#	crates/compose/src/tests.rs
2026-10-07 23:14:02 -04:00
aiongg 141a5306bf Merge #83 into feat/text-editing-and-frames 2026-10-07 23:12:38 -04:00
aiongg 1bdca77eea Merge the fork's feat/text-editing-and-frames 2026-10-07 23:12:38 -04:00
aiongg 673039f5dc Merge the fork's feat/layout-parity 2026-10-07 23:12:31 -04:00
Brandon ThomasandClaude Opus 5.5 4eb4e72d94 Merge #84 (text editing, includes #83) into fix/29-kerning-across-runs
Hidden place-holders, now shaped from pieces, also zero #83's typographic
ascent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 23:09:21 -04:00
aiongg 124bddaf8b Text: a change of kenten character keeps the kerning across it
Pieces of a paragraph that differ only in how they are painted are
shaped together; the kenten character only picks the emphasis mark drawn
over the text, so it is one of those paint attributes, like kenten
itself.
2026-10-07 23:08:45 -04:00
aiongg 3a10a749db Text: a missing font's substitute takes fallback fonts across a colour change
Text is shaped in pieces that differ only in paint, so each piece group,
and each piece shaped apart, takes its style's environment: a missing
font's substitute draws the characters it lacks from fallback fonts
whatever Draw Missing Glyphs from Fallback Fonts says.
2026-10-07 23:08:13 -04:00
aiongg c8d4ed8fa3 Merge main into fix/29-kerning-across-runs
# Conflicts:
#	crates/compose/src/shape.rs
#	crates/compose/src/tests.rs
2026-10-07 23:07:47 -04:00
aiongg e13dee0728 Text: Bold and Italic link the document's own fonts
Bold and Italic find the linked style through the document's font scope,
so a family from the document's fonts folder links its own styles; the
Character panel's B and I state reads the same scope.
2026-10-07 23:04:29 -04:00
Brandon ThomasandClaude Opus 5.5 44e8981364 Merge origin/main into fix/29-kerning-across-runs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 23:02:09 -04:00
aiongg b40e221d58 Text: a frame removed from a thread keeps the story's direction
Tests that a frame taken out of a vertical or right-to-left thread gets
a new story with the thread's vertical setting and column direction.
2026-10-07 23:02:03 -04:00
aiongg f2f14120f3 Merge #83 into feat/text-editing-and-frames 2026-10-07 23:01:07 -04:00
Brandon ThomasandClaude Opus 5.5 eca9eb25fe Merge #83 (layout parity) into feat/text-editing-and-frames
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:58:41 -04:00
Brandon ThomasandClaude Opus 5.5 fc6101d10f Merge origin/main into feat/text-editing-and-frames
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:58:36 -04:00
Brandon ThomasandClaude Opus 5.5 f2b8c3dce1 Merge origin/main into feat/layout-parity
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:58:28 -04:00
aiongg 5e515725c6 IDML: one reader and writer for the paragraph Kashidas attribute
The paragraph Kashidas attribute is imported and exported by the Arabic
attribute code; the second copy in the paragraph defaults, which read and
wrote the same values, is gone.
2026-10-07 22:57:58 -04:00
aiongg 487e10f766 Merge main into feat/layout-parity
# Conflicts:
#	ROADMAP.md
2026-10-07 22:57:15 -04:00
aiongg 6fe91b0dfb Text: a drop cap in a document font aligns its left edge
A drop cap set in one of the document's own fonts measures its side
bearing in that font, through the document's font scope, so Align Left
Edge puts its ink at the indent.
2026-10-07 22:57:03 -04:00
aiongg 8ce8ed5fbe Text: list labels don't raise the Ascent first baseline
The bullet or number a paragraph's list adds no longer counts toward the
first line's tallest typographic ascender: with First Baseline Offset
set to Ascent, only the line's own text places the first baseline. The
label still counts toward the line's ascent, descent and leading, and
toward the Cap Height and x Height offsets. An empty list paragraph
places its first baseline as an empty paragraph does.

Characters that don't draw, such as spaces, keep counting toward the
Ascent offset; a test pins that.
2026-10-07 22:56:10 -04:00
aiongg bb608dc03f Text: a frame's visible stroke insets its text
A text frame's text area starts at the inner edge of its stroke: the
frame edge, then the part of the stroke inside the frame, then the
inset, on all four edges. A centred stroke takes half its weight, an
inside stroke all of it and an outside stroke none. A stroke without a
colour (or with no weight) doesn't count.

Composition, hit testing and vertical frames all take the text area
from the frame, so they agree. Graphics frames, wraps and the frame's
bounds are unchanged, and type on a path, which has no inset, ignores
the stroke as well.
2026-10-07 22:55:43 -04:00
aiongg 93287b0b10 Text: vertical scale doesn't move the Ascent first baseline
With First Baseline Offset set to Ascent, the first baseline sits the
font's typographic ascender times the nominal point size below the top
of the text area: vertically scaled characters no longer push it down.
The line's ascent and descent, its leading, the Cap Height and x Height
offsets and drop caps still follow the vertical scale.
2026-10-07 22:55:24 -04:00
Brandon ThomasandClaude Opus 5.5 6f42f598bc Merge origin/main into fix/29-kerning-across-runs
Pieces carry their style's shaping settings (a missing font's glyph
fallback) and group only with pieces that share them; jidori pieces stay
apart, since jidori fits its own run. shape_run / shape_run_raw take the
per-byte style runs; the digit substitution takes main's multi-byte
ranges and fallback lookup.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:54:25 -04:00
Brandon Thomas f4a4c9709b Merge pull request #76 from CameronGilroy/pr/data-merge
Data merge: linked source, placeholders, preview, and tiled merge
2026-10-07 22:53:41 -04:00
Brandon ThomasandClaude Opus 5.5 0590f63406 Merge #83 (layout parity) into feat/text-editing-and-frames
Trailing spaces and drop caps both join the placed line; hit testing checks
the drop cap first, then the closest line (hit_line). hit_char also picks
the drop cap's character under the point, so a double click on the cap
selects from it (the follow-up both PRs named).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:47:17 -04:00
Brandon Thomas b05fe0aed4 Merge pull request #78 from ShaoWenbinSaleh/multi-language-fix
Complete Arabic translations, refine Chinese terminology, and cache RTL label layouts
2026-10-07 22:46:52 -04:00
Brandon ThomasandClaude Opus 5.5 962234fbdf Merge origin/main into feat/text-editing-and-frames
Resolve conflicts with the CJK/Arabic work: trailing spaces follow the line
only in left-to-right paragraphs without right-to-left glyphs (layout_line
now takes the bidi info); style linking moves to ScopedFonts so the
document's own fonts count (FontDb delegates to scope 0); threading keeps
the receiving story's direction and Vertical Type, and frames split off by
threading or removed from a thread keep theirs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:41:43 -04:00
aiongg acf0059d84 UI: toolbars that don't fit the window switch to two columns or scroll (#57)
In a short window the Tools panel lays its tools out in two columns,
without changing the single/double-column preference, which comes back
when the window grows again. While the window forces two columns the
column toggle is disabled. Whatever two columns can't fit scrolls
vertically.

The Control panel and the application bar scroll sideways when their
controls are wider than the window. The Control panel keeps its height.
In the application bar the workspace controls follow the menus instead of
overlapping them. A plain mouse wheel scrolls these one-direction bars,
and a thin floating scroll bar shows only when something overflows, so
nothing changes while everything fits.

Tool buttons, icon buttons and the Fill proxy carry accessibility
labels, which the new window-size tests use to find them.
2026-10-07 22:37:21 -04:00
Brandon ThomasandClaude Opus 5.5 6e8e252cc4 Merge origin/main into feat/layout-parity
Resolve conflicts with the CJK/Arabic composition work: line metrics keep
the first-baseline tops and add the CJK alignment shift; the CJK line
reference adjustment applies before baseline-grid snapping; layout_line
takes the bidi info and the drop cap is spliced in after it; vertical text
is now the story's direction (FrameSpec::vertical); IDML insets use main's
validated inset_spacing over the object style chain; format's JSON upgrade
(vertical frames) and model upgrade (format v2 defaults) both run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:34:18 -04:00
Brandon ThomasandClaude Opus 5.5 8d2d180062 Merge origin/main into multi-language-fix
Resolve i18n conflicts: keep this branch's revised zh/ar wording plus
main's new rows (font-name, missing-glyph, Korean line-break labels).
Brazilian Portuguese (#103) now uses the same cached HashMap lookup as
Arabic; the cached-lookup test covers pt-br too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:32:13 -04:00
Brandon ThomasandClaude Opus 5.5 48dfbcfd19 Merge origin/main into data-merge
Resolve conflicts keeping both sides: doc gains both `cjk` and
`datamerge` modules; file.open resolves data-merge sources and loads the
document's fonts; DocState keeps preview_stash/preview_record and fonts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:28:15 -04:00
aiongg ed3e8ba8c3 UI: text fields take Select All, Copy, Cut, Paste, Undo and Redo from the Mac menu (#30)
The macOS menu bar takes Cmd+A, Cmd+C, Cmd+X, Cmd+V, Cmd+Z and Cmd+Shift+Z
before the window sees them, so in a panel, dialog or search field they ran
the document's commands: Select All selected every frame, Paste pasted into
the layout, Undo undid the last document change.

While a text field has keyboard focus, these Edit items now act on the field,
whether chosen by shortcut or from the menu: Select All, Undo and Redo reach
it as their keys, Copy and Cut as clipboard events, and Paste asks the
window for the system clipboard. The items stay enabled for the field even
when the document has nothing to copy or undo. With no field focused, and
for every other item, the menu works as before.
2026-10-07 22:23:01 -04:00
Brandon Thomas 8e2a5b1fc3 Merge pull request #55 from EthanSuquet/fix/cmyk-tiff-pdf-export
PDF: placed CMYK TIFFs keep their inks
2026-10-07 22:13:56 -04:00
Brandon Thomas 2c8ea6d167 Merge remote-tracking branch 'origin/main' into r55
# Conflicts:
#	Cargo.toml
2026-10-07 22:13:23 -04:00
Brandon Thomas e97d98977f Merge pull request #103 from RicSchonfelder/i18n-pt-br
i18n: add Brazilian Portuguese (pt-br) UI translation
2026-10-07 22:13:15 -04:00
Brandon Thomas 9f2f61bfbf Merge pull request #82 from aiongg/fix/psd-channels
Images: PSD composites decode by colour mode
2026-10-07 22:13:10 -04:00
Brandon ThomasandClaude Opus 5.5 2d889af2e2 M2: keep the system clipboard away from the control channel
Commands run while handling a control request (engine.execute,
ui.menu.invoke, ...) no longer read the system clipboard into Paste or
write Copy/Cut text to it; only user-initiated runs do. Regression test
included. append_story allocates note, endnote, editorial and table ids
with saturating_add (no overflow panic on hostile ids), with a test.
Also fixes a clippy nonminimal_bool in cmd/text.rs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:11:44 -04:00
Brandon ThomasandClaude Opus 5.5 84f2eadb39 Release CI: macOS job on macos-15-xlarge
Custom macOS larger runners in a runner group do not pick up jobs; the
built-in M2 Pro label does. Only release.yml uses it, and the
actions_macos_xl budget caps the monthly spend.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 22:08:05 -04:00
Brandon Thomas a39c8893b9 Merge remote-tracking branch 'origin/main' into fix/cmyk-tiff-pdf-export
# Conflicts:
#	crates/pdf/Cargo.toml
#	crates/pdf/src/tests.rs
2026-10-07 22:05:52 -04:00
Brandon Thomas 1c2aa451cf Merge pull request #85 from aiongg/feat/cjk-and-fonts
CJK: language-aware shaping and fallback, vertical metrics, document fonts, missing-glyph boxes (builds on #75)
2026-10-07 22:05:01 -04:00