mirror of
https://github.com/storytold/deckcraft.git
synced 2026-10-26 03:27:03 -06:00
* fix(windows): keep the shortcut icon after an update (#1114) The MSI's Start menu shortcut took its icon from the WiX <Icon>, which Windows Installer caches under %APPDATA%\Microsoft\Installer\{ProductCode}\. Every update is a major upgrade with a new ProductCode, so the old folder is deleted. A taskbar pin is a copy of the shortcut that the update never touches, so it kept pointing at the deleted file and lost its icon. Drop the Icon from the shortcut so it shows the icon embedded in deckcraft.exe, whose path survives updates. The <Icon> stays for ARPPRODUCTICON. A test keeps shortcuts from naming an MSI icon again. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * contributors: credit Sofia Alves Figueredo by real name Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(windows): make the Start menu shortcut non-advertised (#1114) Addresses the review comment: without an MSI Icon, a non-advertised shortcut targets the installed exe directly and takes its embedded icon. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(windows): package.ps1 rejects a deckcraft.exe with no embedded icon (#1114) The shortcuts now take the exe's own icon, and -SkipBuild packages an existing exe that may come from a build without DECKCRAFT_REQUIRE_WINRES=1. Count its icons with ExtractIconEx and stop before WiX when there are none. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
71 lines
1.9 KiB
TOML
71 lines
1.9 KiB
TOML
# Contributor names for the About window (craftrules standards/contributors.md).
|
|
#
|
|
# Everyone who contributes is credited by GitHub username automatically. Anything more is up to
|
|
# you: add YOUR OWN entry below, in your own PR (commit it yourself). Never add someone else; a
|
|
# maintainer may add a person only when that person asked, recording where in consent_source.
|
|
#
|
|
# Easiest: python3 ../../craftrules/scripts/contributors.py --add-me . \
|
|
# [--real-name "Ada Lovelace"] [--display-name "Ada"] [--sync-github-name]
|
|
#
|
|
# Or copy this block, replacing your-github-username (every field is optional):
|
|
#
|
|
# [people.your-github-username]
|
|
# real_name = "Your Name" # shown when the viewer picks "Real name"
|
|
# display_name = "Nickname" # shown when the viewer picks "Display name"
|
|
# sync_github_name = true # or: use the name on your public GitHub profile as display name
|
|
#
|
|
# To remove your names, delete your entry (or set fields empty) in a PR. The next
|
|
# contributors.py run, and the next build, drop them.
|
|
|
|
[people.echelon]
|
|
real_name = "Brandon Thomas"
|
|
display_name = "Brandon Thomas"
|
|
sync_github_name = false
|
|
|
|
[people.alexanderalber]
|
|
real_name = "Alexander Alber"
|
|
|
|
[people.switch87]
|
|
real_name = "Gert Pellin"
|
|
display_name = "Gert Pellin"
|
|
sync_github_name = false
|
|
|
|
[people.DimaSmaha]
|
|
real_name = "Dmytro Smaha"
|
|
display_name = "Dima Smaha"
|
|
sync_github_name = false
|
|
|
|
[people.Johannesgauss]
|
|
sync_github_name = true
|
|
|
|
[people.Silvertree2010]
|
|
display_name = "Netter"
|
|
sync_github_name = false
|
|
|
|
[people.dotCooCoo]
|
|
real_name = "Robert Lee"
|
|
sync_github_name = true
|
|
|
|
[people.Momentum96]
|
|
sync_github_name = true
|
|
|
|
[people.NikitkaRa]
|
|
real_name = "Nikita Rakitin"
|
|
|
|
[people.RCShoemaker]
|
|
real_name = "Ryan C. Shoemaker"
|
|
|
|
[people.marcoarnulfo]
|
|
real_name = "Marco Arnulfo"
|
|
display_name = "Marco Arnulfo"
|
|
sync_github_name = false
|
|
|
|
[people.GhostMitra]
|
|
sync_github_name = true
|
|
|
|
[people.Katacc]
|
|
sync_github_name = true
|
|
|
|
[people.SofiaAFigueredo]
|
|
real_name = "Sofia Alves Figueredo"
|