From 8e83e8bb81449fbf06f4f00fa5b3c5adfc142ad7 Mon Sep 17 00:00:00 2001 From: Sazid Al Bayazid Date: Fri, 16 Oct 2026 02:35:40 +0600 Subject: [PATCH] Render: quick styles render on empty placeholder text boxes (#832) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The render gate for an empty placeholder's fill checked only s.fill.is_none(). A quick style that sets a style reference without an explicit fill left s.fill as None, so the gate skipped the fill even though the shape had been formatted — the style only appeared after text was added. The gate now also checks s.line and s.style: if any of the three has a local override, the placeholder is considered formatted and the fill is drawn. A truly unformatted empty placeholder still shows the dashed outline and prompt. --- ROADMAP.md | 1 + crates/render/src/lib.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ROADMAP.md b/ROADMAP.md index 93bc931e..91cfac6f 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -137,6 +137,7 @@ app's JSON control channel (`deckcraft --control PORT`). | 2026-10-17 | Edit Points: turning a shape into a freeform is one undo step, so Undo brings the original shape back (it used to stay a freeform) | | 2026-10-17 | While a placeholder's text is being edited, a click on a shape in front of it selects that shape instead of moving the caret, as in PowerPoint (#931) | | 2026-10-15 | Native saves keep an imported chart's embedded workbook, drawings and relationships; headless PPTX → edit → native save/reopen → PPTX tests verify the payloads and stale-workbook rejection | +| 2026-10-15 | Render: quick styles render on empty placeholders — the fill gate now checks for style and line overrides too (#832) | | 2026-10-15 | PPTX trigger sequences keep separate On Click steps, including paragraph builds; synthetic import/edit/save/reopen and headless show regressions | | 2026-10-16 | Export: PNG with a transparent background — the slide background is left out, only the slide's content is drawn (Export… dialog, File › Export, web download, `file.export`/`file.render` `transparentBackground`, `deckcraft-cli render --transparent`) (#784) | | 2026-10-16 | Arrange ▸ Align: Align to Slide and Align Selected Objects, as in PowerPoint. One object aligns to the slide and several to each other until the other choice is ticked; the choice holds for that selection and also drives Distribute | diff --git a/crates/render/src/lib.rs b/crates/render/src/lib.rs index cf124a9f..96a063b3 100644 --- a/crates/render/src/lib.rs +++ b/crates/render/src/lib.rs @@ -1106,7 +1106,7 @@ impl Renderer { } _ => { if let Some(fl) = &fill - && !(empty_ph && f.opts.edit && s.fill.is_none()) + && !(empty_ph && f.opts.edit && s.fill.is_none() && s.line.is_none() && s.style.is_none()) { for (i, sp) in geo.paths.iter().enumerate() { if sp.fill == FillMode::None || fade(i).fill <= 0.0 {