From 31e22977f75bd2f3118d81db8e79c2ed71cb5428 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Wed, 14 Oct 2026 14:05:00 -0400 Subject: [PATCH] Fix up merged PRs: the palette test skips UI commands that need a value (#440 hides them) Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/src/menus.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/crates/ui-egui/src/menus.rs b/crates/ui-egui/src/menus.rs index 85d55396..c6f1e640 100644 --- a/crates/ui-egui/src/menus.rs +++ b/crates/ui-egui/src/menus.rs @@ -305,7 +305,11 @@ mod tests { assert_eq!(exports[0].0, "app.exportDialog"); } // Open…, Save As…, Audio/Video from File… and Notes had the same duplicates: every UI command is the only entry with its label. - for (id, label, _, _) in crate::UI_COMMANDS { + // Commands that need a value (Set Zoom's percent) are left out of the palette. + for (id, label, _, params) in crate::UI_COMMANDS { + if deckcraft_engine::cmd::needs_arguments(params) { + continue; + } let same: Vec<_> = palette_items(&session, &label.to_lowercase()).into_iter().filter(|(_, l, _)| l == label).collect(); assert_eq!(same.len(), 1, "{label}"); assert_eq!(same[0].0, *id, "{label}");