From 0ac222a5437d0763adb023b05bd041a580973600 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Wed, 14 Oct 2026 13:51:49 -0400 Subject: [PATCH] Fix up merged PRs: split ribbon buttons carry their label once (#512's label predates main's) Co-Authored-By: Claude Opus 5.5 --- crates/ui-egui/src/widgets.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/crates/ui-egui/src/widgets.rs b/crates/ui-egui/src/widgets.rs index 47fc53a43..63ab39348 100644 --- a/crates/ui-egui/src/widgets.rs +++ b/crates/ui-egui/src/widgets.rs @@ -124,10 +124,6 @@ pub fn small_button_ex(ui: &mut Ui, icon: Icon, label: &str, enabled: bool, sele let main_rect = Rect::from_min_max(rect.min, pos2(rect.max.x - arrow_w, rect.max.y)); let main_resp = if split { ui.interact(main_rect, resp.id.with("m"), if enabled { Sense::click() } else { Sense::hover() }) } else { resp.clone() }; - // Screen readers (and UI tests) find the button by its text. - if !label.is_empty() { - main_resp.widget_info(|| egui::WidgetInfo::labeled(egui::WidgetType::Button, enabled, label)); - } let arrow_resp = split.then(|| { ui.interact( Rect::from_min_max(pos2(rect.max.x - arrow_w, rect.min.y), rect.max),