From d96aa15980a3f2ddbf44f88246ffebcb2b35f542 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sat, 24 Oct 2026 08:53:39 +0000 Subject: [PATCH] fix: item_json params --- crates/engine/src/cmd/annotate.rs | 4 ++-- crates/engine/src/cmd/inquiry/usage.rs | 11 +++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/crates/engine/src/cmd/annotate.rs b/crates/engine/src/cmd/annotate.rs index 6fdd0869d..b60a7c2e4 100644 --- a/crates/engine/src/cmd/annotate.rs +++ b/crates/engine/src/cmd/annotate.rs @@ -120,7 +120,7 @@ fn style(s: &Session) -> String { s.doc().map(|d| d.header.str("DIMSTYLE", "Standard")).unwrap_or_else(|_| "Standard".into()) } -fn dim(s: &Session, kind: DimKind, defpt: Vec2, p13: Vec2, p14: Vec2, p15: Vec2, text: &str) -> EntityKind { +fn dim(s: &Session, kind: DimKind, defpt: Vec2, p13: Vec2, p14: Vec2, p15: Vec2, p16: Vec2, text: &str) -> EntityKind { EntityKind::Dimension(Dimension { kind, defpt: v3(defpt), @@ -128,7 +128,7 @@ fn dim(s: &Session, kind: DimKind, defpt: Vec2, p13: Vec2, p14: Vec2, p15: Vec2, p13: v3(p13), p14: v3(p14), p15: v3(p15), - p16: v3(Vec2::ZERO), + p16: v3(p16), text: text.into(), style: style(s), measurement: 0.0, diff --git a/crates/engine/src/cmd/inquiry/usage.rs b/crates/engine/src/cmd/inquiry/usage.rs index d2f0eb5dc..fc3f0e39e 100644 --- a/crates/engine/src/cmd/inquiry/usage.rs +++ b/crates/engine/src/cmd/inquiry/usage.rs @@ -282,8 +282,7 @@ fn item_json( name: &str, (entities, block_entities): (usize, usize), references: usize, - used: bool, - empty: bool, + (used, empty): (bool, bool), current: Option, unused: &Unused, ) -> Value { @@ -313,13 +312,13 @@ fn items(scan: &Scan, unused: &Unused, d: &Drawing) -> Vec { let (e, b) = scan.layers.get(&l.name.to_ascii_lowercase()).copied().unwrap_or_default(); let uses = e.saturating_add(b); let cur = l.name.eq_ignore_ascii_case(¤t_layer); - out.push(item_json(Category::Layer, &l.name, (e, b), 0, uses > 0, uses == 0, Some(cur), unused)); + out.push(item_json(Category::Layer, &l.name, (e, b), 0, (uses > 0, uses == 0), Some(cur), unused)); } for b in d.blocks.values() { let (e, n) = scan.blocks.get(&b.name.to_ascii_lowercase()).copied().unwrap_or_default(); // A definition is used when a reference to it is reachable, as PURGE counts it. let used = scan.used_blocks.contains(&b.name.to_ascii_uppercase()); - out.push(item_json(Category::Block, &b.name, (e, n), 0, used, e.saturating_add(n) == 0, None, unused)); + out.push(item_json(Category::Block, &b.name, (e, n), 0, (used, e.saturating_add(n) == 0), None, unused)); } let current_style = d.header.str("TEXTSTYLE", "Standard"); for t in &d.text_styles { @@ -327,7 +326,7 @@ fn items(scan: &Scan, unused: &Unused, d: &Drawing) -> Vec { let r = scan.style_refs.get(&t.name.to_ascii_lowercase()).copied().unwrap_or(0); let uses = e.saturating_add(b).saturating_add(r); let cur = t.name.eq_ignore_ascii_case(¤t_style); - out.push(item_json(Category::TextStyle, &t.name, (e, b), r, uses > 0, uses == 0, Some(cur), unused)); + out.push(item_json(Category::TextStyle, &t.name, (e, b), r, (uses > 0, uses == 0), Some(cur), unused)); } let current_linetype = d.header.str("CELTYPE", "ByLayer"); for t in &d.linetypes { @@ -335,7 +334,7 @@ fn items(scan: &Scan, unused: &Unused, d: &Drawing) -> Vec { let r = scan.linetype_refs.get(&t.name.to_ascii_lowercase()).copied().unwrap_or(0); let uses = e.saturating_add(b).saturating_add(r); let cur = t.name.eq_ignore_ascii_case(¤t_linetype); - out.push(item_json(Category::Linetype, &t.name, (e, b), r, uses > 0, uses == 0, Some(cur), unused)); + out.push(item_json(Category::Linetype, &t.name, (e, b), r, (uses > 0, uses == 0), Some(cur), unused)); } out }